retryable 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ab358b3281332a22c7a8995598640d74e4c275c3
-  data.tar.gz: 1af4d17e2c3c0e3171a98a594273b3c1098be0d1
+SHA256:
+  metadata.gz: 4adf6498d39c3a76bb6c3ea4c2ef8bd479d620b65c969cc43c970ae1dc1e8dd7
+  data.tar.gz: d60ff44f63519d2df8a70ca8729e5db2cda03e2b9ba2bf9af42dae66df9f65d5
 SHA512:
-  metadata.gz: 790c0d7cca9fcec2f1bdcb36ded2451e50af933cb6d181842918a8bf8d3f714bd54716ad63714a218be3825ae8e9d09d16b0b2b1ab8e61a6d75d62553952303b
-  data.tar.gz: 208cdf97146fb043b88b9c046bf0edba12095dc0b3bbd6808702e7620f6457521f7a2cc8ad4a2bd9c0a5e646f1f277f5cbb3ba672278ea56fb8b61dd1e374e7c
+  metadata.gz: 24fc7de390a5996451a2c9d0296811b031ce21e38a3c4374d4a002e3e12d6278c07f31a84dd86efcf9006fd2ff2f7ef40e40da791f2d98dedb56ee2b0c7b3006
+  data.tar.gz: '09360b246ca4c6868fc40807f1fc4978933f3aae138237efdb396e51e52a36fd2c8e1a44310365336cc9d43c08df62726d9d390739e3fdcce23640abdb0b2733'

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## Retryable 3.0.5 ##
+
+Instead of :infinite magic constant from now on you can just use Ruby's native infinity data type e.g. Float::INFINITY.
+See https://github.com/nfedyashev/retryable/commit/16f60bb09560c9470266dca8cd47c934594a67c5
+This version is backwards compatible with older versions, no changes needed in your code.
+
 ## Retryable 3.0.4 ##
 
 Fixed typo in exception message given invalid :matching argument type https://github.com/nfedyashev/retryable/pull/29

data/README.md

@@ -50,9 +50,11 @@ end
 
 Try the block forever.
 ```ruby
-Retryable.retryable(tries: :infinite) do
+# For ruby versions prior to 1.9.2 use :infinite symbol instead
+Retryable.retryable(tries: Float::INFINITY) do
   # code here
 end
+
 ```
 
 Do something, retry up to four times for either `ArgumentError` or
@@ -261,11 +263,12 @@ versions:
 
 * Ruby 1.9.3
 * Ruby 2.0.0
-* Ruby 2.1.2
-* Ruby 2.2.0
-* Ruby 2.3.1
-* Ruby 2.4.0
-* Ruby 2.5.0
+* Ruby 2.1.10
+* Ruby 2.2.10
+* Ruby 2.3.8
+* Ruby 2.4.5
+* Ruby 2.5.3
+* Ruby 2.6.1
 
 *NOTE: if you need `retryable` to be running on Ruby 1.8 use gem versions prior to 3.0.0 release*
 

data/lib/retryable.rb

@@ -75,7 +75,9 @@ module Retryable
       rescue *on_exception => exception
         raise unless configuration.enabled?
         raise unless matches?(exception.message, matching)
-        raise if tries != :infinite && retries + 1 >= tries
+
+        infinite_retries = :infinite || tries.respond_to?(:infinite?) && tries.infinite?
+        raise if tries != infinite_retries && retries + 1 >= tries
 
         # Interrupt Exception could be raised while sleeping
         begin

data/lib/retryable/version.rb

@@ -15,7 +15,7 @@ module Retryable
 
     # @return [Integer]
     def patch
-      4
+      5
     end
 
     # @return [Hash]

data/spec/retryable/configuration_spec.rb

@@ -21,6 +21,22 @@ RSpec.describe Retryable do
     end
   end
 
+  context 'when configured locally' do
+    it 'does not affect the original global config' do
+      new_sleep = 2
+      original_sleep = described_class.configuration.send(:sleep)
+
+      expect(original_sleep).not_to eq(new_sleep)
+
+      counter(tries: 2, sleep: new_sleep) do |tries, ex|
+        raise StandardError if tries < 1
+      end
+
+      actual = described_class.configuration.send(:sleep)
+      expect(actual).to eq(original_sleep)
+    end
+  end
+
   context 'when configured globally with custom sleep parameter' do
     it 'passes retry count and exception on retry' do
       expect(Kernel).to receive(:sleep).once.with(3)

data/spec/retryable_spec.rb

@@ -78,14 +78,29 @@ RSpec.describe Retryable do
       expect(counter.count).to eq(3)
     end
 
-    it 'retries infinitely' do
-      expect do
-        Timeout.timeout(3) do
-          counter(tries: :infinite, sleep: 0.1) { raise StandardError }
-        end
-      end.to raise_error Timeout::Error
+    context 'infinite retries' do
+      example 'with magic constant' do
+        expect do
+          Timeout.timeout(3) do
+            counter(tries: :infinite, sleep: 0.1) { raise StandardError }
+          end
+        end.to raise_error Timeout::Error
+
+        expect(counter.count).to be > 10
+      end
 
-      expect(counter.count).to be > 10
+      example 'with native infinity data type' do
+        expect do
+          require 'bigdecimal'
+
+          tries = [Float::INFINITY, BigDecimal::INFINITY, BigDecimal("1.0") / BigDecimal("0.0")]
+          Timeout.timeout(3) do
+            counter(tries: tries.sample, sleep: 0.1) { raise StandardError }
+          end
+        end.to raise_error Timeout::Error
+
+        expect(counter.count).to be > 10
+      end
     end
 
     it 'executes exponential backoff scheme for :sleep option' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: retryable
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Nikita Fedyashev
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-20 00:00:00.000000000 Z
+date: 2019-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -70,8 +70,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Retrying code blocks in Ruby