retentiongrid 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 296a60c0128c31e8dcac9d228abbfa45368304af
-  data.tar.gz: f7f6913b175940dd7201754c834f50172d4d5fe7
+  metadata.gz: 24fb32635d2a74736c03ef77f1da24fe73b68a79
+  data.tar.gz: 20292022dc0b3f0814184b84ac11a990dd1cd526
 SHA512:
-  metadata.gz: b9a8e54ef544bc1fd23dcee0666b23acb156dae2bc6b5cd05d553d34811a633156f1170ab1a62310e06c70f09d71e9713fee18471a1712a38287363baef472b6
-  data.tar.gz: 2e63450795275aa8377f4f7c0841fc78f4e2fd957a16f852ab0b21d79a71f0caa0105da8f52179ab3e13e7b54bacc94352cb892775dd65e92238e78b69afd9f1
+  metadata.gz: 5654c2ec32d372aad12587ab0d93e08c653779028312d3ab92c21702ceec21d8b5ecd9d62fa9086710caa6b97c8f7137b143299987e13cbbb8ff0e5a7f8d1110
+  data.tar.gz: accbccc386f6587cefb87901d6c616ea36baf8343b97e000e0d75d47d6a78fbfbf9d97fb78fbe773fc30dfce69128b1a186dedf744012d5636f4e1605c188ee5

data/lib/retentiongrid/api.rb

@@ -32,7 +32,12 @@ module Retentiongrid
       # @raise [Retentiongrid::ServerError] (500) in case something went wrong on the retentiongrid server
       # @return [Httparty::Response]
       def get_with_response_check(*args)
-        check_response_codes(get_without_response_check(*args))
+        begin
+          check_response_codes(get_without_response_check(*args))
+        rescue TooManyRequests => e
+          sleep 1
+          retry
+        end
       end
       alias_method :get_without_response_check, :get
       alias_method :get, :get_with_response_check
@@ -45,7 +50,12 @@ module Retentiongrid
       # @raise [Retentiongrid::ServerError] (500) in case something went wrong on the retentiongrid server
       # @return [Httparty::Response]
       def post_with_response_check(*args)
-        check_response_codes(post_without_response_check(*args))
+        begin
+          check_response_codes(post_without_response_check(*args))
+        rescue TooManyRequests => e
+          sleep 1
+          retry
+        end
       end
       alias_method :post_without_response_check, :post
       alias_method :post, :post_with_response_check
@@ -58,7 +68,12 @@ module Retentiongrid
       # @raise [Retentiongrid::ServerError] (500) in case something went wrong on the retentiongrid server
       # @return [Httparty::Response]
       def delete_with_response_check(*args)
-        check_response_codes(delete_without_response_check(*args))
+        begin
+          check_response_codes(delete_without_response_check(*args))
+        rescue TooManyRequests => e
+          sleep 1
+          retry
+        end
       end
       alias_method :delete_without_response_check, :delete
       alias_method :delete, :delete_with_response_check
@@ -78,6 +93,7 @@ module Retentiongrid
       when 405 then raise MethodNotAllowed.new(body)
       when 410 then raise Gone.new(body)
       when 422 then raise UnprocessableEntity.new(body)
+      when 429 then raise TooManyRequests.new(body)
       when 500 then raise ServerError, 'Internal Server Error'
       when 503 then raise Unavailable, 'Service Unavailable'
       else raise "Unknown response code: #{response.code}"

data/lib/retentiongrid/errors.rb

@@ -30,6 +30,9 @@ module Retentiongrid
   # The request was well-formed but was unable to be followed due to semantic errors.
   class UnprocessableEntity < HTTParty::Error; end # 422
 
+  # The request was ok, but you sent too many after each other
+  class TooManyRequests < HTTParty::Error; end # 429
+
   # Unspecified API server error.
   class ServerError < HTTParty::Error; end # 500
 

data/lib/retentiongrid/product.rb

@@ -7,7 +7,7 @@ module Retentiongrid
     ATTRIBUTES_NAMES = [  :product_id, :available, :metadata,
                           :title, :image_url, :currency, :price,
                           :sale_price, :cost_price, :product_url,
-                          :product_created_at, :product_updated_at, :metadata
+                          :product_created_at, :product_updated_at
                        ].freeze
 
     ATTRIBUTES_NAMES.each do |attrib|

data/lib/retentiongrid/version.rb

@@ -1,3 +1,3 @@
 module Retentiongrid
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/spec/integration/line_item_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe LineItem do
         "product_id": 25,
         "variant_id": null,
         "sku": "",
-        "name": "Protestsülze"
+        "name": "Protestsuelze"
       }
     }
     EOF

data/spec/integration/product_spec.rb

@@ -36,6 +36,13 @@ RSpec.describe Product do
       Product.find('123')
     end
 
+    it "should retry upon 429 TooManyRequests" do
+      stub_request(:get, "http://retentiongrid.apiary-mock.com/products/123").
+        to_return(:status => 429, :body => '429 Too Many Requests (5 request/s on average allowed. Burst of max 10/s require you to wait 1 second.)', :headers => {'Content-Type' => 'text/plain'}).then.
+        to_return(:status => 200, :body => valid_order, :headers => {'Content-Type' => 'application/json'})
+      Product.find('123')
+    end
+
     it "should build a Product from API response" do
       expect(subject.class).to eql Retentiongrid::Product
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: retentiongrid
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Christoph Bünte
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-19 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A ruby client for retentiongrid.com API.