retained 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5889b1f2f5d17776a5955402abf0bb72a628c1b
-  data.tar.gz: d0e5963b0989d0bdf257b4f6b1be551538dec580
+  metadata.gz: 73e354c2a489016a3d1c873e021d8f1b58a18dd2
+  data.tar.gz: 84dc43a781952b4a5b6d97584e1fff0d7ff77665
 SHA512:
-  metadata.gz: 62d5f2c52a6286581a4924a3f23df5918450345e40088e3c0d012b24a9a53d3c505cd0199d0c93fb4a590237ad6e80f42b64a3821844defed9f81d83cb59d703
-  data.tar.gz: 9279624e9cc42bf400675110ddecddf97cba3c8436880abe5e17e571a7a6b0a9f728b02bd2611cd632ce55184cbdf983320a94c72063d03e1920a41ed7f50819
+  metadata.gz: 2939b0bf01bfd76a12106ad70b87c57885b9a80d27b6cac0e7ae28fabebc02efec4e8fba4dab704421c68104f7280d06a147c89dc64106868a535bc237fdf75c
+  data.tar.gz: de8476c725c0db2dfeb7335309a42e3524ddf857a1ec43efd6e7f573160f357adca06edb3636c0ac3f83539bffadcac91c4c2d614e631243196a945bc2e6279c

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 0.2.3
+
+  * Updated to latest redis-bitops, which includes multiple fixes
+  and performance improvements.
+  * Refactor to ensure that unique_active is properly measured
+  across measurement periods.
+
 # 0.2.2
 
   * Fixed default group.  Was erroneously using an empty string

data/Gemfile

@@ -1,7 +1,7 @@
 source 'http://rubygems.org'
 
 gem 'redis', '~> 3.1.0'
-gem 'redis-bitops', github: 'msaffitz/redis-bitops', branch: 'watch_keys_fix'
+gem 'redis-bitops', github: 'msaffitz/redis-bitops', ref: '2ebd12b5044046db67e7958eda0701257b3eb3f9'
 gem 'activesupport'
 
 group :development do

data/Gemfile.lock

@@ -1,7 +1,7 @@
 GIT
   remote: git://github.com/msaffitz/redis-bitops.git
-  revision: a82f1bdc809e843ff297bcaf4c7664d3fc461772
-  branch: watch_keys_fix
+  revision: 2ebd12b5044046db67e7958eda0701257b3eb3f9
+  ref: 2ebd12b5044046db67e7958eda0701257b3eb3f9
   specs:
     redis-bitops (0.2.1)
       redis

data/lib/retained/tracker.rb

@@ -34,7 +34,8 @@ module Retained
     # period is provided.
     def unique_active(group: 'default', start:, stop: Time.now)
       bitmaps = []
-      while ( start <= stop)
+      start = period_start(group, start)
+      while (start <= stop)
         bitmaps << config.redis_connection.sparse_bitmap(key_period(group, start))
         start += seconds_in_reporting_interval(config.group(group).reporting_interval)
       end
@@ -83,11 +84,15 @@ LUA
     # Returns the key for the group at the period.  All periods are
     # internally stored relative to UTC.
     def key_period(group, period)
-      period = period.utc.send("beginning_of_#{config.group(group).reporting_interval}")
-      "#{config.prefix}:#{group}:#{period.to_i}"
+      "#{config.prefix}:#{group}:#{period_start(group, period).to_i}"
     end
 
     private
+    # Returns the time (UTC) that the period starts at for the given group
+    def period_start(group, period)
+      period.utc.send("beginning_of_#{config.group(group).reporting_interval}")
+    end
+
     def seconds_in_reporting_interval(interval)
       case(interval.to_sym)
         when :day    then 60*60*24

data/lib/retained/version.rb

@@ -2,7 +2,7 @@ module Retained
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 2
+    PATCH = 3
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')

data/retained.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: retained 0.2.2 ruby lib
+# stub: retained 0.2.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "retained"
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Mike Saffitz"]
-  s.date = "2014-11-07"
+  s.date = "2014-11-16"
   s.description = "\n    Easy tracking of activity and retention at scale in daily, hourly, or minute intervals\n    using sparse Redis bitmaps.\n  "
   s.email = "m@saffitz.com"
   s.extra_rdoc_files = [

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: retained
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Mike Saffitz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-07 00:00:00.000000000 Z
+date: 2014-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis