restpack_serializer 0.6.5 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7b7353b8336e2522e29fd3f7d784cb3d0b7700aa
-  data.tar.gz: d82b914f3692048c54b3725f8909c40c469b4a0f
+  metadata.gz: 33de851fe3b900b57c1cd36c7146dd6d7e799ee5
+  data.tar.gz: fc2674844a0ad0a839cab52e2182c0661611a763
 SHA512:
-  metadata.gz: 3e188183204596a3010a77922b7ce1bf7567dc5a2e9935f503bab9b10147f9cf5be77cdd678dead2ce697bfaefeb8f02641049329526af0a84a73efc035f5d40
-  data.tar.gz: f2da61ed3c6ec04db90bd9a5720e1d983f9a71c341d355e474f3849ec85e77fa0963b79177f8019397ccd8ab775a65b9d5987d12d4c10b865cffa783628c16b3
+  metadata.gz: 94794f6281fbd6c7efe7d36ab39439d462ba0200605c1c488dee9522311e4fc5a917e7b660eab673e41d96339ec35a3d9eb67fac87b48dcfb908d8a9705dff9e
+  data.tar.gz: 7bec627210c72d263d706a53391e48db1721dc9a6ea754a2e31043fa036e5f8cbdd629896d0b42a72062230a9ce2b8d838c2ff85b1ee89902ba79be3068d9203

data/lib/restpack_serializer/serializable.rb

@@ -38,15 +38,13 @@ module RestPack
       end
 
       @model, @context = model, context
-      user_defined_methods = self.class.user_defined_methods || []
 
       data = {}
       if self.class.serializable_attributes.present?
         self.class.serializable_attributes.each do |key, attribute|
           method_name = attribute[:include_method_name]
           name = attribute[:name]
-
-          if user_defined_methods.include?(method_name)
+          if self.class.memoized_has_user_defined_method?(method_name)
             data[key] = self.send(name) if self.send(method_name)
           else
             #the default implementation of `include_abc?`
@@ -105,6 +103,24 @@ module RestPack
         end
       end
 
+      def has_user_defined_method?(method_name)
+        user_defined_methods = self.user_defined_methods || []
+        return true if user_defined_methods.include?(method_name)
+        return self.superclass.try(:has_user_defined_method?, method_name)
+      end
+
+      def memoized_has_user_defined_method?(method_name)
+        @memoized_user_defined_methods ||= {}
+
+        if @memoized_user_defined_methods.has_key? method_name
+          return @memoized_user_defined_methods[method_name]
+        else
+          has_method = has_user_defined_method?(method_name)
+          @memoized_user_defined_methods[method_name] = has_method
+          return has_method
+        end
+      end
+
       def array_as_json(models, context = {})
         new.as_json(models, context)
       end

data/lib/restpack_serializer/version.rb

@@ -1,5 +1,5 @@
 module RestPack
   module Serializer
-    VERSION = '0.6.5'
+    VERSION = '0.6.6'
   end
 end

data/spec/serializable/serializer_spec.rb

@@ -34,27 +34,48 @@ describe RestPack::Serializer do
   context "serializer inheritance" do
     class BaseSerializer
       include RestPack::Serializer
-      attributes :name
+      attributes :name, :colour
+      optional :count
 
       def name
-        "Ben"
+        @context[:name]
+      end
+
+      def count
+        99
       end
 
       def age
         -2
       end
+
+      def colour
+        'purple'
+      end
+
+      def include_colour?
+        false
+      end
     end
 
     class DerivedSerializer < BaseSerializer
-      attributes :name, :age
+      attributes :name, :age, :food, :colour, :count
 
       def age
-        1
+        @context[:age]
+      end
+
+      def food
+        'crackers'
       end
     end
 
     it ".as_json serializes" do
-      DerivedSerializer.as_json(person).should == { name: "Ben", age: 1 }
+      serialized = DerivedSerializer.as_json({}, { include_food?: false, name: 'Ben', age: 1 })
+      serialized.should == { #NOTE: I think this should include colour as DerivedSerializer defines it, but this would be a big breaking change
+        name: "Ben",
+        age: 1
+      }
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: restpack_serializer
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.6.6
 platform: ruby
 authors:
 - Gavin Joyce
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-10 00:00:00.000000000 Z
+date: 2016-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport