restify 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f44b84123c73ffd08cc8668448b03470c06acaf0f693e844fface91ff44179b5
-  data.tar.gz: c194b2db48a18a7f234bba20ff4161f98277b1146e6b7bf2572c877c285c3794
+  metadata.gz: 9393a0338cd138604044dd16e2ced2370b317d00c4317dfb05f559d4dd9111e4
+  data.tar.gz: '0348f419a9d4aadb7edc5e5c5ded5f3317ddac726571eaec3a81e180993323b0'
 SHA512:
-  metadata.gz: 89de3a2282568b6cd4b58afdf04e2271abf283721a25535e5420a4b1e52e4ed6b3edf894180d6fd15ee010c7692f99942c047fe7baef81d5bd67ff13b756e189
-  data.tar.gz: e6b18bfd819aec933acdb9fbec820ea7e742918eebc795c77f5f7ba0b927ccae85b876b367df8325d90e2899aad77bcf30f691781419669fd7406a156e197f86
+  metadata.gz: 36f07fdcba6ed8bdfebd6ef58bcb1929a8ae4bb96a0201936fceccc618c095cb8ca4ca7cb387d9b98dcd9551bf08f22ed304eb67651a2ba71c25a657b3804b4f
+  data.tar.gz: 3ab69445ea47a84ad59aa9dc2050ec8fa507283d89fb9aca641a55e7a51893e6c0989d3052f00d8160cbfd6530808b566ae593e91711cf460f3ee1d7b3cf2a53

data/CHANGELOG.md

@@ -1,91 +1,132 @@
 # Changelog
+All notable changes to this project will be documented in this file.
 
-## 1.10.0
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-* Raise more specific error on a few status codes (#17)
-* Complete promises with an empty list (but a list) of dependencies (#18)
 
-## 1.9.0
+## Unreleased
+---
 
-* Do not raise error on 3XX responses but return responses
+### New
 
-## 1.8.0
+### Changes
 
-* Add HEAD request method (#16)
+### Fixes
 
-## 1.7.0
+### Breaks
 
-* Introduce promise dependency timeouts (#15)
 
-## 1.6.0
+## 1.11.0 - (2019-07-11)
+### New
+* Explicit exception classes for HTTP status codes 500, 502, 503, 504
 
-* Specify headers on restify clients and individual requests (#14)
+## 1.10.0 - 2018-12-11
+### Changed
+- Raise more specific error on a few status codes (#17)
+- Complete promises with an empty list (but a list) of dependencies (#18)
 
-## 1.5.0
+## 1.9.0 - 2018-11-13
+### Changed
+- Do not raise error on 3XX responses but return responses
 
-* Tune typhoeus adapter to be more race-condition resilent
-* Add MessagePack processor enabled by default
+## 1.8.0 - 2018-08-22
+### Added
+- Add HEAD request method (#16)
 
-## 1.4.4
+## 1.7.0 - 2018-08-15
+### Added
+- Introduce promise dependency timeouts (#15)
 
-* Fix race condition in typhoeus adapter
-* Add `#request` to `NetworkError` to ease debugging
+## 1.6.0 - 2018-08-09
+### Changed
+- Specify headers on restify clients and individual requests (#14)
 
-## 1.4.3
+## 1.5.0 - 2018-07-31
+### Added
+- Add MessagePack processor enabled by default
 
-* Add advanced logging capabilities using logging gem
-* Improve compatibility with webmocks returning `nil` as headers
+### Changed
+- Tune typhoeus adapter to be more race-condition resilent
 
-## 1.4.1
+## 1.4.4 - 2018-07-13
+### Added
+- Add `#request` to `NetworkError` to ease debugging
 
-* Fix possible deadlock issues
+### Changed
+- Fix race condition in typhoeus adapter
 
-## 1.4.0
+## 1.4.3 - 2017-11-15
+### Added
+- Add advanced logging capabilities using logging gem
 
-* Fix possible concurrency issue with typhoeus adapter
-* Add timeout option to requests (only supported by typhoeus adapter)
+### Changed
+- Improve compatibility with webmocks returning `nil` as headers
 
-## 1.3.1
+## 1.4.1 - 2017-11-15
+### Changed
+- Fix possible deadlock issues
 
-* Improve typhoeus adapters initial request queuing
-* Disable default pipelining
+## 1.4.0 - 2017-11-10
+### Added
+- Add timeout option to requests (only supported by typhoeus adapter)
 
-## 1.3.0
+### Changed
+- Fix possible concurrency issue with typhoeus adapter
 
-* Improve typhoeus adapter to better utilize concurrency
-* Default to new typhoeus adapter
+## 1.3.1 - 2017-11-10
+### Changed
+- Improve typhoeus adapters initial request queuing
+- Disable default pipelining
 
-## 1.2.1
+## 1.3.0 - 2017-11-08
+### Changed
+- Improve typhoeus adapter to better utilize concurrency
+- Default to new typhoeus adapter
 
-* Fix issue with Ruby 2.2 compatibility
+## 1.2.1 - 2017-10-30
+### Changed
+- Fix issue with Ruby 2.2 compatibility
 
-## 1.2.0
+## 1.2.0 - 2017-10-30
+### Added
+- Add experimental PooledEM adapter (#10)
 
-* Add experimental PooledEM adapter (#10)
-* Improve marshalling of resources
+### Changed
+- Improve marshaling of resources
 
-## 1.1.0
+## 1.1.0 - 2017-05-12
+### Added
+- Add shortcuts for creating fulfilled / rejected promises (#6)
 
-* Return response body if no processor matches (#7)
-* Add shortcuts for creating fulfilled / rejected promises (#6)
+### Changed
+- Return response body if no processor matches (#7)
 
-## 1.0.0
+## 1.0.0 - 2016-08-22
+### Added
+- Experimental cache API doing nothing for now
 
-* Experimental cache API doing nothing for now
-* Use `~> 1.0` of `concurrent-ruby`
+### Changed
+- Use `~> 1.0` of `concurrent-ruby`
 
-## 0.5.0
+## 0.5.0 - 2016-04-04
+### Added
+- Add `sync` option to typhoeus adapter
+- Add registry for storing entry points
 
-* Add `sync` option to typhoeus adapter
-* Add registry for storing entry points
-* Make eventmachine based adapter default
+### Changed
+- Make eventmachine based adapter default
 
-## 0.4.0
+## 0.4.0 - 2016-02-24
+### Added
+- Add method to explicit access resource data
 
-* Add method to explicit access resource data
-* Drop obligation in favor of simple Concurrent::IVar based promise class.
+### Changed
+- Use typhoeus as default adapter
+- `Restify.new` returns relation now instead of resource
+
+### Removed
+- Drop obligation in favor of simple Concurrent::IVar based promise class.
   Notable changes:
-    - Returned object us of type `Restify::Promise` now.
-    - `value` will not raise exception but return `nil` in case of failure. Use `value!` for old behavior.
-* Use typhoeus as default adapter
-* `Restify.new` returns relation now instead of resource
+  - Returned object us of type `Restify::Promise` now.
+  - `value` will not raise exception but return `nil` in case of failure. Use `value!` for old behavior.

data/README.md

@@ -1,6 +1,7 @@
 # Restify
 
 [![Build Status](https://travis-ci.org/jgraichen/restify.svg?branch=master)](https://travis-ci.org/jgraichen/restify)
+[![Code Quality](https://codebeat.co/badges/18ffe6b7-8239-493a-b5b6-be329b9f275d)](https://codebeat.co/projects/github-com-jgraichen-restify-master)
 
 Restify is an hypermedia REST client that does parallel, concurrent and keep-alive requests by default.
 

data/lib/restify/adapter/typhoeus.rb

@@ -21,6 +21,7 @@ module Restify
         @hydra  = ::Typhoeus::Hydra.new(**options)
         @mutex  = Mutex.new
         @signal = ConditionVariable.new
+        @thread = nil
       end
 
       def sync?

data/lib/restify/error.rb

@@ -34,6 +34,14 @@ module Restify
           UnprocessableEntity.new(response)
         when 400...500
           ClientError.new(response)
+        when 500
+          InternalServerError.new(response)
+        when 502
+          BadGateway.new(response)
+        when 503
+          ServiceUnavailable.new(response)
+        when 504
+          GatewayTimeout.new(response)
         when 500...600
           ServerError.new(response)
         else
@@ -87,6 +95,13 @@ module Restify
   # 5XX status code.
   class ServerError < ResponseError; end
 
+  # A {GatewayError} is the common base class for 502, 503 and 504
+  # response codes often used by load balancers when upstream servers are
+  # failing or not available.
+  #
+  # This can be used to catch "common" gateway responses.
+  class GatewayError < ResponseError; end
+
   ###
   # CONCRETE SUBCLASSES FOR TYPICAL STATUS CODES
   #
@@ -97,4 +112,10 @@ module Restify
   class NotFound < ClientError; end
   class NotAcceptable < ClientError; end
   class UnprocessableEntity < ClientError; end
+
+  class InternalServerError < ServerError; end
+
+  class BadGateway < GatewayError; end
+  class ServiceUnavailable < GatewayError; end
+  class GatewayTimeout < GatewayError; end
 end

data/lib/restify/link.rb

@@ -25,10 +25,10 @@ module Restify
     end
 
     class << self
-      REGEXP_URI = /<[^>]*>\s*/
-      REGEXP_PAR = /;\s*\w+\s*=\s*/i
-      REGEXP_QUT = /"[^"]*"\s*/
-      REGEXP_ARG = /\w+\s*/i
+      REGEXP_URI = /<[^>]*>\s*/.freeze
+      REGEXP_PAR = /;\s*\w+\s*=\s*/i.freeze
+      REGEXP_QUT = /"[^"]*"\s*/.freeze
+      REGEXP_ARG = /\w+\s*/i.freeze
 
       def parse(string)
         scanner = StringScanner.new(string.strip)

data/lib/restify/promise.rb

@@ -23,6 +23,7 @@ module Restify
 
       super
       raise t if incomplete?
+
       self
     end
 

data/lib/restify/relation.rb

@@ -79,6 +79,7 @@ module Restify
 
     def convert_param(value)
       return value.to_param.to_s if value.respond_to?(:to_param)
+
       value
     end
 

data/lib/restify/timeout.rb

@@ -61,6 +61,7 @@ module Restify
     class << self
       def new(timeout, *args)
         return timeout if timeout.is_a?(self)
+
         super
       end
     end

data/lib/restify/version.rb

@@ -3,7 +3,7 @@
 module Restify
   module VERSION
     MAJOR = 1
-    MINOR = 10
+    MINOR = 11
     PATCH = 0
     STAGE = nil
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.').freeze

data/spec/restify/error_spec.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Restify::ResponseError do
+  let(:response) { double 'response' }
+  let(:message) { 'Error' }
+  let(:uri) { 'http://localhost' }
+
+  before do
+    allow(response).to receive(:uri).and_return(uri)
+    allow(response).to receive(:code).and_return(code)
+    allow(response).to receive(:message).and_return(message)
+    allow(response).to receive(:decoded_body).and_return({})
+  end
+
+
+  describe '.from_code' do
+    subject(:err) { described_class.from_code(response) }
+
+    context 'with 400 Bad Request' do
+      let(:code) { 400 }
+      it { is_expected.to be_a ::Restify::BadRequest }
+    end
+
+    context 'with 401 Unauthorized' do
+      let(:code) { 401 }
+      it { is_expected.to be_a ::Restify::Unauthorized }
+    end
+
+    context 'with 404 Unauthorized' do
+      let(:code) { 404 }
+      it { is_expected.to be_a ::Restify::NotFound }
+    end
+
+    context 'with 406 Not Acceptable' do
+      let(:code) { 406 }
+      it { is_expected.to be_a ::Restify::NotAcceptable }
+    end
+
+    context 'with 422 Unprocessable Entity' do
+      let(:code) { 422 }
+      it { is_expected.to be_a ::Restify::UnprocessableEntity }
+    end
+
+    context 'with 500 Internal Server Error' do
+      let(:code) { 500 }
+      it { is_expected.to be_a ::Restify::InternalServerError }
+    end
+
+    context 'with 502 Bad Gateway' do
+      let(:code) { 502 }
+      it { is_expected.to be_a ::Restify::BadGateway }
+    end
+
+    context 'with 503 Service Unavailable' do
+      let(:code) { 503 }
+      it { is_expected.to be_a ::Restify::ServiceUnavailable }
+    end
+
+    context 'with 504 Gateway Timeout' do
+      let(:code) { 504 }
+      it { is_expected.to be_a ::Restify::GatewayTimeout }
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -3,11 +3,14 @@
 require 'rspec'
 require 'webmock/rspec'
 
-if ENV['CI'] || (defined?(:RUBY_ENGINE) && RUBY_ENGINE != 'rbx')
-  require 'coveralls'
-  Coveralls.wear! do
-    add_filter 'spec'
-  end
+require 'simplecov'
+SimpleCov.start do
+  add_filter 'spec'
+end
+
+if ENV['CI']
+  require 'codecov'
+  SimpleCov.formatter = SimpleCov::Formatter::Codecov
 end
 
 require 'restify'
@@ -51,6 +54,7 @@ RSpec.configure do |config|
     ::Logging.logger.root.add_appenders ::Logging.appenders.stdout
   end
 
+  config.warnings = true
   config.after(:suite) do
     EventMachine.stop if defined?(EventMachine) && EventMachine.reactor_running?
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: restify
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2019-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -140,16 +140,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
 description: An experimental hypermedia REST client that uses parallel, keep-alive
   and pipelined requests by default.
 email:
@@ -186,6 +186,7 @@ files:
 - lib/restify/version.rb
 - spec/restify/cache_spec.rb
 - spec/restify/context_spec.rb
+- spec/restify/error_spec.rb
 - spec/restify/features/head_requests_spec.rb
 - spec/restify/features/request_headers_spec.rb
 - spec/restify/features/response_errors.rb
@@ -221,13 +222,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: An experimental hypermedia REST client.
 test_files:
 - spec/restify/cache_spec.rb
 - spec/restify/context_spec.rb
+- spec/restify/error_spec.rb
 - spec/restify/features/head_requests_spec.rb
 - spec/restify/features/request_headers_spec.rb
 - spec/restify/features/response_errors.rb