restfulness 0.2.6 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c6d3884753e3b58d9c9d459a633f5973de4b5f2
-  data.tar.gz: 7694025035531b633586bbb361978b543c37a532
+  metadata.gz: 7c75c4e41bde16b35b2e5ea93df0958073b8d114
+  data.tar.gz: 4d72d5c989d8d4cc1fdabdeb92475a07ee0e354a
 SHA512:
-  metadata.gz: dc2abb03ebf2caea3f7f2e528b19917bbb7d7144c4f4ddc78ee5e8469c0aa53c2a2f45b8d4865b21ca21ffbfaa4c10072864358361238b92eb0b9b84cf7b21d9
-  data.tar.gz: ae4f3c662aeb5b5e78a331fc5225d27289727ccc22c22f8d957d89e6178d7dfd262aaa65d45a301d3ae14dfa74b6f7fbf2580f222f7adc5aa9f3dddeab41df68
+  metadata.gz: f78f392d57d5d9c64fc446def406f99fe12fdad295ad415bf15a9f3d7c789def2b304face6fc1e1a60f7db8dc256002aa6bce2a936e46f69b07abdfef1046183
+  data.tar.gz: 198200ae4575a6f756a75b142c4d07683cd1f4105cf8cd317603c018491c3d5644c5add334fbdcbeb4251b529bf6b4d648c1eb44e4256a04e1904b05c9365516

data/README.md

@@ -246,7 +246,7 @@ Resources also have support for simple set of built-in callbacks. These have sim
 
 The supported callbacks are:
 
- * `exists?` - True by default, not called in create actions like POST.
+ * `exists?` - True by default, not called in create actions like POST or PUT.
  * `authorized?` - True by default, is the current user valid?
  * `allowed?` - True by default, does the current have access to the resource?
  * `last_modified` - The date of last update on the model, only called for GET and HEAD requests. Validated against the `If-Modified-Since` header.
@@ -331,8 +331,8 @@ request.path[0]            # 'project
 request.path.to_s          # '/project/123456/task/234567'
 request.path               # ['project', '123456', 'task', '234567']
 request.path[:id]          # '234567'
-require.path[:project_id]  # '123456'
-require.path[2]            # 'task'
+request.path[:project_id]  # '123456'
+request.path[2]            # 'task'
 
 # The request query
 request.query              # {:page => 1} - Hash with indifferent access
@@ -618,6 +618,11 @@ Restfulness is still a work in progress but at Cabify we are using it in product
 
 ## History
 
+### 0.3.0 - May 13, 2014
+
+ * Possible breaking change: `put` requests no longer check for existing resource via `exists?` callback. (@samlown)
+ * Avoid Rack Lint errors by not providing Content-Type or Length in empty responses. (@samlown)
+
 ### 0.2.6 - March 7, 2014
 
  * Support scope block when adding a resource to router. (@samlown)

data/lib/restfulness/resource.rb

@@ -60,7 +60,7 @@ module Restfulness
       forbidden!          unless allowed?
 
       # The following callbacks only make sense for certain methods
-      if [:head, :get, :put, :patch, :delete].include?(request.action)
+      if [:head, :get, :patch, :delete].include?(request.action)
         resource_not_found! unless exists?
 
         if [:get, :head].include?(request.action)

data/lib/restfulness/response.rb

@@ -70,10 +70,10 @@ module Restfulness
     def payload=(body)
       if body.nil? || body.is_a?(String)
         @payload = body.to_s
-        update_content_headers(:text)
+        update_content_headers(:text) unless @payload.empty?
       else
         @payload = MultiJson.encode(body)
-        update_content_headers(:json)
+        update_content_headers(:json) unless @payload.empty?
       end
     end
     

data/lib/restfulness/version.rb

@@ -1,3 +1,3 @@
 module Restfulness
-  VERSION = "0.2.6"
+  VERSION = "0.3.0"
 end

data/spec/unit/resource_spec.rb

@@ -142,7 +142,7 @@ describe Restfulness::Resource do
       }.to raise_error(Restfulness::HTTPException, "Method Not Allowed")
     end
 
-    [:head, :get, :put, :delete].each do |action|
+    [:head, :get, :patch, :delete].each do |action|
       it "should raise error when not exists for #{action.to_s.upcase}" do
         request.action = action
         obj.stub(:exists?).and_return(false)
@@ -152,7 +152,7 @@ describe Restfulness::Resource do
       end
     end
 
-    [:post].each do |action|
+    [:put, :post].each do |action|
       it "should not check exists? for #{action.to_s.upcase}" do
         obj.request.action = action
         obj.should_not_receive(:exists?)

data/spec/unit/response_spec.rb

@@ -40,8 +40,8 @@ describe Restfulness::Response do
         obj.run
         obj.status.should eql(404)
         obj.payload.should be_empty
-        obj.headers['Content-Type'].should match(/text\/plain/)
-        obj.headers['Content-Length'].should eql(0.to_s)
+        obj.headers['Content-Type'].should be_nil
+        obj.headers['Content-Length'].should be_nil
       end
     end
     context "with route" do
@@ -75,7 +75,8 @@ describe Restfulness::Response do
         route.stub(:build_resource).and_return(resource)
         obj.run
         obj.status.should eql(204)
-        obj.headers['Content-Type'].should match(/text\/plain/)
+        obj.headers['Content-Type'].should be_nil
+        obj.headers['Content-Length'].should be_nil
       end
 
       it "should set string content type if payload is a string" do

data/spec/unit/router_spec.rb

@@ -48,10 +48,10 @@ describe Restfulness::Router do
         add 'examples', SecondRouterResource
       end
       route = obj.routes.first
-      route.resource.should eql(RouterResource)
+      route.resource.should eql(SecondRouterResource)
       route.path.should eql(['project', 'examples'])
       route = obj.routes.last
-      route.resource.should eql(SecondRouterResource)
+      route.resource.should eql(RouterResource)
       route.path.should eql(['project'])
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: restfulness
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.3.0
 platform: ruby
 authors:
 - Sam Lown
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-07 00:00:00.000000000 Z
+date: 2014-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack