restful_resource 2.2.6 → 2.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b0958e356e2525fc286894548cc434ff68486f4c
-  data.tar.gz: e7ca6b8704b648c7d55482d988fa59ee8ab648a0
+  metadata.gz: 9faff51b36ab1690640882d31329a7737aa68f4e
+  data.tar.gz: f850d5a2afc9f32bbc18f9673dc82ed9d520ca33
 SHA512:
-  metadata.gz: c6bde5bde53b14d936f6afbe2e483fc1a99502f6d6b9f58a19f4e4b2b1e50c532d2aae7367b626a8797355ba1439c69d69bc8789d0ca816c19033e9ee8b78fa4
-  data.tar.gz: 7ef2459add247da55d390c2c7dc2caac34f6473d9bd53e23f4be19f455daf054d973c0df27651a5713da024ba4edfb775757a7548be3b8b96dfa9271748d2746
+  metadata.gz: 137d0b430d88db910b9e6ed5de1c6f00c50e509a94cfc46c51ffd819245cf9103d5bf4e6063e3da7473518927adda7958f056727a2c7c635772e84b5879aa2e9
+  data.tar.gz: c03523b7ae7a3763185d484cf0a49f2491cac3cec1862271d7bd5bc1801367ddb8e7a01f3418da3a467b3a5ac19ceac6194afeb57537688b6d99493372c20c03

data/lib/restful_resource/base.rb

@@ -8,11 +8,9 @@ module RestfulResource
                        logger: nil,
                        cache_store: nil,
                        instrumentation: {},
-                       context_lambda: nil,
                        faraday_config: nil)
 
       @base_url = URI.parse(base_url)
-      @context_lambda = context_lambda
 
       @http = RestfulResource::HttpClient.new(username: username,
                                               password: password,
@@ -56,7 +54,7 @@ module RestfulResource
 
     def self.put(id, data: {}, headers: {}, **params)
       params_without_options, options = format_params(params)
-      headers.merge! options.delete(:headers)
+      options.delete(:headers)
 
       url = member_url(id, params_without_options)
 
@@ -66,7 +64,7 @@ module RestfulResource
 
     def self.post(data: {}, headers: {}, **params)
       params_without_options, options = format_params(params)
-      headers.merge! options.delete(:headers)
+      options.delete(:headers)
 
       url = collection_url(params_without_options)
 
@@ -121,18 +119,12 @@ module RestfulResource
       replace_parameters(url, params)
     end
 
-    def self.context_lambda
-      superclass.instance_variable_get :@context_lambda
-    end
-
     private
 
     def self.format_params(params = {})
       headers = params.delete(:headers) || {}
 
       headers.merge!(cache_control: 'no-cache') if params.delete(:no_cache)
-      headers.merge!(context_headers) if self.context_lambda
-
       open_timeout = params.delete(:open_timeout)
       timeout = params.delete(:timeout)
 
@@ -192,12 +184,5 @@ module RestfulResource
       array = parse_json(response.body).map { |attributes| self.new(attributes) }
       PaginatedArray.new(array, previous_page_url: prev_url, next_page_url: next_url, total_count: response.headers[:x_total_count])
     end
-
-    def self.context_headers
-      self
-      .context_lambda
-      .call
-      .select { |k,_| k.to_s.start_with?('source_') }
-    end
   end
 end

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = '2.2.6'
+  VERSION = '2.2.7'
 end

data/spec/restful_resource/base_spec.rb

@@ -65,32 +65,6 @@ RSpec.describe RestfulResource::Base do
 
       Make.find(12, no_cache: true)
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_get("http://api.carwow.co.uk/makes/12",
-        RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Make.find(12, no_cache: true)
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_get("http://api.carwow.co.uk/makes/12",
-        RestfulResource::Response.new,
-        headers: {
-          cache_control: 'no-cache',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Make.find(12, no_cache: true)
-    end
   end
 
   describe "#where" do
@@ -132,32 +106,6 @@ RSpec.describe RestfulResource::Base do
 
       Model.where(make_slug: 'Volkswagen', on_sale: true, group_id: 15, no_cache: true)
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true",
-        RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Model.where(make_slug: 'Volkswagen', on_sale: true, group_id: 15, no_cache: true)
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true",
-        RestfulResource::Response.new,
-        headers: {
-          cache_control: 'no-cache',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Model.where(make_slug: 'Volkswagen', on_sale: true, group_id: 15, no_cache: true)
-    end
   end
 
   describe "#all" do
@@ -186,32 +134,6 @@ RSpec.describe RestfulResource::Base do
 
       Make.all(no_cache: true)
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_get("http://api.carwow.co.uk/makes",
-        RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Make.all(no_cache: true)
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_get("http://api.carwow.co.uk/makes",
-        RestfulResource::Response.new,
-        headers: {
-          cache_control: 'no-cache',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Make.all(no_cache: true)
-    end
   end
 
   describe "#base_url" do
@@ -272,32 +194,6 @@ RSpec.describe RestfulResource::Base do
 
       Make.action(:average_score).get(no_cache: true)
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_get("http://api.carwow.co.uk/makes/average_score",
-        RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Make.action(:average_score).get(no_cache: true)
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_get("http://api.carwow.co.uk/makes/average_score",
-        RestfulResource::Response.new,
-        headers: {
-          cache_control: 'no-cache',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Make.action(:average_score).get(no_cache: true)
-    end
   end
 
   describe "#put" do
@@ -348,32 +244,6 @@ RSpec.describe RestfulResource::Base do
 
       Make.put(1, data: {}, headers: { accept: 'application/json' })
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_put("http://api.carwow.co.uk/makes/1",
-        RestfulResource::Response.new,
-        headers: { accept: 'application/json' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Make.put(1, data: {}, headers: { accept: 'application/json' })
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_put("http://api.carwow.co.uk/makes/1",
-        RestfulResource::Response.new,
-        headers: {
-          accept: 'application/json',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Make.put(1, data: {}, headers: { accept: 'application/json' })
-    end
   end
 
   describe "#post" do
@@ -396,32 +266,6 @@ RSpec.describe RestfulResource::Base do
 
       Make.post(data: {}, headers: { accept: 'application/json' })
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_post("http://api.carwow.co.uk/makes",
-        RestfulResource::Response.new,
-        headers: { accept: 'application/json' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Make.post(data: {}, headers: { accept: 'application/json' })
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_post("http://api.carwow.co.uk/makes",
-        RestfulResource::Response.new,
-        headers: {
-          accept: 'application/json',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Make.post(data: {}, headers: { accept: 'application/json' })
-    end
   end
 
   describe "#delete" do
@@ -441,32 +285,6 @@ RSpec.describe RestfulResource::Base do
 
       Make.delete(1, headers: { accept: 'application/json' })
     end
-
-    it 'skips context headers when context_lambda is not set' do
-      expect_delete("http://api.carwow.co.uk/makes/1",
-        RestfulResource::Response.new,
-        headers: { accept: 'application/json' })
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(nil)
-
-      Make.delete(1, headers: { accept: 'application/json' })
-    end
-
-    it 'adds context headers when context_lambda is set' do
-      expect_delete("http://api.carwow.co.uk/makes/1",
-        RestfulResource::Response.new,
-        headers: {
-          accept: 'application/json',
-          source_type: 'controller',
-          source_class: 'SomeController',
-          source_identifier: 'index',
-        }
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(context_lambda).twice
-
-      Make.delete(1, headers: { accept: 'application/json' })
-    end
   end
 
   describe ".as_json" do
@@ -516,43 +334,6 @@ RSpec.describe RestfulResource::Base do
                                       instrumentation: instrumentation,
                                       faraday_config: faraday_config)
     end
-
-    it "stores a lambda when it is defined" do
-      a_lambda = lambda { {context: 'info'} }
-
-      RestfulResource::Base.configure(base_url: 'http://foo.bar',
-                                      instrumentation: {context_lambda: a_lambda})
-
-      RestfulResource::Base.instance_variable_get(:@context_lambda).equal?(a_lambda)
-    end
-  end
-
-  describe ".context_headers" do
-    it "builds headers from keys in context_lambda starting with 'source_' only" do
-      a_lambda = context_lambda(
-        source_present: 'value',
-        random_key: 'should not be present'
-      )
-
-      expect(RestfulResource::Base).to receive(:context_lambda).and_return(a_lambda)
-
-      expect(RestfulResource::Base.context_headers).to eq(
-        source_type: 'controller',
-        source_class: 'SomeController',
-        source_identifier: 'index',
-        source_present: 'value'
-      )
-    end
-  end
-
-  def context_lambda(args = {})
-    lambda do
-      {
-        source_type: 'controller',
-        source_class: 'SomeController',
-        source_identifier: 'index',
-      }.merge(args)
-    end
   end
 
   def response_with_page_information

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 2.2.6
+  version: 2.2.7
 platform: ruby
 authors:
 - David Santoro
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-21 00:00:00.000000000 Z
+date: 2018-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -258,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.14.1
 signing_key: 
 specification_version: 4
 summary: A simple activerecord inspired rest resource base class implemented using