restful_resource 2.2.2 → 2.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03a7e9a15a400320a4a636f9d010e65e34880b49
-  data.tar.gz: ebcae394889e3a8dbe9193a8a43a07d6377aa911
+  metadata.gz: 3f0b710977f827bb7d5698d80989ce066d532dac
+  data.tar.gz: 036d21d808eaf17e83dc0c0dcaaa61e03f2b1005
 SHA512:
-  metadata.gz: 3a22f16b829e19e92215c00cadf942b042026cba134aefc4f75bcdaeab66dfdc20b23a6608c639bdfb8faf4fdf07b067f56ff3f2836208f71d80f15410fffb09
-  data.tar.gz: 5980a0c3537c0147a947c1470df0f7a79f9850b30377a03bae1dcf699049c9f6f01b74c5e97949d28b94c78fc6bbef2c07cb391aa68a470cce968d3fe79d1fe6
+  metadata.gz: 13aeb2fd10f632f1b7e99f2cf4ecb7bdfcc8d4856b719ad7cd1ef0a8ffb7640b7a057f2267e2fa03754f77ac56f97fbb349c6491407f6caed487c214a0c262e0
+  data.tar.gz: 4866c6e3d44c15591953ff9f7a096a902466e347d8c5505bb2f9d8a3b07f281a18d5027a85285d228b0796ca2f909ff64aa550916ad2ca4962e741fd1e42ec5e

data/lib/restful_resource/http_client.rb

@@ -96,6 +96,7 @@ module RestfulResource
                                                         faraday_config: faraday_config)
 
       @connection.basic_auth(username, password) if username && password
+      @connection.headers[:user_agent] = build_user_agent(instrumentation[:app_name])
       @default_open_timeout = open_timeout
       @default_timeout = timeout
     end
@@ -197,6 +198,13 @@ module RestfulResource
       end
     end
 
+    def build_user_agent(app_name)
+      parts = ["RestfulResource/#{VERSION}"]
+      parts << "(#{app_name})" if app_name
+      parts << "Faraday/#{Faraday::VERSION}"
+      parts.join(' ')
+    end
+
     def http_request(request)
       response = @connection.send(request.method) do |req|
         req.options.open_timeout = request.open_timeout || default_open_timeout # seconds

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = '2.2.2'
+  VERSION = '2.2.3'
 end

data/spec/restful_resource/http_client_spec.rb

@@ -186,4 +186,32 @@ RSpec.describe RestfulResource::HttpClient do
       expect(response.status).to eq 200
     end
   end
+
+  describe 'User-Agent' do
+    def http_client(connection, app_name: nil)
+      described_class.new(connection: connection, instrumentation: { app_name: app_name })
+    end
+
+    it 'sets a default user-agent header' do
+      connection = faraday_connection do |stubs|
+        user_agent = "RestfulResource/#{RestfulResource::VERSION} Faraday/#{Faraday::VERSION}"
+        stubs.get('http://httpbin.org/get', { 'User-Agent' => user_agent }) { |env| [200, {}, nil] }
+      end
+
+      response = http_client(connection).get('http://httpbin.org/get')
+
+      expect(response.status).to eq 200
+    end
+
+    it 'sets a default user-agent header including app name' do
+      connection = faraday_connection do |stubs|
+        user_agent = "RestfulResource/#{RestfulResource::VERSION} (my-app) Faraday/#{Faraday::VERSION}"
+        stubs.get('http://httpbin.org/get', { 'User-Agent' => user_agent }) { |env| [200, {}, nil] }
+      end
+
+      response = http_client(connection, app_name: "my-app").get('http://httpbin.org/get')
+
+      expect(response.status).to eq 200
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.2.3
 platform: ruby
 authors:
 - David Santoro
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2018-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -258,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: A simple activerecord inspired rest resource base class implemented using