restful_resource 2.10.1 → 2.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '081a984e1de78fc016fefc2780fcb3704500150aadbd9522ed7ef2f853974280'
-  data.tar.gz: b6c1c0c81446ad5bd91425331a8da03e41472dde92f5b212cc77fb135b259fac
+  metadata.gz: 68a4372ef797bce4031a74263c47edd86898a4f10c7a3516d08cfecdb52b59c5
+  data.tar.gz: 46ebcfbb5dbdda37c06c678369e838bdf646f0b3e4d6ea103ddd25407e3e98bb
 SHA512:
-  metadata.gz: ea91622af6f36d6a3263ffe856bd86eb625e67114391409dce009622091924cb4f6b7e994925f2f76aa994184b8043a031c4e40ea65abd0b8c274cf6f2569e06
-  data.tar.gz: 1dc365a6041eeb909e6f3c70450682a90ad1203aaecd26a6fd48335330ab6ec8608a9c10bf034100c235d1ed3a9e2fda82787a48773d45251eca582cdf6f6d84
+  metadata.gz: 58bec55b531529a570598f66ab67c7fd113a9315ee7f8fa1cbb9219b7ac326c734a43f8697feb81debb59cb02447c9853d37e8b630a7f0d477c6ce388261c4a8
+  data.tar.gz: 7dd64a01a76e08587f2c1f9b122648b2a00a0436b4dc8233b8fb94f3677c96e21e03ff829f829e7c8450dbb8c8536c2c2851cb717c0c89239aa0ea9b56dcaa7c

data/.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/ruby:2.6
+      - image: circleci/ruby:2.7
     steps:
       - checkout
       - run:

data/.rubocop_todo.yml

@@ -1,130 +1,132 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-09-11 09:24:50 +0000 using RuboCop version 0.59.0.
+# on 2020-11-12 16:45:32 UTC using RuboCop version 1.3.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'restful_resource.gemspec'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: Width, IgnoredPatterns.
+Layout/IndentationWidth:
+  Exclude:
+    - 'lib/restful_resource/associations.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 Layout/RescueEnsureAlignment:
   Exclude:
     - 'lib/restful_resource/associations.rb'
 
-# Offense count: 10
-Lint/IneffectiveAccessModifier:
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: space
+
+# Offense count: 6
+# Configuration parameters: AllowedMethods.
+Lint/ConstantDefinitionInBlock:
   Exclude:
-    - 'lib/restful_resource/base.rb'
+    - 'spec/restful_resource/base_authorization_spec.rb'
+    - 'spec/restful_resource/http_client_configuration_spec.rb'
 
 # Offense count: 1
+Lint/DuplicateBranch:
+  Exclude:
+    - 'lib/restful_resource/http_client.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
 Lint/Loop:
   Exclude:
     - 'lib/restful_resource/base.rb'
 
 # Offense count: 2
-Lint/ParenthesesAsGroupedExpression:
+Lint/MissingSuper:
   Exclude:
-    - 'spec/restful_resource/base_spec.rb'
+    - 'lib/restful_resource/http_client.rb'
+    - 'lib/restful_resource/parameter_missing_error.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
   Exclude:
     - 'lib/restful_resource/redirections.rb'
 
-# Offense count: 3
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/restful_resource/base.rb'
-    - 'lib/restful_resource/redirections.rb'
-
-# Offense count: 5
+# Offense count: 4
 Lint/UselessAssignment:
   Exclude:
-    - 'lib/restful_resource/rails_validations.rb'
     - 'lib/restful_resource/redirections.rb'
     - 'spec/restful_resource/base_spec.rb'
+    - 'spec/restful_resource/http_client_spec.rb'
     - 'spec/restful_resource/redirections_spec.rb'
 
 # Offense count: 8
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
-  Max: 101
-
-# Offense count: 1
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
-Metrics/BlockLength:
-  Max: 27
+  Max: 102
 
 # Offense count: 2
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 162
+  Max: 195
 
-# Offense count: 2
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 42
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 201
-
 # Offense count: 10
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
   Max: 56
 
-# Offense count: 8
+# Offense count: 9
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
-  Max: 10
+  Max: 11
 
-# Offense count: 1
+# Offense count: 2
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 8
+  Max: 11
 
 # Offense count: 2
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'lib/restful_resource/associations.rb'
 
-# Offense count: 14
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/restful_resource/http_client_configuration_spec.rb'
-    - 'spec/restful_resource/rails_validations_spec.rb'
-    - 'spec/restful_resource/request_spec.rb'
-
 # Offense count: 1
 RSpec/DescribeMethod:
   Exclude:
     - 'spec/restful_resource/base_authorization_spec.rb'
 
-# Offense count: 19
+# Offense count: 2
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Exclude:
     - 'spec/restful_resource/base_spec.rb'
-    - 'spec/restful_resource/http_client_configuration_spec.rb'
-    - 'spec/restful_resource/http_client_spec.rb'
     - 'spec/restful_resource/open_object_spec.rb'
-    - 'spec/restful_resource/rails_validations_spec.rb'
-    - 'spec/restful_resource/redirections_spec.rb'
 
-# Offense count: 53
+# Offense count: 71
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
@@ -134,7 +136,13 @@ RSpec/InstanceVariable:
     - 'spec/restful_resource/rails_validations_spec.rb'
     - 'spec/restful_resource/redirections_spec.rb'
 
-# Offense count: 14
+# Offense count: 6
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/restful_resource/base_authorization_spec.rb'
+    - 'spec/restful_resource/http_client_configuration_spec.rb'
+
+# Offense count: 17
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -143,27 +151,38 @@ RSpec/MessageSpies:
     - 'spec/restful_resource/redirections_spec.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 22
-# Configuration parameters: AggregateFailuresByDefault.
+# Offense count: 24
 RSpec/MultipleExpectations:
   Max: 7
 
-# Offense count: 6
+# Offense count: 1
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+
+# Offense count: 13
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Exclude:
+    - 'spec/restful_resource/rails_validations_spec.rb'
     - 'spec/restful_resource/redirections_spec.rb'
 
-# Offense count: 10
+# Offense count: 12
 RSpec/NestedGroups:
   Max: 5
 
-# Offense count: 2
+# Offense count: 4
 RSpec/RepeatedDescription:
   Exclude:
     - 'spec/restful_resource/base_spec.rb'
 
-# Offense count: 3
-# Configuration parameters: IgnoreSymbolicNames.
+# Offense count: 10
+RSpec/StubbedMock:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 4
+# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/restful_resource/base_spec.rb'
@@ -176,28 +195,58 @@ Style/AsciiComments:
   Exclude:
     - 'lib/restful_resource/instrumentation.rb'
 
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: Keywords.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
+Style/CommentAnnotation:
+  Exclude:
+    - 'spec/restful_resource/http_client_spec.rb'
+
 # Offense count: 1
-Style/MethodMissingSuper:
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: braces, no_braces
+Style/HashAsLastArrayItem:
   Exclude:
-    - 'lib/restful_resource/open_object.rb'
+    - 'lib/restful_resource/base.rb'
 
 # Offense count: 1
 Style/MissingRespondToMissing:
   Exclude:
     - 'lib/restful_resource/open_object.rb'
 
+# Offense count: 2
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/restful_resource/open_object.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
+Style/RedundantFileExtensionInRequire:
+  Exclude:
+    - 'lib/restful_resource.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/StringConcatenation:
   Exclude:
+    - 'lib/restful_resource/authorization.rb'
     - 'lib/restful_resource/base.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
-# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, AllowedMethods.
+# AllowedMethods: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
 Style/TrivialAccessors:
   Exclude:
     - 'lib/restful_resource/base.rb'
+
+# Offense count: 29
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 201

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    restful_resource (2.10.1)
+    restful_resource (2.10.3)
       activesupport (~> 6.0)
       faraday (~> 1.0)
       faraday-cdn-metrics (~> 0.2)
@@ -15,24 +15,25 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3.3)
+    activesupport (6.0.3.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
       zeitwerk (~> 2.2, >= 2.2.2)
-    ast (2.4.0)
-    carwow_rubocop (3.3.0)
-      rubocop (>= 0.78)
+    ast (2.4.1)
+    carwow_rubocop (3.4.1)
+      rubocop (>= 0.93)
       rubocop-performance
       rubocop-rspec
     coderay (1.1.2)
     concurrent-ruby (1.1.7)
-    diff-lcs (1.3)
+    diff-lcs (1.4.4)
     ethon (0.12.0)
       ffi (>= 1.3.0)
-    faraday (1.0.1)
+    faraday (1.1.0)
       multipart-post (>= 1.2, < 3)
+      ruby2_keywords
     faraday-cdn-metrics (0.2.0)
       faraday (~> 1)
     faraday-encoding (0.0.5)
@@ -48,49 +49,54 @@ GEM
     method_source (1.0.0)
     minitest (5.14.2)
     multipart-post (2.1.1)
-    parallel (1.19.1)
-    parser (2.7.1.2)
-      ast (~> 2.4.0)
+    parallel (1.20.0)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
-    rspec-expectations (3.9.0)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.0)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
+      rspec-support (~> 3.10.0)
     rspec-its (1.3.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.9.0)
+    rspec-mocks (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.0)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (0.84.0)
+    rubocop (1.3.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.0.3)
+      rubocop-ast (>= 1.1.1)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
-    rubocop-performance (1.6.0)
-      rubocop (>= 0.71.0)
-    rubocop-rspec (1.39.0)
-      rubocop (>= 0.68.1)
+    rubocop-ast (1.1.1)
+      parser (>= 2.7.1.5)
+    rubocop-performance (1.8.1)
+      rubocop (>= 0.87.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rspec (2.0.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.10.1)
+    ruby2_keywords (0.0.2)
     thread_safe (0.3.6)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)

data/lib/restful_resource.rb

@@ -8,7 +8,7 @@ require 'faraday_cdn_metrics'
 require 'faraday/encoding'
 require 'active_support'
 require 'active_support/all'
-require 'resolv-replace.rb'
+require 'resolv-replace'
 require_relative 'restful_resource/version'
 require_relative 'restful_resource/null_logger'
 require_relative 'restful_resource/paginated_array'

data/lib/restful_resource/base.rb

@@ -34,35 +34,35 @@ module RestfulResource
     end
 
     def self.find(id, **params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
 
       response = http.get(member_url(id, **params_without_options), **options)
       new(parse_json(response.body))
     end
 
     def self.where(**params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
 
-      url = collection_url(params_without_options)
+      url = collection_url(**params_without_options)
       response = http.get(url, **options)
       paginate_response(response)
     end
 
     def self.get(**params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
 
-      response = http.get(collection_url(params_without_options), **options)
+      response = http.get(collection_url(**params_without_options), **options)
       new(parse_json(response.body))
     end
 
     def self.delete(id, **params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
       response = http.delete(member_url(id, **params_without_options), **options)
       new(parse_json(response.body))
     end
 
     def self.patch(id, data: {}, headers: {}, **params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
       options.delete(:headers)
 
       url = member_url(id, **params_without_options)
@@ -72,7 +72,7 @@ module RestfulResource
     end
 
     def self.put(id, data: {}, headers: {}, **params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
       options.delete(:headers)
 
       url = member_url(id, **params_without_options)
@@ -82,10 +82,10 @@ module RestfulResource
     end
 
     def self.post(data: {}, headers: {}, **params)
-      params_without_options, options = format_params(params)
+      params_without_options, options = format_params(**params)
       options.delete(:headers)
 
-      url = collection_url(params_without_options)
+      url = collection_url(**params_without_options)
 
       response = http.post(url, data: data, headers: headers, **options)
 
@@ -93,7 +93,7 @@ module RestfulResource
     end
 
     def self.all(**params)
-      where(params)
+      where(**params)
     end
 
     def self.action(action_name)
@@ -119,8 +119,6 @@ module RestfulResource
       end
     end
 
-    protected
-
     def self.http
       @http || superclass.http
     end
@@ -135,11 +133,9 @@ module RestfulResource
 
     def self.collection_url(**params)
       url = merge_url_paths(base_url, @resource_path, @action_prefix)
-      replace_parameters(url, params)
+      replace_parameters(url, **params)
     end
 
-    private
-
     def self.format_params(**params)
       headers = params.delete(:headers) || {}
 
@@ -147,7 +143,7 @@ module RestfulResource
       open_timeout = params.delete(:open_timeout)
       timeout = params.delete(:timeout)
 
-      [params, headers: headers, open_timeout: open_timeout, timeout: timeout]
+      [params, { headers: headers, open_timeout: open_timeout, timeout: timeout }]
     end
 
     def self.merge_url_paths(uri, *paths)
@@ -177,7 +173,7 @@ module RestfulResource
       missing_params = []
       params = params.with_indifferent_access
 
-      url_params = url.scan(/:([A-Za-z][^\/]*)/).flatten
+      url_params = url.scan(%r{:([A-Za-z][^/]*)}).flatten
       url_params.each do |key|
         value = params.delete(key)
         if value.nil?

data/lib/restful_resource/redirections.rb

@@ -9,15 +9,17 @@ module RestfulResource
     def self.included(base)
       base.instance_eval do
         def post(data: {}, delay: 1.0, max_attempts: 10, headers: {}, open_timeout: nil, timeout: nil, **params)
-          url = collection_url(params)
+          url = collection_url(**params)
 
-          response = accept_redirected_result(response: http.post(url, data: data, headers: headers, open_timeout: nil, timeout: nil), delay: delay, max_attempts: max_attempts)
+          response = accept_redirected_result(
+            response: http.post(url, data: data, headers: headers, open_timeout: nil, timeout: nil),
+            delay: delay,
+            max_attempts: max_attempts
+          )
 
           new(parse_json(response.body))
         end
 
-        private
-
         def self.accept_redirected_result(response:, delay:, max_attempts:)
           new_response = response
           if response.status == 303

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = '2.10.1'.freeze
+  VERSION = '2.10.3'.freeze
 end

data/spec/restful_resource/associations_spec.rb

@@ -11,7 +11,6 @@ describe RestfulResource::Associations do
             { first_name: 'David', second_name: 'Doe' },
             { first_name: 'Mary', second_name: 'Doe' }
           ]
-
       )
     end
 
@@ -39,7 +38,6 @@ describe RestfulResource::Associations do
       @child = ComplicatedModule::Child.new(
         first_name: 'David', second_name: 'Smith',
         parent: { name: 'John Smith' }
-
       )
     end
 

data/spec/restful_resource/base_spec.rb

@@ -365,17 +365,17 @@ RSpec.describe RestfulResource::Base do
     end
 
     it 'does not return inner object table' do
-      expect(@makes.first.as_json).to eq ({ 'name' => 'Audi', 'slug' => 'Audi-Slug' })
+      expect(@makes.first.as_json).to eq({ 'name' => 'Audi', 'slug' => 'Audi-Slug' })
     end
 
     it 'returns inner object table on selected fields' do
-      expect(@makes.last.as_json(only: [:name])).to eq ({ 'name' => 'Fiat' })
+      expect(@makes.last.as_json(only: [:name])).to eq({ 'name' => 'Fiat' })
     end
   end
 
   describe '.member_url' do
     it 'requires a member ID' do
-      expect { described_class.member_url('', {}) }.to raise_error(RestfulResource::ResourceIdMissingError)
+      expect { described_class.member_url('') }.to raise_error(RestfulResource::ResourceIdMissingError)
     end
   end
 
@@ -406,17 +406,17 @@ RSpec.describe RestfulResource::Base do
                                                                )
 
       client.configure(base_url: 'http://foo.bar',
-                                username: username,
-                                password: password,
-                                auth_token: auth_token,
-                                logger: logger,
-                                cache_store: cache_store,
-                                instrumentation: instrumentation,
-                                timeout: timeout,
-                                open_timeout: open_timeout,
-                                faraday_config: faraday_config,
-                                faraday_options: faraday_options
-                               )
+                       username: username,
+                       password: password,
+                       auth_token: auth_token,
+                       logger: logger,
+                       cache_store: cache_store,
+                       instrumentation: instrumentation,
+                       timeout: timeout,
+                       open_timeout: open_timeout,
+                       faraday_config: faraday_config,
+                       faraday_options: faraday_options
+                      )
     end
   end
 

data/spec/restful_resource/http_client_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe RestfulResource::HttpClient do
 
   describe 'Basic HTTP' do
     shared_examples 'error codes throw exception' do |verb, status, exception_class|
-      it "should raise an error #{status}" do
+      it "raises an error #{status}" do
         url = "http://httpbin.org/status/#{status}"
 
         connection = faraday_connection do |stubs|
@@ -58,7 +58,7 @@ RSpec.describe RestfulResource::HttpClient do
 
       it 'executes patch' do
         connection = faraday_connection do |stubs|
-          # Note: request body is serialized as url-encoded so the stub body must be in the same format to match
+          # NOTE: request body is serialized as url-encoded so the stub body must be in the same format to match
           stubs.patch('http://httpbin.org/patch', 'name=Alfred') { |_env| [200, {}, nil] }
         end
 
@@ -71,7 +71,7 @@ RSpec.describe RestfulResource::HttpClient do
       include_examples 'raise an exception on error responses', :put
       it 'executes put' do
         connection = faraday_connection do |stubs|
-          # Note: request body is serialized as url-encoded so the stub body must be in the same format to match
+          # NOTE: request body is serialized as url-encoded so the stub body must be in the same format to match
           stubs.put('http://httpbin.org/put', 'name=Alfred') { |_env| [200, {}, nil] }
         end
 
@@ -84,7 +84,7 @@ RSpec.describe RestfulResource::HttpClient do
       include_examples 'raise an exception on error responses', :post
       it 'executes post' do
         connection = faraday_connection do |stubs|
-          # Note: request body is serialized as url-encoded so the stub body must be in the same format to match
+          # NOTE: request body is serialized as url-encoded so the stub body must be in the same format to match
           stubs.post('http://httpbin.org/post', 'name=Alfred') { |_env| [200, {}, %("name": "Alfred")] }
         end
 
@@ -219,10 +219,10 @@ RSpec.describe RestfulResource::HttpClient do
       conn
     end
 
-
     context 'when explicit timeout set on connection' do
       let(:timeout) { 5 }
       let(:required_headers) { { 'X-Client-Timeout' => 5 } }
+
       it 'sets X-Client-Timeout correctly' do
         response = http_client.get('http://httpbin.org/get')
 

data/spec/restful_resource/rails_validations_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe RestfulResource::RailsValidations do
     allow(Dealer).to receive(:http).and_return(@mock_http)
   end
 
-  context '#patch without errors' do
+  describe '#patch without errors' do
     before do
       data = { name: 'Barak' }
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
@@ -25,7 +25,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#patch with errors' do
+  describe '#patch with errors' do
     before do
       data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
@@ -72,7 +72,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#put without errors' do
+  describe '#put without errors' do
     before do
       data = { name: 'Barak' }
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
@@ -90,7 +90,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#put with errors' do
+  describe '#put with errors' do
     before do
       data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
@@ -137,7 +137,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#post without errors' do
+  describe '#post without errors' do
     before do
       data = { name: 'Barak' }
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
@@ -155,7 +155,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#post with errors' do
+  describe '#post with errors' do
     before do
       data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
@@ -192,7 +192,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#get without errors' do
+  describe '#get without errors' do
     before do
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
       expect_get('http://api.carwow.co.uk/dealers', expected_response)
@@ -209,7 +209,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#get with errors' do
+  describe '#get with errors' do
     before do
       @error = 'Missing parameter'
       expected_response = RestfulResource::Response.new(body: { errors: [@error] }.to_json)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 2.10.1
+  version: 2.10.3
 platform: ruby
 authors:
 - David Santoro
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-01 00:00:00.000000000 Z
+date: 2020-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler