restful_resource 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d2d72ef667a20e5c2773931c3b5c449af79ed096
-  data.tar.gz: f0d464e0d0ffd5740c61d5ae6e251e755844e940
+  metadata.gz: 48aee54274e098eadf07461bb8c73efda0b9553b
+  data.tar.gz: 9d83d3d0a16de24eaf675521e6400ac781d54699
 SHA512:
-  metadata.gz: 161b0138fea97c3cb5853514ddc3b799328bf01d8829276b84f1dadcd2b1513739f2a8a7163a35c54304c1549e184dd0d3d1731920b4c16e41e859fadbeb61fe
-  data.tar.gz: 40177d79fd2a410a23adbb5e93037b72fc82657f7d9caa1353cc318aa296984fd1e862d5a11eb3ca8ea45b1d1d3320332146777b5b75d419cc5d387105272304
+  metadata.gz: 1fd7d3aa052150f89935e0ac1465b91041ce26144e0632cb51b523cf20d8d528a898987c251997a5afb8b3c2229bbb157ec4ce5dc003206ac98fbb2fef16411a
+  data.tar.gz: f9fc76246b16b16d927320b6ce1980fd71ce7b04ebba6736dd9f2f997f69f9b27d3569b5f6d56c9a2b0cf554b553f7b13ab7b1580e7619d7b397623a90d141f7

data/lib/restful_resource/base.rb

@@ -31,9 +31,9 @@ module RestfulResource
       self.paginate_response(response)
     end
 
-    def self.get(params={})
+    def self.get(params = {})
       response = http.get(collection_url(params))
-      RestfulResource::OpenObject.new(parse_json(response.body))
+      self.new(parse_json(response.body))
     end
 
     def self.delete(id, **params)

data/lib/restful_resource/rails_validations.rb

@@ -18,8 +18,21 @@ module RestfulResource
       end
 
       def post(data: {}, **params)
-        begin
+        with_validations(data: data) do
           super(data: data, **params)
+        end
+      end
+
+      def get(params = {})
+        with_validations do
+          super(params)
+        end
+      end
+
+      private
+      def with_validations(data: {}, &block)
+        begin
+          block.call
         rescue HttpClient::UnprocessableEntity => e
           errors = parse_json(e.response.body)
           result = nil

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

data/spec/restful_resource/base_spec.rb

@@ -123,13 +123,12 @@ describe RestfulResource::Base do
 
   describe "#get" do
     it "should return an open_object" do
-      expected_response = RestfulResource::Response.new(body: {average_score: 4.3}.to_json)
+      expected_response = RestfulResource::Response.new(body: {average_score: 4.3}.to_json, status: 200)
       expect_get('http://api.carwow.co.uk/makes/average_score?make_slug%5B%5D=Volkswagen&make_slug%5B%5D=Audi', expected_response)
 
       object = Make.action(:average_score).get(make_slug: ['Volkswagen', 'Audi'])
 
       expect(object.average_score).to eq 4.3
-      expect(object.class).to eq RestfulResource::OpenObject
     end
   end
 

data/spec/restful_resource/rails_validations_spec.rb

@@ -126,4 +126,52 @@ describe RestfulResource::RailsValidations do
       expect(@object.errors).to eq @error
     end
   end
+
+  context "#get without errors" do
+    before :each do
+      expected_response = RestfulResource::Response.new(body: {name: 'Barak'}.to_json)
+      expect_get("http://api.carwow.co.uk/dealers", expected_response)
+
+      @object = Dealer.get
+    end
+
+    it 'should return object' do
+      expect(@object.name).to eq 'Barak'
+    end
+
+    it 'should return valid object' do
+      expect(@object.valid?).to be_truthy
+    end
+  end
+
+  context "#get with errors" do
+    before :each do
+      @error = 'Missing parameter'
+      expected_response = RestfulResource::Response.new(body: {errors: [@error]}.to_json)
+      expect_get_with_unprocessable_entity("http://api.carwow.co.uk/dealers", expected_response)
+
+      @object = Dealer.get
+    end
+
+    it "should have an error" do
+      expect(@object.errors.count).to eq 1
+    end
+
+    it 'should have correct error' do
+      expect(@object.errors.first).to eq @error
+    end
+
+    it 'should return not valid object' do
+      expect(@object.valid?).to be_falsey
+    end
+
+    it 'should handle errors returned as root object' do
+      expected_response = RestfulResource::Response.new(body: @error.to_json)
+      expect_get_with_unprocessable_entity("http://api.carwow.co.uk/dealers", expected_response)
+
+      @object = Dealer.get
+      expect(@object.valid?).to be_falsey
+      expect(@object.errors).to eq @error
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -24,6 +24,13 @@ def expect_post(url, response, data: {})
   expect(@mock_http).to receive(:post).with(url, data: data).and_return(response)
 end
 
+def expect_get_with_unprocessable_entity(url, response)
+  request = RestfulResource::Request.new(:get, url)
+  rest_client_response = OpenStruct.new({body: response.body, headers: response.headers, code: response.status})
+  exception = RestfulResource::HttpClient::UnprocessableEntity.new(request, rest_client_response)
+  expect(@mock_http).to receive(:get).with(url).and_raise(exception)
+end
+
 def expect_put_with_unprocessable_entity(url, response, data: {})
   request = RestfulResource::Request.new(:put, url, body: data)
   rest_client_response = OpenStruct.new({body: response.body, headers: response.headers, code: response.status})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - David Santoro
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-24 00:00:00.000000000 Z
+date: 2016-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler