restful_resource 0.8.29 → 0.8.30

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e1200df2ffe234dcae828f3463568f0958041047
-  data.tar.gz: ecba1c50b0cd518e23b446e804d6431161f3f17e
+  metadata.gz: dafad3983beafc514d01f30c74e2fe97095219d9
+  data.tar.gz: 9ba218ee514a73b4ba75447928b19a3fb7dfb030
 SHA512:
-  metadata.gz: 44f87745629a441306ece3cadd634d30ff33fbc034407f99f0e4097d6c7640484c6df533e636983276d63b133303ad56c93bfc512e7a2376c957e7a3eb42713d
-  data.tar.gz: a1a6c039ab088c5310c40c5ab59e3dcbfcb639b0627b659b4b9ef3f02a0f26ced3fd3f8f55e202b2c9e5c1152aba28120f36277d343aff5ef881b27b352965f0
+  metadata.gz: eef8abc3f5eb592f611a33ac2880fa061b09eaabf895ce0dd583c8f4d6135ca85425ca7fea67db4274fb538cc16bbd48319514f94f2a680517c37477cc1f6a29
+  data.tar.gz: 958bbb693ef40b49ad0c8f8267516b3348862d0294d2f6ef91632c6599b2e1383ee3aa6e925a5cb4a7de7d843de0ead2b9bf840535ecf66248977501f5d64e97

data/lib/restful_resource/base.rb

@@ -2,9 +2,11 @@ module RestfulResource
   class Base < OpenObject
     extend RestfulResource::Associations
 
-    def self.configure(base_url: nil, username: nil, password: nil)
+    def self.configure(base_url: nil, username: nil, password: nil, logger: NullLogger.new)
       @base_url = URI.parse(base_url)
 
+      RestClient.log = logger
+
       auth = nil
 
       if (username.present? && password.present?)
@@ -24,7 +26,8 @@ module RestfulResource
     end
 
     def self.where(params={})
-      response = http.get(collection_url(params))
+      url = collection_url(params)
+      response = http.get(url)
       self.paginate_response(response)
     end
 
@@ -40,7 +43,6 @@ module RestfulResource
 
     def self.put(id, data: {}, **params)
       url = member_url(id, params)
-
       response = http.put(url, data: data)
       self.new(parse_json(response.body))
     end

data/lib/restful_resource/null_logger.rb

@@ -0,0 +1,6 @@
+module RestfulResource
+  class NullLogger
+    def <<(*args)
+    end
+  end
+end

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = "0.8.29"
+  VERSION = "0.8.30"
 end

data/lib/restful_resource.rb

@@ -5,6 +5,7 @@ require 'restclient'
 require 'active_support'
 require 'active_support/all'
 require_relative "restful_resource/version"
+require_relative 'restful_resource/null_logger'
 require_relative "restful_resource/paginated_array"
 require_relative "restful_resource/parameter_missing_error"
 require_relative "restful_resource/resource_id_missing_error"

data/spec/restful_resource/base_spec.rb

@@ -223,6 +223,34 @@ describe RestfulResource::Base do
     end
   end
 
+  describe 'logger' do
+    before do
+      RestfulResource::Base.configure(base_url: 'http://api.carwow.co.uk/')
+    end
+
+    context 'when no logger is passed' do
+      it 'defaults to NullLogger' do
+        expect(RestClient.log).to be_instance_of(RestfulResource::NullLogger)
+      end
+    end
+
+    context 'when a logger is passed' do
+      before do
+        RestfulResource::Base.configure(base_url: 'http://api.carwow.co.uk/', logger: my_logger)
+      end
+
+      after do
+        RestClient.log = RestfulResource::NullLogger.new
+      end
+
+      let(:my_logger) { double('logger') }
+
+      it 'uses that logger' do
+        expect(RestClient.log).to eq(my_logger)
+      end
+    end
+  end
+
   def response_with_page_information
     RestfulResource::Response.new(body: [{ id: 1, name: 'Golf'}, { id: 2, name: 'Polo' }].to_json,
                                  headers: { links: '<http://api.carwow.co.uk/makes/Volkswagen/models.json?page=6>;rel="last",<http://api.carwow.co.uk/makes/Volkswagen/models.json?page=2>;rel="next"'})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 0.8.29
+  version: 0.8.30
 platform: ruby
 authors:
 - David Santoro
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-12 00:00:00.000000000 Z
+date: 2015-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -127,6 +127,7 @@ files:
 - lib/restful_resource/authorization.rb
 - lib/restful_resource/base.rb
 - lib/restful_resource/http_client.rb
+- lib/restful_resource/null_logger.rb
 - lib/restful_resource/old_base.rb
 - lib/restful_resource/open_object.rb
 - lib/restful_resource/paginated_array.rb