restforce 2.5.1 → 2.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a2edec8fbe80bbf028b896e38efbe598ce91ba9
-  data.tar.gz: 567b7ede645cc03d358320ac85898efd106f9415
+  metadata.gz: 2fe36ce396f2e18efc3f6ca5baa391ba0d3e5ada
+  data.tar.gz: e968e760eb726434e54576836985732221fd9457
 SHA512:
-  metadata.gz: 902362f2c9cc5c24d70c945873f3afc182b1225925cb7d2dd8d5419a1b5ba02d4fc3f1f833813981118620c33994a843bf3c244e4dc42546c85fb85d79896861
-  data.tar.gz: 42a7923a9ae9e2e8c9d2928b746fe2832b5f40ed0a81882aed777cf8cd0e8fee91fc76f8e42f1e7e9212b1d9a280c5d3411535409b5a81e431b8b219e65bc982
+  metadata.gz: 3a60bb6adcd71799a5bdbb4b19a41bfefa9aa554db975e3442ee3c90af2db4489a4f699029617dba0f50c5fe2fe2e0ed535160cfb617211cb0054f1cbc0ea165
+  data.tar.gz: 9af84717f844c3497bcc357083e468fcb7fe4c50e070dac0465696bfbea001395335a01d18efdc02c29d1375ccd1af98638f6388ef6cca69d87a98bcca30e53e

data/CHANGELOG.md

@@ -1,9 +1,16 @@
+## 2.5.2 (Apr 3, 2017)
+
+* Ensure `Restforce::Middleware::Logger` is the last Faraday middleware to be called so everything is properly logged (including the effects of the `Gzip` and `CustomHeaders` middlewares which were previously running after it) (@jonnymacs)
+* Suppress [Hashie](https://github.com/intridea/hashie) warnings when using Hashie v3.5.0 or later (see [#295](https://github.com/ejholmes/restforce/pull/295) for details) (@janraasch)
+
 ## 2.5.1 (Mar 16, 2017)
 
 * Allow setting custom headers, [required by parts of the Salesforce API](https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/headers.htm), by specifiying a `:request_headers` option when instantiating the client (@moskeyombus)
 * Add support for `upsert`ing using an ID (see the [Salesforce docs](https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/dome_upsert.htm) for more details) (@ecbypi)
 * Relax `faraday` dependency to allow upgrading to Faraday 1.0 (@tinogomes, @alexluke)
 
+*(This should have been a minor version rather than a patch version, following format MAJOR.MINOR.PATCH, since we use [Semantic Versioning](http://semver.org/) and this adds functionality. Sorry! @timrogers)*
+
 ## 2.5.0 (Dec 7, 2016)
 
 * __Deprecate support for Ruby 1.9__, since [official support was dropped nearly two years ago](https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/), and it's causing problems with keeping our dependencies up to date

data/README.md

@@ -25,7 +25,7 @@ Features include:
 
 Add this line to your application's Gemfile:
 
-    gem 'restforce', '~> 2.5.1'
+    gem 'restforce', '~> 2.5.2'
 
 And then execute:
 

data/lib/restforce/concerns/connection.rb

@@ -46,14 +46,14 @@ module Restforce
           builder.use      Restforce::Middleware::RaiseError
           # Parses returned JSON response into a hash.
           builder.response :json, content_type: /\bjson$/
-          # Log request/responses
-          builder.use      Restforce::Middleware::Logger,
-                           Restforce.configuration.logger,
-                           options if Restforce.log?
           # Compress/Decompress the request/response
           builder.use      Restforce::Middleware::Gzip, self, options
           # Inject custom headers into requests
           builder.use      Restforce::Middleware::CustomHeaders, self, options
+          # Log request/responses
+          builder.use      Restforce::Middleware::Logger,
+                           Restforce.configuration.logger,
+                           options if Restforce.log?
 
           builder.adapter  adapter
         end

data/lib/restforce/config.rb

@@ -141,6 +141,9 @@ module Restforce
     # Set SSL options
     option :ssl, default: {}
 
+    # A Hash that is converted to HTTP headers
+    option :request_headers
+
     # Set a logger for when Restforce.log is set to true, defaulting to STDOUT
     option :logger, default: ::Logger.new(STDOUT)
 

data/lib/restforce/mash.rb

@@ -2,6 +2,8 @@ require 'hashie/mash'
 
 module Restforce
   class Mash < Hashie::Mash
+    disable_warnings if respond_to?(:disable_warnings)
+
     class << self
       # Pass in an Array or Hash and it will be recursively converted into the
       # appropriate Restforce::Collection, Restforce::SObject and

data/lib/restforce/version.rb

@@ -1,3 +1,3 @@
 module Restforce
-  VERSION = '2.5.1'
+  VERSION = '2.5.2'.freeze
 end

data/spec/unit/concerns/connection_spec.rb

@@ -60,6 +60,22 @@ describe Restforce::Concerns::Connection do
         end
       end
     end
+
+    describe ":logger option" do
+      let(:options) { { adapter: Faraday.default_adapter } }
+
+      before(:each) do
+        client.stub(:authentication_middleware)
+        client.stub(:cache)
+        client.stub(options: options)
+        Restforce.stub(log?: true)
+      end
+
+      it "must always be used last before the Faraday Adapter" do
+        client.middleware.handlers.reverse.index(Restforce::Middleware::Logger).
+          should eq 1
+      end
+    end
   end
 
   describe '#adapter' do

data/spec/unit/config_spec.rb

@@ -27,7 +27,7 @@ describe Restforce do
       its(:ssl)                    { should eq({}) }
       [:username, :password, :security_token, :client_id, :client_secret,
        :oauth_token, :refresh_token, :instance_url, :compress, :timeout,
-       :proxy_uri, :authentication_callback, :mashify].each do |attr|
+       :proxy_uri, :authentication_callback, :mashify, :request_headers].each do |attr|
         its(attr) { should be_nil }
       end
     end
@@ -59,8 +59,8 @@ describe Restforce do
   describe '#configure' do
     [:username, :password, :security_token, :client_id, :client_secret, :compress,
      :timeout, :oauth_token, :refresh_token, :instance_url, :api_version, :host, :mashify,
-     :authentication_retries, :proxy_uri, :authentication_callback, :ssl, :log_level,
-     :logger].each do |attr|
+     :authentication_retries, :proxy_uri, :authentication_callback, :ssl,
+     :request_headers, :log_level, :logger].each do |attr|
       it "allows #{attr} to be set" do
         Restforce.configure do |config|
           config.send("#{attr}=", 'foobar')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restforce
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 2.5.2
 platform: ruby
 authors:
 - Eric J. Holmes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-16 00:00:00.000000000 Z
+date: 2017-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday