restforce 0.1.7 → 0.1.8

data/.travis.yml

@@ -3,4 +3,9 @@ rvm:
   - 1.8.7
   - 1.9.2
   - 1.9.3
+  - jruby-18mode
+  - jruby-19mode
+  - ree
+  - rbx-18mode
+  - rbx-19mode
 script: bundle exec rake

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in restforce.gemspec
 gemspec
+
+gem 'jruby-openssl', :platforms => :jruby

data/README.md

@@ -98,6 +98,14 @@ Restforce.configure do |config|
 end
 ```
 
+### Bang methods
+
+All the CRUD methods (create, update, upsert, destroy) have equivalent methods with 
+a ! at the end (create!, update!, upsert!, destroy!), which can be used if you need
+to do some custom error handling. The bang methods will raise exceptions, while the 
+non-bang methods will return false in the event that an exception is raised. This
+works similarly to ActiveRecord.
+
 * * *
 
 ### query(soql)

data/lib/restforce.rb

@@ -31,10 +31,12 @@ module Restforce
     #
     # Returns the Hash context if the message is valid.
     def decode_signed_request(message, client_secret)
-      encryped_secret, payload = message.split('.')
+      signature, payload = message.split('.')
+      signature = Base64.decode64(signature)
       digest = OpenSSL::Digest::Digest.new('sha256')
-      signature = Base64.encode64(OpenSSL::HMAC.hexdigest(digest, client_secret, payload))
-      JSON.parse(Base64.decode64(payload)) if encryped_secret == signature
+      hmac = OpenSSL::HMAC.digest(digest, client_secret, payload)
+      return nil if signature != hmac
+      JSON.parse(Base64.decode64(payload))
     end
   end
 

data/lib/restforce/version.rb

@@ -1,3 +1,3 @@
 module Restforce
-  VERSION = '0.1.7'
+  VERSION = '0.1.8'
 end

data/restforce.gemspec

@@ -24,5 +24,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'webmock'
   gem.add_development_dependency 'simplecov'
-  gem.add_development_dependency 'faye', '0.8.3'
+  gem.add_development_dependency 'faye', '0.8.3' unless RUBY_PLATFORM == 'java'
 end

data/spec/lib/client_spec.rb

@@ -378,7 +378,7 @@ shared_examples_for 'methods' do
       let(:data) { Base64.encode64('{ "key": "value" }') }
       let(:message) do
         digest = OpenSSL::Digest::Digest.new('sha256')
-        signature = Base64.encode64(OpenSSL::HMAC.hexdigest(digest, client_secret, data))
+        signature = Base64.encode64(OpenSSL::HMAC.digest(digest, client_secret, data))
         "#{signature}.#{data}"
       end
 
@@ -440,7 +440,7 @@ shared_examples_for 'methods' do
       let(:oauth_token) { 'bar' }
       specify { expect { subject }.to_not raise_error }
     end
-  end
+  end unless RUBY_PLATFORM == 'java'
 
   describe 'authentication retries' do
     context 'when retries reaches 0' do

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ SimpleCov.start
 
 require 'bundler/setup'
 Bundler.require :default, :test
+require 'faye' unless RUBY_PLATFORM == 'java'
 
 require 'webmock/rspec'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restforce
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-31 00:00:00.000000000 Z
+date: 2012-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake