rest_my_case 1.9.1 → 1.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4eaca5ca9d55737b8d3aadc7d215d3bb13f2aabe
-  data.tar.gz: e4a6d32211c6c2033b341a1c53e4894b642a9985
+  metadata.gz: 088ea74126da74d24cd42b6ca1bd23838cf16f74
+  data.tar.gz: a5c583155c12293f7e23e23213bab13c74cf3544
 SHA512:
-  metadata.gz: f34ecef601ece173ee6960d489ca331c767a23e255977f46c0b2362d745555781f9540a2bbb9032e9e1cd44ad3bd9c96c8c20741d047fefbf5f1644e05cdc790
-  data.tar.gz: b2a4efbdf1e1975f9b037a7a6e6162e3a6548c02533dca21474a6f6a53798e7399b78266765478eb814382b9482d7bdcba71abd846f94bc245553ad5ca1a9fde
+  metadata.gz: d48c0464b9ea66217c168963ebbef24542273a55336486e0c0dcbfb0a7bf5ae8bbdf38cbdfb7d4dbf646f401a7d9ff62196e9885c13493a1e8af19c418c39057
+  data.tar.gz: 6c8546d1508b909c58e19287d7e8e8dc826f311a4e52387d7aeaf49b72d693e3d40816fba6da3c90d9253d4d3f5cdfed6fed21dc88c450cc613b6ffb5f73a69e

data/lib/rest_my_case/context/errors/base.rb

@@ -10,10 +10,20 @@ module RestMyCase
           @context = context
         end
 
-        def add(error, message)
-          self[error] ||= []
+        def add(class_name, message)
+          self[class_name] ||= []
 
-          self[error].push(message)
+          self[class_name].push(message.to_s)
+        end
+
+        def messages
+          self.values.flatten
+        end
+
+        def full_messages
+          self.map do |class_name, messages|
+            "#{class_name}: #{messages.join(', ')}"
+          end
         end
 
       end

data/lib/rest_my_case/context/errors/status.rb

@@ -7,7 +7,9 @@ module RestMyCase
         def add(error, message)
           super
 
-          @context.status.send("#{message}!")
+          status = message.to_s.split(' - ')[0]
+
+          @context.status.send("#{status}!")
         end
 
       end

data/lib/rest_my_case/version.rb

@@ -1,5 +1,5 @@
 module RestMyCase
 
-  VERSION = '1.9.1'
+  VERSION = '1.9.2'
 
 end

data/spec/rest_my_case/accusation_attorneys/base_spec.rb

@@ -4,9 +4,9 @@ describe RestMyCase::AccusationAttorneys::Base do
 
   describe '#validate' do
     context "given that the child class hasn't implemented the validate method" do
-      TestCase4 = Class.new(described_class)
+      AccusationAttorneysTestCase1 = Class.new(described_class)
 
-      before { @instance = TestCase4.new({ attributes: { id: '1' } }) }
+      before { @instance = AccusationAttorneysTestCase1.new({ attributes: { id: '1' } }) }
 
       it 'should raise an error' do
         expect { @instance.validate(nil) }.to raise_error

data/spec/rest_my_case/accusation_attorneys/each_spec.rb

@@ -4,9 +4,9 @@ describe RestMyCase::AccusationAttorneys::Each do
 
   describe '#validate_each' do
     context "given that the child class hasn't implemented the validate_each method" do
-      TestCase5 = Class.new(described_class)
+      AccusationAttorneysTestCase2 = Class.new(described_class)
 
-      before { @instance = TestCase5.new({ attributes: { id: '1' } }) }
+      before { @instance = AccusationAttorneysTestCase2.new({ attributes: { id: '1' } }) }
 
       it 'should raise an error' do
         expect { @instance.validate_each(nil, nil, nil) }.to raise_error

data/spec/rest_my_case/base_spec.rb

@@ -108,6 +108,7 @@ describe RestMyCase::Base do
 
       it "context should contain only one error" do
         expect(@context.errors).to match a_hash_including({"Perform::ValidateName"=>[""]})
+        expect(@context.errors.full_messages).to eq ["Perform::ValidateName: "]
       end
 
       it "context prove that only the correct method have ran" do
@@ -130,6 +131,7 @@ describe RestMyCase::Base do
 
       it "context should contain only one error" do
         expect(@context.errors).to match a_hash_including({"Perform::ValidateName"=>[""]})
+        expect(@context.errors.full_messages).to eq ["Perform::ValidateName: "]
       end
 
       it "context prove that only the correct method have ran" do
@@ -231,6 +233,7 @@ describe RestMyCase::Base do
 
         it "context should contain only 2 errors" do
           expect(@context.errors).to match a_hash_including({"Perform::ValidateName"=>[""], "Perform::ValidateBody"=>[""]})
+          expect(@context.errors.full_messages).to eq ["Perform::ValidateName: ", "Perform::ValidateBody: "]
         end
 
         it "context prove that only the correct method have ran" do
@@ -255,6 +258,7 @@ describe RestMyCase::Base do
 
         it "context should contain only 2 errors" do
           expect(@context.errors).to match a_hash_including({"Perform::ValidateName"=>[""], "Perform::ValidateBody"=>[""]})
+          expect(@context.errors.full_messages).to eq ["Perform::ValidateName: ", "Perform::ValidateBody: "]
         end
 
         it "context prove that only the correct method have ran" do
@@ -290,6 +294,7 @@ describe RestMyCase::Base do
 
         it "context should contain only 4 errors" do
           expect(@context.errors).to match a_hash_including({"Perform::BuildPost"=>[""], "Perform::ValidateName"=>[""], "Perform::ValidateBody"=>[""], "Perform::SavePost"=>[""]})
+          expect(@context.errors.full_messages).to eq ["Perform::BuildPost: ", "Perform::ValidateName: ", "Perform::ValidateBody: ", "Perform::SavePost: "]
         end
 
         it "context prove that only the correct method have ran" do

data/spec/rest_my_case/status_spec.rb

@@ -18,10 +18,10 @@ describe RestMyCase::Status do
       end
     end
 
-    context "when failure(:unprocessable_entity) is used" do
+    context "when error(:unprocessable_entity) is used" do
       TestCase2 = Class.new(described_class) do
         def perform
-          failure(:unprocessable_entity)
+          error(:unprocessable_entity)
           context.next_line = true
         end
       end
@@ -41,14 +41,17 @@ describe RestMyCase::Status do
       end
 
       it "context's errors should have a proper message" do
-        expect(@context.errors["TestCase2"]).to eq ["unprocessable_entity"]
+        message = "unprocessable_entity"
+
+        expect(@context.errors["TestCase2"]).to eq [message]
+        expect(@context.errors.messages).to eq [message]
       end
     end
 
-    context "when failure!(:internal_server_error) is used" do
+    context "when error!(:internal_server_error) is used" do
       TestCase3 = Class.new(described_class) do
         def perform
-          failure!(:internal_server_error)
+          error!(:internal_server_error)
           context.next_line = true
         end
       end
@@ -68,7 +71,70 @@ describe RestMyCase::Status do
       end
 
       it "context's errors should have a proper message" do
-        expect(TestCase3.perform.errors["TestCase3"]).to eq ["internal_server_error"]
+        message = "internal_server_error"
+
+        expect(@context.errors["TestCase3"]).to eq [message]
+        expect(@context.errors.messages).to eq [message]
+      end
+    end
+
+    context "when failure(:unprocessable_entity) is used" do
+      TestCase4 = Class.new(described_class) do
+        def perform
+          failure(:unprocessable_entity, 'invalid id')
+          context.next_line = true
+        end
+      end
+
+      before { @context = TestCase4.perform }
+
+      it "@context.status.unprocessable_entity? should be true" do
+        expect(@context.status.unprocessable_entity?).to be true
+      end
+
+      it "@context.next_line should be true" do
+        expect(@context.next_line).to be true
+      end
+
+      it "@context.status.ok? should be false" do
+        expect(@context.status.ok?).to be false
+      end
+
+      it "context's errors should have a proper message" do
+        message = "unprocessable_entity - invalid id"
+
+        expect(@context.errors["TestCase4"]).to eq [message]
+        expect(@context.errors.messages).to eq [message]
+      end
+    end
+
+    context "when failure!(:internal_server_error) is used" do
+      TestCase5 = Class.new(described_class) do
+        def perform
+          failure!(:internal_server_error, 'while saving the resource')
+          context.next_line = true
+        end
+      end
+
+      before { @context = TestCase5.perform }
+
+      it "@context.status.internal_server_error? should be true" do
+        expect(@context.status.internal_server_error?).to be true
+      end
+
+      it "@context.next_line should be true" do
+        expect { context.next_line }.to raise_error
+      end
+
+      it "@context.status.ok? should be false" do
+        expect(@context.status.ok?).to be false
+      end
+
+      it "context's errors should have a proper message" do
+        message = "internal_server_error - while saving the resource"
+
+        expect(@context.errors["TestCase5"]).to eq [message]
+        expect(@context.errors.messages).to eq [message]
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rest_my_case
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.9.2
 platform: ruby
 authors:
 - goncalvesjoao