rest_my_case 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4247a51223096c120fdb4055309c9fbbabd8517f
-  data.tar.gz: a3c6837847258f454c8cb604ceed36a1e836c1ef
+  metadata.gz: d82932cb42f7f06eaa0a2ffd09fc866ae7217047
+  data.tar.gz: 35df440b5058dde4f650d7cc20a1f4f116c9c45f
 SHA512:
-  metadata.gz: 6d7663942c2b7324ea877778295c87a19c7a18fdacb022e16136ca71b35d969b9beb473d8142a06bc9e9ef5b50540d93db4f3673232e2fd9c84700db8d6422a3
-  data.tar.gz: 1a39bb5b4b29d394c71179cba26052066e404d418026c3c150475cb6980a99803cb70503d5ff3542b3ea16346193db95bbb8978b51a8d31c0d9172694e007da4
+  metadata.gz: 0495e5467c6f6331d5dd19878fc74171903f915ba5de464b3770cfdaa26df83df943b2773f857d23aec381995237ac5e5279ac912a6726bdc56b3b42829486bb
+  data.tar.gz: 5a28d8b8550466280cddb7352c12135b0f3f5d6bf8d90cdc5418eedbfa1908996321cb4a13d1c2d4441c23e143fea495e979354eb807a7222b9405d6123f9514

data/.rubocop.yml

@@ -0,0 +1,30 @@
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+Style/EmptyLinesAroundMethodBody:
+  Enabled: false
+
+Style/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+Style/DotPosition:
+  Enabled: false
+
+Style/Encoding:
+  Enabled: true
+  EnforcedStyle: when_needed
+
+AllCops:
+  Exclude:
+    - '**/Rakefile'
+    - '**/*.gemspec'
+    - '**/console'
+    - 'spec/**/*'
+    - 'tmp/**/*'
+    - 'pkg/**/*'
+
+Documentation:
+  Enabled: false

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+rvm:
+- 1.9.3
+- 2.1.0
+
+addons:
+  code_climate:
+    repo_token:
+      secure: "ByiO5La5wZqGf6TA/pwBTDs1CN/FBHxLiPR3tlhLi8Ij4ikXswlP5IqBwlFDxvlLeCU5cDMT+n9mpU9kQHhT2BZg/aeuEsUbELVUrTpTOnPbnptvRWGzvN7ipsuXZZI1UdL4L9YGo84vO1EQMdDS+zr2OSSP7t1U14uAjiFGwQQ="
+
+env:
+  global:
+    secure: ByiO5La5wZqGf6TA/pwBTDs1CN/FBHxLiPR3tlhLi8Ij4ikXswlP5IqBwlFDxvlLeCU5cDMT+n9mpU9kQHhT2BZg/aeuEsUbELVUrTpTOnPbnptvRWGzvN7ipsuXZZI1UdL4L9YGo84vO1EQMdDS+zr2OSSP7t1U14uAjiFGwQQ=

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015 João
+Copyright (c) 2015 João Gonçalves
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,2 +1,4 @@
-# RestMyCase
-Very light Ruby gem with everything you need in a "The Clean Architecture" use case scenario. Strongly inspired on the tdantas/usecasing gem.
+# RestMyCase [![Code Climate](https://codeclimate.com/github/goncalvesjoao/rest_my_case/badges/gpa.svg)](https://codeclimate.com/github/goncalvesjoao/rest_my_case) [![Build Status](https://travis-ci.org/goncalvesjoao/rest_my_case.svg?branch=master)](https://travis-ci.org/goncalvesjoao/rest_my_case) [![Test Coverage](https://codeclimate.com/github/goncalvesjoao/rest_my_case/badges/coverage.svg)](https://codeclimate.com/github/goncalvesjoao/rest_my_case) [![Gem Version](https://badge.fury.io/rb/rest_my_case.svg)](http://badge.fury.io/rb/rest_my_case)
+
+Very light Ruby gem with everything you need in a "The Clean Architecture" use case scenario.
+Props to [@tdantas](https://github.com/tdantas) and [@junhanamaki](https://github.com/junhanamaki)

data/Rakefile

@@ -1,2 +1,7 @@
 require "bundler/gem_tasks"
 
+require 'rspec/core/rake_task'
+
+task :default => :test
+
+RSpec::Core::RakeTask.new(:test)

data/console

@@ -10,7 +10,4 @@ require 'bundler'
 
 Bundler.require(:default, 'development')
 
-
-require 'spec/support/perform'
-
 binding.pry

data/lib/rest_my_case/base.rb

@@ -7,7 +7,7 @@ module RestMyCase
     TRIAL_COURT = Trial::Court.new Judge::Base, DefenseAttorney::Base
 
     def self.depends(*use_case_classes)
-      dependencies.push *use_case_classes
+      dependencies.push(*use_case_classes)
     end
 
     def self.dependencies
@@ -18,7 +18,7 @@ module RestMyCase
       attributes ||= {}
 
       unless attributes.respond_to?(:to_hash)
-        raise ArgumentError.new('Must respond_to method #to_hash')
+        fail ArgumentError, 'Must respond_to method #to_hash'
       end
 
       TRIAL_COURT.execute([self], attributes.to_hash).context
@@ -72,15 +72,15 @@ module RestMyCase
     end
 
     def abort!
-      abort && raise(Errors::Abort)
+      abort && fail(Errors::Abort)
     end
 
-    def fail(message = '')
+    def error(message = '')
       abort && context.errors[self.class.name].push(message)
     end
 
-    def fail!(message = '')
-      fail(message) && raise(Errors::Abort)
+    def error!(message = '')
+      error(message) && fail(Errors::Abort)
     end
 
     def skip
@@ -88,7 +88,7 @@ module RestMyCase
     end
 
     def skip!
-      skip && raise(Errors::Skip)
+      skip && fail(Errors::Skip)
     end
 
     protected ######################## PROTECTED ###############################

data/lib/rest_my_case/context/base.rb

@@ -3,7 +3,7 @@ module RestMyCase
 
     class Base < OpenStruct
 
-      alias :attributes :marshal_dump
+      alias_method :attributes, :marshal_dump
 
       include ActiveModel::Serialization if defined?(ActiveModel)
 
@@ -19,7 +19,7 @@ module RestMyCase
         errors.empty?
       end
 
-      alias :ok? :valid?
+      alias_method :ok?, :valid?
 
     end
 

data/lib/rest_my_case/defense_attorney/base.rb

@@ -20,7 +20,7 @@ module RestMyCase
         return [] unless use_case_class.respond_to? :dependencies
 
         all_dependencies(use_case_class.superclass) |
-        dependencies_including_itself_last(use_case_class, nil)
+          dependencies_including_itself_last(use_case_class, nil)
       end
 
       private ########################### PRIVATE ##############################

data/lib/rest_my_case/errors.rb

@@ -7,5 +7,7 @@ module RestMyCase
 
     class Abort < Base; end
 
+    class Error < Base; end
+
   end
 end

data/lib/rest_my_case/judge/base.rb

@@ -6,7 +6,7 @@ module RestMyCase
       def initialize(trial_case)
         @trial_case            = trial_case
         @performed_use_cases   = []
-        @use_case_that_aborted = false
+        @use_case_that_aborted = nil
       end
 
       def determine_the_sentence
@@ -15,7 +15,7 @@ module RestMyCase
         run_rollback_methods
         run_final_methods
 
-        @trial_case.aborted = !!@use_case_that_aborted
+        @trial_case.aborted = !@use_case_that_aborted.nil?
       end
 
       protected ######################## PROTECTED #############################
@@ -37,7 +37,7 @@ module RestMyCase
       def run_rollback_methods
         return nil unless @use_case_that_aborted
 
-        @performed_use_cases.reverse.each do |use_case|
+        @performed_use_cases.reverse_each do |use_case|
           method_aborts?(:rollback, use_case)
         end
       end
@@ -63,15 +63,13 @@ module RestMyCase
       end
 
       def method_aborts?(method_name, use_case)
-        begin
-          use_case.send(method_name)
-
-          use_case.options[:should_abort] && @use_case_that_aborted = use_case
-        rescue Errors::Skip
-          false
-        rescue Errors::Abort
-          @use_case_that_aborted = use_case
-        end
+        use_case.send(method_name)
+
+        use_case.options[:should_abort] && @use_case_that_aborted = use_case
+      rescue Errors::Skip
+        false
+      rescue Errors::Abort
+        @use_case_that_aborted = use_case
       end
 
     end

data/lib/rest_my_case/trial/court.rb

@@ -1,7 +1,7 @@
 module RestMyCase
   module Trial
 
-    class Court < Struct.new(:judge_class, :defense_attorney_class)
+    Court = Struct.new(:judge_class, :defense_attorney_class) do
 
       def execute(use_case_classes, attributes = {})
         trial_case = Case.new(use_case_classes, attributes)

data/lib/rest_my_case/trial/defendant.rb

@@ -1,8 +1,7 @@
 module RestMyCase
   module Trial
 
-    class Defendant < Struct.new(:use_case_classes)
-    end
+    Defendant = Struct.new(:use_case_classes)
 
   end
 end

data/lib/rest_my_case/version.rb

@@ -1,5 +1,5 @@
 module RestMyCase
 
-  VERSION = "1.5.0"
+  VERSION = '1.6.0'
 
 end

data/lib/rest_my_case.rb

@@ -1,20 +1,20 @@
 require 'ostruct'
 
-require "rest_my_case/version"
-require "rest_my_case/errors"
+require 'rest_my_case/version'
+require 'rest_my_case/errors'
 
-require "rest_my_case/config/base"
-require "rest_my_case/config/general"
+require 'rest_my_case/config/base'
+require 'rest_my_case/config/general'
 
-require "rest_my_case/defense_attorney/base"
-require "rest_my_case/context/base"
-require "rest_my_case/judge/base"
+require 'rest_my_case/defense_attorney/base'
+require 'rest_my_case/context/base'
+require 'rest_my_case/judge/base'
 
-require "rest_my_case/trial/defendant"
-require "rest_my_case/trial/case"
-require "rest_my_case/trial/court"
+require 'rest_my_case/trial/defendant'
+require 'rest_my_case/trial/case'
+require 'rest_my_case/trial/court'
 
-require "rest_my_case/base"
+require 'rest_my_case/base'
 
 module RestMyCase
 

data/rest_my_case.gemspec

@@ -4,22 +4,24 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rest_my_case/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = "rest_my_case"
+  gem.name          = 'rest_my_case'
   gem.version       = RestMyCase::VERSION
-  gem.authors       = ["goncalvesjoao"]
-  gem.email         = ["goncalves.joao@gmail.com"]
+  gem.authors       = ['goncalvesjoao']
+  gem.email         = ['goncalves.joao@gmail.com']
   gem.summary       = %q{Quick and light "The Clean Architecture" use case implementation.}
   gem.description   = %q{Very light Ruby gem with everything you need in a "The Clean Architecture" use case scenario}
-  gem.homepage      = "https://github.com/goncalvesjoao/rest_my_case"
-  gem.license       = "MIT"
+  gem.homepage      = 'https://github.com/goncalvesjoao/rest_my_case'
+  gem.license       = 'MIT'
 
   gem.files         = `git ls-files -z`.split("\x0")
   gem.executables   = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.require_paths = ['lib']
 
-  gem.add_development_dependency "pry", '~> 0.10'
-  gem.add_development_dependency "rake", '~> 10.1'
-  gem.add_development_dependency "rspec",'~> 3.2'
-  gem.add_development_dependency "simplecov", '~> 0.9'
+  gem.add_development_dependency 'pry', '~> 0.10'
+  gem.add_development_dependency 'rake', '~> 10.1'
+  gem.add_development_dependency 'rspec', '~> 3.2'
+  gem.add_development_dependency 'rubocop', '~> 0.30'
+  gem.add_development_dependency 'simplecov', '~> 0.9'
+  gem.add_development_dependency 'codeclimate-test-reporter', '~> 0.4'
 end

data/spec/rest_my_case/base_spec.rb

@@ -96,10 +96,10 @@ describe RestMyCase::Base do
 
     end
 
-    context "When a use case calls #fail during the setup process" do
+    context "When a use case calls #error during the setup process" do
       before do
         @context = Perform::CreatePost.perform \
-          fail: ['Perform::ValidateName_setup', 'Perform::ValidateBody_setup']
+          error: ['Perform::ValidateName_setup', 'Perform::ValidateBody_setup']
       end
 
       it "context should reflect an invalid state" do
@@ -118,10 +118,10 @@ describe RestMyCase::Base do
       end
     end
 
-    context "When a use case calls #fail! during the setup process" do
+    context "When a use case calls #error! during the setup process" do
       before do
         @context = Perform::CreatePost.perform \
-          fail_bang: ['Perform::ValidateName_setup']
+          error_bang: ['Perform::ValidateName_setup']
       end
 
       it "context should reflect an invalid state" do
@@ -219,10 +219,10 @@ describe RestMyCase::Base do
       before  { Perform::Validations.silence_dependencies_abort = true }
       after   { Perform::Validations.silence_dependencies_abort = nil }
 
-      context "When a use case calls #fail during the setup process" do
+      context "When a use case calls #error during the setup process" do
         before do
           @context = Perform::CreatePost.perform \
-            fail: ['Perform::ValidateName_setup', 'Perform::ValidateBody_setup']
+            error: ['Perform::ValidateName_setup', 'Perform::ValidateBody_setup']
         end
 
         it "context should reflect an invalid state" do
@@ -242,11 +242,11 @@ describe RestMyCase::Base do
 
       end
 
-      context "When a use case calls #fail during the perform process" do
+      context "When a use case calls #error during the perform process" do
 
         before do
           @context = Perform::CreatePost.perform \
-            fail: ['Perform::ValidateName_perform', 'Perform::ValidateBody_perform']
+            error: ['Perform::ValidateName_perform', 'Perform::ValidateBody_perform']
         end
 
         it "context should reflect an invalid state" do
@@ -277,11 +277,11 @@ describe RestMyCase::Base do
       end
       after { RestMyCase.reset_config }
 
-      context "When a use case calls #fail during the perform process" do
+      context "When a use case calls #error during the perform process" do
 
         before do
           @context = Perform::CreatePost.perform \
-            fail: ['Perform::ValidateName_perform', 'Perform::ValidateBody_perform', 'Perform::BuildPost_perform', 'Perform::SavePost_perform']
+            error: ['Perform::ValidateName_perform', 'Perform::ValidateBody_perform', 'Perform::BuildPost_perform', 'Perform::SavePost_perform']
         end
 
         it "context should reflect an invalid state" do
@@ -396,7 +396,7 @@ describe RestMyCase::Base do
 
       before do
         @context = Perform::CreatePost2.perform \
-          fail: ['Perform::ValidateName_perform', 'Perform::ValidateBody_perform']
+          error: ['Perform::ValidateName_perform', 'Perform::ValidateBody_perform']
       end
 
       it "invoker should abort the process it his invokees have also aborted" do

data/spec/spec_helper.rb

@@ -1,3 +1,7 @@
+require "codeclimate-test-reporter"
+
+CodeClimate::TestReporter.start
+
 require "simplecov"
 
 SimpleCov.start do

data/spec/support/perform.rb

@@ -4,8 +4,8 @@ module Perform
     def flow_control(method)
       id = "#{self.class.name}_#{method}"
 
-      context.fail        ||= []
-      context.fail_bang   ||= []
+      context.error       ||= []
+      context.error_bang  ||= []
       context.skip        ||= []
       context.skip_bang   ||= []
       context.abort       ||= []
@@ -15,8 +15,8 @@ module Perform
       context.rollback    ||= []
       context.final       ||= []
 
-      fail    if context.fail.include? id
-      fail!   if context.fail_bang.include? id
+      error   if context.error.include? id
+      error!  if context.error_bang.include? id
       skip    if context.skip.include? id
       skip!   if context.skip_bang.include? id
       abort   if context.abort.include? id

data/spec/support/rest_my_case_base.rb

@@ -3,11 +3,11 @@ module RestMyCaseBase
   class BuildPost < RestMyCase::Base; end
 
   class ValidateName < RestMyCase::Base
-    def perform; fail('no name present!'); end
+    def perform; error('no name present!'); end
   end
 
   class ValidateBody < RestMyCase::Base
-    def perform; fail('no body present!'); end
+    def perform; error('no body present!'); end
   end
 
   class Validations < RestMyCase::Base

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rest_my_case
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - goncalvesjoao
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.30'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.30'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
 description: Very light Ruby gem with everything you need in a "The Clean Architecture"
   use case scenario
 email:
@@ -76,9 +104,10 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE
-- LICENSE.txt
 - README.md
 - Rakefile
 - console

data/LICENSE.txt

@@ -1,22 +0,0 @@
-Copyright (c) 2015 goncalvesjoao
-
-MIT License
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.