rest-more 3.3.4 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab435e1b0b7117a382c7428c0225a6d2f97f79d2
-  data.tar.gz: 676394586c1415ac9650a032f410b47571594816
+  metadata.gz: c6890c9728c71859155f4faa86e8222567d4ea7e
+  data.tar.gz: 9c709ac13ba18a68c0d0b0c5436e17b39374f77d
 SHA512:
-  metadata.gz: 66932c197c76174e7686fdbd34b6489c230f91442d64cb176adff5965b326cc924d9380967b9b330a52054e5e7d925a2ded9579ad9c236f9573540dc95d1a10d
-  data.tar.gz: ed2ead251cbd3828c83b2ddd2fe8f3271b7478bab361e808f699ca543c1721e6ff4403ff6fa6b9e65ae3a333baf8674e74b95f237289111c6e527911fe6d3843
+  metadata.gz: 11e56fe43e2e321e788c527107275acbc69e44f0b17e4e18f4016a4c3acc4fa6a6bd50f43a4610976f661252443ee458d55118b84339d0ca28d0a59f250e3ead
+  data.tar.gz: a6a80e43e0553914b5e6365ebc024e6168e50e0124c0fa29bac360958d74ab0f022f1d9b556074c5dda0bf0a49cc5cb13f82668201e2e5504ecf0e62eb3faed8

data/.travis.yml

@@ -1,14 +1,17 @@
-
+sudo: false
 language: ruby
 rvm:
-  - 2.0
-  - 2.1
   - 2.2
-  - rbx-2
-  - jruby
+  - 2.3.0
+  - rbx
+  - jruby-9
 
+before_install:
+  - rvm get head
+  - rvm reload
+  - rvm use --install $TRAVIS_RUBY_VERSION --binary --latest
 install: 'bundle install --retry=3'
-script: 'ruby -r bundler/setup -S rake test:travis'
+script: 'ruby -vr bundler/setup -S rake test:travis'
 
 env:
   - 'RESTMORE=rest-more'
@@ -18,3 +21,5 @@ matrix:
   allow_failures:
     - rvm: 2.2
       env: 'RESTMORE=rails3'
+    - rvm: 2.3.0
+      env: 'RESTMORE=rails3'

data/CHANGES.md

@@ -1,5 +1,13 @@
 # CHANGES
 
+## rest-more 3.4.0 -- 2016-02-04
+
+* `RC::Github` would now follow redirect for 5 times by default.
+* `RestCore::Github::Error::ClientError` was never used and removed.
+* `RestCore::Github::Error::ServerError` was also removed and favouring
+  just `RestCore::Github::Error`.
+* Adopt rest-core 4.0.0
+
 ## rest-more 3.3.4 -- 2015-10-15
 
 * [`Dropbox`] Updated content API server. Thanks khoa nguyen (@khoan)

data/Rakefile

@@ -2,19 +2,20 @@
 begin
   require "#{dir = File.dirname(__FILE__)}/task/gemgem"
 rescue LoadError
-  sh 'git submodule update --init'
+  sh 'git submodule update --init --recursive'
   exec Gem.ruby, '-S', $PROGRAM_NAME, *ARGV
 end
 
-$LOAD_PATH.unshift(File.expand_path("#{dir}/rest-core/lib"))
+%w[lib rest-builder/lib rest-builder/promise_pool/lib].each do |path|
+  $LOAD_PATH.unshift(File.expand_path("#{dir}/rest-core/#{path}"))
+end
 
 Gemgem.init(dir) do |s|
   require 'rest-more/version'
-  s.name     = 'rest-more'
-  s.version  = RestMore::VERSION
-  s.homepage = 'https://github.com/godfat/rest-more'
+  s.name    = 'rest-more'
+  s.version = RestMore::VERSION
 
-  %w[rest-core].each{ |g| s.add_runtime_dependency(g, '>=3.3.0') }
+  %w[rest-core].each{ |g| s.add_runtime_dependency(g, '>=4.0.0') }
 
   # exclude rest-core
   s.files.reject!{ |f| f.start_with?('rest-core/') }

data/lib/rest-core/client/github.rb

@@ -4,31 +4,29 @@ require 'rest-core'
 # http://developer.github.com/v3/
 module RestCore
   Github = Builder.client(:client_id, :client_secret, :data) do
-    use Timeout       , 10
-
     use DefaultSite   , 'https://api.github.com/'
     use DefaultHeaders, {'Accept' => 'application/json'}
     use Oauth2Query   , nil
 
-    use CommonLogger  , nil
+    use Timeout       , 10
+    use FollowRedirect, 5
     use ErrorHandler  , lambda{ |env| Github::Error.call(env) }
     use ErrorDetectorHttp
     use JsonResponse  , true
+    use CommonLogger  , nil
     use Cache         , nil, 600
   end
 end
 
 class RestCore::Github::Error < RestCore::Error
   include RestCore
-  class ServerError         < Github::Error; end
-  class ClientError         < Github::Error; end
 
   class BadRequest          < Github::Error; end
   class Unauthorized        < Github::Error; end
   class Forbidden           < Github::Error; end
   class NotFound            < Github::Error; end
   class UnprocessableEntity < Github::Error; end
-  class InternalServerError < Github::Error::ServerError; end
+  class InternalServerError < Github::Error; end
 
   attr_reader :error, :code, :url
   def initialize error, code, url=''

data/lib/rest-more/version.rb

@@ -1,4 +1,4 @@
 
 module RestMore
-  VERSION = '3.3.4'
+  VERSION = '3.4.0'
 end

data/rest-more.gemspec

@@ -1,117 +1,117 @@
 # -*- encoding: utf-8 -*-
-# stub: rest-more 3.3.4 ruby lib
+# stub: rest-more 3.4.0 ruby lib
 
 Gem::Specification.new do |s|
-  s.name = "rest-more"
-  s.version = "3.3.4"
+  s.name = "rest-more".freeze
+  s.version = "3.4.0"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
-  s.authors = ["Lin Jen-Shin (godfat)"]
-  s.date = "2015-10-15"
-  s.description = "Various REST clients such as Facebook and Twitter built with [rest-core][].\n\n[rest-core]: https://github.com/godfat/rest-core"
-  s.email = ["godfat (XD) godfat.org"]
-  s.executables = ["rib-rest-core"]
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Lin Jen-Shin (godfat)".freeze]
+  s.date = "2016-02-04"
+  s.description = "Various REST clients such as Facebook and Twitter built with [rest-core][].\n\n[rest-core]: https://github.com/godfat/rest-core".freeze
+  s.email = ["godfat (XD) godfat.org".freeze]
+  s.executables = ["rib-rest-core".freeze]
   s.files = [
-  ".gitignore",
-  ".gitmodules",
-  ".travis.yml",
-  "CHANGES.md",
-  "Gemfile",
-  "LICENSE",
-  "README.md",
-  "Rakefile",
-  "TODO.md",
-  "bin/rib-rest-core",
-  "doc/facebook.md",
-  "example/multi.rb",
-  "example/rails3/Gemfile",
-  "example/rails3/README",
-  "example/rails3/Rakefile",
-  "example/rails3/app/controllers/application_controller.rb",
-  "example/rails3/app/views/application/helper.html.erb",
-  "example/rails3/config.ru",
-  "example/rails3/config/application.rb",
-  "example/rails3/config/boot.rb",
-  "example/rails3/config/environment.rb",
-  "example/rails3/config/environments/development.rb",
-  "example/rails3/config/environments/production.rb",
-  "example/rails3/config/environments/test.rb",
-  "example/rails3/config/initializers/secret_token.rb",
-  "example/rails3/config/initializers/session_store.rb",
-  "example/rails3/config/rest-core.yaml",
-  "example/rails3/config/routes.rb",
-  "example/rails3/test/functional/application_controller_test.rb",
-  "example/rails3/test/test_helper.rb",
-  "example/rails3/test/unit/rails_util_test.rb",
-  "example/simple.rb",
-  "example/sinatra/config.ru",
-  "lib/rest-core/client/dropbox.rb",
-  "lib/rest-core/client/facebook.rb",
-  "lib/rest-core/client/facebook/rails_util.rb",
-  "lib/rest-core/client/github.rb",
-  "lib/rest-core/client/github/rails_util.rb",
-  "lib/rest-core/client/instagram.rb",
-  "lib/rest-core/client/linkedin.rb",
-  "lib/rest-core/client/linkedin/rails_util.rb",
-  "lib/rest-core/client/stackexchange.rb",
-  "lib/rest-core/client/twitter.rb",
-  "lib/rest-core/client/twitter/rails_util.rb",
-  "lib/rest-core/util/rails_util_util.rb",
-  "lib/rest-more.rb",
-  "lib/rest-more/test.rb",
-  "lib/rest-more/version.rb",
-  "lib/rib/app/rest-core.rb",
-  "rest-more.gemspec",
-  "task/README.md",
-  "task/gemgem.rb",
-  "test/dropbox/test_dropbox.rb",
-  "test/facebook/test_api.rb",
-  "test/facebook/test_default.rb",
-  "test/facebook/test_error.rb",
-  "test/facebook/test_handler.rb",
-  "test/facebook/test_misc.rb",
-  "test/facebook/test_oauth.rb",
-  "test/facebook/test_old.rb",
-  "test/facebook/test_page.rb",
-  "test/facebook/test_parse.rb",
-  "test/facebook/test_serialize.rb",
-  "test/facebook/test_timeout.rb",
-  "test/github/test_github.rb",
-  "test/instagram/test_instagram.rb",
-  "test/stackexchange/test_stackexchange.rb",
-  "test/twitter/test_twitter.rb"]
-  s.homepage = "https://github.com/godfat/rest-more"
-  s.licenses = ["Apache License 2.0"]
-  s.rubygems_version = "2.4.8"
-  s.summary = "Various REST clients such as Facebook and Twitter built with [rest-core][]."
+  ".gitignore".freeze,
+  ".gitmodules".freeze,
+  ".travis.yml".freeze,
+  "CHANGES.md".freeze,
+  "Gemfile".freeze,
+  "LICENSE".freeze,
+  "README.md".freeze,
+  "Rakefile".freeze,
+  "TODO.md".freeze,
+  "bin/rib-rest-core".freeze,
+  "doc/facebook.md".freeze,
+  "example/multi.rb".freeze,
+  "example/rails3/Gemfile".freeze,
+  "example/rails3/README".freeze,
+  "example/rails3/Rakefile".freeze,
+  "example/rails3/app/controllers/application_controller.rb".freeze,
+  "example/rails3/app/views/application/helper.html.erb".freeze,
+  "example/rails3/config.ru".freeze,
+  "example/rails3/config/application.rb".freeze,
+  "example/rails3/config/boot.rb".freeze,
+  "example/rails3/config/environment.rb".freeze,
+  "example/rails3/config/environments/development.rb".freeze,
+  "example/rails3/config/environments/production.rb".freeze,
+  "example/rails3/config/environments/test.rb".freeze,
+  "example/rails3/config/initializers/secret_token.rb".freeze,
+  "example/rails3/config/initializers/session_store.rb".freeze,
+  "example/rails3/config/rest-core.yaml".freeze,
+  "example/rails3/config/routes.rb".freeze,
+  "example/rails3/test/functional/application_controller_test.rb".freeze,
+  "example/rails3/test/test_helper.rb".freeze,
+  "example/rails3/test/unit/rails_util_test.rb".freeze,
+  "example/simple.rb".freeze,
+  "example/sinatra/config.ru".freeze,
+  "lib/rest-core/client/dropbox.rb".freeze,
+  "lib/rest-core/client/facebook.rb".freeze,
+  "lib/rest-core/client/facebook/rails_util.rb".freeze,
+  "lib/rest-core/client/github.rb".freeze,
+  "lib/rest-core/client/github/rails_util.rb".freeze,
+  "lib/rest-core/client/instagram.rb".freeze,
+  "lib/rest-core/client/linkedin.rb".freeze,
+  "lib/rest-core/client/linkedin/rails_util.rb".freeze,
+  "lib/rest-core/client/stackexchange.rb".freeze,
+  "lib/rest-core/client/twitter.rb".freeze,
+  "lib/rest-core/client/twitter/rails_util.rb".freeze,
+  "lib/rest-core/util/rails_util_util.rb".freeze,
+  "lib/rest-more.rb".freeze,
+  "lib/rest-more/test.rb".freeze,
+  "lib/rest-more/version.rb".freeze,
+  "lib/rib/app/rest-core.rb".freeze,
+  "rest-more.gemspec".freeze,
+  "task/README.md".freeze,
+  "task/gemgem.rb".freeze,
+  "test/dropbox/test_dropbox.rb".freeze,
+  "test/facebook/test_api.rb".freeze,
+  "test/facebook/test_default.rb".freeze,
+  "test/facebook/test_error.rb".freeze,
+  "test/facebook/test_handler.rb".freeze,
+  "test/facebook/test_misc.rb".freeze,
+  "test/facebook/test_oauth.rb".freeze,
+  "test/facebook/test_old.rb".freeze,
+  "test/facebook/test_page.rb".freeze,
+  "test/facebook/test_parse.rb".freeze,
+  "test/facebook/test_serialize.rb".freeze,
+  "test/facebook/test_timeout.rb".freeze,
+  "test/github/test_github.rb".freeze,
+  "test/instagram/test_instagram.rb".freeze,
+  "test/stackexchange/test_stackexchange.rb".freeze,
+  "test/twitter/test_twitter.rb".freeze]
+  s.homepage = "https://github.com/godfat/rest-more".freeze
+  s.licenses = ["Apache License 2.0".freeze]
+  s.rubygems_version = "2.5.2".freeze
+  s.summary = "Various REST clients such as Facebook and Twitter built with [rest-core][].".freeze
   s.test_files = [
-  "test/dropbox/test_dropbox.rb",
-  "test/facebook/test_api.rb",
-  "test/facebook/test_default.rb",
-  "test/facebook/test_error.rb",
-  "test/facebook/test_handler.rb",
-  "test/facebook/test_misc.rb",
-  "test/facebook/test_oauth.rb",
-  "test/facebook/test_old.rb",
-  "test/facebook/test_page.rb",
-  "test/facebook/test_parse.rb",
-  "test/facebook/test_serialize.rb",
-  "test/facebook/test_timeout.rb",
-  "test/github/test_github.rb",
-  "test/instagram/test_instagram.rb",
-  "test/stackexchange/test_stackexchange.rb",
-  "test/twitter/test_twitter.rb"]
+  "test/dropbox/test_dropbox.rb".freeze,
+  "test/facebook/test_api.rb".freeze,
+  "test/facebook/test_default.rb".freeze,
+  "test/facebook/test_error.rb".freeze,
+  "test/facebook/test_handler.rb".freeze,
+  "test/facebook/test_misc.rb".freeze,
+  "test/facebook/test_oauth.rb".freeze,
+  "test/facebook/test_old.rb".freeze,
+  "test/facebook/test_page.rb".freeze,
+  "test/facebook/test_parse.rb".freeze,
+  "test/facebook/test_serialize.rb".freeze,
+  "test/facebook/test_timeout.rb".freeze,
+  "test/github/test_github.rb".freeze,
+  "test/instagram/test_instagram.rb".freeze,
+  "test/stackexchange/test_stackexchange.rb".freeze,
+  "test/twitter/test_twitter.rb".freeze]
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<rest-core>, [">= 3.3.0"])
+      s.add_runtime_dependency(%q<rest-core>.freeze, [">= 4.0.0"])
     else
-      s.add_dependency(%q<rest-core>, [">= 3.3.0"])
+      s.add_dependency(%q<rest-core>.freeze, [">= 4.0.0"])
     end
   else
-    s.add_dependency(%q<rest-core>, [">= 3.3.0"])
+    s.add_dependency(%q<rest-core>.freeze, [">= 4.0.0"])
   end
 end

data/test/facebook/test_error.rb

@@ -51,15 +51,4 @@ describe RC::Facebook::Error do
     error.should.not.kind_of?(RC::Facebook::Error::AccessToken)
     error.should    .kind_of?(RC::Facebook::Error)
   end
-
-  would 'nuke cache upon errors' do
-    stub_request(:get, 'https://graph.facebook.com/me').
-      to_return(:body => '{"error":"wrong"}').times(2)
-
-    rg = RC::Facebook.new(:cache => {},
-                          :error_handler => lambda{|env|env})
-    rg.get('me'); rg.get('me')
-    rg.wait
-    rg.cache.values.should.eq []
-  end
 end

data/test/facebook/test_parse.rb

@@ -77,7 +77,7 @@ describe RC::Facebook do
 
   describe 'signed_request' do
     def encode str
-      [str].pack('m0').tr('=', '').tr('+/', '-_')
+      [str].pack('m0').tr('+/', '-_')
     end
 
     def setup_sr secret, data, sig=nil

data/test/facebook/test_timeout.rb

@@ -10,7 +10,7 @@ describe RC::Facebook do
   would 'respect timeout' do
     stub_request(:get, 'https://graph.facebook.com/me').
       to_return(:body => '{}')
-    any_instance_of(RC::Timeout::Timer){ |timer|
+    any_instance_of(PromisePool::Timer){ |timer|
       mock(timer).on_timeout
     }
     RC::Facebook.new.get('me').should.eq({})
@@ -19,7 +19,7 @@ describe RC::Facebook do
   would 'override timeout' do
     stub_request(:get, 'https://graph.facebook.com/me').
       to_return(:body => 'true')
-    mock(RC::Timeout::Timer).new(99, is_a(Timeout::Error))
+    mock(PromisePool::Timer).new(99, is_a(Timeout::Error))
     RC::Facebook.new(:timeout => 1).get('me', {}, :timeout => 99).
       should.eq true
   end

data/test/github/test_github.rb

@@ -6,6 +6,8 @@ describe RC::Github do
     WebMock.reset!
   end
 
+  # TODO: Pork::Failure: Expect [0].==([0, 1, 2]) to return true
+  # https://travis-ci.org/godfat/rest-more/jobs/105298582
   would 'get all' do
     link = '</users/godfat/repos?type=o&per_page=100&page=3>; rel="last"'
     headers = {'Link' => link}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rest-more
 version: !ruby/object:Gem::Version
-  version: 3.3.4
+  version: 3.4.0
 platform: ruby
 authors:
 - Lin Jen-Shin (godfat)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-15 00:00:00.000000000 Z
+date: 2016-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: 4.0.0
 description: |-
   Various REST clients such as Facebook and Twitter built with [rest-core][].
 
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Various REST clients such as Facebook and Twitter built with [rest-core][].