resque-retry 1.7.5 → 1.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a29581b3dc95632cee77ae024594ec6371f180aa2c321f2ab8867ea9b0a98fd
-  data.tar.gz: 6c833821432ee8fbaa5d701bf93f0ce85655a88273f550cd6fb52f1556ac2f47
+  metadata.gz: bcd42f2b0761226dd2cfa5f9c9d4ff336cda1be0f6acf972ae15cd553f88fa0b
+  data.tar.gz: d65b4261a3ff1068f9880739ea1f4647c10be957511840203331f714cb8281dc
 SHA512:
-  metadata.gz: 916ae887694f4e1cf3b7acba5c444c59983d031f16f3b811b7535cd2c2bd39bfcea98ca095897558151156c76ff5f3e909600ed5150582da508aafa91242c1d9
-  data.tar.gz: ed7eaef67c2fc766b1bf188c8904b354d05079d591dd6cfb8c9c4191e773ece241fdf3ce37c1333300d69d1bc6b40a73deaf39956c6832919a173fc8e7f8fba3
+  metadata.gz: 78c8fccf7a670f1fc0246d7e8862941eae3fb2bda8ea4d11fb1bea2a5890ed1867f50ff9389a752f3383bf5383783b32e3f63c5ef623909a28aaeba62f4576a2
+  data.tar.gz: 8e3e0ed80d154282e6dddd85b8b7b95b22949d580ad6c0c7a0fc9c3a16475dca861320f919db0f2ddf6b8dca78e8bdd846a48b86db6a5761848d6d4fcb7012a4

data/.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
           - 6379:6379
     strategy:
       matrix:
-        ruby-version: [2.7, 2.6, 2.5, 2.4, 2.3]
+        ruby-version: [2.7, 2.6]
 
     steps:
       - uses: actions/checkout@v2
@@ -21,4 +21,4 @@ jobs:
       - name: Install dependencies
         run: bundle install
       - name: Run tests
-        run: bundle exec rake
+        run: bundle exec rake

data/HISTORY.md

@@ -1,3 +1,9 @@
+# 1.7.6 (2021-08-06)
+
+* Fix Redis 4.3 breaking saving job failures with multiple failure backend
+* Disable verbose logging by default during test-runs
+* Remove support for ruby < 2.6
+
 # 1.7.5 (2021-08-06)
 
 * Support `retry_delay` methods with different arity

data/lib/resque-retry/version.rb

@@ -1,3 +1,3 @@
 module ResqueRetry
-  VERSION = '1.7.5'
+  VERSION = '1.7.6'
 end

data/lib/resque/failure/multiple_with_retry_suppression.rb

@@ -143,7 +143,17 @@ module Resque
       end
 
       def retrying?
-        Resque.redis.exists(retry_key)
+        redis_key_exists?(retry_key)
+      end
+
+      private
+
+      def redis_key_exists?(key)
+        if Resque.redis.respond_to?(:exists?)
+          Resque.redis.exists?(key)
+        else
+          ![false, 0].include?(Resque.redis.exists(key) || false)
+        end
       end
     end
   end

data/test/multiple_failure_test.rb

@@ -157,6 +157,20 @@ class MultipleFailureTest < Minitest::Test
     end
   end
 
+  def test_redis_exists_returns_integer
+    Resque.enqueue(RetryDefaultsJob)
+    original = Redis.exists_returns_integer
+    Redis.exists_returns_integer = true
+
+    3.times do
+      perform_next_job(@worker)
+    end
+
+    Redis.exists_returns_integer = original
+
+    assert_equal 1, MockFailureBackend.errors.size
+  end
+
   def teardown
     Resque::Failure.backend = @old_failure_backend
   end

data/test/test_helper.rb

@@ -1,6 +1,8 @@
 dir = File.dirname(File.expand_path(__FILE__))
 $LOAD_PATH.unshift dir + '/../lib'
+
 $TESTING = true
+$VERBOSE = ENV['VERBOSE'] != 'true' ? nil : true
 
 # Run code coverage in MRI 1.9 only.
 if RUBY_VERSION >= '1.9' && RUBY_ENGINE == 'ruby'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: resque-retry
 version: !ruby/object:Gem::Version
-  version: 1.7.5
+  version: 1.7.6
 platform: ruby
 authors:
 - Luke Antins