resque-retry 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18f7b00c3922adebe816efc0357bfba5925dddc5ae85bea9d4b69e0a05e9fb46
-  data.tar.gz: dd4d14d570a628aa667445cd4f64929ecc0bcab22bc536b164bc9e9437574a59
+  metadata.gz: 4acedc3a5e5a68e8a87eff5c05d02db56d2230393bc9950af0d60eb0489718bd
+  data.tar.gz: 5766a03c06859e1b4c36d5b34c4f8f746c38063f946b99633c9481cc92c52b6f
 SHA512:
-  metadata.gz: ffab51ba83437149d5bc39400983e436a38cd4e2d200b7562fa892f16f6facf1310a0dcf666030d8181aec5424dbcd80c146983ce25b3579f7e9a4088692dc8f
-  data.tar.gz: dcef4495dfc111270f16bb02dafa72d1fb66caebe4302dbb0359aad2dcaf72f29c887cc7e0caa22c3ef012aba5813933fb19c1c210b597bea17b6ab4ab561ff6
+  metadata.gz: ecc9d3abda29d488eeb08b779ec2211dca31965023f0cdc8d69b60c57dfd223b68d7a4fc6d6a650cb55471a16b41c82d69d357264e07cd142c26bd8f3a91d82b
+  data.tar.gz: 480e49d4b4bfd340cce9e5551f839ea68d38953ce85fd57418b008f227cf23b8692b0ed54466df1603b19e9e8750326f39ddab4dd09b39760a05293df749ba94

data/HISTORY.md

@@ -1,11 +1,24 @@
+# 1.7.0 (2019-06-15)
+
+!!! [Potential] breaking changes -- details below !!!
+
+* Remove support for `args_for_retry` -- it has been deprecated for almost 5
+  years
+* Work w/ shallow-clone(s) of `args` in `MultipleWithRetrySuppression#save` and
+  `Retry.retry_args`
+* Remove deprecated options from `Gem::Specification`
+* Clean-up formatting in HISTORY.md
+
 # 1.6.0 (2019-04-21)
 
-* Clean-up / refactoring in preparation for a release (`ruby` deprecations, etc.)
+* Clean-up / refactoring in preparation for a release (`ruby` deprecations,
+  etc.)
 * Loosen version requirement to allow resque v2.0 and up (@peret)
 
 # 1.5.3 (2018-11-26)
 
-* Monkey patch in the `requeue_queue` method onto the `Resque::Failure` backend (this _should_ be a temporary fix)
+* Monkey patch in the `requeue_queue` method onto the `Resque::Failure` backend
+  (this _should_ be a temporary fix)
 
 # 1.5.2 (2018-07-16)
 
@@ -14,11 +27,15 @@
 
 # 1.5.1 (2018-01-07)
 
-* Added build support for `ruby-2.2.x`, `ruby-2.3.x`, `ruby-2.4.x` and `ruby-2.5.x`
-* Dropped build support for `ruby-1.9.3` and `ruby-2.0.0` (these versions are no unsupported)
+* Added build support for `ruby-2.2.x`, `ruby-2.3.x`, `ruby-2.4.x` and
+  `ruby-2.5.x`
+* Dropped build support for `ruby-1.9.3` and `ruby-2.0.0` (these versions are
+  no unsupported)
 * Fix some deprecation warnings in tests
-* Feature: If no exact exception class is present in `@retry_exceptions` hash, try to find closest superclass (@fanfilmu)
-* Feature: When running Resque inline, explicitly don't try to retry, don't touch Redis (@michaelglass)
+* Feature: If no exact exception class is present in `@retry_exceptions` hash,
+  try to find closest superclass (@fanfilmu)
+* Feature: When running Resque inline, explicitly don't try to retry, don't
+  touch Redis (@michaelglass)
 
 # 1.5.0 (2015-10-24)
 
@@ -40,25 +57,35 @@
 ## 1.3.0 (2014-07-25)
 
 * Adjust gem dependency on `resque-scheduler` to ~> 3.0
-* Deprecated: `args_for_retry` in favor of `retry_args` (will output deprecation warnings if your using the older method).
-* Feature: Allow changing the args for a given exception using `retry_args_for_exception` (@jonp)
+* Deprecated: `args_for_retry` in favor of `retry_args` (will output deprecation
+  warnings if your using the older method).
+* Feature: Allow changing the args for a given exception using
+  `retry_args_for_exception` (@jonp)
 * Feature: Allow setting `@expire_retry_key_after` on the fly (@orenmazor)
 
 ## 1.2.1 (2014-06-09)
 
-* Fixed Kernel.rand: "invalid argument - 0.0 (ArgumentError)" error with "ExponentialBackoff" (on "Rubinius") when `retry_delay_multiplicand_min` and `retry_delay_multiplicand_max` were the same value (@saizai)
+* Fixed Kernel.rand: "invalid argument - 0.0 (ArgumentError)" error with
+  "ExponentialBackoff" (on "Rubinius") when `retry_delay_multiplicand_min` and
+  `retry_delay_multiplicand_max` were the same value (@saizai)
 
 ## 1.2.0 (2014-05-19)
 
-* Fixed scenario where job does not get retried correctly when `perform` is not called as expected.
-* Feature: Optional `@expire_retry_key_after` settings; expires retry counters from redis to save you cleaning up stale state.
-* Feature: Expose inner-workings of plugin through debug messages using `Resque.logger` (when logging level is Logger:DEBUG).
+* Fixed scenario where job does not get retried correctly when `perform` is not
+  called as expected.
+* Feature: Optional `@expire_retry_key_after` settings; expires retry counters
+  from redis to save you cleaning up stale state.
+* Feature: Expose inner-workings of plugin through debug messages using
+  `Resque.logger` (when logging level is Logger:DEBUG).
 
 ## 1.1.4 (2014-03-17)
 
-* Fixed displaying retry information in resque web interface, caused by `Resque::Helpers` being deprecated.
-* Feature: Allow `@fatal_exceptions` as inverse of `@retry_exceptions`, when fatal exception is raised the job will be immediately fail.
-* Feature: Allow a random retry delay (within a range) when using exponential backoff strategy.
+* Fixed displaying retry information in resque web interface, caused by
+  `Resque::Helpers` being deprecated.
+* Feature: Allow `@fatal_exceptions` as inverse of `@retry_exceptions`, when
+  a fatal exception is raised the job will be immediately fail.
+* Feature: Allow a random retry delay (within a range) when using exponential
+  backoff strategy.
 
 ## 1.1.1 (2014-03-12)
 
@@ -67,7 +94,8 @@
 ## 1.1.0 (2014-03-12)
 
 * Remove dependence on `Resque::Helpers`, will be removed in Resque 2.0
-* Use SHA1 for default `#retry_identifier` to prevents issues with long args gobbling space.
+* Use SHA1 for default `#retry_identifier` to prevents issues with long args
+  gobbling space.
 * Minimum version of Resque is now ~> 1.25
 
 ## 1.0.0 (2012-09-07)
@@ -75,12 +103,16 @@
 ** !!! WARNING !!! INCLUDES NON-BACKWARDS COMPATIBLE CHANGES **
 
 * Fixed issues related to infinite job retries and v1.20.0 of resque.
-* Minimum gem dependency versions changed: resque >= 1.10.0, resque-scheduler >= 1.9.9
-* Feature: Setting `@retry_job_delegate` allows you to separate the original job from a the retry job. (@tanob/@jniesen)
-* Web interface will work without needing to `require` your job code. (n.b. less details available via web).
+* Minimum gem dependency versions changed: resque >= 1.10.0, resque-scheduler
+  >= 1.9.9
+* Feature: Setting `@retry_job_delegate` allows you to separate the original job
+  from a the retry job. (@tanob/@jniesen)
+* Web interface will work without needing to `require` your job code. (n.b.
+  less details available via web).
 * IMPORTANT: `#identifier` method has been namespaced to `#retry_identifier`.
 * Bugfix: `Remove` button on retry web interface was not working.
-* Feature: Allow `tagging` exceptions with a module instead of an exception class. (@tils - Tilmann Singer)
+* Feature: Allow `tagging` exceptions with a module instead of an exception
+  class. (@tils - Tilmann Singer)
 
 ## 0.2.2 (2011-12-08)
 
@@ -88,7 +120,8 @@
 
 ## 0.2.1 (2011-11-23)
 
-* Bugfix: Fixed error when we tried to parse a number/string as JSON on the reque-retry web interface.
+* Bugfix: Fixed error when we tried to parse a number/string as JSON on the
+  reque-retry web interface.
 
 ## 0.2.0 (2011-11-22)
 
@@ -98,9 +131,10 @@
     PREVIOUSLY: 0 == infinite retries.
            NOW: -1 == infinite retries; 0 == means never retry.
 
-* Bugfix: `#redis_retry_key` incorrectly built key when custom identifier was used. (Bogdan Gusiev)
+* Bugfix: `#redis_retry_key` incorrectly built key when custom identifier was
+  used. (Bogdan Gusiev)
 * Feature: Ability to sleep worker after re-queuing a job, may be used to bias
-           against the same worker from picking up the job again. (Michael Keirnan)
+  against the same worker from picking up the job again. (Michael Keirnan)
 * Feature: Ability to remove retry jobs using resque-web. (Thiago Morello)
 * Added example demo application.
 * Added Bundler `Gemfile`.
@@ -130,7 +164,8 @@
 ## 0.0.2 (2010-05-06)
 
 * Bugfix: Were calling non-existent method to delete redis key.
-* Delay no-longer falls back to `sleep`. resque-scheduler is a required dependancy.
+* Delay no-longer falls back to `sleep`. resque-scheduler is a required
+  dependancy.
 * Redis key doesn't include ending colon `:` if no args were passed to the job.
 
 ## 0.0.1 (2010-04-27)

data/lib/resque-retry/version.rb

@@ -1,3 +1,3 @@
 module ResqueRetry
-  VERSION = '1.6.0'
+  VERSION = '1.7.0'
 end

data/lib/resque/failure/multiple_with_retry_suppression.rb

@@ -27,7 +27,9 @@ module Resque
       #
       # @api private
       def save
-        log_message 'failure backend save', args_from(payload), exception
+        args = args_from(payload)
+
+        log_message 'failure backend save', args, exception
 
         retryable = retryable?
         job_being_retried = retryable && retrying?
@@ -35,7 +37,7 @@ module Resque
         if !job_being_retried
           log_message(
             "#{retryable ? '' : 'non-'}retryable job is not being retried - sending failure to superclass",
-            args_from(payload),
+            args,
             exception
           )
 
@@ -44,7 +46,7 @@ module Resque
         elsif retry_delay > 0
           log_message(
             "retry_delay: #{retry_delay} > 0 - saving details in Redis",
-            args_from(payload),
+            args,
             exception
           )
 
@@ -67,7 +69,7 @@ module Resque
         else
           log_message(
             "retry_delay: #{retry_delay} <= 0 - ignoring",
-            args_from(payload),
+            args,
             exception
           )
         end
@@ -100,7 +102,7 @@ module Resque
       protected
 
       def args_from(payload)
-        (payload || {})['args']
+        (payload || {})['args'].dup
       end
 
       def cleanup_retry_failure_log!

data/lib/resque/plugins/retry.rb

@@ -186,15 +186,7 @@ module Resque
       #
       # @api public
       def retry_args(*args)
-        # Here for backwards compatibility. If an "args_for_retry" method exists
-        # invoke it, but warn that it is deprecated (and will be removed in a
-        # future revision)
-        if respond_to?(:args_for_retry)
-          warn "`Resque::Plugins::Retry#args_for_retry` is deprecated, please use `Resque::Plugins::Retry#retry_args` instead."
-          args_for_retry(*args)
-        else
-          args
-        end
+        args.dup
       end
 
       # @abstract

data/resque-retry.gemspec

@@ -25,7 +25,6 @@ Gem::Specification.new do |s|
   s.homepage = 'http://github.com/lantins/resque-retry'
   s.license = 'MIT'
 
-  s.has_rdoc = false
   s.files = `git ls-files`.split($/)
   s.require_paths = %w[lib]
 

data/test/retry_test.rb

@@ -55,13 +55,6 @@ class RetryTest < Minitest::Test
     assert_equal test_args, job['args']
   end
 
-  def test_job_args_can_be_modified_by_overriding_args_for_retry
-    Resque.enqueue(DeprecatedRetryWithModifiedArgsJob)
-    DeprecatedRetryWithModifiedArgsJob.expects(:warn)
-    DeprecatedRetryWithModifiedArgsJob.expects(:args_for_retry)
-    perform_next_job(@worker)
-  end
-
   def test_job_args_can_be_modified_by_overriding_retry_args
     Resque.enqueue(RetryWithModifiedArgsJob)
     RetryWithModifiedArgsJob.expects(:retry_args)

data/test/test_jobs.rb

@@ -146,14 +146,6 @@ class InheritTestWithMoreExtraJob < InheritTestWithExtraJob
   end
 end
 
-class DeprecatedRetryWithModifiedArgsJob < RetryDefaultsJob
-  @queue = :testing
-
-  def self.args_for_retry(*args)
-    # NOTE: implementation is irrelevant we only care that it's invoked
-  end
-end
-
 class RetryWithModifiedArgsJob < RetryDefaultsJob
   @queue = :testing
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: resque-retry
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Luke Antins
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-21 00:00:00.000000000 Z
+date: 2019-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque