resque-rate_limited_queue 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3d514482bdda5f90ef98a9d898bfe9cc2bd3a4c
-  data.tar.gz: 0f2162ec01cb03476e918d62545a5fc9081000e9
+  metadata.gz: 5cab3ff531eddf3677d1dce33e4d8d0a4dc9d515
+  data.tar.gz: 2b916b8dd1515d1fe533ae20115bf45f05d1985a
 SHA512:
-  metadata.gz: a688b780cffbef935aea3a5d7a6402c255e3933e91bb9367bd18b830a76669b209afdf9c74f4b97ce883e1aad1382b0f7df68592762ffe0f18665b6b196e2d29
-  data.tar.gz: 183fa3c3080f6de61da2d9d157666fa078ea094c025658993ed6e1097b7482bb8f61013148a13ebaf8b944695a1f623a5d4bb4891a87254523afd2c940a14722
+  metadata.gz: 2a33bc20ca9ddb4424c0728dbba292b50df89167697240e2a3edb253ba47dc4a4f5a4eb54fe6b5b38053bb6f0b9f1242007b5aff7aeb41493ff728245ecbd790
+  data.tar.gz: 5bdf3b1ebd1d2860facd9d2630ca79a3cd94f28ca1104430f84c8a4b09c881ba203789db738ea8ae5bb06e6562fb15e6161050026abab739b3ae200388dc3048

data/.hound.yml

@@ -0,0 +1,4 @@
+---
+ruby:
+  enabled: true
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,46 @@
+---
+AllCops:
+  Exclude:
+    - 'tmp/**/*'
+    - 'coverage/**/*'
+    - 'spec/dummy/**/*'
+
+#-------------------------------------------------------------------------------
+# Project standards
+#-------------------------------------------------------------------------------
+StringLiterals:
+  EnforcedStyle: single_quotes
+  Enabled: true
+
+DotPosition:
+  Description: 'Checks the position of the dot in multi-line method calls.'
+  EnforcedStyle: leading
+  Enabled: true
+
+Documentation:
+  Description: 'Document classes and non-namespace modules.'
+  Enabled: false
+
+FileName:
+  Description: 'Use snake_case for source file names.'
+  Enabled: true
+
+Style/SymbolArray:
+  Description: 'Use %i or %I for arrays of symbols.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-i'
+  Enabled: false # Only available in Ruby 2.0+
+
+Style/ExtraSpacing:
+  Description: 'Do not use unnecessary spacing.'
+  Enabled: true
+
+Lint/LiteralInInterpolation:
+  Description: 'Avoid interpolating literals in strings'
+  AutoCorrect: true
+
+#-------------------------------------------------------------------------------
+# These rules have been relaxed because of existing code
+# We should tighten these up over time
+#-------------------------------------------------------------------------------
+LineLength:
+  Max: 166 # project standard is 120

data/Guardfile

@@ -0,0 +1,16 @@
+guard :rubocop do
+  watch(/.+\.rb$/)
+  watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+end
+
+guard(
+  :rspec,
+  all_after_pass: true,
+  all_on_start: true,
+  cmd: 'NO_SIMPLECOV=true bundle exec rspec --fail-fast --format documentation'
+) do
+  watch(%r{spec/.+_spec\.rb$})
+  watch(%r{lib/(.+)\.rb$}) { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb') { 'spec' }
+  watch(%r{^spec/support/.+\.rb$}) { 'spec' }
+end

data/Rakefile

@@ -1,2 +1 @@
-require "bundler/gem_tasks"
-
+require 'bundler/gem_tasks'

data/lib/resque-rate_limited_queue/version.rb

@@ -1,3 +1,3 @@
 module RateLimitedQueue
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

data/lib/resque/plugins/rate_limited_queue/apis/evernote_queue.rb

@@ -9,6 +9,7 @@ module Resque
         def self.perform(klass, *params)
           super
         rescue Evernote::EDAM::Error::EDAMSystemException => e
+          raise unless e.errorCode == Evernote::EDAM::Error::EDAMErrorCode::RATE_LIMIT_REACHED
           pause_until(Time.now + 60 * e.rateLimitDuration.seconds)
           rate_limited_requeue(self, klass, *params)
         end

data/resque-rate_limited_queue.gemspec

@@ -4,37 +4,40 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'resque-rate_limited_queue/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "resque-rate_limited_queue"
+  spec.name          = 'resque-rate_limited_queue'
   spec.version       = RateLimitedQueue::VERSION
-  spec.authors       = ["Greg Dowling"]
-  spec.email         = ["mail@greddowling.com"]
-  spec.summary     = %q{A Resque plugin to help manage jobs that use rate limited apis, pausing when you hit the limits and restarting later.}
-  spec.description = %q{A Resque plugin which allows you to create dedicated queues for jobs that use rate limited apis.
+  spec.authors       = ['Greg Dowling']
+  spec.email         = ['mail@greddowling.com']
+  spec.summary     = 'A Resque plugin to help manage jobs that use rate limited apis, pausing when you hit the limits and restarting later.'
+  spec.description = 'A Resque plugin which allows you to create dedicated queues for jobs that use rate limited apis.
 These queues will pause when one of the jobs hits a rate limit, and unpause after a suitable time period.
 The rate_limited_queue can be used directly, and just requires catching the rate limit exception and pausing the
 queue. There are also additional queues provided that already include the pause/rety logic for twitter, angelist
-and evernote; these allow you to support rate limited apis with minimal changes.}
+and evernote; these allow you to support rate limited apis with minimal changes.'
 
-  spec.homepage      = "http://github.com/pavoni/resque-rate-limited-queue"
-  spec.license       = "MIT"
+  spec.homepage      = 'http://github.com/pavoni/resque-rate-limited-queue'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_dependency('resque', '~> 1.9', '>= 1.9.10')
-  spec.add_dependency('redis-mutex','~> 4.0', '>= 4.0.0')
-
-  spec.add_dependency("angellist_api", '~> 1.0', '>= 1.0.7')
-  spec.add_dependency("evernote-thrift", '~> 1.25', '>= 1.25.1')
-  spec.add_dependency("twitter", '~> 5.11', '>= 5.11.0')
-
-
-  spec.add_development_dependency("bundler", "~> 1.7")
-  spec.add_development_dependency("rake", "~> 10.0")
-  spec.add_development_dependency("rspec", "~> 2.6")
-  spec.add_development_dependency("simplecov", '~> 0.9.1')
-
-
+  spec.require_paths = ['lib']
+
+  spec.add_dependency 'resque', '~> 1.9', '>= 1.9.10'
+  spec.add_dependency 'redis-mutex', '~> 4.0', '>= 4.0.0'
+
+  spec.add_dependency 'angellist_api', '~> 1.0', '>= 1.0.7'
+  spec.add_dependency 'evernote-thrift', '~> 1.25', '>= 1.25.1'
+  spec.add_dependency 'twitter', '~> 5.11', '>= 5.11.0'
+
+  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 2.6'
+  spec.add_development_dependency 'simplecov', '~> 0.9.1'
+  spec.add_development_dependency 'gem-release', '~> 0.7'
+  spec.add_development_dependency 'guard', '~> 2.12'
+  spec.add_development_dependency 'guard-rspec', '~> 4.1', '>= 4.1.1'
+  spec.add_development_dependency 'guard-rubocop', '~> 1.2'
+  spec.add_development_dependency 'parser', '~> 2.2.2.5' # To avoid Rubocop parser warnings
+  spec.add_development_dependency 'rubocop', '~> 0.32'
 end

data/spec/apis/angellist_queue_spec.rb

@@ -3,7 +3,7 @@ require 'resque/rate_limited_queue'
 
 class RateLimitedTestQueueAL
   def self.perform(succeed)
-    raise(AngellistApi::Error::TooManyRequests, 'error') unless succeed
+    fail(AngellistApi::Error::TooManyRequests, 'error') unless succeed
   end
 end
 

data/spec/apis/evernote_queue_spec.rb

@@ -9,7 +9,17 @@ end
 
 class RateLimitedTestQueueEn
   def self.perform(succeed)
-    raise(Evernote::EDAM::Error::EDAMSystemException, rateLimitDuration: RateLimitDuration) unless succeed
+    fail(
+      Evernote::EDAM::Error::EDAMSystemException,
+      errorCode: Evernote::EDAM::Error::EDAMErrorCode::RATE_LIMIT_REACHED,
+      rateLimitDuration: RateLimitDuration
+    ) unless succeed
+  end
+end
+
+class RateLimitedTestQueueOther
+  def self.perform
+    fail(Evernote::EDAM::Error::EDAMSystemException)
   end
 end
 
@@ -51,6 +61,16 @@ describe Resque::Plugins::RateLimitedQueue::EvernoteQueue do
           .enqueue(RateLimitedTestQueueEn, false)
       end
     end
+
+    context 'with exception that is not rate limit' do
+      before do
+        Resque::Plugins::RateLimitedQueue::EvernoteQueue.stub(:rate_limited_requeue)
+      end
+      it 'raises the exception when request fails' do
+        expect do
+          Resque::Plugins::RateLimitedQueue::EvernoteQueue.enqueue(RateLimitedTestQueueOther)
+        end.to raise_error Evernote::EDAM::Error::EDAMSystemException
+      end
+    end
   end
 end
-

data/spec/apis/twitter_queue_spec.rb

@@ -3,7 +3,7 @@ require 'resque/rate_limited_queue'
 
 class RateLimitedTestQueueTw
   def self.perform(succeed)
-    raise(Twitter::Error::TooManyRequests
+    fail(Twitter::Error::TooManyRequests
       .new('', 'x-rate-limit-reset' => (Time.now + 60).to_i)) unless succeed
   end
 end

data/spec/rate_limited_un_pause_spec.rb

@@ -45,5 +45,4 @@ describe Resque::Plugins::RateLimitedQueue::UnPause do
         .to eq(Resque::Plugins::RateLimitedQueue::UnPause)
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -9,7 +9,7 @@ require 'simplecov'
 
 SimpleCov.start
 
-RSpec.configure do |config|
+RSpec.configure do |_config|
   # Use database 15 for testing so we don't accidentally step on your real data.
   RedisClassy.redis = Redis.new(db: 15)
   unless RedisClassy.keys.empty?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-rate_limited_queue
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Greg Dowling
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-06 00:00:00.000000000 Z
+date: 2016-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
@@ -166,6 +166,96 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.1
+- !ruby/object:Gem::Dependency
+  name: gem-release
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.7'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.12'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.1.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.1.1
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: parser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.2.2.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.2.2.5
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.32'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.32'
 description: |-
   A Resque plugin which allows you to create dedicated queues for jobs that use rate limited apis.
   These queues will pause when one of the jobs hits a rate limit, and unpause after a suitable time period.
@@ -179,8 +269,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -231,4 +324,3 @@ test_files:
 - spec/rate_limited_queue_spec.rb
 - spec/rate_limited_un_pause_spec.rb
 - spec/spec_helper.rb
-has_rdoc: