resque-lonely_job 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 77d6fb9e55406f71e625a51f3aed732858c53c30
-  data.tar.gz: 5428f1070c91a492eefd4b13eaf9ba9bb4d404fa
+  metadata.gz: 83362de6a98d68ae3f20fd8e7cd0cb11fff06be7
+  data.tar.gz: 829b8cc700dbfda2772cd3c15f3df8ab1fd7deed
 SHA512:
-  metadata.gz: 5014e12936d857fec3009b2c8b017689a4c3e25765f3122a196d984d3fbc9fa07c1cf4591de26d5801716104b67b6948d08fdc59e52a8fb5aff73e91970b24b0
-  data.tar.gz: 57fbd6bcb2a2189bc382814751f29efd4b14071e059a4e50087a0c5e6e8ad8f7109d640ce0755bfd48566d7df40646430c2fdfc2415f83378d4615e7a2309ef1
+  metadata.gz: b9bfed33191b4010235ca4eec4b141a33b5cdfd81162823b46b044de4bfe13a9b469e85b1904f836d95ddd5b6ee65831297e18ede0281af896d5122402f1d52c
+  data.tar.gz: 9d38553d777a2a8fe93b2f421f2cd21dfcd56dd0ed8c8a04cd1357d983aa2c85a7468347f955db00f761a5cbda9c1241302631b61a5eb8768083c724e7ac2a5d

data/README.md

@@ -12,14 +12,19 @@ Requires a version of MRI Ruby >= 1.9.3.
 Ensures that for a given queue, only one worker is working on a job at any given
 time.
 
-This differs from [resque-queue-lock](https://github.com/mashion/resque-queue-lock), [resque-lock](https://github.com/defunkt/resque-lock) and
+Resque::LonelyJob differs from [resque-queue-lock](https://github.com/mashion/resque-queue-lock), [resque-lock](https://github.com/defunkt/resque-lock) and
 [resque-loner](http://github.com/jayniz/resque-loner) in that the same job may
 be queued multiple times but you're guaranteed that first job queued will run to
 completion before subsequent jobs are run.
 
-However, it is possible that subsequent jobs are re-ordered depending upon
-worker behavior.  Therefore it is recommended that the payload for jobs be
-stored in a separate redis list distinct from the Resque queue (see Example #3).
+However, it is a very *strong* possibility that subsequent jobs are re-ordered due to
+the implementation of
+[reenqueue](https://github.com/wallace/resque-lonely_job/blob/master/lib/resque-lonely_job.rb#L35).
+(See Example #2 for an alternative approach that attempts to preserve job
+ordering but introduces the possibility of starvation.)
+
+Therefore it is recommended that the payload for jobs be stored in a separate
+redis list distinct from the Resque queue (see Example #3).
 
 ## Installation
 
@@ -73,7 +78,8 @@ method.
       end
 
       # Overwrite reenqueue to lpush instead of default rpush.  This attempts to
-      # preserve job ordering but job order is *NOT* guaranteed.
+      # preserve job ordering but job order is *NOT* guaranteed and also not
+      # likely. See the comment on SHA: e9912fb2 for why.
       def self.reenqueue(*args)
         Resque.redis.lpush("queue:#{Resque.queue_from_class(self)}", Resque.encode(class: self, args: args))
       end
@@ -147,8 +153,6 @@ It now doesn't matter whether job 1 and job 2 are re-ordered as whichever goes
 first will perform an atomic pop on the redis list that contains the data needed
 for its job (data x, data y, data z).
 
-*NOTE*: Worker starvation and fairness is still possible as in Example 2.
-
 ## Contributing
 
 1. Fork it

data/lib/resque-lonely_job.rb

@@ -31,10 +31,6 @@ module Resque
         Resque.redis.del(redis_key(*args))
       end
 
-      # Unfortunately, there's not a Resque interface for lpush so we have to
-      # role our own.  This is based on Resque.push but we don't need to
-      # call Resque.watch_queue as the queue should already exist if we're
-      # unable to get the lock.
       def reenqueue(*args)
         Resque.enqueue(self, *args)
       end

data/lib/resque-lonely_job/version.rb

@@ -1,7 +1,7 @@
 module Resque
   module Plugins
     module LonelyJob
-      VERSION = "1.0.1"
+      VERSION = "1.0.2"
     end
   end
 end

data/resque-lonely_job.gemspec

@@ -13,6 +13,7 @@ Gem::Specification.new do |gem|
   gem.name          = "resque-lonely_job"
   gem.require_paths = ["lib"]
   gem.version       = Resque::Plugins::LonelyJob::VERSION
+  gem.license       = "MIT"
 
   gem.add_dependency 'resque', '>= 1.2'
   gem.add_development_dependency 'mock_redis'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-lonely_job
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Jonathan R. Wallace
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-05 00:00:00.000000000 Z
+date: 2014-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
@@ -115,7 +115,8 @@ files:
 - spec/lib/lonely_job_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/wallace/resque-lonely_job
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []