resque-cleaner 0.2.6 → 0.2.7

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.2.7 (2012-01-17)
+
+* Support Travis CI
+* Support failure jobs without payload information (#11).
+
 ## 0.2.6 (2011-08-23)
 
 * Follow the latest resque for date format.

data/README.markdown

@@ -1,4 +1,4 @@
-ResqueCleaner
+ResqueCleaner [ ![Travis-CI](https://secure.travis-ci.org/ono/resque-cleaner.png?branch=master "Travis CI") ](http://travis-ci.org/ono/resque-cleaner "Travis CI for resque-cleaner")
 ==============
 
 [github.com/ono/resque-cleaner](https://github.com/ono/resque-cleaner)
@@ -264,7 +264,7 @@ You could know if the limiter is on with on? method.
 You can change the maximum number of the limiter with maximum attribute.
 
 ```ruby
-    > cleaner.limiter.maxmum = 3000
+    > cleaner.limiter.maximum = 3000
     => 3,000
     > cleaner.limiter.count
     => 3,000

data/lib/resque_cleaner/server.rb

@@ -108,7 +108,11 @@ module ResqueCleaner
           @jobs = cleaner.select
           @stats, @total = {}, {"total" => 0, "1h" => 0, "3h" => 0, "1d" => 0, "3d" => 0, "7d" => 0}
           @jobs.each do |job|
-            klass = job["payload"]["class"]
+            klass = if job["payload"] && job["payload"]["class"]
+              job["payload"]["class"]
+            else
+              "UNKNOWN"
+            end
             failed_at = Time.parse job["failed_at"]
 
             @stats[klass] ||= {"total" => 0, "1h" => 0, "3h" => 0, "1d" => 0, "3d" => 0, "7d" => 0}

data/lib/resque_cleaner.rb

@@ -53,7 +53,7 @@ module Resque
       def stats_by_class(&block)
         jobs, stats = select(&block), {}
         jobs.each do |job|
-          klass = job["payload"]["class"]
+          klass = job["payload"] && job["payload"]["class"] ? job["payload"]["class"] : "UNKNOWN"
           stats[klass] ||= 0
           stats[klass] += 1
         end
@@ -171,7 +171,11 @@ module Resque
 
         # Returns true if the class of the job matches. Otherwise returns false.
         def klass?(klass_or_name)
-          self["payload"]["class"] == klass_or_name.to_s
+          if self["payload"] && self["payload"]["class"]
+            self["payload"]["class"] == klass_or_name.to_s
+          else
+            klass_or_name=="UNKNOWN"
+          end
         end
 
         # Returns true if the exception raised by the failed job matches. Otherwise returns false.
@@ -211,7 +215,7 @@ module Resque
           end
         end
 
-        # Returns jobs. If numbers of jobs is more than maixum, it returns only
+        # Returns jobs. If numbers of jobs is more than maximum, it returns only
         # the maximum.
         def jobs
           if @locked

data/test/resque_cleaner_test.rb

@@ -153,6 +153,12 @@ context "ResqueCleaner" do
     assert_equal 7, ret['BadJobWithSyntaxError']
   end
 
+  test "#stats_by_class works with broken log" do
+    add_empty_payload_failure
+    ret = @cleaner.stats_by_class
+    assert_equal 1, ret['UNKNOWN']
+  end
+
   test "#stats_by_exception returns stats grouped by exception" do
     ret = @cleaner.stats_by_exception
     assert_equal 35, ret['RuntimeError']

data/test/test_helper.rb

@@ -137,3 +137,17 @@ end
 def queue_size(*queues)
   queues.inject(0){|sum,queue| sum + Resque.size(queue).to_i}
 end
+
+def add_empty_payload_failure
+  data = {
+    :failed_at => Time.now.strftime("%Y/%m/%d %H:%M:%S %Z"),
+    :payload   => nil,
+    :exception => "Resque::DirtyExit",
+    :error     => "Resque::DirtyExit",
+    :backtrace => [],
+    :worker    => "worker",
+    :queue     => "queue"
+  }
+  data = Resque.encode(data)
+  Resque.redis.rpush(:failed, data)
+end

metadata

@@ -1,49 +1,38 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: resque-cleaner
-version: !ruby/object:Gem::Version 
-  hash: 27
-  prerelease: false
-  segments: 
-  - 0
-  - 2
-  - 6
-  version: 0.2.6
+version: !ruby/object:Gem::Version
+  version: 0.2.7
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Tatsuya Ono
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-08-23 00:00:00 +01:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-01-17 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: resque
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70281247431200 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 1
-        - 0
-        version: "1.0"
+      - !ruby/object:Gem::Version
+        version: '1.0'
   type: :runtime
-  version_requirements: *id001
-description: "    resque-cleaner maintains the cleanliness of failed jobs on Resque.\n"
+  prerelease: false
+  version_requirements: *70281247431200
+description: ! '    resque-cleaner maintains the cleanliness of failed jobs on Resque.
+
+'
 email: ononoma@gmail.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
 - README.markdown
 - CHANGELOG.md
-files: 
+files:
 - README.markdown
 - CHANGELOG.md
 - Rakefile
@@ -61,39 +50,29 @@ files:
 - test/resque_cleaner_test.rb
 - test/resque_web_test.rb
 - test/test_helper.rb
-has_rdoc: true
 homepage: http://github.com/ono/resque-cleaner
 licenses: []
-
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --charset=UTF-8
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Resque plugin cleaning up failed jobs.
 test_files: []
-