resque-append 0.0.1 → 0.0.2

data/.gitignore

@@ -16,3 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 .rspec
+.rvmrc

data/lib/resque/append/version.rb

@@ -1,5 +1,5 @@
 module Resque
   module Append
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/lib/resque/append.rb

@@ -6,7 +6,7 @@ module Resque
     def self.enable!; @enabled = true; end
     def self.enabled; @enabled; end
     def self.enabled?; !!@enabled; end
-    def self.enabled=(enabled); @enabled = enabled; end
+    def self.enabled=(enabled); @enabled = !!enabled; end
     def self.idle!; @processing = false; end
     def self.processing!; @processing = true; end
     def self.processing=(processing); @processing = !!processing; end
@@ -20,7 +20,7 @@ module Resque
     end
 
     def after_enqueue_append(*args)
-      unless Resque::Append.processing?
+      if Resque::Append.enabled? && !Resque::Append.processing?
         Resque::Append.processing!
         Resque::Append.worker.work(0)
         Resque::Append.idle!

data/spec/resque/append_spec.rb

@@ -13,7 +13,7 @@ end
 class JobA
   extend Resque::Append
 
-  @queue = :job_a
+  @queue = :default
 
   def self.perform
     JobAudit.events << [self, 'started']
@@ -27,7 +27,7 @@ end
 class JobB
   extend Resque::Append
 
-  @queue = :job_b
+  @queue = :default
 
   def self.perform
     JobAudit.events << [self, 'started']
@@ -42,7 +42,7 @@ end
 class JobC
   extend Resque::Append
 
-  @queue = :job_c
+  @queue = :default
 
   def self.perform
     JobAudit.events << [self, 'started']
@@ -52,28 +52,46 @@ end
 
 describe "resque-append" do
   before(:each) do
-    Resque::Append.enable!
     JobAudit.reset!
+    Resque.remove_queue(:default)
   end
 
-  context "when a job enqueues another job" do
-    it "should run the second job after the first has finished" do
-      Resque.enqueue(JobA)
+  context "when enabled" do
+    before(:each) do
+      Resque::Append.enable!
+    end
 
-      JobAudit.events.should == [
-        [JobA, 'started'],
-        [JobA, 'finished'],
-        [JobB, 'started'],
-        [JobB, 'finished'],
-        [JobC, 'started'],
-        [JobC, 'finished'],
-        [JobC, 'started'],
-        [JobC, 'finished'],
-      ]
+    context "when a job enqueues another job" do
+      it "should run the second job after the first has finished" do
+        Resque.enqueue(JobA)
+
+        JobAudit.events.should == [
+          [JobA, 'started'],
+          [JobA, 'finished'],
+          [JobB, 'started'],
+          [JobB, 'finished'],
+          [JobC, 'started'],
+          [JobC, 'finished'],
+          [JobC, 'started'],
+          [JobC, 'finished'],
+        ]
+      end
+    end
+
+    it "should conform to plugin standards" do
+      Resque::Plugin.lint(Resque::Append)
     end
   end
 
-  it "should conform to plugin standards" do
-    Resque::Plugin.lint(Resque::Append)
+  context "when disabled" do
+    before(:each) do
+      Resque::Append.disable!
+    end
+
+    it "should not run anything" do
+      Resque.enqueue(JobA)
+
+      JobAudit.events.should == []
+    end
   end
 end

metadata

@@ -2,14 +2,14 @@
 name: resque-append
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Josh Lane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-15 00:00:00.000000000 Z
+date: 2013-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
@@ -107,3 +107,4 @@ summary: resque-append detects uses a Resque::Worker to process your queue inlin
 test_files:
 - spec/resque/append_spec.rb
 - spec/spec_helper.rb
+has_rdoc: