response 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2df2679f6688ba11f2c48d6ea83f4aa844b74509
-  data.tar.gz: 12a33786958b3267a207a2c48bd24da61297f945
+  metadata.gz: 594421f32ae4ecca4902485826463b93f0b60ee0
+  data.tar.gz: aa5481f15f6443f0ef5cfc88851b1d3a88d4cf82
 SHA512:
-  metadata.gz: d760eb7961469ba60a98339c61286445706ecb0c62f5919b66c9232176eadc11a6a0a88835bed905083c1f90f66a256fc510d2a098def75ac77219f4a763ac67
-  data.tar.gz: 086b4bf3bc5239e7f6639af630258592a44ba871f49c466d68c2d3e9b0be036f82dac5ef84d8737621b41510db27a5f98ef3dab372cb3a997e0a5bf25dbccda5
+  metadata.gz: df0fdb98b71b167c8763391bca7161b51ad25ebd5aec93dd37da2eca5661099695fcf7f0ae949a99da34690a32a55d544242af1e71a1f416359a86c27c44b45e
+  data.tar.gz: f1dd2fd0a82f1224be814e7353d2b1b5b364b5fdaf701637bffebb15017653b73b2602554a2cd1d6d2835d2722008b2111c54927d15b75808500020e263bb052

data/.rubocop.yml

@@ -0,0 +1,7 @@
+AllCops:
+  Include:
+    - 'Gemfile'
+  Exclude:
+    - 'Gemfile.devtools'
+    - 'vendor/**'
+    - 'benchmarks/**'

data/.travis.yml

@@ -4,9 +4,8 @@ script: bundle exec rake ci
 rvm:
   - 1.9.3
   - 2.0.0
-  - rbx-19mode
+  - 2.1.2
+  - rbx-2
   - jruby-19mode
-  - jruby-head
 matrix:
-  allow_failures:
-    rvm: ruby-head
+  allow_failures: rbx-2

data/Gemfile

@@ -2,5 +2,5 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'devtools', :git => 'https://github.com/rom-rb/devtools.git'
-eval File.read('Gemfile.devtools')
+gem 'devtools', git: 'https://github.com/rom-rb/devtools.git'
+eval_gemfile 'Gemfile.devtools'

data/Gemfile.devtools

@@ -1,47 +1,63 @@
 # encoding: utf-8
 
 group :development do
-  gem 'rake',  '~> 10.1.0'
-  gem 'rspec', '~> 2.14.1'
-  gem 'yard',  '~> 0.8.7'
+  gem 'rake',       '~> 10.3.2'
+  gem 'rspec',      '~> 3.0.0'
+  gem 'rspec-its',  '~> 1.0.1'
+  gem 'yard',       '~> 0.8.7.4'
+
+  platform :rbx do
+    gem 'rubysl-singleton', '~> 2.0.0'
+  end
 end
 
 group :yard do
-  gem 'kramdown', '~> 1.2.0'
+  gem 'kramdown', '~> 1.3.3'
 end
 
 group :guard do
-  gem 'guard',         '~> 1.8.1'
-  gem 'guard-bundler', '~> 1.0.0'
-  gem 'guard-rspec',   '~> 3.0.2'
-  gem 'guard-rubocop', '~> 0.2.0'
-  gem 'guard-mutant',  '~> 0.0.1'
+  gem 'guard',         '~> 2.6.1'
+  gem 'guard-bundler', '~> 2.0.0'
+  gem 'guard-rspec',   '~> 4.2.9'
+  gem 'guard-rubocop', '~> 1.1.0'
 
   # file system change event handling
-  gem 'listen',     '~> 1.3.0'
+  gem 'listen',     '~> 2.7.7'
   gem 'rb-fchange', '~> 0.0.6', require: false
-  gem 'rb-fsevent', '~> 0.9.3', require: false
-  gem 'rb-inotify', '~> 0.9.0', require: false
+  gem 'rb-fsevent', '~> 0.9.4', require: false
+  gem 'rb-inotify', '~> 0.9.5', require: false
 
   # notification handling
-  gem 'libnotify',               '~> 0.8.0', require: false
+  gem 'libnotify',               '~> 0.8.3', require: false
   gem 'rb-notifu',               '~> 0.0.4', require: false
   gem 'terminal-notifier-guard', '~> 1.5.3', require: false
 end
 
 group :metrics do
-  gem 'coveralls', '~> 0.6.7'
-  gem 'flay',      '~> 2.4.0'
-  gem 'flog',      '~> 4.1.1'
-  gem 'reek',      '~> 1.3.2'
-  gem 'rubocop',   '~> 0.13.0'
+  gem 'coveralls', '~> 0.7.0'
+  gem 'flay',      '~> 2.5.0'
+  gem 'flog',      '~> 4.2.1'
+  gem 'reek',      '~> 1.3.7'
+  gem 'rubocop',   '~> 0.23.0'
   gem 'simplecov', '~> 0.7.1'
-  gem 'yardstick', '~> 0.9.7', git: 'https://github.com/dkubb/yardstick.git'
+  gem 'yardstick', '~> 0.9.9'
+
+  platforms :mri do
+    gem 'mutant',       '~> 0.6.0'
+    gem 'mutant-rspec', '~> 0.6.0'
+  end
 
   platforms :ruby_19, :ruby_20 do
-    gem 'mutant', git: 'https://github.com/mbj/mutant.git'
     gem 'yard-spellcheck', '~> 0.1.5'
   end
+
+  platform :rbx do
+    gem 'json',               '~> 1.8.1'
+    gem 'racc',               '~> 1.4.11'
+    gem 'rubysl-logger',      '~> 2.0.0'
+    gem 'rubysl-open-uri',    '~> 2.0.0'
+    gem 'rubysl-prettyprint', '~> 2.0.3'
+  end
 end
 
 group :benchmarks do
@@ -50,6 +66,6 @@ end
 
 platform :jruby do
   group :jruby do
-    gem 'jruby-openssl', '~> 0.8.5'
+    gem 'jruby-openssl', '~> 0.9.4'
   end
 end

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2013 Markus Schirp
+Copyright (c) 2014 Markus Schirp
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/circle.yml

@@ -0,0 +1,6 @@
+machine:
+  ruby:
+    version: 2.0.0
+test:
+  override:
+    - bundle exec rake ci

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 16
-total_score: 40
+total_score: 46

data/config/rubocop.yml

@@ -0,0 +1,82 @@
+inherit_from: ../.rubocop.yml
+
+AllCops:
+  Include:
+    - '**/*.rake'
+    - 'Gemfile'
+    - 'Gemfile.triage'
+
+# Avoid parameter lists longer than five parameters.
+ParameterLists:
+  Max: 3
+  CountKeywordArgs: true
+
+MethodLength:
+  CountComments: false
+  Max: 15
+
+# Avoid more than `Max` levels of nesting.
+BlockNesting:
+  Max: 3
+
+# Align with the style guide.
+CollectionMethods:
+  PreferredMethods:
+    collect:  'map'
+    inject:   'reduce'
+    find:     'detect'
+    find_all: 'select'
+
+# Limit line length
+LineLength:
+  Max: 113  # TODO: lower to 79 once the rubocop branch in shared/Gemfile is removed
+
+ClassLength:
+  Max: 204
+
+# Disabled because of indenting with private keyword in class bodies.
+IndentationWidth:
+  Enabled: false
+
+# I like raise more
+SignalException:
+  Enabled: false
+
+# False positive in unparser source
+OneLineConditional:
+  Enabled: false
+
+Documentation:
+  Enabled: false
+
+# Disable documentation checking until a class needs to be documented once
+Documentation:
+  Enabled: false
+
+# Do not favor modifier if/unless usage when you have a single-line body
+IfUnlessModifier:
+  Enabled: false
+
+# Allow case equality operator (in limited use within the specs)
+CaseEquality:
+  Enabled: false
+
+# Constants do not always have to use SCREAMING_SNAKE_CASE
+ConstantName:
+  Enabled: false
+
+# Not all trivial readers/writers can be defined with attr_* methods
+TrivialAccessors:
+  Enabled: false
+
+# Do not prefer do/end over {} for multiline blocks
+Blocks:
+  Enabled: false
+
+# I like to have an empty line before closing the currently opened body
+EmptyLinesAroundBody:
+  Enabled: false
+
+# I like my style more
+AccessModifierIndentation:
+  Enabled: false

data/lib/response.rb

@@ -1,4 +1,4 @@
-#encoding: utf-8
+# encoding: utf-8
 
 require 'time'
 require 'ice_nine'
@@ -120,7 +120,7 @@ class Response
 
   # Return response with merged headers
   #
-  # @param [Hash] headers
+  # @param [Hash] new_headers
   #   the headers to merge
   #
   # @example
@@ -134,8 +134,8 @@ class Response
   # @return [Response]
   #   returns new response with merged header
   #
-  def merge_headers(headers)
-    self.class.new(status, self.headers.merge(headers), body)
+  def merge_headers(new_headers)
+    self.class.new(status, headers.merge(new_headers), body)
   end
 
   # Return rack compatible array after asserting response is valid
@@ -261,9 +261,7 @@ private
   # @api private
   #
   def assert_valid
-    unless valid?
-      raise InvalidError, "Not a valid response: #{inspect}"
-    end
+    raise InvalidError, "Not a valid response: #{inspect}" unless valid?
   end
 end
 

data/lib/response/redirect.rb

@@ -35,7 +35,14 @@ class Response
     # @api public
     #
     def self.build(location)
-      super(self::STATUS, {'Location' => location, 'Content-Type' => TEXT_PLAIN}, "You are beeing redirected to: #{location}")
+      super(
+        self::STATUS,
+        {
+          'Location'      => location,
+          'Content-Type' => TEXT_PLAIN
+        },
+        "You are beeing redirected to: #{location}"
+      )
     end
 
     # Response with default status code of 302

data/lib/response/status.rb

@@ -5,15 +5,15 @@ class Response
 
     private_class_method :new
 
-    OK                    = new(200, 'OK'                   )
-    CREATED               = new(201, 'Created'              )
-    NOT_FOUND             = new(404, 'Not Found'            )
-    NOT_MODIFIED          = new(304, 'Not Modified'         )
-    FOUND                 = new(302, 'Found'                )
-    MOVED_PERMANENTLY     = new(301, 'Moved Permanently'    )
-    BAD_REQUEST           = new(400, 'Bad Request'          )
-    NOT_AUTHORIZED        = new(401, 'Not Authorized'       )
-    FORBIDDEN             = new(403, 'Forbidden'            )
+    OK                    = new(200, 'OK')
+    CREATED               = new(201, 'Created')
+    NOT_FOUND             = new(404, 'Not Found')
+    NOT_MODIFIED          = new(304, 'Not Modified')
+    FOUND                 = new(302, 'Found')
+    MOVED_PERMANENTLY     = new(301, 'Moved Permanently')
+    BAD_REQUEST           = new(400, 'Bad Request')
+    NOT_AUTHORIZED        = new(401, 'Not Authorized')
+    FORBIDDEN             = new(403, 'Forbidden')
     INTERNAL_SERVER_ERROR = new(500, 'Internal Server Error')
 
     # Return status code

data/response.gemspec

@@ -2,20 +2,21 @@
 
 Gem::Specification.new do |gem|
   gem.name        = 'response'
-  gem.version     = '0.0.4'
+  gem.version     = '0.0.5'
   gem.authors     = [ 'Markus Schirp' ]
   gem.email       = [ 'mbj@schir-dso.com' ]
   gem.description = 'Build rack responses with functional style'
   gem.summary     = gem.description
   gem.homepage    = 'https://github.com/mbj/response'
+  gem.license     = 'MIT'
 
   gem.require_paths    = [ 'lib' ]
   gem.files            = `git ls-files`.split("\n")
   gem.test_files       = `git ls-files -- {spec}/*`.split("\n")
   gem.extra_rdoc_files = %w[LICENSE README.md TODO]
 
-  gem.add_dependency('ice_nine',      '~> 0.9.0')
-  gem.add_dependency('adamantium',    '~> 0.1.0')
+  gem.add_dependency('ice_nine',      '~> 0.11.0')
+  gem.add_dependency('adamantium',    '~> 0.2.0')
   gem.add_dependency('equalizer',     '~> 0.0.7')
   gem.add_dependency('abstract_type', '~> 0.0.6')
   gem.add_dependency('concord',       '~> 0.1.4')

data/spec/spec_helper.rb

@@ -3,6 +3,3 @@
 require 'response'
 require 'devtools'
 Devtools.init_spec_helper
-
-RSpec.configure do |config|
-end

data/spec/unit/response/class_methods/build_spec.rb

@@ -17,7 +17,13 @@ describe Response, '.build' do
   context 'with block' do
     let(:yields) { [] }
     let(:value) { double('Value') }
-    let(:block) { lambda { |response| yields << response; value } }
+
+    let(:block) do
+      lambda do |response|
+        yields << response
+        value
+      end
+    end
 
     it 'should return value from block' do
       should be(value)

data/spec/unit/response/content_type_spec.rb

@@ -23,4 +23,3 @@ describe Response, '#content_type' do
     it_should_behave_like 'an idempotent method'
   end
 end
-

data/spec/unit/response/merge_headers_spec.rb

@@ -17,4 +17,3 @@ describe Response, '#merge_headers' do
 
   it_should_behave_like 'a functional command method'
 end
-

data/spec/unit/response/redirect/class_methods/build_spec.rb

@@ -6,7 +6,7 @@ describe Response::Redirect::Found, '#build' do
 
   let(:object) { described_class }
 
-  let(:location) { double('Location', :to_s => 'THE-LOCATION') }
+  let(:location) { double('Location', to_s: 'THE-LOCATION') }
 
   its(:status)  { should be(Response::Status::FOUND) }
   its(:headers) { should eql('Location' => location, 'Content-Type' => 'text/plain; charset=UTF-8') }
@@ -19,10 +19,9 @@ describe Response::Redirect::Permanent, '#build' do
 
   let(:object) { described_class }
 
-  let(:location) { double('Location', :to_s => 'THE-LOCATION') }
+  let(:location) { double('Location', to_s: 'THE-LOCATION') }
 
   its(:status)  { should be(Response::Status::MOVED_PERMANENTLY) }
   its(:headers) { should eql('Location' => location, 'Content-Type' => 'text/plain; charset=UTF-8') }
   its(:body)    { should eql('You are beeing redirected to: THE-LOCATION') }
 end
-

data/spec/unit/response/valid_predicate_spec.rb

@@ -27,6 +27,14 @@ describe Response, '#valid?' do
     it_should_behave_like 'an idempotent method'
   end
 
+  context 'without headers' do
+    let(:object) { described_class.build(Response::Status::OK, Response::Undefined, double('Body')) }
+
+    it { should be(false) }
+
+    it_should_behave_like 'an idempotent method'
+  end
+
   context 'without status and body' do
     let(:object) { described_class.build }
 

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: response
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-15 00:00:00.000000000 Z
+date: 2014-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ice_nine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: adamantium
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: equalizer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.7
 - !ruby/object:Gem::Dependency
   name: abstract_type
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.6
 - !ruby/object:Gem::Dependency
   name: concord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.1.4
 description: Build rack responses with functional style
@@ -90,9 +90,10 @@ extra_rdoc_files:
 - README.md
 - TODO
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Changelog.md
 - Gemfile
 - Gemfile.devtools
@@ -101,12 +102,14 @@ files:
 - README.md
 - Rakefile
 - TODO
+- circle.yml
 - config/devtools.yml
 - config/flay.yml
 - config/flog.yml
 - config/mutant.yml
 - config/reek.yml
 - config/roodi.yml
+- config/rubocop.yml
 - config/yardstick.yml
 - lib/response.rb
 - lib/response/html.rb
@@ -139,7 +142,8 @@ files:
 - spec/unit/response/with_status_spec.rb
 - spec/unit/response/xml/class_methods/build_spec.rb
 homepage: https://github.com/mbj/response
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -147,17 +151,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Build rack responses with functional style