responders 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 729b9991a4c4c71e5def865e458f1941283aa074
-  data.tar.gz: 2f866da6f3f9f07fbc21f87405e66fd8245e12c6
+  metadata.gz: afe9de77cd0ac2f430924b58d84e0cf582e3011c
+  data.tar.gz: e8771d1fb3bd0b9e0036a70b5aaf667528451e2a
 SHA512:
-  metadata.gz: 550177b2c6824672e37d78391dd9e96b8e36c12ffe5a570aa116737b33301287cb53dac1b304d84f022c3c5d30aa42de1d0cfa3fde93caf991e069908ad79682
-  data.tar.gz: 01b5e546b4c55e00d29865e0479e1ce2ced384a31f4108ed79617596473e357d1ca1b8752e015cb4ac242d9385b7998f02433b7d26cbc51ad9909b7c4db7f7b5
+  metadata.gz: cd38360684067e7b60ab94a362f438676b69ab4bb956ffdea5197f1831a4bdfadbc1bfd373395ca235124af57c863094935390362e333995a8614a3ad3fff98b
+  data.tar.gz: ddf8300eb26872a38e79fe55ca308120d9b3c0f0ec3e80aaf44a8337f2ea54d4b515151adccda351b59fb519db182e49e202793be6634c21f831bc0e891009ce

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.0
+
+* Support Rails 4.1.
+* Allow callable objects as the location.
+
 ## 1.0.0
 
 * Improve controller generator to work closer to the Rails 4 one, and make it

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2009-2013 Plataforma Tecnologia. http://blog.plataformatec.com.br
+Copyright 2009-2014 Plataforma Tecnologia. http://blog.plataformatec.com.br
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -60,6 +60,24 @@ You can also have embedded HTML. Just create a `_html` scope.
 
 See also the `namespace_lookup` option to search the full hierarchy of possible keys.
 
+### Location Responder
+
+This responder allows you to use callable objects as the redirect location.
+Useful when you want to use the `respond_with` method with
+a custom route that requires persisted objects, but the validation may fail.
+
+```ruby
+class ThingsController < ApplicationController
+  responders :location, :flash
+  respond_to :html
+
+  def create
+    @thing = Things.create(params[:thing])
+    respond_with @thing, location: -> { thing_path(@thing) }
+  end
+end
+```
+
 ### HttpCacheResponder
 
 Automatically adds Last-Modified headers to API requests. This
@@ -168,4 +186,4 @@ If you discover any bugs or want to drop a line, feel free to create an issue on
 
 http://github.com/plataformatec/responders/issues
 
-MIT License. Copyright 2009-2013 Plataforma Tecnologia. http://blog.plataformatec.com.br
+MIT License. Copyright 2009-2014 Plataforma Tecnologia. http://blog.plataformatec.com.br

data/lib/responders/flash_responder.rb

@@ -89,7 +89,10 @@ module Responders
 
     self.flash_keys = [ :notice, :alert ]
     self.namespace_lookup = false
-    self.helper = Object.new.extend(ActionView::Helpers::TranslationHelper)
+    self.helper = Object.new.extend(
+      ActionView::Helpers::TranslationHelper,
+      ActionView::Helpers::TagHelper
+    )
 
     def initialize(controller, resources, options={})
       super

data/lib/responders/location_responder.rb

@@ -0,0 +1,26 @@
+module Responders
+  # Responder to accept callable objects as the redirect location.
+  # Useful when you want to use the <tt>respond_with</tt> method with
+  # a route that requires persisted objects, but the validation may fail.
+  #
+  #   class ThingsController < ApplicationController
+  #     responders :location, :flash
+  #     respond_to :html
+  #
+  #     def create
+  #       @thing = Things.create(params[:thing])
+  #       respond_with @thing, location: -> { thing_path(@thing) }
+  #     end
+  #   end
+  #
+  module LocationResponder
+    def initialize(controller, resources, options = {})
+      super
+
+      if options[:location].respond_to?(:call)
+        location = options.delete(:location)
+        options[:location] = location.call unless has_errors?
+      end
+    end
+  end
+end

data/lib/responders/version.rb

@@ -1,3 +1,3 @@
 module Responders
-  VERSION = "1.0.0".freeze
+  VERSION = "1.1.0".freeze
 end

data/lib/responders.rb

@@ -4,6 +4,7 @@ module Responders
   autoload :FlashResponder,      'responders/flash_responder'
   autoload :HttpCacheResponder,  'responders/http_cache_responder'
   autoload :CollectionResponder, 'responders/collection_responder'
+  autoload :LocationResponder,   'responders/location_responder'
 
   require 'responders/controller_method'
 

data/test/flash_responder_test.rb

@@ -51,6 +51,12 @@ class AddressesController < ApplicationController
   end
 end
 
+class PolymorphicAddesssController < AddressesController
+  def create
+    respond_with(User.new, Address.new)
+  end
+end
+
 module Admin
   class AddressesController < ::AddressesController
   end
@@ -185,9 +191,10 @@ class FlashResponderTest < ActionController::TestCase
     assert_not_flash_now :failure
   end
 
-  # If we have flash.now, it's always marked as used.
+  # If we have flash.now, it's always marked as used. Rails 4.1 has string keys,
+  # whereas 3.2 and 4.0 has symbols, so we need to test both.
   def assert_flash_now(k)
-    assert flash.used_keys.include?(k.to_sym),
+    assert flash.used_keys.include?(k.to_sym) || flash.used_keys.include?(k.to_s),
      "Expected #{k} to be in flash.now, but it's not."
   end
 
@@ -237,3 +244,17 @@ class NamespacedFlashResponderTest < ActionController::TestCase
     assert_equal nil, flash[:notice]
   end
 end
+
+class PolymorhicFlashResponderTest < ActionController::TestCase
+  tests PolymorphicAddesssController
+
+  def setup
+    Responders::FlashResponder.flash_keys = [ :notice, :alert ]
+    @controller.stubs(:polymorphic_url).returns("/")
+  end
+
+  def test_polymorhic_respond_with
+    post :create
+    assert_equal "Address was successfully created.", flash[:notice]
+  end
+end

data/test/location_responder_test.rb

@@ -0,0 +1,44 @@
+require 'test_helper'
+
+class LocationResponder < ActionController::Responder
+  include Responders::LocationResponder
+end
+
+class LocationsController < ApplicationController
+  self.responder = LocationResponder
+
+  respond_to :html
+  before_filter :set_resource
+
+  def create
+    respond_with @resource, location: -> { 'given_location' }
+  end
+
+  def update
+    respond_with @resource, location: 'given_location'
+  end
+
+  def set_resource
+    @resource = Address.new
+    @resource.errors[:fail] << "FAIL" if params[:fail]
+  end
+end
+
+class LocationResponderTest < ActionController::TestCase
+  tests LocationsController
+
+  def test_redirects_to_block_location_on_success
+    post :create
+    assert_redirected_to 'given_location'
+  end
+
+  def test_renders_page_on_fail
+    post :create, fail: true
+    assert @response.body.include?('new.html.erb')
+  end
+
+  def test_redirects_to_plain_string
+    post :update
+    assert_redirected_to 'given_location'
+  end
+end

data/test/test_helper.rb

@@ -1,7 +1,5 @@
-require 'bundler'
-
-Bundler.setup
-require 'test/unit'
+require 'bundler/setup'
+require 'minitest/autorun'
 require 'mocha/setup'
 
 # Configure Rails
@@ -16,6 +14,7 @@ require 'rails/railtie'
 $:.unshift File.expand_path('../../lib', __FILE__)
 require 'responders'
 
+I18n.enforce_available_locales = true
 I18n.load_path << File.expand_path('../locales/en.yml', __FILE__)
 I18n.reload!
 

data/test/views/locations/new.html.erb

@@ -0,0 +1 @@
+new.html.erb

metadata

@@ -1,33 +1,33 @@
 --- !ruby/object:Gem::Specification
 name: responders
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - José Valim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-21 00:00:00.000000000 Z
+date: 2014-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5'
 description: A set of Rails responders to dry up your application
@@ -39,26 +39,29 @@ files:
 - CHANGELOG.md
 - MIT-LICENSE
 - README.md
+- lib/generators/rails/USAGE
 - lib/generators/rails/responders_controller_generator.rb
 - lib/generators/rails/templates/controller.rb
-- lib/generators/rails/USAGE
 - lib/generators/responders/install_generator.rb
+- lib/responders.rb
 - lib/responders/collection_responder.rb
 - lib/responders/controller_method.rb
 - lib/responders/flash_responder.rb
 - lib/responders/http_cache_responder.rb
 - lib/responders/locales/en.yml
+- lib/responders/location_responder.rb
 - lib/responders/version.rb
-- lib/responders.rb
 - test/collection_responder_test.rb
 - test/controller_method_test.rb
 - test/flash_responder_test.rb
 - test/http_cache_responder_test.rb
 - test/locales/en.yml
+- test/location_responder_test.rb
 - test/test_helper.rb
 - test/views/addresses/create.js.erb
 - test/views/addresses/edit.html.erb
 - test/views/addresses/new.html.erb
+- test/views/locations/new.html.erb
 homepage: http://github.com/plataformatec/responders
 licenses:
 - MIT
@@ -69,17 +72,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: responders
-rubygems_version: 2.0.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A set of Rails responders to dry up your application
@@ -89,7 +92,9 @@ test_files:
 - test/flash_responder_test.rb
 - test/http_cache_responder_test.rb
 - test/locales/en.yml
+- test/location_responder_test.rb
 - test/test_helper.rb
 - test/views/addresses/create.js.erb
 - test/views/addresses/edit.html.erb
 - test/views/addresses/new.html.erb
+- test/views/locations/new.html.erb