responders 1.0.0.rc → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: de01024464852eb08914a193b19d0f915877c0ac
-  data.tar.gz: 6df0e03ed0128f02e604e86b41b633fbc374ddfc
+  metadata.gz: 729b9991a4c4c71e5def865e458f1941283aa074
+  data.tar.gz: 2f866da6f3f9f07fbc21f87405e66fd8245e12c6
 SHA512:
-  metadata.gz: a7eeff649c82736af6c3873899d731395014acca97a914db15069d9d94d64fb84912a7fa8646535118e3816190174a6bf378bdd252abe7d6ee966ec8d1253ca8
-  data.tar.gz: 3b78f0a5d481abf8b667613355e064f586b1918890c8a04c216ef99283433b74f362bbe5ff724480b40a5b9027031c73f66b9dfb759c557bb31c9916f12fa469
+  metadata.gz: 550177b2c6824672e37d78391dd9e96b8e36c12ffe5a570aa116737b33301287cb53dac1b304d84f022c3c5d30aa42de1d0cfa3fde93caf991e069908ad79682
+  data.tar.gz: 01b5e546b4c55e00d29865e0479e1ce2ced384a31f4108ed79617596473e357d1ca1b8752e015cb4ac242d9385b7998f02433b7d26cbc51ad9909b7c4db7f7b5

data/CHANGELOG.md

@@ -1,5 +1,7 @@
-## 1.0.0.rc
+## 1.0.0
 
+* Improve controller generator to work closer to the Rails 4 one, and make it
+  compatible with strong parameters.
 * Drop support for Rails 3.1 and Ruby 1.8, keep support for Rails 3.2
 * Support for Rails 4.0 onward
 * Fix flash message on destroy failure. Fixes #61

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2012 Plataforma Tecnologia. http://blog.plataformatec.com.br
+Copyright 2009-2013 Plataforma Tecnologia. http://blog.plataformatec.com.br
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -4,7 +4,7 @@
 [![Build Status](https://api.travis-ci.org/plataformatec/responders.png?branch=master)](http://travis-ci.org/plataformatec/responders)
 [![Code Climate](https://codeclimate.com/github/plataformatec/responders.png)](https://codeclimate.com/github/plataformatec/responders)
 
-A set of responders modules to dry up your Rails 3+ app.
+A set of responders modules to dry up your Rails 3.2+ app.
 
 ## Responders Types
 
@@ -131,14 +131,14 @@ You can pass in extra interpolation options for the translation by adding an `in
 ```ruby
 class InvitationsController < ApplicationController
   responders :flash, :http_cache
-  
+
   def create
     @invitation = Invitation.create(params[:invitation])
     respond_with @invitation
-  end  
-  
+  end
+
   private
-  
+
   def interpolation_options
     { resource_name: @invitation.email }
   end
@@ -168,4 +168,4 @@ If you discover any bugs or want to drop a line, feel free to create an issue on
 
 http://github.com/plataformatec/responders/issues
 
-MIT License. Copyright 2012 Plataforma Tecnologia. http://blog.plataformatec.com.br
+MIT License. Copyright 2009-2013 Plataforma Tecnologia. http://blog.plataformatec.com.br

data/lib/generators/rails/responders_controller_generator.rb

@@ -14,6 +14,34 @@ module Rails
           Rails.application.config.responders.flash_keys.blank?
         end
       end
+
+      def orm_instance_update(params)
+        if orm_instance.respond_to?(:update)
+          orm_instance.update params
+        else
+          orm_instance.update_attributes params
+        end
+      end
+
+      def controller_before_filter
+        if ActionController::Base.respond_to?(:before_action)
+          "before_action"
+        else
+          "before_filter"
+        end
+      end
+
+      def attributes_params
+        if strong_parameters_defined?
+          "#{file_name}_params"
+        else
+          "params[:#{file_name}]"
+        end
+      end
+
+      def strong_parameters_defined?
+        defined?(ActionController::StrongParameters)
+      end
     end
   end
-end
+end

data/lib/generators/rails/templates/controller.rb

@@ -1,5 +1,7 @@
 <% module_namespacing do -%>
 class <%= controller_class_name %>Controller < ApplicationController
+  <%= controller_before_filter %> :set_<%= file_name %>, only: [:show, :edit, :update, :destroy]
+
 <% unless options[:singleton] -%>
   def index
     @<%= table_name %> = <%= orm_class.all(class_name) %>
@@ -8,7 +10,6 @@ class <%= controller_class_name %>Controller < ApplicationController
 <% end -%>
 
   def show
-    @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
     respond_with(@<%= file_name %>)
   end
 
@@ -18,25 +19,37 @@ class <%= controller_class_name %>Controller < ApplicationController
   end
 
   def edit
-    @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
   end
 
   def create
-    @<%= file_name %> = <%= orm_class.build(class_name, "params[:#{file_name}]") %>
+    @<%= file_name %> = <%= orm_class.build(class_name, attributes_params) %>
     <%= "flash[:notice] = '#{class_name} was successfully created.' if " if flash? %>@<%= orm_instance.save %>
     respond_with(@<%= file_name %>)
   end
 
   def update
-    @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
-    <%= "flash[:notice] = '#{class_name} was successfully updated.' if " if flash? %>@<%= orm_instance.update_attributes("params[:#{file_name}]") %>
+    <%= "flash[:notice] = '#{class_name} was successfully updated.' if " if flash? %>@<%= orm_instance_update(attributes_params) %>
     respond_with(@<%= file_name %>)
   end
 
   def destroy
-    @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
     @<%= orm_instance.destroy %>
     respond_with(@<%= file_name %>)
   end
+
+  private
+    def set_<%= file_name %>
+      @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
+    end
+    <%- if strong_parameters_defined? -%>
+
+    def <%= "#{file_name}_params" %>
+      <%- if attributes_names.empty? -%>
+      params[:<%= file_name %>]
+      <%- else -%>
+      params.require(:<%= file_name %>).permit(<%= attributes_names.map { |name| ":#{name}" }.join(', ') %>)
+      <%- end -%>
+    end
+    <%- end -%>
 end
-<% end -%>
+<% end -%>

data/lib/responders/flash_responder.rb

@@ -12,7 +12,7 @@ module Responders
   #   flash.actions.create.status
   #
   # The statuses by default are :notice (when the object can be created, updated
-  # or destroyed with success) and :alert (when the objecy cannot be created
+  # or destroyed with success) and :alert (when the object cannot be created
   # or updated).
   #
   # On I18n, the resource_name given is available as interpolation option,

data/lib/responders/version.rb

@@ -1,3 +1,3 @@
 module Responders
-  VERSION = "1.0.0.rc".freeze
+  VERSION = "1.0.0".freeze
 end

data/test/test_helper.rb

@@ -1,4 +1,3 @@
-require 'rubygems'
 require 'bundler'
 
 Bundler.setup

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: responders
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc
+  version: 1.0.0
 platform: ruby
 authors:
 - José Valim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-08 00:00:00.000000000 Z
+date: 2013-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -74,12 +74,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: responders
-rubygems_version: 2.0.3
+rubygems_version: 2.0.6
 signing_key: 
 specification_version: 4
 summary: A set of Rails responders to dry up your application