responders 0.9.1 → 0.9.2

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.9.2
+
+* Properly inflect custom responders names
+
 ## 0.9.1
 
 * Fix bug with namespace lookup

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    responders (0.9.1)
+    responders (0.9.2)
       railties (~> 3.1)
 
 GEM

data/README.md

@@ -1,9 +1,6 @@
 # Responders
 
-A set of responders modules to dry up your Rails 3 app. If you are interested in the version
-to be used with Rails 2.3 together with Inherited Resources, please check this branch instead:
-
-http://github.com/plataformatec/responders/tree/v0.4
+A set of responders modules to dry up your Rails 3+ app.
 
 ## Responders Types
 
@@ -56,6 +53,8 @@ You can also have embedded HTML. Just create a `_html` scope.
         notice_html: "<strong>Yay!</strong> You did it!"
 ```
 
+See also the `namespace_lookup` option to search the full hierarchy of possible keys.
+
 ### HttpCacheResponder
 
 Automatically adds Last-Modified headers to API requests. This
@@ -68,7 +67,7 @@ Makes your create and update action redirect to the collection on success.
 
 ## Configuring your own responder
 
-The first step is instal responders gem and configure it in your application:
+The first step is to install the responders gem and configure it in your application:
 
 ```console
 gem install responders

data/lib/generators/rails/templates/controller.rb

@@ -1,51 +1,38 @@
 <% module_namespacing do -%>
 class <%= controller_class_name %>Controller < ApplicationController
 <% unless options[:singleton] -%>
-  # GET /<%= table_name %>
-  # GET /<%= table_name %>.xml
   def index
     @<%= table_name %> = <%= orm_class.all(class_name) %>
     respond_with(@<%= table_name %>)
   end
 <% end -%>
 
-  # GET /<%= table_name %>/1
-  # GET /<%= table_name %>/1.xml
   def show
     @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
     respond_with(@<%= file_name %>)
   end
 
-  # GET /<%= table_name %>/new
-  # GET /<%= table_name %>/new.xml
   def new
     @<%= file_name %> = <%= orm_class.build(class_name) %>
     respond_with(@<%= file_name %>)
   end
 
-  # GET /<%= table_name %>/1/edit
   def edit
     @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
   end
 
-  # POST /<%= table_name %>
-  # POST /<%= table_name %>.xml
   def create
     @<%= file_name %> = <%= orm_class.build(class_name, "params[:#{file_name}]") %>
     <%= "flash[:notice] = '#{class_name} was successfully created.' if " if flash? %>@<%= orm_instance.save %>
     respond_with(@<%= file_name %>)
   end
 
-  # PUT /<%= table_name %>/1
-  # PUT /<%= table_name %>/1.xml
   def update
     @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
     <%= "flash[:notice] = '#{class_name} was successfully updated.' if " if flash? %>@<%= orm_instance.update_attributes("params[:#{file_name}]") %>
     respond_with(@<%= file_name %>)
   end
 
-  # DELETE /<%= table_name %>/1
-  # DELETE /<%= table_name %>/1.xml
   def destroy
     @<%= file_name %> = <%= orm_class.find(class_name, "params[:id]") %>
     @<%= orm_instance.destroy %>

data/lib/responders/controller_method.rb

@@ -2,7 +2,7 @@ module Responders
   module ControllerMethod
     # Adds the given responders to the current controller's responder, allowing you to cherry-pick
     # which responders you want per controller.
-    # 
+    #
     #   class InvitationsController < ApplicationController
     #     responders :flash, :http_cache
     #   end
@@ -22,11 +22,11 @@ module Responders
           when Module
             responder
           when String, Symbol
-            Responders.const_get("#{responder.to_s.classify}Responder")
+            Responders.const_get("#{responder.to_s.camelize}Responder")
           else
             raise "responder has to be a string, a symbol or a module"
           end
-        
+
         klass.send(:include, responder)
         klass
       end
@@ -34,4 +34,4 @@ module Responders
   end
 end
 
-ActionController::Base.extend Responders::ControllerMethod
+ActionController::Base.extend Responders::ControllerMethod

data/lib/responders/flash_responder.rb

@@ -113,11 +113,11 @@ module Responders
 
     def set_flash_message!
       if has_errors?
-        set_flash(:alert, @alert)
         status = Responders::FlashResponder.flash_keys.last
+        set_flash(status, @alert)
       else
-        set_flash(:notice, @notice)
         status = Responders::FlashResponder.flash_keys.first
+        set_flash(status, @notice)
       end
 
       return if controller.flash[status].present?

data/lib/responders/version.rb

@@ -1,3 +1,3 @@
 module Responders
-  VERSION = "0.9.1".freeze
+  VERSION = "0.9.2".freeze
 end

data/test/controller_method_test.rb

@@ -16,7 +16,7 @@ module BarResponder
   end
 end
 
-module BazResponder
+module PeopleResponder
   def to_html
     @resource << "baz"
     super
@@ -25,7 +25,7 @@ end
 
 class PeopleController < ApplicationController
   responders :foo, BarResponder
-  
+
   def index
     @array = []
     respond_with(@array) do |format|
@@ -35,7 +35,7 @@ class PeopleController < ApplicationController
 end
 
 class SpecialPeopleController < PeopleController
-  responders :baz
+  responders :people
 end
 
 class ControllerMethodTest < ActionController::TestCase
@@ -49,7 +49,7 @@ class ControllerMethodTest < ActionController::TestCase
     get :index
     assert assigns(:array).include? "foo"
   end
-  
+
   def test_bar_responder_gets_added
     get :index
     assert assigns(:array).include? "bar"
@@ -58,15 +58,15 @@ end
 
 class ControllerMethodInheritanceTest < ActionController::TestCase
   tests SpecialPeopleController
-  
+
   def setup
-    @controller.stubs(:polymorphic_url).returns("/") 
+    @controller.stubs(:polymorphic_url).returns("/")
   end
-  
+
   def test_responder_is_inherited
     get :index
     assert assigns(:array).include? "foo"
     assert assigns(:array).include? "bar"
     assert assigns(:array).include? "baz"
   end
-end
+end

data/test/flash_responder_test.rb

@@ -131,6 +131,16 @@ class FlashResponderTest < ActionController::TestCase
     assert_not_flash_now :success
   end
 
+  def test_sets_message_based_on_notice_key_with_custom_keys
+    post :another
+    assert_equal "Yes, notice this!", flash[:success]
+  end
+
+  def test_sets_message_based_on_alert_key_with_custom_keys
+    post :another, :fail => true
+    assert_equal "Warning, warning!", flash[:failure]
+  end
+
   def test_sets_message_based_on_notice_key
     Responders::FlashResponder.flash_keys = [ :notice, :alert ]
     post :another
@@ -161,12 +171,12 @@ class FlashResponderTest < ActionController::TestCase
 
   def test_sets_flash_now_on_failure_by_default
     post :another, :fail => true
-    assert_flash_now :alert
+    assert_flash_now :failure
   end
 
   def test_never_set_flash_now
     post :flexible, :fail => true, :responder_options => { :flash_now => false, :alert => "Warning" }
-    assert_not_flash_now :alert
+    assert_not_flash_now :failure
   end
 
   # If we have flash.now, it's always marked as used.

data/test/http_cache_responder_test.rb

@@ -63,15 +63,15 @@ class HttpCacheResponderTest < ActionController::TestCase
   end
 
   def test_does_not_set_cache_unless_get_requests
-    put :single
+    post :single
     assert_nil @response.headers["Last-Modified"]
-    assert_equal 204, @response.status
+    assert_equal 201, @response.status
   end
 
   def test_does_not_use_cache_unless_get_requests
     @request.env["HTTP_IF_MODIFIED_SINCE"] = Time.utc(2009, 6).httpdate
-    put :single
-    assert_equal 204, @response.status
+    post :single
+    assert_equal 201, @response.status
   end
 
   def test_does_not_set_cache_if_http_cache_is_false
@@ -117,4 +117,4 @@ class HttpCacheResponderTest < ActionController::TestCase
     assert_equal "<xml />", @response.body
     assert_equal 200, @response.status
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: responders
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-24 00:00:00.000000000 Z
+date: 2012-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
-  requirement: &70100053167580 !ruby/object:Gem::Requirement
+  requirement: &2166146420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,7 +21,7 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70100053167580
+  version_requirements: *2166146420
 description: A set of Rails 3 responders to dry up your application
 email: contact@plataformatec.com.br
 executables: []
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: responders
-rubygems_version: 1.8.11
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: A set of Rails 3 responders to dry up your application
@@ -91,3 +91,4 @@ test_files:
 - test/views/addresses/create.js.erb
 - test/views/addresses/edit.html.erb
 - test/views/addresses/new.html.erb
+has_rdoc: