responders 0.6.3 → 0.6.4

data/lib/responders/http_cache_responder.rb

@@ -22,7 +22,9 @@ module Responders
   protected
 
     def do_http_cache!
-      timestamp = resource.updated_at.try(:utc) if resource.respond_to?(:updated_at)
+      timestamp = resources.map do |resource|
+        resource.updated_at.try(:utc) if resource.respond_to?(:updated_at)
+      end.compact.max
 
       controller.response.last_modified ||= timestamp if timestamp
 
@@ -31,7 +33,8 @@ module Responders
     end
 
     def do_http_cache?
-      get? && @http_cache != false && ActionController::Base.perform_caching && persisted? && resourceful?
+      get? && @http_cache != false && ActionController::Base.perform_caching &&
+        persisted? && resourceful? && resource.respond_to?(:updated_at)
     end
 
     def persisted?

data/lib/responders/version.rb

@@ -1,3 +1,3 @@
 module Responders
-  VERSION = "0.6.3".freeze
+  VERSION = "0.6.4".freeze
 end

data/test/http_cache_responder_test.rb

@@ -13,12 +13,12 @@ class HttpCacheController < ApplicationController
     respond_with(Address.new(Time.utc(2009)), options)
   end
 
-  def collection
-    respond_with [Address.new(Time.utc(2009)), Address.new(Time.utc(2008))]
+  def nested
+    respond_with Address.new(Time.utc(2009)), Address.new(Time.utc(2008))
   end
 
-  def changing_collection
-    respond_with Address.all
+  def collection
+    respond_with [Address.new(Time.utc(2009)), Address.new(Time.utc(2008))]
   end
 
   def not_persisted
@@ -88,23 +88,16 @@ class HttpCacheResponderTest < ActionController::TestCase
 
   def test_does_not_set_cache_for_collection
     get :collection
-
     assert_nil @response.headers["Last-Modified"]
     assert_not_nil @response.headers["ETag"]
     assert_equal 200, @response.status
   end
 
-  def test_does_not_return_not_modified_if_collection_has_changed
-    #First request. Returns 2 items
-    Address.stubs(:all).returns [Address.new(Time.utc(2009)), Address.new(Time.utc(2008))]
-    get :changing_collection
-
-    #Second request. Returns 1 item, simulating scenario where a address was deleted
-    Address.stubs(:all).returns [Address.new(Time.utc(2009))]
-    @request.env["HTTP_IF_MODIFIED_SINCE"] = @response.headers["Last-Modified"]
-    get :changing_collection
-
-    assert_not_equal 304, @response.status
+  def test_works_for_nested_resources
+    get :nested
+    assert_equal Time.utc(2009).httpdate, @response.headers["Last-Modified"]
+    assert_match /xml/, @response.body
+    assert_equal 200, @response.status
   end
 
   def test_work_with_an_empty_array

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: responders
 version: !ruby/object:Gem::Version 
-  hash: 1
+  hash: 15
   prerelease: 
   segments: 
   - 0
   - 6
-  - 3
-  version: 0.6.3
+  - 4
+  version: 0.6.4
 platform: ruby
 authors: 
 - "Jos\xC3\xA9 Valim"