respond_to_faster 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b424a2e779015c87f2875079a8ec8df721c23ac3
-  data.tar.gz: d9f71e62dad4f85912e22e4a1cb2922e4e99e3d7
+  metadata.gz: 3075ab9a3b42594397ce71908c6a9e324ae8ede6
+  data.tar.gz: 59ca831802f576914a254c1cb4fde907833a82c2
 SHA512:
-  metadata.gz: 1e83e14ed3105dcdbd3c56279873311db4ae60426c64a21f0a7fd8066785a3ed0111fc2b3ace7556f069583568c4895809cfeb507fff4661c900d429beba16e8
-  data.tar.gz: e7996d9d301c561e9e64a40cff73e8382eac3919f018f96913111e03a1cebf27ea44d72f34e9439a1c4df4e4afe1e2daef1e72ff1103d42d930e6e4ea6afed22
+  metadata.gz: cc1068552d098ce3aca0cafde960b3129f8039df0bbaf1df83bbcb22a4cc8640ca258a2cdb3e627b39d4008dd40f300f795092ffdce67903fa889ef775f42544
+  data.tar.gz: 6203af98ff0c87ba8aab51d74b926ae6dbac84a5350c186867352d2a72e81728f2ea1c68fa9394843253c42fdbcfe735b1e717dd72cb1a31d1a3b273d3e643d1

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # RespondToFaster Changelog
 
+## 0.2
+
+### 0.2.0
+* Override `find_by_sql` instead of `init_with` [3d05c0e](https://github.com/shioyama/respond_to_faster/commit/3d05c0e9b50a07612ec1edf83fae7f0bcea724db)
+* Put back `respond_to?` and `method_missing` for now [7f95710](https://github.com/shioyama/respond_to_faster/commit/7f95710e34f7068ac21fb55202dda0c69cbfcbfa)
+* Handle case of no results [90084dd](https://github.com/shioyama/respond_to_faster/commit/90084ddee0ec25e8052628b563f1c352b742b883)
+
 ## 0.1
 
 ### 0.1.0

data/Gemfile

@@ -19,5 +19,4 @@ group :development, :test do
 
   gem 'benchmark-ips'
   gem 'sqlite3'
-  gem 'pry-byebug'
 end

data/Gemfile.lock

@@ -1,12 +1,16 @@
 PATH
-  remote: .
-  specs:
-    respond_to_faster (0.0.1)
-      activerecord (>= 5.0, < 6.0)
-
-GEM
-  remote: https://rubygems.org/
+  remote: ../../rails
   specs:
+    actioncable (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      nio4r (~> 2.0)
+      websocket-driver (~> 0.6.1)
+    actionmailer (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      actionview (= 5.2.0.beta2)
+      activejob (= 5.2.0.beta2)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
     actionpack (5.2.0.beta2)
       actionview (= 5.2.0.beta2)
       activesupport (= 5.2.0.beta2)
@@ -20,17 +24,52 @@ GEM
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      globalid (>= 0.3.6)
     activemodel (5.2.0.beta2)
       activesupport (= 5.2.0.beta2)
     activerecord (5.2.0.beta2)
       activemodel (= 5.2.0.beta2)
       activesupport (= 5.2.0.beta2)
       arel (>= 9.0)
+    activestorage (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      activerecord (= 5.2.0.beta2)
     activesupport (5.2.0.beta2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    rails (5.2.0.beta2)
+      actioncable (= 5.2.0.beta2)
+      actionmailer (= 5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      actionview (= 5.2.0.beta2)
+      activejob (= 5.2.0.beta2)
+      activemodel (= 5.2.0.beta2)
+      activerecord (= 5.2.0.beta2)
+      activestorage (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      bundler (>= 1.3.0)
+      railties (= 5.2.0.beta2)
+      sprockets-rails (>= 2.0.0)
+    railties (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+
+PATH
+  remote: .
+  specs:
+    respond_to_faster (0.1.0)
+      activerecord (>= 5.0, < 6.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
     arel (9.0.0)
     benchmark-ips (2.7.2)
     builder (3.2.3)
@@ -41,16 +80,42 @@ GEM
     database_cleaner (1.6.2)
     diff-lcs (1.3)
     erubi (1.7.0)
+    ffi (1.9.18)
+    formatador (0.2.5)
+    globalid (0.4.1)
+      activesupport (>= 4.2.0)
+    guard (2.14.1)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
     i18n (0.9.1)
       concurrent-ruby (~> 1.0)
+    listen (3.1.5)
+      rb-fsevent (~> 0.9, >= 0.9.4)
+      rb-inotify (~> 0.9, >= 0.9.7)
+      ruby_dep (~> 1.2)
     loofah (2.1.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
+    lumberjack (1.0.12)
+    mail (2.7.0)
+      mini_mime (>= 0.1.1)
     method_source (0.9.0)
+    mini_mime (1.0.0)
     mini_portile2 (2.3.0)
     minitest (5.10.3)
+    nenv (0.3.0)
+    nio4r (2.1.0)
     nokogiri (1.8.1)
       mini_portile2 (~> 2.3.0)
+    notiffany (0.1.1)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
@@ -65,13 +130,10 @@ GEM
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (5.2.0.beta2)
-      actionpack (= 5.2.0.beta2)
-      activesupport (= 5.2.0.beta2)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
     rake (10.5.0)
+    rb-fsevent (0.10.2)
+    rb-inotify (0.9.10)
+      ffi (>= 0.5.0, < 2)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
       rspec-expectations (~> 3.7.0)
@@ -85,22 +147,34 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.0)
+    ruby_dep (1.5.0)
+    shellany (0.0.1)
+    sprockets (3.7.1)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
     sqlite3 (1.3.13)
     thor (0.20.0)
     thread_safe (0.3.6)
     tzinfo (1.2.4)
       thread_safe (~> 0.1)
+    websocket-driver (0.6.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.3)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 5.2.0.beta2, < 5.3)
   benchmark-ips
   bundler (~> 1.16)
   database_cleaner (~> 1.6)
+  guard
   pry-byebug
-  railties (>= 5.2.0.beta2, < 5.3)
+  rails!
   rake (~> 10.0)
   respond_to_faster!
   rspec (~> 3.0)

data/README.md

@@ -17,11 +17,11 @@ queries.
 Just add the gem to your Gemfile:
 
 ```ruby
-gem 'respond_to_faster', '~> 0.1.0'
+gem 'respond_to_faster', '~> 0.2.0'
 ```
 
 That's it! Read on to learn about what RespondToFaster is doing under the hood
-(or checkout the source code, it's only 20 lines long!)
+(or checkout the source code, it's only a dozen lines long!)
 
 ## Background
 
@@ -79,36 +79,25 @@ alternative.
 
 ## What this gem does
 
-So what this gem does is to *remove these overrides*, which have been around
-since the dawn of Ruby on Rails. Not just tweak them, or override them, but
-**remove them**.
+The reality is that in the vast majority of cases, you don't need this
+`method_missing` override. AR has grown over the years to the point where most
+attribute methods are defined, so these fallbacks are not necessary.
 
-Here is the code that does this, just two lines:
-
-```ruby
-ActiveModel::AttributeMethods.send(:remove_method, :respond_to?)
-ActiveModel::AttributeMethods.send(:remove_method, :method_missing)
-```
-
-For the vast majority of cases, *this will have no impact on your ActiveRecord
-objects*. AR has grown over the years to the point where most attribute methods
-are defined, so these fallbacks are not necessary.
-
-The one exception is the example earlier with the custom aliased query. In this
-case, depending on the query, some custom attributes are needed on the objects
-returned, and ActiveRecord still relies on this (very slow) mechanism to make
-the magic work.
+But there is one case where you do: so-called "virtual columns". This is the
+type of query mentioned at the top of this readme. In this case, depending on
+the query, some custom attributes are needed on the objects returned, and
+ActiveRecord still relies on this (very slow) mechanism to make the magic work.
 
 But this is a high price to pay for some simple magic. This gem instead
-*defines the methods* on the singleton class of the objects returned, so that
-you never need to go to `method_missing`. This makes things **much faster**, as
-much as 5-10 times faster.
+*defines the methods* on a module included into the singleton classes of the
+objects returned, so that you never need to go to `method_missing`. This makes
+calling these accessors things significantly faster, as much as 5-10 times
+faster.
 
 ## Caveats
 
 If you don't use any custom querying with aliases like the one above, this gem
-might not do much for you. It should make `respond_to?` a bit faster, but you
-may not even notice that.
+will not do much for you.
 
 However, if you've got some crazy heavy SQL logic somewhere deep in your
 application, and you're finding it takes forever, give this gem a shot and tell

data/lib/respond_to_faster.rb

@@ -2,22 +2,16 @@ require "active_record"
 require "respond_to_faster/version"
 
 module RespondToFaster
-  def init_with(coder)
-    super.tap do
-      unless (uncached_attrs = attribute_names - self.class.attribute_names).empty?
-        klass = self.class
-        mod_name = "RespondToFaster_#{uncached_attrs.hash.abs}".freeze
-        if klass.const_defined?(mod_name)
-          singleton_class.include klass.const_get(mod_name)
-        else
-          uncached_attrs.each &singleton_class.method(:define_attribute_method)
-          klass.const_set(mod_name, singleton_class.send(:generated_attribute_methods))
-        end
+  def find_by_sql(sql, binds = [], preparable: nil, &block)
+    super.tap do |records|
+      record = records.first
+      unless record.nil? || (uncached_attrs = record.attribute_names - attribute_names).empty?
+        uncached_attrs.each &record.singleton_class.method(:define_method_attribute)
+        mod = record.singleton_class.send(:generated_attribute_methods)
+        records[1..-1].each { |record| record.singleton_class.include mod }
       end
     end
   end
 end
 
-ActiveRecord::Base.include RespondToFaster
-ActiveModel::AttributeMethods.send(:remove_method, :respond_to?)
-ActiveModel::AttributeMethods.send(:remove_method, :method_missing)
+ActiveRecord::Base.extend RespondToFaster

data/lib/respond_to_faster/version.rb

@@ -1,3 +1,3 @@
 module RespondToFaster
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: respond_to_faster
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Chris Salzberg
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-19 00:00:00.000000000 Z
+date: 2017-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Faster response times for your ActiveRecord attribute methods.