resource_kit 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee27d303775af18adad2dafcfcaef1d1af3788ba
-  data.tar.gz: 3bc5c1aa4352638e03f2cb775dd34465d822fef7
+  metadata.gz: debf0798083a39aebb213b7a9995a645398a2d1f
+  data.tar.gz: e5f9b6538de589a4f1318d057ce4d011d1b10000
 SHA512:
-  metadata.gz: 0eeb8ed53484b56feeb69fecda64b3083348d38c0b1051dc23b053bb0c162cd8da70da06547a20b8e1131ba02ddeef66b299720444685163f33b040a259537aa
-  data.tar.gz: f9946fc5aefe0becad0403664b5a0099a4da88f8736d79ea6959c045558006eaf8b1c9b535d448a05b8958ef7af57102d5ceff36e4920e40999550f3e6c903f2
+  metadata.gz: a3de72db2d188acab91e170f1443053bb25233b5c2f7589e1367efea6d9e2393b8fb2bb24fc9ea8ec2d15a92bd623d094bc958be814576f29440634aa641bc95
+  data.tar.gz: 397411346322facbb8f2894f83c69f9524c14520b32ba73f8f57d80019f1358c2e3f546d94aca9ea2d049d0dfdc81cc1eaab0257c9f5ab194cbfd1fcf704297c

data/.travis.yml

@@ -3,8 +3,8 @@ cache: bundler
 
 rvm:
   - "2.0.0"
-  - "2.1.5"
-  - "2.2.0"
+  - "2.1.8"
+  - "2.2.4"
 
 script:
   - bundle exec rspec ./spec

data/lib/resource_kit/action_invoker.rb

@@ -32,7 +32,7 @@ module ResourceKit
       raise ArgumentError, "Verb '#{action.verb}' is not allowed" unless ALLOWED_VERBS.include?(action.verb)
 
       @response = connection.send(action.verb, resolver.resolve(options)) do |request|
-        request.body = construct_body if action.body and [:post, :put, :patch].include?(action.verb)
+        request.body = construct_body if action.body and [:post, :put, :patch, :delete].include?(action.verb)
         append_hooks(:before, request)
       end
     end

data/lib/resource_kit/testing/action_handler_matchers.rb

@@ -5,7 +5,7 @@ module ResourceKit
     class ActionHandlerMatchers
       ResponseStub = Class.new(OpenStruct)
 
-      attr_reader :action, :response_stub
+      attr_reader :action, :response_stub, :failure_message
 
       def initialize(action)
         @action = action
@@ -21,10 +21,16 @@ module ResourceKit
       def matches?(subject, &block)
         @handled_block ||= block
         action = subject.resources.find_action(self.action)
-        return false unless action
+        unless action
+          @failure_message = "expected :#{self.action} to be handled by the class."
+          return false
+        end
 
         status_code = response_stub.status || 200
-        return false unless action.handlers[status_code]
+        unless action.handlers[status_code]
+          @failure_message = "expected the #{status_code} status code to be handled by the class."
+          return false
+        end
 
         handled_response = action.handlers[status_code].call(response_stub)
         @handled_block.call(handled_response)

data/lib/resource_kit/testing/have_action_matchers.rb

@@ -5,6 +5,7 @@ module ResourceKit
 
       def initialize(action)
         @action = action
+        @failures = []
       end
 
       def that_handles(*codes)
@@ -39,14 +40,25 @@ module ResourceKit
         @handler_codes ||= []
       end
 
+      def failure_message
+        return "expected class to have action #{action}." if failures.empty?
+
+        failures.map do |validation, expected, got|
+          "expected #{expected} #{validation}, got #{got} instead."
+        end.join('\n')
+      end
+
       private
+      attr_reader :failures
 
       def check_keys(action)
         keys = action.handlers.keys
 
-        if !handler_codes.empty?
+        unless handler_codes.empty?
           handler_codes.each do |handler_code|
-            return false unless keys.include?(handler_code)
+            unless keys.include?(handler_code)
+              return failed(:status_code, handler_code, keys)
+            end
           end
         end
 
@@ -55,14 +67,19 @@ module ResourceKit
 
       def check_path(action)
         return true unless self.path
-        action.path == self.path
+        action.path == self.path or failed(:path, self.path, action.path)
       end
 
       def check_verb(action)
         return true unless self.verb
         checked_verb = self.verb.kind_of?(String) ? self.verb.downcase.to_sym : self.verb
-        action.verb == checked_verb
+        action.verb == checked_verb or failed(:verb, checked_verb, action.verb)
+      end
+
+      def failed(validation, expected, got)
+        failures << [validation, expected, got]
+        false
       end
     end
   end
-end
+end

data/lib/resource_kit/version.rb

@@ -1,3 +1,3 @@
 module ResourceKit
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/spec/lib/resource_kit/testing/action_handler_matchers_spec.rb

@@ -37,4 +37,32 @@ RSpec.describe ResourceKit::Testing::ActionHandlerMatchers do
       expect(change_var).to be(true)
     end
   end
-end
+
+  describe '#failure_message' do
+    context "when the matchers doesnt handle the same status code" do
+      it 'returns "expected the #{status_code} status code to be handled by the class."' do
+        resource_class.resources.action :all, 'GET /all' do
+          handler(200) { |response| JSON.load(response.body) }
+        end
+
+        matcher.with(status: 201, body: '{"Hello": "World"}')
+        matcher.matches?(resource_class) { }
+
+        expect(matcher.failure_message).to eq('expected the 201 status code to be handled by the class.')
+      end
+    end
+
+    context "when the matchers doesnt handle the same status code" do
+      it 'returns "expected the #{status_code} status code to be handled by the class."' do
+        resource_class.resources.action :show, 'GET /all' do
+          handler(200) { |response| JSON.load(response.body) }
+        end
+
+        matcher.with(status: 200, body: '{"Hello": "World"}')
+        matcher.matches?(resource_class) { }
+
+        expect(matcher.failure_message).to eq('expected :all to be handled by the class.')
+      end
+    end
+  end
+end

data/spec/lib/resource_kit/testing/have_action_matchers_spec.rb

@@ -105,4 +105,53 @@ RSpec.describe ResourceKit::Testing::HaveActionMatchers do
       end
     end
   end
-end
+
+  describe '#failure_message' do
+    let(:resource_class) {
+      Class.new(ResourceKit::Resource) { |resource|
+        resource.resources {
+          action :all, 'POST valid_path' do
+            handler(201)
+          end
+        }
+      }
+    }
+
+    context 'when the matcher doesnt find the action' do
+      it 'returns "expected class to have action #{action}".' do
+        matcher = described_class.new(:all)
+        expect(matcher.failure_message).to eq('expected class to have action all.')
+      end
+    end
+
+    context 'when the matcher doesnt find the path' do
+      it 'returns "expected #{expected} path, got #{gotten_value} instead".' do
+        matcher = described_class.new(:all)
+        matcher.at_path('invalid_path')
+        matcher.matches?(resource_class)
+
+        expect(matcher.failure_message).to eq('expected invalid_path path, got valid_path instead.')
+      end
+    end
+
+    context 'when the matcher doesnt find the status code' do
+      it 'returns "expected #{expected} status_code, got #{gotten_value} instead".' do
+        matcher = described_class.new(:all)
+        matcher.that_handles(:ok)
+        matcher.matches?(resource_class)
+
+        expect(matcher.failure_message).to eq('expected 200 status_code, got [201] instead.')
+      end
+    end
+
+    context 'when the matcher doesnt find the verb code' do
+      it 'returns "expected #{expected} verb, got #{gotten_value} instead".' do
+        matcher = described_class.new(:all)
+        matcher.with_verb(:get)
+        matcher.matches?(resource_class)
+
+        expect(matcher.failure_message).to eq('expected get verb, got post instead.')
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: resource_kit
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Robert Ross
@@ -9,118 +9,118 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-17 00:00:00.000000000 Z
+date: 2016-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.3.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.3.6
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.18.0
 - !ruby/object:Gem::Dependency
   name: kartograph
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.8
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.1
 description: ''
@@ -132,9 +132,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -177,17 +177,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Resource Kit provides tools to aid in making API Clients. Such as URL resolving,