research_metadata_batch 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc61ec93f5d5bffe445daa23c318a5ddd2a829b01a799a5d46866e9094f9d594
-  data.tar.gz: b0b0a8d00afb219911466efb16b3ec024a670af3e307a86426ed0c13de84e1fd
+  metadata.gz: 4dd55837b2cfc04e261c6b4ab714a63b0767839dd07daa4b4d0f5b6f16c4f8aa
+  data.tar.gz: f9e675684cd2ba0fd35e7c78f4f72451ed4fd9c26e9394c81e4b636450f506fe
 SHA512:
-  metadata.gz: 412d324f9e61ed97b51f3b8a8c1fbb42d9f93f41dd12d98c4487922816cfee9d9387c7e06cc6a0041fc8ccf7096eb352ded2345e8208d6f70a7f8cf45a6ca063
-  data.tar.gz: 3235149ee8993d812b876165efa311017ea42ef80747c5c6730b0da3bc27c0208884fbabaf02676bd1da253756e25c1690bb00b76a32137e6dce28c321480f08
+  metadata.gz: 188bd5524e03206bd00f84b33a94f56559f0898f95e02e23df2f44ebf4fba5443a07e3e2b2885038d8800d038bf8d0eb1439ac777ef1d4e552fee1ac6fce3e2a
+  data.tar.gz: f1936694098d4543dd6d310e7ed0ba6ff1317b827824a7c3edff650dfa9d2754810eeef03686dc9928d82085282deab935656f0cf61f1dc2117eb70f44497e26

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 0.2.0 - 2018-10-05
+### Changed
+- Record validation
+
 ## 0.1.0 - 2018-09-27
 ### Added
 - Support for resource types: 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    research_metadata_batch (0.1.0)
+    research_metadata_batch (0.2.0)
       puree (~> 2.2)
 
 GEM

data/README.md

@@ -77,7 +77,8 @@ end
 
 ### Running a batch process
 ```ruby
-require_relative '/path/to/your/opened/class'
+require 'research_metadata_batch'
+# require your opened classes
 
 pure_config = {
   url:      ENV['PURE_URL'],

data/lib/research_metadata_batch/base.rb

@@ -66,8 +66,9 @@ module ResearchMetadataBatch
 
         result.each do |i|
 
-          if !record_valid? i
-            @logger.warn "#{log_message_prefix(position, i.uuid)} - record invalid"
+          record_validation_error = validate_record i
+          if record_validation_error
+            @logger.warn "#{log_message_prefix(position, i.uuid)} - VALIDATION_ERROR=#{record_validation_error}"
             position += 1
             next
           end
@@ -78,7 +79,11 @@ module ResearchMetadataBatch
             else
               act_msg = mock_act i
             end
-            @logger.info "#{log_message_prefix(position, i.uuid)} - #{act_success_log_message(i, act_msg)}" if act_msg
+            if act_msg
+              @logger.info "#{log_message_prefix(position, i.uuid)} - #{act_success_log_message(i, act_msg)}"
+            else
+              @logger.info "#{log_message_prefix(position, i.uuid)}"
+            end
           rescue => error
             @logger.error "#{log_message_prefix(position, i.uuid)} - ERROR=#{error}"
           end
@@ -93,7 +98,7 @@ module ResearchMetadataBatch
 
         # handle error response
         if result.empty?
-          @logger.error "#{log_message_prefix(position, nil)} - ERROR=system"
+          @logger.error "PURE_RECORD=#{position} - ERROR=No data"
           position += 1
         end
 
@@ -110,10 +115,6 @@ module ResearchMetadataBatch
       puts model.inspect
     end
 
-    def record_valid?(model)
-      true
-    end
-
     # @return [String]
     def log_message_prefix(pure_record, pure_uuid)
       "PURE_RECORD=#{pure_record} - PURE_UUID=#{pure_uuid}"

data/lib/research_metadata_batch/custom.rb

@@ -38,8 +38,8 @@ module ResearchMetadataBatch
     end
 
     # Check for values in metadata
-    # @return [Boolean]
-    def record_valid?(model)
+    # @return [String, nil]
+    def validate_record(model)
     end
 
   end

data/lib/research_metadata_batch/version.rb

@@ -1,4 +1,4 @@
 module ResearchMetadataBatch
   # Semantic version number
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/research_metadata_batch.gemspec

@@ -9,11 +9,13 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Adrian Albin-Clark"]
   spec.email         = ["a.albin-clark@lancaster.ac.uk"]
   spec.summary       = %q{Batch processing for the Pure Research Information System.}
-  spec.homepage      = 'https://github.com/lulibrary/research_metadata_batch'
   spec.license       = "MIT"
   spec.files         = `git ls-files -z`.split("\x0")
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
   spec.required_ruby_version = '~> 2.1'
   spec.add_dependency 'puree', '~> 2.2'
+  spec.metadata = {
+    "source_code_uri" => "https://github.com/lulibrary/research_metadata_batch"
+  }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: research_metadata_batch
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Adrian Albin-Clark
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-02 00:00:00.000000000 Z
+date: 2018-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puree
@@ -52,10 +52,11 @@ files:
 - lib/research_metadata_batch/research_output.rb
 - lib/research_metadata_batch/version.rb
 - research_metadata_batch.gemspec
-homepage: https://github.com/lulibrary/research_metadata_batch
+homepage: 
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/lulibrary/research_metadata_batch
 post_install_message: 
 rdoc_options: []
 require_paths: