requeue 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16b7f85c1aa1c960e6ff842c6552d8a2f15da648
-  data.tar.gz: 0659835500d1aa2cbe07d6f1cb874d5d00684e4c
+  metadata.gz: a50634423a9b4983dabf590dec78f667453341d6
+  data.tar.gz: a0cc2ce7e7b85502f94aac32e8d961f27f908fe5
 SHA512:
-  metadata.gz: 3eb5540f3996393bb6f2db1fd0590ad99fbd0321e3264e81aaf00dec1d47fd46e5f3011f2ef098e66c9e9b807839aae7d3a391e0d28c9b547fb096c72d9cd111
-  data.tar.gz: 0128cb11ff7c9b6ce4999d73ac7eb4e700d0e550c703ebe533002a750445429c943557482084e37ad3ea096e46777f233cf2b6bff69f39a7a827a0b96c2d0a13
+  metadata.gz: f7fbb67b2d91a065672e78c609b3071dae7a501233e447b4de713de8a9ef2c4481dfeedea9d3179ea362e8474fc992f66535de1b3160cd390ff341977d933d61
+  data.tar.gz: d5b8e45fc3d90c7a904a09ccdaa0b57775301dfb7ce589c07521b132f17cbe0fb0689a97decbf4feea416133207bf5a61cfa769bd2e07fa0535d7683e7827019

data/README.md

@@ -1,5 +1,5 @@
 # Requeue
-
+[![Code Climate](https://codeclimate.com/github/lumoslabs/requeue.png)](https://codeclimate.com/github/lumoslabs/requeue)
 Requeue is a rediciulosly simple queue backed by redis.
 
 ## Installation

data/lib/requeue.rb

@@ -45,7 +45,7 @@ module Requeue
     end
     
     def remove!(value)
-      @redis.lrem(name,0,value)
+      @redis.lrem(name, 0, value)
     end
 
     def owner
@@ -53,7 +53,7 @@ module Requeue
     end
 
     def first
-      @redis.lrange(name,0,1).first 
+      @redis.lrange(name, 0, 1).first 
     end
 
     def owned?
@@ -61,7 +61,7 @@ module Requeue
     end
 
     def steal!(value)
-      @redis.lpush(name,value)
+      @redis.lpush(name, value)
     end
     
     def as_json

data/lib/requeue/version.rb

@@ -1,3 +1,3 @@
 module Requeue
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

data/spec/requeue_spec.rb

@@ -9,27 +9,25 @@ describe Requeue::Queue do
    @queue.clear!
  end
 
- describe '.queue_name' do
+ describe '.name' do
   it { expect(@queue.name).to eq("test:queue") }
  end
 
- describe '.clear_queue!' do
+ describe '.clear!' do
    before { @queue.enqueue!('eric') }
-   before { @queue.clear! }
 
    it 'should empty the queue' do
-     expect(@redis.llen(@queue.name)).to eq(0)
+     expect{ @queue.clear! }.to change { @queue.length }.from(1).to(0)
    end
 
    it 'should see an empty queue' do
-      expect(@queue).not_to be_owned 
+     expect {@queue.clear! }.to change { @queue.owned? }.from(true).to(false)
    end
  end
 
  describe '.enqueue' do
    context 'when no users are enqueued' do
-     after { @queue.clear! }
-     it 'should return 1' do
+     it 'returns the number of users in the queue' do
        expect(@queue.enqueue!('eric')).to eq(1)
      end
    end
@@ -37,7 +35,6 @@ describe Requeue::Queue do
    context 'when some users are enqueued' do
      before { @queue.enqueue!('bob') }
      before { @queue.enqueue!('eric') }
-     after  { @queue.clear! }
      it 'should have a length of 2' do
        expect(@queue.length).to eq(2)
      end
@@ -50,8 +47,7 @@ describe Requeue::Queue do
      it 'should add non-unique values if the queue is set to non-unique' do
        nonunique = Requeue::Queue.new(unique:false)
        nonunique.enqueue!('eric')
-       nonunique.enqueue!('eric')
-       expect(nonunique.length).to eq(2)
+       expect{ nonunique.enqueue!('eric') }.to change { nonunique.length }.from(1).to(2)
      end
    end
  end
@@ -66,22 +62,25 @@ describe Requeue::Queue do
    context 'when some users are enqueued' do
      before { @queue.enqueue!('bob') }
      before { @queue.enqueue!('eric') }
-     after  { @queue.clear! }
+
      it 'should have the current users' do
        expect(@queue.list).to eq(['bob', 'eric'])
      end
    end
  end
+
  describe '.user_queued?' do
    before { @queue.enqueue!('bob') }
    before { @queue.enqueue!('eric') }
-   after  { @queue.clear! }
+
    it 'should show eric as queued' do
      expect(@queue.queued? 'eric').to eq(true)
    end
+
    it 'should show bob as queued' do
      expect(@queue.queued? 'bob').to eq(true)
    end
+  
    it 'should not show an unqueued user as queued' do
      expect(@queue.queued? 'jim').to eq(false)
    end
@@ -90,7 +89,7 @@ describe Requeue::Queue do
  describe '.user_position' do
    before { @queue.enqueue!('bob') }
    before { @queue.enqueue!('eric') }
-   after  { @queue.clear! }
+
    it 'eric should be in position 1 (the second place)' do
      expect(@queue.position 'eric').to eq(1)
      expect(@queue.position 'bob').to eq(0)
@@ -100,14 +99,14 @@ describe Requeue::Queue do
  describe '.dequeue' do
    before { @queue.enqueue!('bob') }
    before { @queue.enqueue!('eric') }
-   before { @queue.dequeue! }
+
    it 'eric should be in position 1 (the second place)' do
-     expect(@queue.position 'eric').to eq(0)
+     expect{ @queue.dequeue! }.to change {@queue.position 'eric'}.from(1).to(0)
    end
  end
 
  describe '.owner' do
-   context 'when no users are enqueued' do
+    context 'when no users are enqueued' do
       it 'should return empty string' do
         expect(@queue.owner).to eq(nil) 
       end
@@ -124,28 +123,26 @@ describe Requeue::Queue do
  describe '.remove!' do
    before { @queue.enqueue!('bob') }
    before { @queue.enqueue!('eric') }
-   before { @queue.remove!('eric') }
    
    it 'should not contain eric anymore' do
-     expect(@queue.queued?('eric')).to eq(false)
-     expect(@queue.list).to eq(['bob'])
+     expect { @queue.remove!('eric') }.to change {@queue.queued?('eric')}
+     expect { @queue.remove!('eric') }.to_not change {@queue.queued?('bob')}
    end
  end
 
  describe '.steal!' do
    before { @queue.enqueue!('bob') }
    before { @queue.enqueue!('eric') }
-   before { @queue.steal!('jim') }
 
    it 'jim should own the queue' do
-     expect(@queue.owner()).to eq('jim')
-     expect(@queue.list).to eq(['jim','bob','eric'])
+     expect { @queue.steal!('jim') }.to change { @queue.owner }.from('bob').to('jim')
    end
 
    it 'the queue should still have everyone else in it' do
-     expect(@queue.length).to eq(3)
+     expect { @queue.steal!('jim') }.to change { @queue.length }.from(2).to(3)
    end
  end
+
  describe '.owned?' do
     context 'when no users are enqueued' do
       it 'should start unowned' do
@@ -154,9 +151,8 @@ describe Requeue::Queue do
     end 
 
     context 'when a user is enqueued' do
-      before { @queue.enqueue!('eric') }
       it 'should be owned' do
-        expect(@queue).to be_owned 
+        expect { @queue.enqueue!('eric') }.to change { @queue.owned? }
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: requeue
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Eric Fode