request_store 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4940fb899c4f08b98633877ca272f29dcdd4ade30456bc87a2529d38da9385e8
-  data.tar.gz: 8be86e88c85f7aeaa3b0ac1eee98da6b26f9c95595319fc010eb800e542eb3cf
+  metadata.gz: a8829219a616f7288e08e65fe5d39d491b1693cb31ca5632355a4a4216167a21
+  data.tar.gz: 1f151729fdffa5b98422b359ab3f145caf8a19943bb075f0b5d2b13999b318b3
 SHA512:
-  metadata.gz: 59f193bbe4aaa3e1a13d5540840b379eadfd654f3f30ac5c9f8dcd780357f0fcc88a2a70d85f3637934a9eff9297cf4d410ceb2829a8ccdc2f6c9cf0631d1579
-  data.tar.gz: 1727397fd735206c9260e5957a78ec9014966619024e7083d29e5ccab5b71178794a2aa1892f0801bbd4afd267a2b7a3b75728a0fc086d0575be2ac477040501
+  metadata.gz: bc75042c21655c31f3392520e49a7bc816a157a5ac60ba783b73436d5293b88379ac08c0dc94ba352b7f4819c6d48cebccd60315a930a1d600c2a65148f14ae8
+  data.tar.gz: d70cb3dbb0868d4311cdb1ff6b710c9bab96c698acdd0d6d4c409ea133dafe119a43bd9d1eee41eea819350e5187aa4338fb4fda3d69613d6a128f9cbd86c7ea

data/.travis.yml

@@ -1,5 +1,4 @@
 language: ruby
-sudo: false
 rvm:
   - 1.9.3
   - 2.0.0
@@ -12,6 +11,7 @@ rvm:
   - jruby-19mode
   - ruby-head
   - jruby-head
+  - truffleruby-head
 matrix:
   allow_failures:
     - rvm: ruby-head

data/README.md

@@ -58,6 +58,16 @@ Yep, everywhere you used `Thread.current` just change it to
 `RequestStore.store`. Now no matter what server you use, you'll get `1` every
 time: the storage is local to that request.
 
+### API
+
+The `fetch` method returns the stored value if it already exists. If no stored value exists, it uses the provided block to add a new stored value.
+
+```ruby
+top_posts = RequestStore.fetch(:top_posts) do
+  # code to obtain the top posts
+end
+```
+
 ### Rails 2 compatibility
 
 The gem includes a Railtie that will configure everything properly for Rails 3+

data/lib/request_store/middleware.rb

@@ -16,12 +16,16 @@ module RequestStore
     def call(env)
       RequestStore.begin!
 
-      response = @app.call(env)
+      status, headers, body = @app.call(env)
 
-      returned = response << Rack::BodyProxy.new(response.pop) do
+      body = Rack::BodyProxy.new(body) do
         RequestStore.end!
         RequestStore.clear!
       end
+      
+      returned = true
+
+      [status, headers, body]
     ensure
       unless returned
         RequestStore.end!

data/lib/request_store/version.rb

@@ -1,3 +1,3 @@
 module RequestStore
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

data/request_store.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |gem|
   gem.email         = ["steve@steveklabnik.com"]
   gem.description   = %q{RequestStore gives you per-request global storage.}
   gem.summary       = %q{RequestStore gives you per-request global storage.}
-  gem.homepage      = "http://github.com/steveklabnik/request_store"
+  gem.homepage      = "https://github.com/steveklabnik/request_store"
   gem.licenses      = ["MIT"]
 
   gem.files         = `git ls-files`.split($/)

data/test/middleware_test.rb

@@ -12,6 +12,7 @@ class MiddlewareTest < Minitest::Test
   def call_middleware(opts = {})
     _, _, proxy = @middleware.call(opts)
     proxy.close
+    proxy
   end
 
   def test_middleware_resets_store
@@ -23,6 +24,17 @@ class MiddlewareTest < Minitest::Test
     assert_equal({}, RequestStore.store)
   end
 
+  def test_middleware_does_not_mutate_response_and_does_not_overflow_stack
+    10000.times do
+      call_middleware
+    end
+
+    resp = call_middleware
+    assert resp.is_a?(::Rack::BodyProxy)
+    assert_equal ["response"], resp.to_a
+    assert_equal ["response"], resp.instance_variable_get(:@body)
+  end
+
   def test_middleware_resets_store_on_error
     e = assert_raises RuntimeError do
       call_middleware({:error => true})
@@ -63,3 +75,27 @@ class MiddlewareTest < Minitest::Test
     refute RequestStore.store[:foo]
   end
 end
+
+class MiddlewareWithConstResponseTest < Minitest::Test
+  def setup
+    @app = RackAppWithConstResponse.new
+    @middleware = RequestStore::Middleware.new(@app)
+  end
+
+  def call_middleware(opts = {})
+    _, _, proxy = @middleware.call(opts)
+    proxy.close
+    proxy
+  end
+
+  def test_middleware_does_not_mutate_response_and_does_not_overflow_stack
+    10000.times do
+      call_middleware
+    end
+
+    resp = call_middleware
+    assert resp.is_a?(::Rack::BodyProxy)
+    assert_equal ["response"], resp.to_a
+    assert_equal ["response"], resp.instance_variable_get(:@body)
+  end
+end

data/test/test_helper.rb

@@ -11,3 +11,19 @@ class RackApp
     [200, {}, ["response"]]
   end
 end
+
+class RackAppWithConstResponse
+  RESPONSE = [200, {}, ["response"]]
+
+  attr_reader :last_value, :store_active
+
+  def call(env)
+    RequestStore.store[:foo] ||= 0
+    RequestStore.store[:foo] += 1
+    @last_value = RequestStore.store[:foo]
+    @store_active = RequestStore.active?
+    raise 'FAIL' if env[:error]
+
+    RESPONSE
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: request_store
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Steve Klabnik
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-20 00:00:00.000000000 Z
+date: 2022-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -73,11 +73,11 @@ files:
 - test/middleware_test.rb
 - test/request_store_test.rb
 - test/test_helper.rb
-homepage: http://github.com/steveklabnik/request_store
+homepage: https://github.com/steveklabnik/request_store
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -92,8 +92,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.15
+signing_key:
 specification_version: 4
 summary: RequestStore gives you per-request global storage.
 test_files: