request_recorder 0.1.1 → 0.1.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    request_recorder (0.1.1)
+    request_recorder (0.1.2)
       activerecord
       rack
 

data/Readme.md

@@ -21,8 +21,8 @@ Usage
 =====
 
  - request a page with `/something?request_recorder=10|my-session-name` -> record next 10 requests from my browser
- - redis 'request_recorder' gets a new entry with all the logging info from rails + activerecord
- - go to redis or build a nice frontend
+ - all the debug-level logging info from rails + activerecord gets stored
+ - get log directly from the store or use the frontend
 
 Frontend
 ========
@@ -31,7 +31,7 @@ Frontend
 
     use RequestRecorder::Middleware, :frontent_auth => lambda{|env| env.warden.user.is_admin? }
 
-Go to /request_recorder/<key> and see the recorded log.
+Go to `/request_recorder/<key>` and see the recorded log.
 
 Author
 ======

data/gemfiles/rails2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/request_recorder
   specs:
-    request_recorder (0.1.0)
+    request_recorder (0.1.1)
       activerecord
       rack
 

data/gemfiles/rails3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/request_recorder
   specs:
-    request_recorder (0.1.0)
+    request_recorder (0.1.1)
       activerecord
       rack
 

data/lib/request_recorder/middleware.rb

@@ -29,13 +29,22 @@ module RequestRecorder
       else
         result = nil
         log = capture_logging do
-          result = @app.call(env)
+          begin
+            result = @app.call(env)
+          rescue Exception => e
+            result = e
+          end
         end
 
         steps_left, id = read_state_from_env(env)
         return [500, {}, "#{MARKER} exceeded maximum value #{MAX_STEPS}"] if steps_left > MAX_STEPS
         id = persist_log(id, log)
-        response_with_data_in_cookie(result, steps_left, id)
+
+        if result.is_a?(Exception)
+          raise result
+        else
+          response_with_data_in_cookie(result, steps_left, id)
+        end
       end
     end
 

data/lib/request_recorder/version.rb

@@ -1,3 +1,3 @@
 module RequestRecorder
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/request_recorder_spec.rb

@@ -1,10 +1,17 @@
 require "spec_helper"
 
 describe RequestRecorder do
+  class FooError < RuntimeError;end
+
   let(:original_logger){ ActiveSupport::BufferedLogger.new("/dev/null").instance_variable_get("@log") }
   let(:activate_logger){ {"QUERY_STRING" => "request_recorder=10"} }
   let(:inner_app){ lambda{|env|
     Car.first
+    if env["raise"]
+      # rails also logs errors
+      ActiveRecord::Base.logger.error(env["raise"])
+      raise FooError.new(env["raise"])
+    end
     [200, {}, "assadasd"]
   } }
   let(:middleware){ RequestRecorder::Middleware.new(inner_app, :store => RequestRecorder::RedisLogger.new(redis)) }
@@ -31,6 +38,15 @@ describe RequestRecorder do
     stored.values.last.should include "SELECT"
   end
 
+  it "records exceptions" do
+    begin
+      middleware.call(activate_logger.merge("raise" => "FooBarError"))
+      fail
+    rescue FooError
+    end
+    stored.values.last.should include "FooBarError"
+  end
+
   it "still writes to the old log to keep us compliant with 'logging all requests'" do
     if ActiveRecord::VERSION::MAJOR == 2
       recorder = StringIO.new

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request_recorder
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-04 00:00:00.000000000 Z
+date: 2012-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -87,7 +87,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2711650895206651119
+      hash: 2574127840943451255
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -96,7 +96,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2711650895206651119
+      hash: 2574127840943451255
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24