request_recorder 0.0.5 → 0.0.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    request_recorder (0.0.5)
+    request_recorder (0.0.6)
       rack
 
 GEM

data/lib/request_recorder/cache_logger.rb

@@ -7,10 +7,23 @@ module RequestRecorder
     end
 
     def write(id, text)
-      id = "#{Time.now.utc.strftime("%Y-%m-%d %H:%M:%S.%L")}_#{Process.pid}" unless id
-      key = "#{KEY}.#{id}"
-      @store.write(key, @store.read(key).to_s + text)
+      if id
+        old = read(id)
+      else
+        id = "#{Time.now.utc.strftime("%Y-%m-%d %H:%M:%S.%L")}_#{Process.pid}"
+      end
+      @store.write(key(id), "#{old}#{text}")
       id
     end
+
+    def read(id)
+      @store.read(key(id))
+    end
+
+    private
+
+    def key(id)
+      "#{KEY}.#{id}"
+    end
   end
 end

data/lib/request_recorder/redis_logger.rb

@@ -2,15 +2,26 @@ module RequestRecorder
   class RedisLogger
     KEY = "request_recorder"
 
-    def initialize(redis)
-      @redis = redis
+    def initialize(store)
+      @store = store
     end
 
     def write(id, text)
-      old = (id ? @redis.hget(KEY, id) : "")
-      id = "#{Time.now.utc.strftime("%Y-%m-%d %H:%M:%S.%L")}_#{Process.pid}" unless id
-      @redis.hset(KEY, id, old.to_s + text)
+      if id
+        old = read(id)
+      else
+        id = "#{Time.now.utc.strftime("%Y-%m-%d %H:%M:%S.%L")}_#{Process.pid}"
+      end
+      @store.hset(KEY, id, "#{old}#{text}")
       id
     end
+
+    def read(id)
+      @store.hget(KEY, id)
+    end
+
+    def keys
+      @store.hkeys(KEY)
+    end
   end
 end

data/lib/request_recorder/version.rb

@@ -1,3 +1,3 @@
 module RequestRecorder
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/request_recorder/cache_logger_spec.rb

@@ -19,26 +19,5 @@ describe RequestRecorder::CacheLogger do
   let(:key){ RequestRecorder::CacheLogger::KEY }
   let(:logger){ RequestRecorder::CacheLogger.new(store) }
 
-  context "#write" do
-    it "returns a unique id" do
-      old = logger.write(nil, "X")
-      sleep 0.01
-      old.should_not == logger.write(nil, "X")
-    end
-
-    it "returns existing ids" do
-      "1111".should == logger.write("1111", "X")
-    end
-
-    it "creates a new entry" do
-      logger.write("1111", "X")
-      store.read("#{key}.1111").should == "X"
-    end
-
-    it "appends to an existing key" do
-      logger.write("1111", "X")
-      logger.write("1111", "X")
-      store.read("#{key}.1111").should == "XX"
-    end
-  end
+  it_behaves_like "a logger"
 end

data/spec/request_recorder/redis_logger_spec.rb

@@ -5,26 +5,16 @@ describe RequestRecorder::RedisLogger do
   let(:key){ RequestRecorder::RedisLogger::KEY }
   let(:logger){ RequestRecorder::RedisLogger.new(store) }
 
-  context "#write" do
-    it "returns a unique id" do
-      old = logger.write(nil, "X")
-      sleep 0.01
-      old.should_not == logger.write(nil, "X")
-    end
-
-    it "returns existing ids" do
-      "1111".should == logger.write("1111", "X")
-    end
+  it_behaves_like "a logger"
 
-    it "creates a new entry" do
-      logger.write("1111", "X")
-      store.hget(key, "1111").should == "X"
+  context "#keys" do
+    it "lists the keys" do
+      logger.write("xxx", "X")
+      logger.keys.should == ["xxx"]
     end
 
-    it "appends to an existing key" do
-      logger.write("1111", "X")
-      logger.write("1111", "X")
-      store.hget(key, "1111").should == "XX"
+    it "returns empty array for empty keys" do
+      logger.keys.should == []
     end
   end
 end

data/spec/spec_helper.rb

@@ -23,3 +23,39 @@ end
 
 class Car < ActiveRecord::Base
 end
+
+shared_examples "a logger" do
+  context "#read" do
+    it "is nil on not found" do
+      logger.read("xxx").should == nil
+    end
+
+    it "finds" do
+      logger.write("xxx", "X")
+      logger.read("xxx").should == "X"
+    end
+  end
+
+  context "#write" do
+    it "returns a unique id" do
+      old = logger.write(nil, "X")
+      sleep 0.01
+      old.should_not == logger.write(nil, "X")
+    end
+
+    it "returns existing ids" do
+      "1111".should == logger.write("1111", "X")
+    end
+
+    it "creates a new entry" do
+      logger.write("1111", "X")
+      logger.read("1111").should == "X"
+    end
+
+    it "appends to an existing key" do
+      logger.write("1111", "X")
+      logger.write("1111", "X")
+      logger.read("1111").should == "XX"
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: request_recorder
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -63,7 +63,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3767464364914123814
+      hash: 3828955395049011862
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -72,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3767464364914123814
+      hash: 3828955395049011862
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24