representable 2.1.7 → 2.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89001d90401ddb1d037e061a528599b5a5766a9a
-  data.tar.gz: e7035bf1405dbb411f4daee3aa8bdfb499d8bb3f
+  metadata.gz: 1474ed4afb6124795809e52491554dd58a2e13aa
+  data.tar.gz: 60f358588f53073142fd022959f6f5994b64a3cc
 SHA512:
-  metadata.gz: 619b6f1015ba1af6a6047864512d39b7f2d0d1b3e237e6124f2967c8fa0dadecef7f0ccd10ce065c1a9b18455fcb09c2ce91e0ab3da5e1417a527f9de0bf4f6b
-  data.tar.gz: 4bcf5e4dae36a937aa1dcba0908ac7dcbd575438c6c8ad0bd92aa011eaa49cb8aa36d4b33f99039713aed14b07b5fa2a564ec06aea6546fa5695f6056c2e77a8
+  metadata.gz: 1c242eac1d5b71200bfe7c67be8bacb9ef5f40431af318e2ce65d4b04a8626ce2f6f1fd2dbdf64844b96588adbd341b1d398ff4e4297190cf74b8db82590d46e
+  data.tar.gz: a812ee6f07deff92f515d41fa185c40a45f00e83c37ff5df71c517aeddc834ec643ab79ff4a2e974fba22014cd60744545b8c2a38590521f19a1f6cef62d4959

data/CHANGES.md

@@ -1,3 +1,19 @@
+# 2.1.8
+
+* API change: features are now included into inline representers in the order they were specified. This used to be the other way round and is, of course, wrong, in case a sub-feature wants to override an existing method introduced by an earlier feature.
+
+  ```ruby
+  class Album < Representable::Decorator
+    include Representable::Hash
+    feature Title
+    feature Date
+
+    property :songs
+      # will include R::Hash, Title, then Date.
+  ```
+
+As this is an edge-casey change, I decided _not_ to minor-version bump.
+
 # 2.1.7
 
 * Adding `Object#to_object`. This is even faster than using `#from_object` for simple transformations.

data/lib/representable/declarative.rb

@@ -76,7 +76,7 @@ module Representable
     def inline_representer_for(base, features, name, options, &block)
       representer = options[:use_decorator] ? Decorator : self
 
-      representer.build_inline(base, features.reverse, name, options, &block)
+      representer.build_inline(base, features, name, options, &block)
     end
 
     def build_config

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "2.1.7"
+  VERSION = "2.1.8"
 end

data/test/features_test.rb

@@ -38,4 +38,33 @@ class FeaturesTest < MiniTest::Spec
 
     it { representer.new(song).to_hash.must_equal({"title"=>"Is It A Lie", "length"=>"2:31", "details"=>{"title"=>"Is It A Lie"}}) }
   end
+end
+
+class FeatureInclusionOrderTest < MiniTest::Spec
+  module Title
+    def title
+      "I was first!"
+    end
+  end
+
+  module OverridingTitle
+    def title
+      "I am number two, " + super
+    end
+  end
+
+  representer!(decorator: true) do
+    feature Title
+    feature OverridingTitle
+
+    property :title, exec_context: :decorator
+
+    property :song do
+      property :title, exec_context: :decorator
+    end
+  end
+
+  it do
+    representer.new(OpenStruct.new(song: Object)).to_hash.must_equal({"title"=>"I am number two, I was first!", "song"=>{"title"=>"I am number two, I was first!"}})
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 2.1.7
+  version: 2.1.8
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -277,52 +277,4 @@ signing_key:
 specification_version: 4
 summary: Renders and parses JSON/XML/YAML documents from and to Ruby objects. Includes
   plain properties, collections, nesting, coercion and more.
-test_files:
-- test/as_test.rb
-- test/benchmarking.rb
-- test/binding_test.rb
-- test/class_test.rb
-- test/coercion_test.rb
-- test/config/inherit_test.rb
-- test/config_test.rb
-- test/decorator_scope_test.rb
-- test/decorator_test.rb
-- test/definition_test.rb
-- test/example.rb
-- test/examples/object.rb
-- test/exec_context_test.rb
-- test/features_test.rb
-- test/filter_test.rb
-- test/for_collection_test.rb
-- test/generic_test.rb
-- test/getter_setter_test.rb
-- test/hash_bindings_test.rb
-- test/hash_test.rb
-- test/if_test.rb
-- test/inherit_test.rb
-- test/inheritable_test.rb
-- test/inline_test.rb
-- test/instance_test.rb
-- test/is_representable_test.rb
-- test/json_test.rb
-- test/lonely_test.rb
-- test/mongoid_test.rb
-- test/nested_test.rb
-- test/object_test.rb
-- test/parse_strategy_test.rb
-- test/pass_options_test.rb
-- test/prepare_test.rb
-- test/reader_writer_test.rb
-- test/realistic_benchmark.rb
-- test/represent_test.rb
-- test/representable_test.rb
-- test/schema_test.rb
-- test/serialize_deserialize_test.rb
-- test/skip_test.rb
-- test/stringify_hash_test.rb
-- test/test_helper.rb
-- test/test_helper_test.rb
-- test/wrap_test.rb
-- test/xml_bindings_test.rb
-- test/xml_test.rb
-- test/yaml_test.rb
+test_files: []