representable 2.1.4 → 2.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 19f89d36352fe54ab21a3759d6c85392950dc564
-  data.tar.gz: c3e581d0e9fb29d0a47f608a8b9b960b48f83fe4
+  metadata.gz: 351c7071b33faa1215070024868b2614288915f4
+  data.tar.gz: 9960a2f4c850764bc48ad3db09c84581fb53049a
 SHA512:
-  metadata.gz: a4cdc220373cb17d0f9934ddc8224925938c274a9489f8da931bcdac9c9782ecde3f1b5204bf7b9b7643b28105b52ba80b786e150d480a8893549e264f3612ce
-  data.tar.gz: 545f594e8786f27d2fca07dcd41241b9b754aacc9298fc02f24f8ff8916381046e24d03bb6907062a323448bc85c4403713e43aa04aaf2bd0f8032cfe519dd74
+  metadata.gz: ae7afd058a763a369761633d3375d865d583e7761988665580c6765980b254dc0443cdc3c3b641a5de3f94476f2cecaa23550dc3bc72c0f10e9b2d215fb6c269
+  data.tar.gz: f44ba7ec3298e2d264be42f491561a00dbb1375a3ff347848abdb4ab5a87d603ad86a1f513721752b48864204be89e2fd5ce512b068d5fc0c183c7c1b0aef106

data/CHANGES.md

@@ -1,3 +1,13 @@
+# 2.1.5
+
+* Using `inherit: true` now works even if the parent property hasn't been defined before. It will simply create a new property. This used to crash with `undefined method `merge!' for nil:NilClass`.
+
+  ```ruby
+  class SongRepresenter < Representable::Decorator
+    property :title, inherit: true # this will create a brand-new :title property.
+  end
+  ```
+
 # 2.1.4
 
 * Allow lonely collection representers without configuration, with inline representer, only. This is for render-only collection representers and very handy.

data/lib/representable/config.rb

@@ -28,9 +28,10 @@ module Representable
       end
 
       def add(name, options, &block)
-        if options[:inherit] # i like that: the :inherit shouldn't be handled outside.
-          return get(name).merge!(options, &block)
+        if options[:inherit] and parent_property = get(name) # i like that: the :inherit shouldn't be handled outside.
+          return parent_property.merge!(options, &block)
         end
+        options.delete(:inherit) # TODO: can we handle the :inherit in one single place?
 
         self[name.to_s] = definition_class.new(name, options, &block)
       end

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "2.1.4"
+  VERSION = "2.1.5"
 end

data/test/inherit_test.rb

@@ -115,6 +115,16 @@ class InheritTest < MiniTest::Spec
     it { inheriting.new(OpenStruct.new(:hit => OpenStruct.new(:title => "Hole In Your Soul", :length => "2:59"))).to_hash.must_equal(
       {"hit"=>{"title"=>"Hole In Your Soul", "length"=>"2:59"}}) }
   end
+
+
+  # :inherit when property doesn't exist, yet.
+  describe ":inherit without inheritable property" do
+    representer! do
+      property :name, :inherit => true
+    end
+
+    it { representer.prepare(Song.new("The Beginning")).to_hash.must_equal({"name"=>"The Beginning"})}
+  end
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: representable
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.1.5
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-21 00:00:00.000000000 Z
+date: 2015-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri