representable 1.1.0 → 1.1.1

data/CHANGES.textile

@@ -1,3 +1,7 @@
+h2. 1.1.1
+
+* When a representer module is extended we no longer set the <code>@representable_attrs</code> ivar directly but use a setter. This makes it work with mongoid and fixes https://github.com/apotonick/roar/issues/10.
+
 h2. 1.1.0
 
 * Added `JSON::Collection` to have plain list representations. And `JSON::Hash` for hashes.

data/lib/representable.rb

@@ -25,6 +25,8 @@ require 'representable/definition'
 #
 #   hero.extend(HeroRepresenter).to_json
 module Representable
+  attr_writer :representable_attrs
+  
   def self.included(base)
     base.class_eval do
       extend ClassMethods
@@ -37,10 +39,7 @@ module Representable
       
       # Copies the representable_attrs to the extended object.
       def self.extended(object)
-        attrs = representable_attrs
-        object.instance_eval do
-          @representable_attrs = attrs
-        end
+        object.representable_attrs=(representable_attrs)
       end
     end
   end

data/lib/representable/version.rb

@@ -1,3 +1,3 @@
 module Representable
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/representable.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "test_xml"
   s.add_development_dependency "minitest", ">= 2.8.1"
   s.add_development_dependency "mocha"
+  s.add_development_dependency "mongoid"
 end

data/test/json_bindings_test.rb

@@ -1,5 +1,4 @@
 require 'test_helper'
-require 'representable/json'
 
 class JSONBindingTest < MiniTest::Spec
   module SongRepresenter

data/test/json_test.rb

@@ -1,5 +1,4 @@
 require 'test_helper'
-require 'representable/json'
 
 module JsonTest
   class APITest < MiniTest::Spec

data/test/mongoid_test.rb

@@ -0,0 +1,31 @@
+require 'test_helper'
+require 'mongoid'
+require 'mongoid/document'
+
+class MongoidTest < MiniTest::Spec
+  describe "Mongoid compatibility" do
+    it "allows #to_json" do
+      class Profile
+        include Mongoid::Document
+        field :name
+      end
+      
+      class Dude
+        include Mongoid::Document
+        embeds_one :profile, :class_name => "MongoidTest::Profile"
+      end
+      
+      module ProfileRepresenter
+       include Representable::JSON
+
+       property :name
+      end
+
+      dude = Dude.new
+      dude.profile = Profile.new
+      dude.profile.name = "Kofi"
+      
+      assert_equal "{\"name\":\"Kofi\"}", dude.profile.extend(ProfileRepresenter).to_json
+    end      
+  end
+end

data/test/representable_test.rb

@@ -56,7 +56,6 @@ class RepresentableTest < MiniTest::Spec
       end
       
       it "allows including the concrete representer module later" do
-        require 'representable/json'
         vd = class VD
           attr_accessor :name, :street_cred
           include Representable::JSON
@@ -199,7 +198,7 @@ class RepresentableTest < MiniTest::Spec
   end
 
   
-  require 'representable/json'  # DISCUSS: i don't like the JSON requirement here, what about some generic test module?
+  # DISCUSS: i don't like the JSON requirement here, what about some generic test module?
   class PopBand
     include Representable::JSON
     property :name
@@ -293,6 +292,6 @@ class RepresentableTest < MiniTest::Spec
     it "allows mapping formats to representers" do
       assert_equal :whatever, @class.representer[:json]
       assert_equal :special, @class.representer["application/order-json"]
-    end
+    end    
   end
 end

data/test/test_helper.rb

@@ -3,6 +3,7 @@ Bundler.setup
 
 gem 'minitest'
 require 'representable'
+require 'representable/json'
 require 'test/unit'
 require 'minitest/spec'
 require 'minitest/autorun'

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 1
-  - 0
-  version: 1.1.0
+  - 1
+  version: 1.1.1
 platform: ruby
 authors: 
 - Nick Sutterer
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-03 00:00:00 +01:00
+date: 2012-02-06 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -97,6 +97,19 @@ dependencies:
         version: "0"
   type: :development
   version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: mongoid
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id007
 description: Maps representation documents from and to Ruby objects. Includes XML and JSON support, plain properties, collections and compositions.
 email: 
 - apotonick@gmail.com
@@ -131,6 +144,7 @@ files:
 - test/definition_test.rb
 - test/json_bindings_test.rb
 - test/json_test.rb
+- test/mongoid_test.rb
 - test/polymorphic_test.rb
 - test/representable_test.rb
 - test/test_helper.rb