repo_parser 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c34e220511f3a91543782ab7559e993bad5092d1
-  data.tar.gz: 17e7bef1af5736910c5ab676dbf2af677029cd87
+  metadata.gz: cdeffd4817a0819085de78226f215116fbf5508f
+  data.tar.gz: f68e267c32a89bb45ccf96c5ff33e671f4aea70b
 SHA512:
-  metadata.gz: 4ead8bf1f8ff620199b910d7e03231596d219c8afbc37a2ccba345e97b33fe04871486e58d5800ab6017b5d212279d6ca91313052a1e2626c15c6ac182007bfe
-  data.tar.gz: 1ffd043b51c7697b2e4f705d6694246ffec436abcb412907e7b046f0de1e4ae7fb396fef140d53488c6ae6f3529c7ab403777dedcbff1f74d7f76c5dcadd46fc
+  metadata.gz: f0bdc0d141b26ccfe5e13a50eae2624e0f2b115d0f005e270222b869679b81becf5338ce26eb9486fa8b5b2362d32dfcb4f7349fec573dc25eef05b7966eea2b
+  data.tar.gz: cbc6ad84326cf79da1480ba907684d463cc24ae47c23fffea1fb9e8297cf6456e62557fc2065a595e9d901738e7de15681487a1a943e8d57dc7c67d06b3a46a2

data/.rubocop.yml

@@ -0,0 +1,3 @@
+# allow class Abc < Struct.new(:def)
+Style/StructInheritance:
+  Enabled: false

data/README.md

@@ -14,7 +14,7 @@ Take response of https://api.github.com/repositories and perform the following a
 
     $ gem install repo_parser
 
-    $ repo-parser
+    $ repo_parser
 
     RepoParser
     ==========

data/Rakefile

@@ -1,7 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
-
+task default: :spec

data/bin/{repo-parser → repo_parser}

@@ -3,4 +3,4 @@
 require 'repo_parser'
 
 result = RepoParser.run
-puts result.to_string
+puts result

data/lib/repo_parser.rb

@@ -6,13 +6,24 @@ require 'httparty'
 # and sorting it.
 module RepoParser
   def self.run
-    repos = Parser.call(Fetcher.call)
-    sorted = Sorter.call(Filterer.call(repos))
-    Result.new(sorted)
+    repos = chain(Fetcher, Parser, Filterer, Sorter)
+    Result.new(repos)
   end
 
+  def self.chain(*processors)
+    # the first is called with no args
+    value = processors.shift.call
+
+    processors.each do |proc|
+      value = proc.call(value)
+    end
+
+    value
+  end
+
+  # Result stores the result of a parsing
   class Result < Struct.new(:repositories)
-    def to_string
+    def to_s
       lines = []
 
       lines << <<-STRING
@@ -20,15 +31,7 @@ module RepoParser
         ==========
       STRING
 
-      repositories.each do |repo|
-        lines << <<-STRING
-        #{repo.name}:
-          name:  #{repo.name}
-          url:   #{repo.url}
-          owner: #{repo.owner}
-        ----------
-        STRING
-      end
+      lines += repositories.map(&:to_s)
 
       lines << <<-STRING
         Total: #{repositories.length}
@@ -58,7 +61,17 @@ module RepoParser
   end
 
   # Repository represents a repository
-  Repository = Struct.new(:name, :url, :owner, :fork)
+  class Repository < Struct.new(:name, :url, :owner, :fork)
+    def to_s
+      <<-STRING
+        #{name}:
+          name:  #{name}
+          url:   #{url}
+          owner: #{owner}
+        ----------
+      STRING
+    end
+  end
 
   # Filterer filters non-matching repositories
   class Filterer

data/lib/repo_parser/version.rb

@@ -1,3 +1,6 @@
+# RepoParser is a coding test
+# involving scraping some github json,
+# and sorting it.
 module RepoParser
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/repo_parser.gemspec

@@ -9,13 +9,12 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Matthew Rudy Jacobs']
   spec.email         = ['matthewrudyjacobs@gmail.com']
   spec.summary       = 'RepoParser is a code example'
-  spec.description   = 'Take the github repositories list, and filter it to ruby libraries.'
   spec.homepage      = 'https://github.com/matthewrudy/repo_parser'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(/^(test|spec|features)\//)
   spec.require_paths = ['lib']
 
   spec.add_dependency 'httparty', '~> 0.13.3'

data/spec/repo_parser_spec.rb

@@ -28,4 +28,12 @@ RSpec.describe RepoParser do
 
     expect(ruby_names).to eq names
   end
+
+  it 'returns only non-forked repositories' do
+    repositories = RepoParser.run.repositories
+
+    forked = repositories.select(&:fork)
+
+    expect(forked).to be_empty
+  end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,7 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'repo_parser'
 
-RSpec.configure do |c|
-  c.disable_monkey_patching!
-end
+RSpec.configure(&:disable_monkey_patching!)
 
 RSpec::Matchers.define :be_present do
   match do |actual|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: repo_parser
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matthew Rudy Jacobs
@@ -66,22 +66,23 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Take the github repositories list, and filter it to ruby libraries.
+description: 
 email:
 - matthewrudyjacobs@gmail.com
 executables:
-- repo-parser
+- repo_parser
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/repo-parser
+- bin/repo_parser
 - lib/repo_parser.rb
 - lib/repo_parser/version.rb
 - repo_parser.gemspec