reply 0.3.0 → 0.5.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 84e5fad805dc4cab2fe9e826bc77cb5791fd59a9
+  data.tar.gz: 60dd5002b7358d651b624dfb7a11ab09fe3373b5
+SHA512:
+  metadata.gz: 4d5381706a43524c06584cf7d1e7072a9b1ac6b75519fca327f2be0fc949a8162cf7b9744e3dcf0e2c3754267f35f0e176dc501f44f1344803bd64e10b7e373a
+  data.tar.gz: 6630adb3454a143d1e22ae4306b76351f3a04dea9db528fa2e4ae6bfdf53de290f35845d81d2732bd75c53a9f0147a5eb35dc7f1f3f9c91f69982aa8804ad793

data/Gemfile

@@ -6,10 +6,11 @@ source "http://rubygems.org"
 # Add dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.
 group :development do
-  gem 'rspec'
-  gem 'guard-rspec'
-  gem "rdoc",          "~> 3.12"
-  gem "bundler",       "~> 1.0"
-  gem "jeweler",       "~> 1.8.7"
   gem 'active_attr',   '~> 0.8'
+  gem 'bundler',       '~> 1.0'
+  gem 'bogus',         '~> 0.1'
+  gem 'guard-rspec',   '~> 3.1'
+  gem 'jeweler',       '~> 2.0'
+  gem 'rdoc',          '~> 3.12'
+  gem 'rspec',         '~> 2.14'
 end

data/Gemfile.lock

@@ -15,8 +15,11 @@ GEM
       tzinfo (~> 0.3.37)
     addressable (2.3.5)
     atomic (1.1.14)
+    bogus (0.1.4)
+      dependor (>= 0.0.4)
     builder (3.1.4)
     coderay (1.0.9)
+    dependor (1.0.1)
     diff-lcs (1.2.4)
     faraday (0.8.8)
       multipart-post (~> 1.2.0)
@@ -43,13 +46,13 @@ GEM
     highline (1.6.19)
     httpauth (0.2.0)
     i18n (0.6.5)
-    jeweler (1.8.7)
+    jeweler (2.0.1)
       builder
-      bundler (~> 1.0)
+      bundler (>= 1.0)
       git (>= 1.2.5)
-      github_api (= 0.10.1)
+      github_api
       highline (>= 1.6.15)
-      nokogiri (= 1.5.10)
+      nokogiri (>= 1.5.10)
       rake
       rdoc
     json (1.8.0)
@@ -105,8 +108,9 @@ PLATFORMS
 
 DEPENDENCIES
   active_attr (~> 0.8)
+  bogus (~> 0.1)
   bundler (~> 1.0)
-  guard-rspec
-  jeweler (~> 1.8.7)
+  guard-rspec (~> 3.1)
+  jeweler (~> 2.0)
   rdoc (~> 3.12)
-  rspec
+  rspec (~> 2.14)

data/Rakefile

@@ -37,6 +37,7 @@ RSpec::Core::RakeTask.new(:spec)
 # end
 
 task :default => :spec
+task :test => :spec
 
 # require 'rdoc/task'
 # Rake::RDocTask.new do |rdoc|

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.5.0

data/lib/reply/reply.rb

@@ -55,10 +55,13 @@ class Reply
   end
   alias :success! :mark_as_success
 
-  def mark_as_error
+  def mark_as_error(msg=nil)
     @simple_status = SIMPLE_STATUS_ERROR
+    add_errors(msg) if msg
+    self
   end
   alias :error! :mark_as_error
+  alias :fail! :mark_as_error
 
   def mark_as_warning
     @simple_status = SIMPLE_STATUS_WARNING

data/readme.md

@@ -1,7 +1,7 @@
 Reply
 ======
 
-A simple class used to encapsulate the reply from a service
+A simple class used to encapsulate the reply from a service / interactor
 
 [![Build Status](https://travis-ci.org/sporto/reply.png)](https://travis-ci.org/sporto/reply)
 
@@ -29,9 +29,15 @@ Usage
   # add error message and mark as error at the same time
   reply.add_error("Something bad happend")
 
-  # add erroor messages and mark as error
+  # add error messages and mark as error
   reply.add_error(["Error 1", "Error 2"])
 
+  # reply.error! also accepts an optional message
+  reply.error!("I don't like you")
+
+  # reply.error returns the reply itself, so you can do one liners like:
+  return reply.error!("Didn't work")
+
   # check if reply was successful
   reply.successful?
   reply.success?
@@ -51,6 +57,25 @@ Usage
   reply.replace_messages_with_errors_for(active_record_object)
 ```
 
+Testing
+--------
+
+  rake spec
+
+or
+
+  guard start
+
+Release
+------
+
+This gem uses jeweler
+https://github.com/technicalpickles/jeweler
+
+  rake version:bump:minor
+  rake release
+
+
 Copyright
 ---------
-Copyright © 2013 Sebastian Porto. See LICENSE.txt for further details.
+Copyright © 2014 Sebastian Porto. See LICENSE.txt for further details.

data/reply.gemspec

@@ -2,14 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: reply 0.5.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "reply"
-  s.version = "0.3.0"
+  s.version = "0.5.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Sebastian Porto"]
-  s.date = "2013-09-25"
+  s.date = "2014-03-05"
   s.description = "An standarized reply object"
   s.email = "s@porto5.com"
   s.extra_rdoc_files = [
@@ -30,41 +32,41 @@ Gem::Specification.new do |s|
     "readme.md",
     "reply.gemspec",
     "spec/lib/reply/reply_spec.rb",
-    "spec/spec_helper.rb",
-    "test/helper.rb",
-    "test/test_reply.rb"
+    "spec/spec_helper.rb"
   ]
   s.homepage = "http://github.com/sporto/reply"
   s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.25"
+  s.rubygems_version = "2.2.1"
   s.summary = "An standarized reply object"
 
   if s.respond_to? :specification_version then
-    s.specification_version = 3
+    s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rspec>, [">= 0"])
-      s.add_development_dependency(%q<guard-rspec>, [">= 0"])
-      s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 1.8.7"])
       s.add_development_dependency(%q<active_attr>, ["~> 0.8"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0"])
+      s.add_development_dependency(%q<bogus>, ["~> 0.1"])
+      s.add_development_dependency(%q<guard-rspec>, ["~> 3.1"])
+      s.add_development_dependency(%q<jeweler>, ["~> 2.0"])
+      s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.14"])
     else
-      s.add_dependency(%q<rspec>, [">= 0"])
-      s.add_dependency(%q<guard-rspec>, [">= 0"])
-      s.add_dependency(%q<rdoc>, ["~> 3.12"])
-      s.add_dependency(%q<bundler>, ["~> 1.0"])
-      s.add_dependency(%q<jeweler>, ["~> 1.8.7"])
       s.add_dependency(%q<active_attr>, ["~> 0.8"])
+      s.add_dependency(%q<bundler>, ["~> 1.0"])
+      s.add_dependency(%q<bogus>, ["~> 0.1"])
+      s.add_dependency(%q<guard-rspec>, ["~> 3.1"])
+      s.add_dependency(%q<jeweler>, ["~> 2.0"])
+      s.add_dependency(%q<rdoc>, ["~> 3.12"])
+      s.add_dependency(%q<rspec>, ["~> 2.14"])
     end
   else
-    s.add_dependency(%q<rspec>, [">= 0"])
-    s.add_dependency(%q<guard-rspec>, [">= 0"])
-    s.add_dependency(%q<rdoc>, ["~> 3.12"])
-    s.add_dependency(%q<bundler>, ["~> 1.0"])
-    s.add_dependency(%q<jeweler>, ["~> 1.8.7"])
     s.add_dependency(%q<active_attr>, ["~> 0.8"])
+    s.add_dependency(%q<bundler>, ["~> 1.0"])
+    s.add_dependency(%q<bogus>, ["~> 0.1"])
+    s.add_dependency(%q<guard-rspec>, ["~> 3.1"])
+    s.add_dependency(%q<jeweler>, ["~> 2.0"])
+    s.add_dependency(%q<rdoc>, ["~> 3.12"])
+    s.add_dependency(%q<rspec>, ["~> 2.14"])
   end
 end
 

data/spec/lib/reply/reply_spec.rb

@@ -113,24 +113,39 @@ describe Reply do
     end
   end
 
-  describe ".success!" do
+  describe "#success!" do
     it "marks the reply as success" do
       reply.success!
       expect(reply).to be_successful
     end
   end
 
-  describe ".mark_as_error" do
+  describe "#mark_as_error" do
     it "marks the reply as error" do
       reply.mark_as_error
       expect(reply).to be_failure
     end
+
+    it "returns the reply" do
+      expect(reply.mark_as_error).to eq(reply)
+    end
+
+    it "accepts an optional message" do
+      err = "XYZ"
+      reply.mark_as_error(err)
+      expect(reply.messages).to include(err)
+    end
   end
 
-  describe ".error!" do
-    it "marks the reply as error" do
-      reply.error!
-      expect(reply).to be_failure
+  describe "#error!" do
+    it 'delegates to mark_as_error' do
+      expect(reply.method(:error!)).to eq(reply.method(:mark_as_error))
+    end
+  end
+
+  describe "#fail!" do
+    it 'delegates to mark_as_error' do
+      expect(reply.method(:fail!)).to eq(reply.method(:mark_as_error))
     end
   end
 

data/spec/spec_helper.rb

@@ -4,6 +4,7 @@
 # loaded once.
 
 require 'active_attr'
+require 'bogus/rspec'
 
 require File.expand_path('../../lib/reply', __FILE__)
 #

metadata

@@ -1,112 +1,113 @@
 --- !ruby/object:Gem::Specification
 name: reply
 version: !ruby/object:Gem::Version
-  version: 0.3.0
-  prerelease: 
+  version: 0.5.0
 platform: ruby
 authors:
 - Sebastian Porto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-25 00:00:00.000000000 Z
+date: 2014-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: active_attr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: bogus
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.7
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.7
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: active_attr
+  name: rdoc
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '3.12'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
 description: An standarized reply object
 email: s@porto5.com
 executables: []
@@ -129,34 +130,28 @@ files:
 - reply.gemspec
 - spec/lib/reply/reply_spec.rb
 - spec/spec_helper.rb
-- test/helper.rb
-- test/test_reply.rb
 homepage: http://github.com/sporto/reply
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1892639974551080489
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.2.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: An standarized reply object
 test_files: []

data/test/helper.rb

@@ -1,18 +0,0 @@
-require 'rubygems'
-require 'bundler'
-begin
-  Bundler.setup(:default, :development)
-rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
-  exit e.status_code
-end
-require 'test/unit'
-require 'shoulda'
-
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'reply'
-
-class Test::Unit::TestCase
-end

data/test/test_reply.rb

@@ -1,7 +0,0 @@
-require 'helper'
-
-class TestReply < Test::Unit::TestCase
-  should "probably rename this file and start testing for real" do
-    flunk "hey buddy, you should probably rename this file and start testing for real"
-  end
-end