replica_pools 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 462aae1dab48a6627d29f3181b50f1c3308dad3ba815a29bb42f99e8a5e8d52f
-  data.tar.gz: 6104dc1df24757864e2be2db306c2dd52781453c80c6c7b268e2302659766a90
+  metadata.gz: b9a32096014e9f2cd137adb7c8fe226173f40d9dea893a319c0dab24cbdf8371
+  data.tar.gz: da62952df8213322963f8b8ce0c5da9ed8efe381c2348801794ec0ef0b6d294a
 SHA512:
-  metadata.gz: d023920b32b935399f3ecf0ee44d74a1050a63c836ce3ea56ce22046b09994aa490df66d0c3ba5d1b578e8fbdf70470158028612f2f1c3fac883c72aeb7713cf
-  data.tar.gz: 8bfe386f6d12b1a706852cc734f3eef33dcf6c686a1726bebf628bee42b0e57030abb9ac58afa67ba579d22e118bf2a49b4e37c182367d536bff8b2990518543
+  metadata.gz: 7f2d2abc5f7badb102c8116213b306d35336f6d54c651a74d6fcaa0e37c53c5282c46fbc643984ffde43f5e54d868051c38590372b8af4329741da1247b68128
+  data.tar.gz: 51c4514ec6e0fa79ea2e6b128fd4d6d3866916d65d89ec743f49621678a5997c0dd3bc0bfe78a25acd72c39d61c5f13523a9f84a9160259966f9408f9c56b109

data/README.md

@@ -194,7 +194,7 @@ First bump the version as appropriate in `lib/replica_pools/version.rb` and then
 
 Author: Dan Drabik, Lance Ivy
 
-Copyright (c) 2012-2019, Kickstarter
+Copyright (c) 2012-2021, Kickstarter
 
 Released under the MIT license
 

data/lib/replica_pools/query_cache.rb

@@ -24,6 +24,8 @@ module ReplicaPools
       # there may be more args for Rails 5.0+, but we only care about arel, name, and binds for caching.
       relation, name, raw_binds = args
 
+      # Rails 6.2 breaks this method as locked? is no longer available
+      # https://github.com/kickstarter/replica_pools/issues/26
       if !query_cache_enabled || locked?(relation)
         return route_to(current, :select_all, *args)
       end
@@ -32,7 +34,7 @@ module ReplicaPools
       if raw_binds.blank? && relation.is_a?(ActiveRecord::Relation)
         arel, binds = relation.arel, relation.bind_values
       else
-        arel, binds = relation, raw_binds
+        arel, binds = relation, Array(raw_binds)
       end
 
       sql = to_sql(arel, binds)

data/lib/replica_pools/version.rb

@@ -1,3 +1,3 @@
 module ReplicaPools
-  VERSION = "2.2.0"
+  VERSION = "2.2.1"
 end

data/spec/query_cache_spec.rb

@@ -1,5 +1,6 @@
 require 'rack'
 require_relative 'spec_helper'
+require_relative 'config/test_model'
 
 describe ReplicaPools::QueryCache do
   before(:each) do
@@ -103,4 +104,16 @@ describe ReplicaPools::QueryCache do
       end
     end
   end
+
+  describe '.pluck regression test' do
+    it 'should work with query caching' do
+      TestModel.connection.enable_query_cache!
+      expect(TestModel.pluck(:id).count).to eql TestModel.all.count
+    end
+
+    it 'should work if query cache is not enabled' do
+      TestModel.connection.disable_query_cache!
+      expect(TestModel.pluck(:id).count).to eql TestModel.all.count
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: replica_pools
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Dan Drabik
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-28 00:00:00.000000000 Z
+date: 2021-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -95,6 +95,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Connection proxy for ActiveRecord for leader / replica setups.
 email: dan@kickstarter.com
 executables: []
@@ -138,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '1.2'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Connection proxy for ActiveRecord for leader / replica setups.