renuo-bin-check 1.0.0.beta1 → 1.0.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49b29562f89e957c52c206a952c8f84b3856915d
-  data.tar.gz: 0d97bdbf04362dce1aac65134a65b42cecbcb30a
+  metadata.gz: 48fab45d683bbc1e9cd8333ff87c35425389711a
+  data.tar.gz: 5384edf0fdd441236be7eb1da70f1556e098f4fd
 SHA512:
-  metadata.gz: d61ab0b4118331bfa28413ec370a9d4f2d9bb5af2cf17bae2f3cef757613a8ff9d153beeb027ab92c5635ac339486c7fde0bbe351bcb9ca86a3d2fe842c48c09
-  data.tar.gz: d6982dd518a622bd5c55a4e2ac73ce95c63553e21395a4fc7c34982e147a1f316343cfbe0bf9c6a0d62f52be1c052fdea4a29a0462a95632808082b217b0ec80
+  metadata.gz: 1f0b98a715b68b7d732e6923a2a2f8575e3f40bf40fdd69916927bf01c4a048fa803e459110ceb795b1fb89a2d9098c4cf3ce0434c0e1d7800f22f53131a724c
+  data.tar.gz: d9b52541149d25add4e55ec50ff6dc01afe9d0e16863354b019803e2309e79526a7626faeb74b2c60d4aeee9d3bda1f0a35a03864ed3906cbb9de45fe404d232

data/.rubocop.yml

@@ -10,9 +10,19 @@ Style/Documentation:
 Style/NonNilCheck:
   IncludeSemanticChanges: true
 
+Style/FileName:
+  Exclude:
+  - 'Gemfile.local.rb'
+  - 'Gemfile.local.example.rb'
+
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Metrics/BlockLength:
+  Enabled: true
+  Exclude:
+    - spec/**/*
+
 AllCops:
   TargetRubyVersion: 2.3
   Include:

data/CHANGELOG.md

@@ -53,3 +53,10 @@ This release introduces a new fancy DSL (yeyy) which is easier to use and brings
 * Defaults are available and can be used
 
 * Possibility to exclude specific checks of a default
+
+## Version 1.0.0.beta2
+
+Fix mistakes in Default Scripts:
+* Rubocop autocorrect fails if any issues are found, even if they can be autocorrected.
+* Rspec wont use the cache, if the Gemfile.lock has changed.
+* Rubocop wont use the cache, if any file from `config/**/*.rb` has changed.

data/README.md

@@ -14,7 +14,7 @@ Add renuo-bin-check to your Gemfile:
 gem 'renuo-bin-check', group: :bin_check
 ```
 
-Create a file at any place you want. Usually it would be called `bin/check though.
+Create a file at any place you want. Usually it would be called `bin/check` though.
 You can now configure your checks like that:
 
 ```rb
@@ -25,7 +25,7 @@ Bundler.require(:bin_check)
 # run bin-check with rails-defaults
 BinCheck.run do
   #add a new check
-  <name-of-check> do
+  <name_of_check> do
     command "<a one line command or a path to a script>"
     files ['<path-to-file-1>', '<path-to-file-2>']
     reversed_exit <true or false>
@@ -45,13 +45,13 @@ It is also possible to have common configurations and to not run the rails-defau
 #run bin without defaults
 BinCheck.run :no_defaults do
   # define common settings for all checks in the block
-  <name of your common configuration> do
+  <name_of_your_common_configuration> do
     reversed_exit <true or false>
     success_message '<output to display if script succeeds>'
     error_message '<output to display if script fails>'
     
     # add check
-    <name-of-check> do
+    <name_of_check> do
         # add specific settings for this check
         command "<a one line command or a path to a script>"
         files ['<path-to-file-1>', '<path-to-file-2>']
@@ -62,20 +62,6 @@ BinCheck.run :no_defaults do
 end
 ```
 
-## Setup
-
-    git clone git@github.com:renuo/renuo-bin-check.git
-    cd renuo-bin-check
-    bin/setup
-
-
-## Run Tests
-
-The following script will run *rspec*, *rubocop*, *reek*, scanner for debugging outputs and a scanner for TODOs
-
-    bin/check
-
-
 ### Options for Configuration
 
 #### command
@@ -178,7 +164,7 @@ The configuration options can be called in any order.
 
 ```rb
 BinCheck do
-  todo-grepper do
+  todo_grepper do
     command "grep --exclude-dir='app/assets/typings/**' -i -r 'TODO'"\
                     "app spec config db Rakefile README.md Gemfile"
     files ['app/**/*', 'spec/**/*', 'config/**/*', 'db/**/*', 'Rakefile', 'README.md', 'Gemfile']
@@ -194,6 +180,20 @@ end
 * scss-lint doesnt work yet with renuo-bin-check
 * reek doesnt work yet with renuo-bin-check
 
+## Setup
+
+    git clone git@github.com:renuo/renuo-bin-check.git
+    cd renuo-bin-check
+    bin/setup
+
+
+## Run Tests
+
+The following script will run *rspec*, *rubocop*, *reek*, scanner for debugging outputs and a scanner for TODOs
+
+    bin/check
+
+
 ## Contribute
 
 If you would like to contribute, you're very welcome to.

data/lib/renuo_bin_check/bin_check.rb

@@ -10,10 +10,8 @@ class BinCheck
     end
   end
 
-  def respond_to_missing?
-    #:nocov:
+  def self.respond_to_missing?(_name, *_params)
     true
-    #:nocov:
   end
 
   def self.run(default = :rails_defaults, &check)

data/lib/renuo_bin_check/default_scripts/default_rails.rb

@@ -108,7 +108,7 @@ module RenuoBinCheck
     def tslint(bin_check)
       bin_check.check do |config|
         config.command 'tslint -c tslint.json app/assets/javascripts/**/*.ts'
-        config.files ['app/assets/javascripts/**/*.ts']
+        config.files ['app/**/*.ts']
       end
     end
 
@@ -128,14 +128,16 @@ module RenuoBinCheck
     def reek(bin_check)
       bin_check.check do |config|
         config.command 'bundle exec reek'
-        config.files ['app/**/*.rb']
+        config.files ['app/**/*.rb', 'spec/**/*.rb', 'config/**/*', 'db/**/*.rb', 'lib/**/*.rb', 'lib/**/*.rake',
+                      'lib/**/*.rake', 'Gemfile*', '.reek']
       end
     end
 
     def rspec(bin_check)
       bin_check.check do |config|
         config.command 'bundle exec rspec'
-        config.files ['app/**/*.rb', 'spec/**/*.rb']
+        config.files ['app/**/*.rb', 'spec/**/*.rb', 'config/**/*', 'db/**/*.rb', 'lib/**/*.rb', 'lib/**/*.rake',
+                      'lib/**/*.rake', 'Gemfile', 'Gemfile.lock', '.rspec']
       end
     end
 

data/lib/renuo_bin_check/default_scripts/default_scripts.rb

@@ -47,6 +47,7 @@ class DefaultScripts
     rspec
     @default_scripts
   end
+
   # rubocop:enable Metrics/MethodLength
 
   def todo
@@ -105,8 +106,8 @@ class DefaultScripts
 
   def rubocop_autocorrect
     @default_scripts << DSLConfig.new('rubocop_autocorrect') do
-      command 'bundle exec rubocop -a -D -c .rubocop.yml'
-      files ['app/**/*.rb', 'spec/**/*.rb']
+      command File.join(File.dirname(__FILE__), 'rubocop-autocorrect.sh')
+      files ['app/**/*.rb', 'spec/**/*.rb', 'config/**/*.rb']
     end
   end
 
@@ -161,7 +162,8 @@ class DefaultScripts
   def rspec
     @default_scripts << DSLConfig.new('rspec') do
       command 'bundle exec rspec'
-      files ['app/**/*.rb', 'spec/**/*.rb']
+      files ['app/**/*.rb', 'spec/**/*.rb', 'config/**/*', 'db/**/*.rb', 'lib/**/*.rb', 'lib/**/*.rake',
+             'lib/**/*.rake', 'Gemfile', 'Gemfile.lock', '.rspec']
     end
   end
 end

data/lib/renuo_bin_check/default_scripts/rubocop-autocorrect.sh

@@ -0,0 +1,11 @@
+#!/bin/zsh
+
+source ~/.zshrc
+
+bundle exec rubocop -D -c .rubocop.yml --fail-fast
+if [ ! $? -eq 0 ]; then
+  echo 'rubocop detected issues!'
+  bundle exec rubocop -a -D -c .rubocop.yml
+  echo 'Tried to auto correct the issues, but must be reviewed manually, commit aborted'
+  exit 1
+fi

data/lib/renuo_bin_check/script_config.rb

@@ -4,6 +4,11 @@ module RenuoBinCheck
     attr_accessor :script_command, :script_files, :script_name, :script_reversed_exit, :script_standard_output,
                   :script_error_output, :appended_standard_output, :appended_error_output
 
+    def initialize
+      @script_command = nil
+      @script_reversed_exit = nil
+    end
+
     def command(command)
       @script_command = command
     end
@@ -53,9 +58,15 @@ module RenuoBinCheck
     end
 
     def script_command
-      raise 'There must be a command set for each script you want to run. Find further instruction on how to use this' \
-' Gem here in the Readme: https://github.com/renuo/renuo-bin-check' unless @script_command
+      raise_script_command_not_set unless @script_command
       @script_command
     end
+
+    private
+
+    def raise_script_command_not_set
+      raise 'There must be a command set for each script you want to run. Find further instruction on how to use' \
+          ' this Gem here in the Readme: https://github.com/renuo/renuo-bin-check'
+    end
   end
 end

data/lib/renuo_bin_check/servant_thread.rb

@@ -8,6 +8,7 @@ module RenuoBinCheck
       @script_config = script_config
       script_files = @script_config.script_files
       @cacher = Cacher.new(@script_config.script_name, script_files) if script_files
+      @result = nil
     end
 
     def run

data/lib/renuo_bin_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module RenuoBinCheck
-  VERSION = '1.0.0.beta1'
+  VERSION = '1.0.0.beta2'
 end

data/spec/renuo/bin-check/default_scripts/default_scripts_spec.rb

@@ -112,12 +112,10 @@ RSpec.describe DefaultScripts do
   end
 
   it '#rubocop_autocorrect' do
-    expect(default_scripts.rubocop_autocorrect.last.configs)
-      .to eq(
-        name: 'rubocop_autocorrect',
-        command: 'bundle exec rubocop -a -D -c .rubocop.yml',
-        files: ['app/**/*.rb', 'spec/**/*.rb']
-      )
+    configs = default_scripts.rubocop_autocorrect.last.configs
+    expect(configs[:name]).to eq('rubocop_autocorrect')
+    expect(configs[:command]).to end_with('lib/renuo_bin_check/default_scripts/rubocop-autocorrect.sh')
+    expect(configs[:files]).to eq(['app/**/*.rb', 'spec/**/*.rb', 'config/**/*.rb'])
   end
 
   it '#slim_lint' do
@@ -185,7 +183,8 @@ RSpec.describe DefaultScripts do
       .to eq(
         name: 'rspec',
         command: 'bundle exec rspec',
-        files: ['app/**/*.rb', 'spec/**/*.rb']
+        files: ['app/**/*.rb', 'spec/**/*.rb', 'config/**/*', 'db/**/*.rb', 'lib/**/*.rb', 'lib/**/*.rake',
+                'lib/**/*.rake', 'Gemfile', 'Gemfile.lock', '.rspec']
       )
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: renuo-bin-check
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta1
+  version: 1.0.0.beta2
 platform: ruby
 authors:
 - Zora Fuchs
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-12 00:00:00.000000000 Z
+date: 2017-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print
@@ -209,6 +209,7 @@ files:
 - lib/renuo_bin_check/cacher.rb
 - lib/renuo_bin_check/default_scripts/default_rails.rb
 - lib/renuo_bin_check/default_scripts/default_scripts.rb
+- lib/renuo_bin_check/default_scripts/rubocop-autocorrect.sh
 - lib/renuo_bin_check/dsl_config.rb
 - lib/renuo_bin_check/initializer.rb
 - lib/renuo_bin_check/master_thread.rb