renuo-bin-check 0.2.1 → 1.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff44c0cca4c757a3b2217a89ace55403cf337e9d
-  data.tar.gz: 7961ea8b231c3066b7424b41e78fef4528308f8f
+  metadata.gz: 49b29562f89e957c52c206a952c8f84b3856915d
+  data.tar.gz: 0d97bdbf04362dce1aac65134a65b42cecbcb30a
 SHA512:
-  metadata.gz: cef222fd0620af85910bca2755a36a47ad6adb8bb0a2c9b93bcf9455cd0c5f100c30db793bb8878e0982312de493c5f9c3065f9cfa5dd5814b789a2594424955
-  data.tar.gz: 67242eb0cddc9323f27ae1652fd9d401d5677eeffd496c7b2e12bc808c2fd83c912784706a7f0729c63987ee7adc509e7e668898d0380d0054a1591d98a0448a
+  metadata.gz: d61ab0b4118331bfa28413ec370a9d4f2d9bb5af2cf17bae2f3cef757613a8ff9d153beeb027ab92c5635ac339486c7fde0bbe351bcb9ca86a3d2fe842c48c09
+  data.tar.gz: d6982dd518a622bd5c55a4e2ac73ce95c63553e21395a4fc7c34982e147a1f316343cfbe0bf9c6a0d62f52be1c052fdea4a29a0462a95632808082b217b0ec80

data/CHANGELOG.md

@@ -39,3 +39,17 @@ This was implemented as many Scripts use the Standard-Output for Outputs even if
 
 * fixed typos
 * refined readme
+
+## Version 1.0.0.beta1
+
+This release introduces a new fancy DSL (yeyy) which is easier to use and brings in much more possibilities
+
+### New Features
+
+* New DSL is implemented (old one still works for now, but the following features only work with the new one.)
+
+* Common Configuration for multiple checks
+
+* Defaults are available and can be used
+
+* Possibility to exclude specific checks of a default

data/README.md

@@ -11,27 +11,55 @@ For faster runtime it makes use of caching and parallel execution.
 Add renuo-bin-check to your Gemfile:
 
 ```rb
-gem 'renuo-bin-check'
+gem 'renuo-bin-check', group: :bin_check
 ```
 
 Create a file at any place you want. Usually it would be called `bin/check though.
-You can now configure your scripts like that:
+You can now configure your checks like that:
 
 ```rb
-require 'renuo-bin-check'
+#require renuo_bin_check in your file
+require 'bundler/setup'
+Bundler.require(:bin_check)
+
+# run bin-check with rails-defaults
+BinCheck.run do
+  #add a new check
+  <name-of-check> do
+    command "<a one line command or a path to a script>"
+    files ['<path-to-file-1>', '<path-to-file-2>']
+    reversed_exit <true or false>
+    success_message '<output to display if script succeeds>'
+    error_message '<output to display if script fails>'
+  end
+  
+  #exclude a default check
+  exclude :<name-of-default-check>
+end
 
-bin_check = RenuoBinCheck::Initializer.new
+```
 
-# add a script, do this for as many scripts as you would like to run
-bin_check.check do |config|
-  config.command "<a one line command or a path to a script>"
-  config.name "<name-of-script>"
-  config.files ['<path-to-file-1>', '<path-to-file-2>']
-  config.reversed_exit <true or false>
-end
+It is also possible to have common configurations and to not run the rails-defaults:
 
-#run all scripts configured above
-bin_check.run
+```rb
+#run bin without defaults
+BinCheck.run :no_defaults do
+  # define common settings for all checks in the block
+  <name of your common configuration> do
+    reversed_exit <true or false>
+    success_message '<output to display if script succeeds>'
+    error_message '<output to display if script fails>'
+    
+    # add check
+    <name-of-check> do
+        # add specific settings for this check
+        command "<a one line command or a path to a script>"
+        files ['<path-to-file-1>', '<path-to-file-2>']
+        # override common settings
+        reversed_exit <true or false>
+      end
+  end
+end
 ```
 
 ## Setup
@@ -55,16 +83,6 @@ The following script will run *rspec*, *rubocop*, *reek*, scanner for debugging
 This option is required. It is either a one-liner such as `ls -al` or a path to a script, that will be runned.
 If command is not configured, the program will raise a RuntimeError.
 
-#### name
-
-This option is optional. It makes it possible to configure the name of the script. 
-It will be used as folder name in the cache.
-
-If it is not set, the hashed command will be used as folder name in the cache.
-
-Attention: If you set the same name twice, it won't raise an error, 
-but it can cause unexpected behaviour, hence it is not recommanded to do so.
-
 #### files
 
 This option is optional. If configured the script output will be cached. You need to list all files in array form, 
@@ -99,23 +117,83 @@ If set to truthy, the output of the configured script will be reversed. Which me
 An example where this option is used, is the command that searches for TODOs. 
 The script should fail though if something is found and not if nothing is found.
 
+### Defaults
+
+For using renuo-bin-check for checking rails applications we have defaults the following defaults:
+
+Usage of defaults:
+
+```
+# use defaults, or don't use any by using :no-defaults
+BinCheck.run :<name-of-default> {}
+```
+
+Excluding specific checks from defaults example:
+
+```
+BinCheck.run :rails_coffee_script_defaults do
+  exclude :todo
+  exclude :reek
+end
+```
+
+#### rails_defaults (will be used if no default is given)
+
+It includes following checks:
+* todo (searches for todos in the code)
+* console_log (searches for console_log in the code)
+* puts_with_brackets  (searches for puts( in the code)
+* puts_without_brackets (searches for puts in the code)
+* pp_and_p  (searches for p and pp in the code)
+* p_with_brackets (searches for p( in the code)
+* rubocop_autocorrect (runs rubocop with autocorrection)
+* slim_lint (runs slim_lint)
+* scss_lint (runs scss_lint ATTENTION: THIS DOESN'T WORK YET)
+* tslint  (runs tslint)
+* brakeman (runs brakeman)
+* reek (runs reek ATTENTION: THIS DOESN'T WORK YET)
+* rspec (runs rspec)
+
+#### rails_coffee_script_defaults
+
+It includes following checks:
+* todo (searches for todos in the code)
+* console_log (searches for console_log in the code)
+* puts_with_brackets  (searches for puts( in the code)
+* puts_without_brackets (searches for puts in the code)
+* pp_and_p  (searches for p and pp in the code)
+* p_with_brackets (searches for p( in the code)
+* rubocop_autocorrect (runs rubocop with autocorrection)
+* slim_lint (runs slim_lint)
+* scss_lint (runs scss_lint ATTENTION: THIS DOESN'T WORK YET)
+* coffeelint  (runs coffeelint ATTENTION: THIS ISN'T TESTED YET)
+* brakeman (runs brakeman)
+* reek (runs reek ATTENTION: THIS DOESN'T WORK YET)
+* rspec (runs rspec)
+
 ### Example
 
 The following example configures a script that looks for TODOs in a project.
 The configuration options can be called in any order.
 
 ```rb
-bin_check.check do |config|
-  config.command "grep --exclude-dir='app/assets/typings/**' -i -r 'TODO'"\
-                  "app spec config db Rakefile README.md Gemfile"
-  config.name "todo-grepper"
-  config.files ['app/**/*', 'spec/**/*', 'config/**/*', 'db/**/*', 'Rakefile', 'README.md', 'Gemfile']
-  config.success_message "No TODO was found :)"
-  config.error_message "+TODO found! Please get rid of them"
-  config.reversed_exit true
+BinCheck do
+  todo-grepper do
+    command "grep --exclude-dir='app/assets/typings/**' -i -r 'TODO'"\
+                    "app spec config db Rakefile README.md Gemfile"
+    files ['app/**/*', 'spec/**/*', 'config/**/*', 'db/**/*', 'Rakefile', 'README.md', 'Gemfile']
+    success_message "No TODO was found :)"
+    error_message "+TODO found! Please get rid of them"
+    reversed_exit true
+  end
 end
 ```
 
+## Known Bugs
+
+* scss-lint doesnt work yet with renuo-bin-check
+* reek doesnt work yet with renuo-bin-check
+
 ## Contribute
 
 If you would like to contribute, you're very welcome to.
@@ -127,7 +205,7 @@ Please follow these instructions:
 
 ## License
 
-Copyright (c) 2016 [Renuo GmbH]
+Copyright (c) 2016 [Renuo AG]
 
 [MIT License][6]
 
@@ -140,4 +218,4 @@ Copyright (c) 2016 [Renuo GmbH]
 [5]: https://github.com/renuo/renuo-bin-check/blob/develop/CODE_OF_CONDUCT.md
 [6]: https://github.com/renuo/renuo-bin-check/blob/develop/LICENSE
 
-[Renuo GmbH]: https://www.renuo.ch
+[Renuo AG]: https://www.renuo.ch

data/bin/check

@@ -9,37 +9,37 @@ if [ $? -eq 0 ]; then
   exit 1
 fi
 
-grep --exclude-dir="lib/renuo_bin_check/default_scripts" -i -r 'TODO' lib spec Gemfile
+grep --exclude-dir={"lib/renuo_bin_check/default_scripts","spec/renuo/bin-check/default_scripts"} -i -r 'TODO' lib spec Gemfile
 if [ $? -eq 0 ]; then
   echo 'TODOs found. Please fix them and try again, commit aborted'
   exit 1
 fi
 
-grep --exclude-dir="lib/renuo_bin_check/default_scripts" -i -r 'console.log' lib spec
+grep --exclude-dir={"lib/renuo_bin_check/default_scripts","spec/renuo/bin-check/default_scripts"} -i -r 'console.log' lib spec
 if [ $? -eq 0 ]; then
   echo 'console.log found. Please fix them and try again, commit aborted'
   exit 1
 fi
 
-grep --exclude-dir="lib/renuo_bin_check/default_scripts" -i -r '  puts ' lib spec
+grep --exclude-dir={"lib/renuo_bin_check/default_scripts","spec/renuo/bin-check/default_scripts"} -i -r '  puts ' lib spec
 if [ $? -eq 0 ]; then
   echo 'puts found. Please fix them and try again, commit aborted'
   exit 1
 fi
 
-grep --exclude-dir="lib/renuo_bin_check/default_scripts" -i -r '  puts(' lib spec
+grep --exclude-dir={"lib/renuo_bin_check/default_scripts","spec/renuo/bin-check/default_scripts"} -i -r '  puts(' lib spec
 if [ $? -eq 0 ]; then
   echo 'puts found. Please fix them and try again, commit aborted'
   exit 1
 fi
 
-grep --exclude-dir="lib/renuo_bin_check/default_scripts" -i -r '  p ' lib spec
+grep --exclude-dir={"lib/renuo_bin_check/default_scripts","spec/renuo/bin-check/default_scripts"} -i -r '  p ' lib spec
 if [ $? -eq 0 ]; then
   echo 'p found. Please fix them and try again, commit aborted'
   exit 1
 fi
 
-grep --exclude-dir="lib/renuo_bin_check/default_scripts" -i -r '  p(' lib spec
+grep --exclude-dir={"lib/renuo_bin_check/default_scripts","spec/renuo/bin-check/default_scripts"} -i -r '  p(' lib spec
 if [ $? -eq 0 ]; then
   echo 'p found. Please fix them and try again, commit aborted'
   exit 1

data/lib/renuo-bin-check.rb

@@ -1,3 +1,4 @@
+require 'renuo_bin_check/bin_check'
 require 'renuo_bin_check/cacher'
 require 'renuo_bin_check/initializer'
 require 'renuo_bin_check/master_thread'

data/lib/renuo_bin_check/bin_check.rb

@@ -0,0 +1,59 @@
+require 'renuo_bin_check/dsl_config'
+require 'renuo_bin_check/default_scripts/default_scripts'
+
+class BinCheck
+  def self.method_missing(name, *_params, &configs)
+    if block_given?
+      @configs << DSLConfig.new(name.to_s, &configs)
+    else
+      super
+    end
+  end
+
+  def respond_to_missing?
+    #:nocov:
+    true
+    #:nocov:
+  end
+
+  def self.run(default = :rails_defaults, &check)
+    @configs = DefaultScripts.new.send(default)
+    instance_eval(&check)
+    initialize_checks
+  end
+
+  def self.initialize_checks
+    @initializer = RenuoBinCheck::Initializer.new
+    @configs.each do |config|
+      if config.children?
+        add_children(config)
+      else
+        add_check(config.configs)
+      end
+    end
+    @initializer.run
+  end
+
+  def self.add_children(config)
+    config.children.each do |child|
+      add_check(child.parent.configs.merge(child.configs))
+    end
+  end
+
+  # :reek:NestedIterators initializer.check is not an iterator
+  def self.add_check(configs)
+    @initializer.check do |config|
+      configs.each do |key, value|
+        config.send key, value
+      end
+    end
+  end
+
+  def self.exclude(check_name)
+    @configs.delete_if { |config| config.configs[:name] == check_name.to_s }
+  end
+
+  class << self
+    attr_reader :configs
+  end
+end

data/lib/renuo_bin_check/default_scripts/default_rails.rb

@@ -10,8 +10,8 @@ module RenuoBinCheck
       mini_profiler(bin_check)
       todo(bin_check)
       console_log(bin_check)
-      put_without_brackets(bin_check)
-      put_with_brackets(bin_check)
+      puts_without_brackets(bin_check)
+      puts_with_brackets(bin_check)
       pp_and_p(bin_check)
       p_with_brackets(bin_check)
       rubocop_autocorrect(bin_check)
@@ -52,7 +52,7 @@ module RenuoBinCheck
       end
     end
 
-    def put_without_brackets(bin_check)
+    def puts_without_brackets(bin_check)
       bin_check.check do |config|
         config.command "grep -i -r '  puts ' app spec"
         config.reversed_exit true
@@ -60,7 +60,7 @@ module RenuoBinCheck
       end
     end
 
-    def put_with_brackets(bin_check)
+    def puts_with_brackets(bin_check)
       bin_check.check do |config|
         config.command "grep -i -r '  puts(' app spec"
         config.reversed_exit true
@@ -143,8 +143,8 @@ module RenuoBinCheck
     module_function :mini_profiler
     module_function :todo
     module_function :console_log
-    module_function :put_without_brackets
-    module_function :put_with_brackets
+    module_function :puts_without_brackets
+    module_function :puts_with_brackets
     module_function :pp_and_p
     module_function :p_with_brackets
     module_function :rubocop_autocorrect

data/lib/renuo_bin_check/default_scripts/default_scripts.rb

@@ -0,0 +1,168 @@
+require 'renuo_bin_check/dsl_config'
+
+# rubocop:disable Metrics/ClassLength
+# :reek:TooManyMethods
+class DefaultScripts
+  def initialize
+    @default_scripts = []
+  end
+
+  def no_defaults
+    []
+  end
+
+  # rubocop:disable Metrics/MethodLength
+  # :reek:TooManyStatements
+  def rails_defaults
+    todo
+    console_log
+    puts_with_brackets
+    puts_without_brackets
+    pp_and_p
+    p_with_brackets
+    rubocop_autocorrect
+    slim_lint
+    scss_lint
+    tslint
+    brakeman
+    reek
+    rspec
+    @default_scripts
+  end
+
+  # :reek:TooManyStatements
+  def rails_coffee_script_defaults
+    todo
+    console_log
+    puts_with_brackets
+    puts_without_brackets
+    pp_and_p
+    p_with_brackets
+    rubocop_autocorrect
+    slim_lint
+    scss_lint
+    coffeelint
+    brakeman
+    reek
+    rspec
+    @default_scripts
+  end
+  # rubocop:enable Metrics/MethodLength
+
+  def todo
+    @default_scripts << DSLConfig.new('todo') do
+      command "grep --exclude-dir='app/assets/typings/**' -i -r 'TODO' app spec config db Rakefile README.md Gemfile"
+      reversed_exit true
+      files ['app/**/*', 'spec/**/*', 'config/**/*', 'db/**/*', 'Rakefile', 'README.md', 'Gemfile']
+      success_message '+TODOs found. Please fix them and try again, commit aborted'
+    end
+  end
+
+  def console_log
+    @default_scripts << DSLConfig.new('console_log') do
+      command "grep -i -r 'console.log' app spec"
+      reversed_exit true
+      files ['app/**/*', 'spec/**/*']
+      success_message '+console.log found. Please fix them and try again, commit aborted'
+    end
+  end
+
+  def puts_without_brackets
+    @default_scripts << DSLConfig.new('puts_without_brackets') do
+      command "grep -i -r '  puts ' app spec"
+      reversed_exit true
+      files ['app/**/*', 'spec/**/*']
+      success_message '+puts found. Please fix them and try again, commit aborted'
+    end
+  end
+
+  def puts_with_brackets
+    @default_scripts << DSLConfig.new('puts_with_brackets') do
+      command "grep -i -r '  puts(' app spec"
+      reversed_exit true
+      files ['app/**/*', 'spec/**/*']
+      success_message '+puts( found. Please fix them and try again, commit aborted'
+    end
+  end
+
+  def pp_and_p
+    @default_scripts << DSLConfig.new('pp_and_p') do
+      command "grep -i -r '(  pp? [^=])|(= pp? )' app spec"
+      reversed_exit true
+      files ['app/**/*', 'spec/**/*']
+      success_message '+p or pp found. Please fix them and try again, commit aborted'
+    end
+  end
+
+  def p_with_brackets
+    @default_scripts << DSLConfig.new('p_with_brackets') do
+      command "grep -i -r '  p(' app spec"
+      reversed_exit true
+      files ['app/**/*', 'spec/**/*']
+      success_message '+p( found. Please fix them and try again, commit aborted'
+    end
+  end
+
+  def rubocop_autocorrect
+    @default_scripts << DSLConfig.new('rubocop_autocorrect') do
+      command 'bundle exec rubocop -a -D -c .rubocop.yml'
+      files ['app/**/*.rb', 'spec/**/*.rb']
+    end
+  end
+
+  def slim_lint
+    @default_scripts << DSLConfig.new('slim_lint') do
+      command 'bundle exec slim-lint app/views/ -c .slim-lint.yml'
+      files ['app/views/**/*.slim']
+      error_message '+slim-lint detected issues, commit aborted'
+    end
+  end
+
+  def scss_lint
+    @default_scripts << DSLConfig.new('scss_lint') do
+      command 'scss-lint app/assets/stylesheets/**/*.scss'
+      files ['app/assets/stylesheets/**/*.scss']
+      error_message '+scss-lint detected issues, commit aborted'
+    end
+  end
+
+  def tslint
+    @default_scripts << DSLConfig.new('tslint') do
+      command 'tslint -c tslint.json app/assets/javascripts/**/*.ts'
+      files ['app/assets/javascripts/**/*.ts']
+      error_message '+tslint detected issues, commit aborted'
+    end
+  end
+
+  def coffeelint
+    @default_scripts << DSLConfig.new('coffeelint') do
+      command 'coffeelint -f .coffeelint.json app/assets/javascripts/**/*.coffee'
+      files ['app/assets/javascripts/**/*.coffee']
+      error_message '+coffeelint detected issues, commit aborted'
+    end
+  end
+
+  def brakeman
+    @default_scripts << DSLConfig.new('brakeman') do
+      command 'bundle exec brakeman -q -z --summary > /dev/null'
+      error_message '+Brakeman has detected one or more security vulnerabilities, please review them and re-commit ' \
+                    'your changes, commit aborted'
+    end
+  end
+
+  def reek
+    @default_scripts << DSLConfig.new('reek') do
+      command 'bundle exec reek'
+      files ['app/**/*.rb']
+      error_message '+reek detected code smells, commit aborted'
+    end
+  end
+
+  def rspec
+    @default_scripts << DSLConfig.new('rspec') do
+      command 'bundle exec rspec'
+      files ['app/**/*.rb', 'spec/**/*.rb']
+    end
+  end
+end
+# rubocop:enable Metrics/ClassLength

data/lib/renuo_bin_check/dsl_config.rb

@@ -0,0 +1,47 @@
+class DSLConfig
+  attr_reader :configs, :children, :parent
+  def initialize(name, parent = nil, &configs)
+    @parent = parent
+    @children = []
+    @configs = { name: name }
+    instance_eval(&configs)
+  end
+
+  def method_missing(name, *_params, &configs)
+    if block_given?
+      @children << DSLConfig.new(name.to_s, self, &configs)
+    else
+      super
+    end
+  end
+
+  def respond_to_missing?(_method_name, _include_private)
+    #:nocov:
+    true
+    #:nocov:
+  end
+
+  def files(files)
+    @configs[:files] = files
+  end
+
+  def command(command)
+    @configs[:command] = command
+  end
+
+  def reversed_exit(reversed_exit)
+    @configs[:reversed_exit] = reversed_exit
+  end
+
+  def error_message(error_message)
+    @configs[:error_message] = error_message
+  end
+
+  def success_message(success_message)
+    @configs[:success_message] = success_message
+  end
+
+  def children?
+    !@children.empty?
+  end
+end

data/lib/renuo_bin_check/master_thread.rb

@@ -22,7 +22,7 @@ module RenuoBinCheck
       until waiter.empty?
         result = waiter.next_wait[:result]
         @results << result
-        exit_with_error(result) if result.exit_code == 1
+        exit_with_error(result) if result.exit_code.nonzero?
       end
       exit_with_success
     end

data/lib/renuo_bin_check/servant_thread.rb

@@ -37,7 +37,7 @@ module RenuoBinCheck
     end
 
     def reverse_result
-      Result.new(@result.error_output, @result.standard_output, @result.exit_code == 0 ? 1 : 0)
+      Result.new(@result.error_output, @result.standard_output, @result.exit_code.zero? ? 1 : 0)
     end
   end
 end

data/lib/renuo_bin_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module RenuoBinCheck
-  VERSION = '0.2.1'
+  VERSION = '1.0.0.beta1'
 end

data/spec/integration/bin_check_spec.rb

@@ -0,0 +1,213 @@
+require 'spec_helper'
+require './lib/renuo_bin_check/bin_check'
+
+RSpec.describe BinCheck do
+  context 'without caching' do
+    it 'returns exit-code 0 and expected output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit0_script do
+              command './spec/spec-files/test_script_exit0'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("I passed\nThis is the second line\n").to_stdout
+    end
+
+    it 'returns exit-code 0 and expected output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            hello_script do
+              command 'echo hello'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("hello\n").to_stdout
+    end
+
+    it 'returns exit-code 0 and expected overridden output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            hello_script do
+              command 'echo hello'
+              success_message 'I passed :)'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("I passed :)\n").to_stdout
+    end
+
+    it 'returns exit-code 0 and expected appended output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            hello_script do
+              command 'echo hello'
+              success_message '+I passed :)'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("hello\nI passed :)\n").to_stdout
+    end
+
+    it 'returns exit-code 1 and expected error-output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit1_script do
+              command './spec/spec-files/test_script_exit1'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(1)
+        end
+      end.to output("I failed\nThis is the second line\n").to_stderr
+    end
+
+    it 'returns exit-code 1 and expected non-error-output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit1_script do
+              command './spec/spec-files/test_script_exit1_no_error_output'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(1)
+        end
+      end.to output("I failed\nThis is the second line\n").to_stderr
+    end
+
+    it 'returns exit-code 1 and expected overridden error-output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit1_script do
+              command './spec/spec-files/test_script_exit1'
+              error_message 'it failed...'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(1)
+        end
+      end.to output("it failed...\n").to_stderr
+    end
+
+    it 'returns exit-code 1 and expected appended error-output' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit1_script do
+              command './spec/spec-files/test_script_exit1'
+              error_message '+it failed...'
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(1)
+        end
+      end.to output("I failed\nThis is the second line\nit failed...\n").to_stderr
+    end
+
+    it 'uses the common configuration right' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            cute_scripts do
+              success_message '+common configuration'
+              hello_script do
+                command 'echo hello'
+              end
+              bye_script do
+                command 'sleep 1 && echo bye'
+              end
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("hello\ncommon configuration\nbye\ncommon configuration\n").to_stdout
+    end
+
+    it 'runns scripts parallel' do
+      start_time = Time.now
+      begin
+        BinCheck.run :no_defaults do
+          sleep1 do
+            command './spec/spec-files/test_script_sleep1'
+          end
+          sleep2 do
+            command './spec/spec-files/test_script_sleep2'
+          end
+        end
+      rescue SystemExit => se
+        expect(se.status).to eq(0)
+      end
+      end_time = Time.now
+      expect(end_time - start_time).to be_within(0.4).of(2)
+    end
+  end
+
+  context 'cached script' do
+    before(:each) do
+      FileUtils.mkdir_p 'tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019'
+      File.write 'tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019/standard_output',
+                 "I'm cached\npassed\n"
+      File.write 'tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019/error_output',
+                 "I'm cached\npassed\n"
+      File.write 'tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019/exit_code', 0
+    end
+
+    after(:each) { FileUtils.remove_dir('./tmp/bin-check') }
+
+    it 'returns cached output and exit-code' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit0 do
+              command './spec/spec-files/test_script_exit0'
+              files %w(./spec/spec-files/file1 ./spec/spec-files/file2)
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("I'm cached\npassed\n").to_stdout
+    end
+  end
+
+  context 'saving to exit0 folder' do
+    after(:each) { FileUtils.remove_dir('./tmp/bin-check') }
+
+    it 'saves output and exit-code to files in folder named by given name' do
+      expect do
+        begin
+          BinCheck.run :no_defaults do
+            exit0 do
+              command './spec/spec-files/test_script_exit0'
+              files %w(./spec/spec-files/file1 ./spec/spec-files/file2)
+            end
+          end
+        rescue SystemExit => se
+          expect(se.status).to eq(0)
+        end
+      end.to output("I passed\nThis is the second line\n").to_stdout
+
+      expect(File.read('./tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019/error_output'))
+        .to eq("I failed\nThis is the second line\n")
+      expect(File.read('./tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019/standard_output'))
+        .to eq("I passed\nThis is the second line\n")
+      expect(File.read('./tmp/bin-check/exit0/df57ab93c06ded11a01f2de950307019/exit_code').to_i).to eq(0)
+    end
+  end
+end

data/spec/renuo/bin-check/bin_check_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+require './lib/renuo_bin_check/bin_check'
+
+RSpec.describe BinCheck do
+  it 'gets the right infos out of a new check' do
+    expect(BinCheck).to receive(:initialize_checks).and_return(true)
+    expect_any_instance_of(DefaultScripts).to receive(:rails_defaults).and_return([])
+
+    BinCheck.run do
+      rubocop do
+        files 'lib/**/*.rb'
+        command 'rubocop'
+        reversed_exit false
+      end
+
+      t0d0_finder do
+        files 'lib/**/*.*'
+        command 'blubb-blubb'
+        reversed_exit true
+      end
+    end
+
+    expect(BinCheck.configs.first.configs)
+      .to eq(name: 'rubocop', files: 'lib/**/*.rb', command: 'rubocop', reversed_exit: false)
+    expect(BinCheck.configs[1].configs)
+      .to eq(name: 't0d0_finder', files: 'lib/**/*.*', command: 'blubb-blubb', reversed_exit: true)
+  end
+
+  it 'understands common configs' do
+    expect(BinCheck).to receive(:initialize_checks).and_return(true)
+    expect_any_instance_of(DefaultScripts).to receive(:rails_defaults).and_return([])
+
+    BinCheck.run do
+      ruby_files do
+        files 'lib/**/*.rb'
+        rubocop do
+          command 'rubocop'
+          reversed_exit false
+        end
+        p_finder do
+          command 'blubb-blubb'
+          reversed_exit true
+        end
+      end
+    end
+    expect(BinCheck.configs.first.configs.merge(BinCheck.configs.first.children.first.configs))
+      .to eq(name: 'rubocop', files: 'lib/**/*.rb', command: 'rubocop', reversed_exit: false)
+    expect(BinCheck.configs.first.configs.merge(BinCheck.configs.first.children[1].configs))
+      .to eq(name: 'p_finder', files: 'lib/**/*.rb', command: 'blubb-blubb', reversed_exit: true)
+  end
+
+  it 'excluds unwanted default checks' do
+    expect(BinCheck).to receive(:initialize_checks).and_return(true)
+
+    BinCheck.run do
+      exclude :config_log
+    end
+
+    BinCheck.configs.each do |config|
+      expect(config.configs).not_to include(name: 'config_log')
+    end
+  end
+
+  it 'calls super if no block is given' do
+    expect { BinCheck.blubb }.to raise_error(NoMethodError)
+  end
+end

data/spec/renuo/bin-check/default_scripts/default_scripts_spec.rb

@@ -0,0 +1,191 @@
+require 'spec_helper'
+require './lib/renuo_bin_check/default_scripts/default_scripts'
+
+RSpec.describe DefaultScripts do
+  let(:default_scripts) { DefaultScripts.new }
+
+  it 'uses all scripts needed for rails default' do
+    expect(default_scripts).to receive(:todo)
+    expect(default_scripts).to receive(:console_log)
+    expect(default_scripts).to receive(:puts_with_brackets)
+    expect(default_scripts).to receive(:puts_without_brackets)
+    expect(default_scripts).to receive(:pp_and_p)
+    expect(default_scripts).to receive(:p_with_brackets)
+    expect(default_scripts).to receive(:rubocop_autocorrect)
+    expect(default_scripts).to receive(:slim_lint)
+    expect(default_scripts).to receive(:scss_lint)
+    expect(default_scripts).to receive(:tslint)
+    expect(default_scripts).to receive(:brakeman)
+    expect(default_scripts).to receive(:reek)
+    expect(default_scripts).to receive(:rspec)
+
+    default_scripts.rails_defaults
+  end
+
+  it 'uses all scripts needed for rails default if coffee is used' do
+    expect(default_scripts).to receive(:todo)
+    expect(default_scripts).to receive(:console_log)
+    expect(default_scripts).to receive(:puts_with_brackets)
+    expect(default_scripts).to receive(:puts_without_brackets)
+    expect(default_scripts).to receive(:pp_and_p)
+    expect(default_scripts).to receive(:p_with_brackets)
+    expect(default_scripts).to receive(:rubocop_autocorrect)
+    expect(default_scripts).to receive(:slim_lint)
+    expect(default_scripts).to receive(:scss_lint)
+    expect(default_scripts).to receive(:coffeelint)
+    expect(default_scripts).to receive(:brakeman)
+    expect(default_scripts).to receive(:reek)
+    expect(default_scripts).to receive(:rspec)
+
+    default_scripts.rails_coffee_script_defaults
+  end
+
+  it '#no_default' do
+    expect(default_scripts.no_defaults).to eq([])
+  end
+
+  it '#todo' do
+    expect(default_scripts.todo.last.configs)
+      .to eq(
+        name: 'todo',
+        command: "grep --exclude-dir='app/assets/typings/**' -i -r 'TODO' app spec config db Rakefile README.md" \
+          ' Gemfile',
+        reversed_exit: true,
+        files: ['app/**/*', 'spec/**/*', 'config/**/*', 'db/**/*', 'Rakefile', 'README.md', 'Gemfile'],
+        success_message: '+TODOs found. Please fix them and try again, commit aborted'
+      )
+  end
+
+  it '#console_log' do
+    expect(default_scripts.console_log.last.configs)
+      .to eq(
+        name: 'console_log',
+        command: "grep -i -r 'console.log' app spec",
+        reversed_exit: true,
+        files: ['app/**/*', 'spec/**/*'],
+        success_message: '+console.log found. Please fix them and try again, commit aborted'
+      )
+  end
+
+  it '#puts_without_brackets' do
+    expect(default_scripts.puts_without_brackets.last.configs)
+      .to eq(
+        name: 'puts_without_brackets',
+        command: "grep -i -r '  puts ' app spec",
+        reversed_exit: true,
+        files: ['app/**/*', 'spec/**/*'],
+        success_message: '+puts found. Please fix them and try again, commit aborted'
+      )
+  end
+
+  it '#puts_with_brackets' do
+    expect(default_scripts.puts_with_brackets.last.configs)
+      .to eq(
+        name: 'puts_with_brackets',
+        command: "grep -i -r '  puts(' app spec",
+        reversed_exit: true,
+        files: ['app/**/*', 'spec/**/*'],
+        success_message: '+puts( found. Please fix them and try again, commit aborted'
+      )
+  end
+
+  it '#pp_and_p' do
+    expect(default_scripts.pp_and_p.last.configs)
+      .to eq(
+        name: 'pp_and_p',
+        command: "grep -i -r '(  pp? [^=])|(= pp? )' app spec",
+        reversed_exit: true,
+        files: ['app/**/*', 'spec/**/*'],
+        success_message: '+p or pp found. Please fix them and try again, commit aborted'
+      )
+  end
+
+  it '#p_with_brackets' do
+    expect(default_scripts.p_with_brackets.last.configs)
+      .to eq(
+        name: 'p_with_brackets',
+        command: "grep -i -r '  p(' app spec",
+        reversed_exit: true,
+        files: ['app/**/*', 'spec/**/*'],
+        success_message: '+p( found. Please fix them and try again, commit aborted'
+      )
+  end
+
+  it '#rubocop_autocorrect' do
+    expect(default_scripts.rubocop_autocorrect.last.configs)
+      .to eq(
+        name: 'rubocop_autocorrect',
+        command: 'bundle exec rubocop -a -D -c .rubocop.yml',
+        files: ['app/**/*.rb', 'spec/**/*.rb']
+      )
+  end
+
+  it '#slim_lint' do
+    expect(default_scripts.slim_lint.last.configs)
+      .to eq(
+        name: 'slim_lint',
+        command: 'bundle exec slim-lint app/views/ -c .slim-lint.yml',
+        files: ['app/views/**/*.slim'],
+        error_message: '+slim-lint detected issues, commit aborted'
+      )
+  end
+
+  it '#scss_lint' do
+    expect(default_scripts.scss_lint.last.configs)
+      .to eq(
+        name: 'scss_lint',
+        command: 'scss-lint app/assets/stylesheets/**/*.scss',
+        files: ['app/assets/stylesheets/**/*.scss'],
+        error_message: '+scss-lint detected issues, commit aborted'
+      )
+  end
+
+  it '#tslint' do
+    expect(default_scripts.tslint.last.configs)
+      .to eq(
+        name: 'tslint',
+        command: 'tslint -c tslint.json app/assets/javascripts/**/*.ts',
+        files: ['app/assets/javascripts/**/*.ts'],
+        error_message: '+tslint detected issues, commit aborted'
+      )
+  end
+
+  it '#coffeelint' do
+    expect(default_scripts.coffeelint.last.configs)
+      .to eq(
+        name: 'coffeelint',
+        command: 'coffeelint -f .coffeelint.json app/assets/javascripts/**/*.coffee',
+        files: ['app/assets/javascripts/**/*.coffee'],
+        error_message: '+coffeelint detected issues, commit aborted'
+      )
+  end
+
+  it '#brakeman' do
+    expect(default_scripts.brakeman.last.configs)
+      .to eq(
+        name: 'brakeman',
+        command: 'bundle exec brakeman -q -z --summary > /dev/null',
+        error_message: '+Brakeman has detected one or more security vulnerabilities, please review them and re-commit' \
+          ' your changes, commit aborted'
+      )
+  end
+
+  it '#reek' do
+    expect(default_scripts.reek.last.configs)
+      .to eq(
+        name: 'reek',
+        command: 'bundle exec reek',
+        files: ['app/**/*.rb'],
+        error_message: '+reek detected code smells, commit aborted'
+      )
+  end
+
+  it '#rspec' do
+    expect(default_scripts.rspec.last.configs)
+      .to eq(
+        name: 'rspec',
+        command: 'bundle exec rspec',
+        files: ['app/**/*.rb', 'spec/**/*.rb']
+      )
+  end
+end

data/spec/renuo/bin-check/dsl_config_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+require './lib/renuo_bin_check/dsl_config'
+
+RSpec.describe DSLConfig do
+  it 'gets the right infos out of a new check' do
+    dsl_config = DSLConfig.new('rspec') do
+      files 'lib/**/*.rb'
+      command 'rubocop'
+      reversed_exit false
+    end
+
+    expect(dsl_config.configs).to eq(name: 'rspec', files: 'lib/**/*.rb', command: 'rubocop', reversed_exit: false)
+    expect(dsl_config.children?).to eq(false)
+  end
+
+  it 'creates new children if there are nested checks' do
+    dsl_config = DSLConfig.new('ruby_files') do
+      files 'lib/**/*.rb'
+      rubocop do
+        command 'rubocop'
+        reversed_exit false
+      end
+      error_message 'an error occured'
+      p_finder do
+        command 'find p'
+        reversed_exit true
+      end
+    end
+
+    expect(dsl_config.configs).to eq(name: 'ruby_files', files: 'lib/**/*.rb', error_message: 'an error occured')
+    expect(dsl_config.children.first.configs).to eq(name: 'rubocop', command: 'rubocop', reversed_exit: false)
+    expect(dsl_config.children[1].configs).to eq(name: 'p_finder', command: 'find p', reversed_exit: true)
+    expect(dsl_config.children?).to eq(true)
+  end
+
+  it 'method_missing calls super if no block is given' do
+    expect { DSLConfig.new('ruby_files') { blubb } }.to raise_error(NameError)
+  end
+end

data/spec/spec-files/test_script_sleep1

@@ -1,2 +1,3 @@
+#!/bin/zsh
 sleep 1
 exit 0

data/spec/spec-files/test_script_sleep2

@@ -1,2 +1,3 @@
+#!/bin/zsh
 sleep 2
-
exit 0
+
exit 0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: renuo-bin-check
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 1.0.0.beta1
 platform: ruby
 authors:
 - Zora Fuchs
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-06-15 00:00:00.000000000 Z
+date: 2016-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print
@@ -205,8 +205,11 @@ files:
 - bin/check
 - bin/setup
 - lib/renuo-bin-check.rb
+- lib/renuo_bin_check/bin_check.rb
 - lib/renuo_bin_check/cacher.rb
 - lib/renuo_bin_check/default_scripts/default_rails.rb
+- lib/renuo_bin_check/default_scripts/default_scripts.rb
+- lib/renuo_bin_check/dsl_config.rb
 - lib/renuo_bin_check/initializer.rb
 - lib/renuo_bin_check/master_thread.rb
 - lib/renuo_bin_check/printer.rb
@@ -220,8 +223,12 @@ files:
 - spec/factories/cacher.rb
 - spec/factories/result.rb
 - spec/factories/script_config.rb
+- spec/integration/bin_check_spec.rb
 - spec/integration/initializer_spec.rb
+- spec/renuo/bin-check/bin_check_spec.rb
 - spec/renuo/bin-check/cacher_spec.rb
+- spec/renuo/bin-check/default_scripts/default_scripts_spec.rb
+- spec/renuo/bin-check/dsl_config_spec.rb
 - spec/renuo/bin-check/initializer_spec.rb
 - spec/renuo/bin-check/master_thread_spec.rb
 - spec/renuo/bin-check/printer_spec.rb
@@ -252,9 +259,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.1
@@ -268,8 +275,12 @@ test_files:
 - spec/factories/cacher.rb
 - spec/factories/result.rb
 - spec/factories/script_config.rb
+- spec/integration/bin_check_spec.rb
 - spec/integration/initializer_spec.rb
+- spec/renuo/bin-check/bin_check_spec.rb
 - spec/renuo/bin-check/cacher_spec.rb
+- spec/renuo/bin-check/default_scripts/default_scripts_spec.rb
+- spec/renuo/bin-check/dsl_config_spec.rb
 - spec/renuo/bin-check/initializer_spec.rb
 - spec/renuo/bin-check/master_thread_spec.rb
 - spec/renuo/bin-check/printer_spec.rb
@@ -285,4 +296,3 @@ test_files:
 - spec/spec-files/test_script_sleep1
 - spec/spec-files/test_script_sleep2
 - spec/spec_helper.rb
-has_rdoc: