rentlinx 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e9c6235c8891f0be05e492ba4811f8ea49caefb
-  data.tar.gz: 68324208bc855cc495a4f9e7abc74748b7f26b68
+  metadata.gz: ef85bce9f2ff14a271f922916dbd8c3698204df4
+  data.tar.gz: 31f3863df3a5104030ea8e978e193bb57e5104c7
 SHA512:
-  metadata.gz: 2f2e8c07d583ad39c97f246f01c9b0a953509f56e2d37140afee8b88d43fa9d49930265889a38156efc0fb6cdb2d211da27e27a4ffb385e8675ecc94669e970d
-  data.tar.gz: 7bec813c58aac658c954d38fba18440a5772b0a6c2cf06e3ff615725e0a641f19879f255899ffb912057901ea34aede345527384ed66a594733c58465c27d848
+  metadata.gz: efbd029b6d1463d9e321949507141bf4b6f2b895d96bb68fc2ca3cfce82759a3b6d2adba6db81376ca1604e2885ed5b64bc5b96a11e62aa0b1b394707aaa4581
+  data.tar.gz: bd45c674674e197bc7c6227fdf51fcdb9587471b5065e57a34acd057c56f5525fca36a421feed553909ffbd4e5997f5d3ad20b35801191b83b78a1e934a99ea8

data/lib/rentlinx/errors.rb

@@ -20,6 +20,12 @@ module Rentlinx
     end
   end
 
+  class IncompatibleGroupOfObjectsForPost < RentlinxError
+    def initialize(property)
+      super("These objects cannot be grouped together ('#{property}' differ).")
+    end
+  end
+
   class HTTPError < RentlinxError
     attr_reader :response
 

data/lib/rentlinx/models/property_link.rb

@@ -10,4 +10,4 @@ module Rentlinx
       { url: url, title: title }
     end
   end
-end
+end

data/lib/rentlinx/models/unit_link.rb

@@ -6,4 +6,4 @@ module Rentlinx
 
     attr_accessor(*ATTRIBUTES)
   end
-end
+end

data/lib/rentlinx/modules/amenity_client_methods.rb

@@ -1,8 +1,10 @@
 module Rentlinx
   module AmenityClientMethods
     def post_amenities(amenities)
-      raise Rentlinx::InvalidObject, amenities.find { |a| !a.valid? } unless amenities.all?(&:valid?)
-      raise Rentlinx::InvalidObject, amenities unless amenities.all? { |p| p.propertyID == amenities.first.propertyID }
+      return if amenities.nil?
+      raise(Rentlinx::InvalidObject, amenities.find { |a| !a.valid? }) unless amenities.all?(&:valid?)
+      raise(Rentlinx::IncompatibleGroupOfObjectsForPost, 'propertyID') unless amenities.all? { |p| p.propertyID == amenities.first.propertyID }
+
       property_amenities = amenities.select { |p| p.class == Rentlinx::PropertyAmenity }
       unit_amenities = amenities - property_amenities
 

data/lib/rentlinx/modules/link_client_methods.rb

@@ -1,8 +1,11 @@
 module Rentlinx
   module LinkClientMethods
     def post_links(links)
-      raise Rentlinx::InvalidObject, links.find { |a| !a.valid? } unless links.all?(&:valid?)
-      raise Rentlinx::InvalidObject, links unless links.all? { |p| p.propertyID == links.first.propertyID }
+      return if links.nil?
+
+      raise(Rentlinx::InvalidObject, links.find { |a| !a.valid? }) unless links.all?(&:valid?)
+      raise(Rentlinx::IncompatibleGroupOfObjectsForPost, 'propertyID') unless links.all? { |p| p.propertyID == links.first.propertyID }
+
       property_links = links.select { |l| l.class == Rentlinx::PropertyLink }
       unit_links = links - property_links
 
@@ -26,17 +29,17 @@ module Rentlinx
 
     def get_links_for_unit(unit)
       links = get_links_for_property_id(unit.propertyID)
-      links.select { |a| defined? a.unitID && a.unitID == unit.unitID }
+      links.select { |link| defined? link.unitID && link.unitID == unit.unitID }
     end
 
     def unpost_link(link)
       case link
-        when Rentlinx::UnitLink
-          unpost_unit_link(link.unitID, link.url)
-        when Rentlinx::PropertyLink
-          unpost_property_link(link.propertyID, link.url)
-        else
-          raise TypeError, "Invalid type: #{link.class}"
+      when Rentlinx::UnitLink
+        unpost_unit_link(link.unitID, link.url)
+      when Rentlinx::PropertyLink
+        unpost_property_link(link.propertyID, link.url)
+      else
+        raise TypeError, "Invalid type: #{link.class}"
       end
     end
 
@@ -62,11 +65,11 @@ module Rentlinx
     end
 
     def unpost_property_link(id, url)
-      request('DELETE', URI.encode("properties/#{id}/links/"), { url: url })
+      request('DELETE', URI.encode("properties/#{id}/links/"), url: url)
     end
 
     def unpost_unit_link(id, url)
-      request('DELETE', URI.encode("units/#{id}/links/"), { url: url })
+      request('DELETE', URI.encode("units/#{id}/links/"), url: url)
     end
   end
-end
+end

data/lib/rentlinx/modules/linkable.rb

@@ -10,9 +10,7 @@ module Rentlinx
     end
 
     def links
-      return @links if @links
-
-      @links =
+      @links ||=
         if defined? unitID
           Rentlinx.client.get_links_for_unit(self)
         else

data/lib/rentlinx/modules/photo_client_methods.rb

@@ -1,8 +1,10 @@
 module Rentlinx
   module PhotoClientMethods
     def post_photos(photos)
-      return false unless photos.all?(&:valid?)
-      return false unless photos.all? { |p| p.propertyID == photos.first.propertyID }
+      return if photos.nil?
+      raise(Rentlinx::InvalidObject, photos.find { |p| !p.valid? }) unless photos.all?(&:valid?)
+      raise(Rentlinx::IncompatibleGroupOfObjectsForPost, 'propertyID') unless photos.all? { |p| p.propertyID == photos.first.propertyID }
+
       property_photos = photos.select { |p| p.class == Rentlinx::PropertyPhoto }
       unit_photos = photos - property_photos
 

data/lib/rentlinx/version.rb

@@ -1,3 +1,3 @@
 module Rentlinx
-  VERSION = '0.7.0'
+  VERSION = '0.7.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rentlinx
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - AppFolio, Inc.