remotipart 1.1.1 → 1.2.0

data/CONTRIBUTING.md

@@ -0,0 +1,53 @@
+## Note on Patches/Pull Requests
+
+* Fork the project.
+* Make your feature addition or bug fix.
+* Add tests for it. This is important so I don't break it in a
+  future version unintentionally.
+* Commit, do not mess with rakefile, version, or history.
+  (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
+* Send me a pull request. Bonus points for topic branches.
+
+## Tests
+
+Because of the nature of AJAX file uploads and certain browser restrictions, we could not simply create unit tests (using qunit or jasmine)
+to test the file upload functionality of remotipart (since the browsers running those test suites won't allow us to set the target of a file
+upload input using javascript). So, instead we created a demo Rails app using remotipart with all remotipart functionality tested using RSpec and Capybara.
+
+* [Demo Rails App with
+  Tests](https://github.com/JangoSteve/Rails-jQuery-Demo/tree/remotipart)
+* [Tests](https://github.com/JangoSteve/Rails-jQuery-Demo/blob/remotipart/spec/features/comments_spec.rb)
+
+To run tests:
+
+Clone the remotipart branch of the demo app
+
+```
+git clone -b remotipart git://github.com/JangoSteve/Rails-jQuery-Demo.git
+```
+
+Install the dependencies
+
+```
+bundle install
+```
+
+Run the tests
+
+```
+bundle exec rspec spec/
+```
+
+If you need to test your own changes to remotipart, just update the Gemfile with your own fork/branch of remotipart:
+
+```
+gem 'remotipart', :git => 'git://github.com/MY_FORK/remotipart.git', :branch => 'MY_BRANCH'
+```
+
+To save time, you can also just bundle remotipart from your current
+local machine / filesystem without having to commit your changes
+or push them remotely:
+
+```
+gem 'remotipart', :path => '../remotipart'
+```

data/History.rdoc

@@ -1,5 +1,10 @@
 = History
 
+=== 1.2.0 / 2013-07-06
+
+* Removed support for older jquery-ujs and jquery < 1.7.
+* Fixed json (and other type) parsing issues, only html_escape HTML responses.
+
 === 1.1.1 / 2013-07-05
 
 * Fixed issue with GET params not being available in middleware.

data/README.rdoc

@@ -13,7 +13,7 @@ This gem augments the native Rails jQuery remote form functionality enabling asy
 
 == Installation
 
-<b>Your app should be using jquery-rails gem v1.0.12 or above (except jquery-rails v2.0.3 and v2.1.0; there was a {bug in jquery-rails}[https://github.com/rails/jquery-ujs/issues/271] which causes remotiarpt to not work for those versions).</b>
+<b>Your app should be using jquery-rails gem v2.3.0 or above.</b>
 
 If you're using an old version of the jquery-rails gem,
 make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version from {VERSION_COMPATIBILITY}[https://github.com/JangoSteve/remotipart/blob/master/VERSION_COMPATIBILITY.rdoc].
@@ -23,7 +23,7 @@ make sure you have a supported jquery-ujs (rails.js or jquery_ujs.js) version fr
 
   * Add this line to your GEMFILE (use the appropriate version from the compatibilty chart if needed)
 
-   gem 'remotipart', '~> 1.0'
+   gem 'remotipart', '~> 1.1'
 
   * And run
 
@@ -139,4 +139,4 @@ Thank you to {Adam Kerr}[https://github.com/ajrkerr] for helping move over to th
 
 == Copyright
 
-Copyright (c) 2011 {Steve Schwartz}[https://github.com/JangoSteve], {Greg Leppert}[https://github.com/leppert]. See LICENSE for details.
+Copyright (c) 2013 {Steve Schwartz}[https://github.com/JangoSteve], {Greg Leppert}[https://github.com/leppert]. See LICENSE for details.

data/lib/remotipart/rails/version.rb

@@ -1,6 +1,6 @@
 module Remotipart
   module Rails
-    VERSION = "1.1.1"
+    VERSION = "1.2.0"
     IFRAMETRANSPORT_VERSION = "02.06.2013"
   end
 end

data/lib/remotipart/render_overrides.rb

@@ -13,7 +13,8 @@ module Remotipart
     def render_with_remotipart *args
       render_without_remotipart *args
       if remotipart_submitted?
-        response.body = %{<textarea data-type=\"#{response.content_type}\" data-status=\"#{response.response_code}\" data-statusText=\"#{response.message}\">#{html_escape(response.body)}</textarea>}
+        textarea_body = response.content_type == 'text/html' ? html_escape(response.body) : response.body
+        response.body = %{<textarea data-type=\"#{response.content_type}\" data-status=\"#{response.response_code}\" data-statusText=\"#{response.message}\">#{textarea_body}</textarea>}
         response.content_type = Mime::HTML
       end
       response_body

data/remotipart.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "remotipart"
-  s.version = "1.1.1"
+  s.version = "1.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Greg Leppert", "Steve Schwartz"]
-  s.date = "2013-07-05"
+  s.date = "2013-07-06"
   s.description = "Remotipart is a Ruby on Rails gem enabling remote multipart forms (AJAX style file uploads) with jquery-rails.\n    This gem augments the native Rails 3 jQuery-UJS remote form function enabling asynchronous file uploads with little to no modification to your application.\n    "
   s.email = ["greg@formasfunction.com", "steve@alfajango.com"]
   s.extra_rdoc_files = [
@@ -18,6 +18,7 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".document",
+    "CONTRIBUTING.md",
     "Gemfile",
     "Gemfile.lock",
     "History.rdoc",

data/vendor/assets/javascripts/jquery.remotipart.js

@@ -73,10 +73,6 @@
 
     remotipart.setup(form);
 
-    // If browser does not support submit bubbling, then this live-binding will be called before direct
-    // bindings. Therefore, we should directly call any direct bindings before remotely submitting form.
-    if (!$.support.submitBubbles && $().jquery < '1.7' && $.rails.callFormSubmitBindings(form) === false) return $.rails.stopEverything(e);
-
     // Manually call jquery-ujs remote call so that it can setup form and settings as usual,
     // and trigger the `ajax:beforeSend` callback to which remotipart binds functionality.
     $.rails.handleRemote(form);

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: remotipart
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-05 00:00:00.000000000Z
+date: 2013-07-06 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70145637696380 !ruby/object:Gem::Requirement
+  requirement: &70282875330640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70145637696380
+  version_requirements: *70282875330640
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70145637694700 !ruby/object:Gem::Requirement
+  requirement: &70282875329180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,7 +33,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70145637694700
+  version_requirements: *70282875329180
 description: ! "Remotipart is a Ruby on Rails gem enabling remote multipart forms
   (AJAX style file uploads) with jquery-rails.\n    This gem augments the native Rails
   3 jQuery-UJS remote form function enabling asynchronous file uploads with little
@@ -48,6 +48,7 @@ extra_rdoc_files:
 - README.rdoc
 files:
 - .document
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.lock
 - History.rdoc
@@ -82,7 +83,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 803845486888652544
+      hash: -3656035227424558239
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: