remote_association 0.0.4 → 0.0.5

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZDRhODhkODdiMDlkMjY3MTdmYjRhMWE2NzY3MWYwODE3OWRjOGFhYw==
+  data.tar.gz: !binary |-
+    YmMxZWIzZDgyODNiYjM3YTJlZjQ3NDZkNTJkMGNhMDk4ODg3MDdjOA==
+SHA512:
+  metadata.gz: !binary |-
+    YWYxZjBkNDIxNmEwNTJlZWNmZmQyNGM0MzkxY2Y3ZDEwZjgxYWJmZjdmNjI2
+    NjM0NjhhYTcxZDQwNjJjNjRjMTEzODVmZWE3YWI4MDQ0ZGE1OTBkOWZjZTJj
+    ZmFjZjBjM2EwMzRjM2FkYjZkMWUyM2I0OTQxNTUxMDM4NWI3MGM=
+  data.tar.gz: !binary |-
+    MmIyYTgwZWMwM2E0MWYyNTIwYjhkZWY3OTJhZWEyNzY5YjYzZmY0ZjliOTQy
+    N2IzOTBhODc3NjUzYzM5NTQ4MzZhZmZjMzE0NzI4MjkzM2FlY2IyY2EwMWEw
+    Y2VmNTQ3ZGMzZTVhYjVkY2NkYTY5YjBiMjc0MWJmYjIwZTAxZjE=

data/.ruby-gemset

@@ -0,0 +1 @@
+remote_association

data/.ruby-version

@@ -0,0 +1 @@
+1.9.3-p550

data/.travis.yml

@@ -2,6 +2,8 @@ language: ruby
 
 rvm:
   - 1.9.3
+  - 2.0
+  - 2.1
 
 before_script:
   - "cp spec/config/database.example.yml spec/config/database.yml"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    remote_association (0.0.4)
+    remote_association (0.0.5)
       activerecord (~> 3.2)
       activeresource (~> 3.2)
       activesupport (~> 3.2)
@@ -9,27 +9,27 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (3.2.8)
-      activesupport (= 3.2.8)
+    activemodel (3.2.19)
+      activesupport (= 3.2.19)
       builder (~> 3.0.0)
-    activerecord (3.2.8)
-      activemodel (= 3.2.8)
-      activesupport (= 3.2.8)
+    activerecord (3.2.19)
+      activemodel (= 3.2.19)
+      activesupport (= 3.2.19)
       arel (~> 3.0.2)
       tzinfo (~> 0.3.29)
-    activeresource (3.2.8)
-      activemodel (= 3.2.8)
-      activesupport (= 3.2.8)
-    activesupport (3.2.8)
-      i18n (~> 0.6)
+    activeresource (3.2.19)
+      activemodel (= 3.2.19)
+      activesupport (= 3.2.19)
+    activesupport (3.2.19)
+      i18n (~> 0.6, >= 0.6.4)
       multi_json (~> 1.0)
-    arel (3.0.2)
-    builder (3.0.3)
+    arel (3.0.3)
+    builder (3.0.4)
     database_cleaner (0.8.0)
     diff-lcs (1.1.3)
     fakeweb (1.3.0)
-    i18n (0.6.1)
-    multi_json (1.3.6)
+    i18n (0.6.11)
+    multi_json (1.10.1)
     pg (0.14.1)
     rake (0.9.2.2)
     rspec (2.11.0)
@@ -40,7 +40,7 @@ GEM
     rspec-expectations (2.11.3)
       diff-lcs (~> 1.1.3)
     rspec-mocks (2.11.3)
-    tzinfo (0.3.33)
+    tzinfo (0.3.42)
 
 PLATFORMS
   ruby

data/lib/remote_association/active_record/relation.rb

@@ -21,6 +21,11 @@ module ActiveRecord
         settings = klass.activeresource_relations[r.to_sym]
         raise RemoteAssociation::SettingsNotFoundError, "Can't find settings for #{r} association" if settings.blank?
 
+        if settings[:polymorphic]
+          puts "Preload of polymorphic associations not supported"
+          next
+        end
+
         ar_class = settings[:class_name].constantize
 
         remote_associations << OpenStruct.new(

data/lib/remote_association/belongs_to_remote.rb

@@ -37,6 +37,13 @@ module RemoteAssociation
       # of "favorite_person_id".
       # [:primary_key]
       # Specify the http query parameter to find associated object used for the association. By default this is <tt>id</tt>.
+      # [:polymorphic]
+      # Specify this association is a polymorphic association by passing true.
+      # [:foreign_type]
+      # Specify the column used to store the associated object’s type, if this is a polymorphic association.
+      # By default this is guessed to be the name of the association with a “_type” suffix.
+      # So a class that defines a belongs_to_remote :owner, :polymorphic => true association
+      # will use “owner_type” as the default :foreign_type.
       # Example:
       #  belongs_to_remote :firm, :primary_key => 'search[id_in]' #=> ...?firms.json?search%5Bid_in%5D%5B%5D=1
       #
@@ -45,34 +52,66 @@ module RemoteAssociation
       #   belongs_to_remote :author, :class_name => "Person", :foreign_key => "author_id"
       def belongs_to_remote(remote_rel, options ={})
         rel_options = {
-                       class_name:  remote_rel.to_s.classify,
-                       foreign_key: remote_rel.to_s.foreign_key,
+                       class_name:    remote_rel.to_s.classify,
+                       foreign_key:   remote_rel.to_s.foreign_key,
+                       foreign_type:  remote_rel.to_s + '_type',
                        association_type: :belongs_to_remote,
                        primary_key: primary_key
                       }.merge(options.symbolize_keys)
 
         add_activeresource_relation(remote_rel.to_sym, rel_options)
 
-        class_eval <<-RUBY, __FILE__, __LINE__+1
+        if rel_options[:polymorphic]
+          class_eval <<-RUBY, __FILE__, __LINE__+1
 
-          attr_accessor :#{remote_rel}
+            attr_accessor :#{remote_rel}
 
-          def #{remote_rel}
-            if remote_resources_loaded?
-              @#{remote_rel} ? @#{remote_rel}.first : nil
-            else
-              @#{remote_rel} ||= self.#{rel_options[:foreign_key]}.present? ? #{rel_options[:class_name]}.find(:first, params: self.class.build_params_hash_for_#{remote_rel}(self.#{rel_options[:foreign_key]})) : nil
+            def #{remote_rel}
+              if remote_resources_loaded?
+                @#{remote_rel} ? @#{remote_rel}.first : nil
+              else
+                @#{remote_rel} ||= if self.#{rel_options[:foreign_key]}.present? && self.#{rel_options[:foreign_class]}.present?
+                                     #{rel_options[:foreign_type]}.classify.constantize.find(:all, params: self.class.build_params_hash_for_#{remote_rel}(self.#{rel_options[:foreign_key]})).try(:first)
+                                   else
+                                     nil
+                                   end
+              end
             end
-          end
 
-          ##
-          # Returns Hash with HTTP parameters to query remote API
-          def self.build_params_hash_for_#{remote_rel}(keys)
-            keys = [keys] unless keys.kind_of?(Array)
-            {"#{rel_options[:primary_key]}" => keys}
-          end
+            ##
+            # Returns Hash with HTTP parameters to query remote API
+            def self.build_params_hash_for_#{remote_rel}(keys)
+              keys = [keys] unless keys.kind_of?(Array)
+              {"#{rel_options[:primary_key]}" => keys}
+            end
+
+          RUBY
+        else
+          class_eval <<-RUBY, __FILE__, __LINE__+1
+
+            attr_accessor :#{remote_rel}
+
+            def #{remote_rel}
+              if remote_resources_loaded?
+                @#{remote_rel} ? @#{remote_rel}.first : nil
+              else
+                @#{remote_rel} ||= if self.#{rel_options[:foreign_key]}.present?
+                                     #{rel_options[:class_name]}.find(:all, params: self.class.build_params_hash_for_#{remote_rel}(self.#{rel_options[:foreign_key]})).try(:first)
+                                   else
+                                     nil
+                                   end
+              end
+            end
+
+            ##
+            # Returns Hash with HTTP parameters to query remote API
+            def self.build_params_hash_for_#{remote_rel}(keys)
+              keys = [keys] unless keys.kind_of?(Array)
+              {"#{rel_options[:primary_key]}" => keys}
+            end
 
-        RUBY
+          RUBY
+        end
       end
   end
 end

data/lib/remote_association/version.rb

@@ -1,3 +1,3 @@
 module RemoteAssociation
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/remote_association.gemspec

@@ -25,5 +25,4 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'pg',                '~> 0.14'
   gem.add_development_dependency 'database_cleaner',  '~> 0.8'
   gem.add_development_dependency 'fakeweb'
-
 end

data/spec/remote_association/belongs_to_remote_spec.rb

@@ -114,6 +114,66 @@ describe RemoteAssociation, "method :belongs_to_remote" do
     end
   end
 
+  context 'with polymorphic option' do
+    before(:each) do
+      unset_const(:PolymorphicProfile)
+      unset_const(:OwnerA)
+      class OwnerA < ActiveResource::Base
+        self.site = REMOTE_HOST
+        self.element_name = "owner_a"
+      end
+      class PolymorphicProfile < ActiveRecord::Base
+        include RemoteAssociation::Base
+        belongs_to_remote :owner, polymorphic: true
+      end
+      add_polymorphic_profile(1, 1, 'owner_a', "")
+
+      body_a = [{owner_a: {id: 1, name: "The Owner A"}}].to_json
+      FakeWeb.register_uri(:get, "#{REMOTE_HOST}/owner_as.json?id%5B%5D=1", body: body_a)
+    end
+
+    it 'has polymorphic option' do
+      PolymorphicProfile.first.owner.name.should eq('The Owner A')
+    end
+
+    pending 'should prefetch remote associations of models with defaults (single request)' do
+      add_polymorphic_profile(2, 2, 'owner_a', "")
+
+      full_body = [{owner_a: {id: 1, name: "The Owner A"}}, {owner_a: {id: 2, name: "The Owner A (other)"}}].to_json
+      FakeWeb.register_uri(:get, "#{REMOTE_HOST}/owner_as.json?id%5B%5D=1&id%5B%5D=2", body: full_body)
+
+      profiles = PolymorphicProfile.scoped.includes_remote(:owner).all
+      profiles.first.owner.name.should eq('The Owner A')
+      profiles.last.owner.name.should eq('The Owner A (other)')
+    end
+  end
+
+  context "resource unavailable" do
+    subject { Profile.first.user }
+    before do
+      unset_const(:Profile)
+      class Profile < ActiveRecord::Base
+        include RemoteAssociation::Base
+        belongs_to_remote :user
+      end
+      FakeWeb.register_uri(:get, "#{REMOTE_HOST}/users.json?id%5B%5D=1", status: '404', body: '<html>
+<head><title>404 Not Found</title></head>
+<body bgcolor="white">
+<center><h1>404 Not Found</h1></center>
+<hr><center>nginx/1.6.2</center>
+</body>
+</html>')
+    end
+
+    it "not raises error" do
+      expect { subject }.to_not raise_error
+    end
+
+    it "is nil" do
+      should be_nil
+    end
+  end
+
   context "safe when using several remotes" do
     before do
       unset_const(:User)

data/spec/spec_helper.rb

@@ -42,6 +42,10 @@ def add_profile(id, user_id, like)
   ActiveRecord::Base.connection.execute("insert into \"public\".\"profiles\" (\"id\", \"user_id\", \"like\") values ( #{id}, #{user_id}, '#{like}');")
 end
 
+def add_polymorphic_profile(id, owner_id, owner_type, like)
+  ActiveRecord::Base.connection.execute("insert into \"public\".\"polymorphic_profiles\" (\"id\", \"owner_id\", \"owner_type\", \"like\") values ( #{id}, #{owner_id}, '#{owner_type}', '#{like}');")
+end
+
 REMOTE_HOST = "http://127.0.0.1:3000"
 
 def unset_const(const_name)

data/spec/tasks/db_setup.rake

@@ -1,4 +1,5 @@
 require 'active_record'
+require 'yaml'
 
 namespace :spec do
   namespace :db do
@@ -36,6 +37,17 @@ CREATE TABLE "public"."profiles" (
 WITH (OIDS=FALSE);
 ALTER TABLE "public"."profiles" OWNER TO "rails";
 
+DROP TABLE IF EXISTS "public"."polymorphic_profiles";
+
+CREATE TABLE "public"."polymorphic_profiles" (
+	"id" int4 NOT NULL,
+	"owner_id" int4,
+	"owner_type" varchar(255) NOT NULL,
+	"like" varchar(255) NOT NULL,
+	CONSTRAINT "polymorphic_profiles_pkey" PRIMARY KEY ("id") NOT DEFERRABLE INITIALLY IMMEDIATE
+)
+WITH (OIDS=FALSE);
+ALTER TABLE "public"."polymorphic_profiles" OWNER TO "rails";
 SQL
                                      )
     end
@@ -64,6 +76,3 @@ SQL
     end
   end
 end
-
-
-

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: remote_association
 version: !ruby/object:Gem::Version
-  version: 0.0.4
-  prerelease: 
+  version: 0.0.5
 platform: ruby
 authors:
 - Denis Yagofarov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-26 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -110,7 +97,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -118,7 +104,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -131,7 +116,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
-- .rvmrc
+- .ruby-gemset
+- .ruby-version
 - .travis.yml
 - Gemfile
 - Gemfile.lock
@@ -154,33 +140,26 @@ files:
 - spec/tasks/db_setup.rake
 homepage: https://github.com/denyago/remote_association
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2390194235140856121
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2390194235140856121
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.4.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Adds relations to ActiveResource models
 test_files:
 - spec/config/database.example.yml

data/.rvmrc

@@ -1,48 +0,0 @@
-#!/usr/bin/env bash
-
-# This is an RVM Project .rvmrc file, used to automatically load the ruby
-# development environment upon cd'ing into the directory
-
-# First we specify our desired <ruby>[@<gemset>], the @gemset name is optional,
-# Only full ruby name is supported here, for short names use:
-#     echo "rvm use 1.9.3" > .rvmrc
-environment_id="ruby-1.9.3-p194@remote_association"
-
-# Uncomment the following lines if you want to verify rvm version per project
-# rvmrc_rvm_version="1.14.3 (stable)" # 1.10.1 seams as a safe start
-# eval "$(echo ${rvm_version}.${rvmrc_rvm_version} | awk -F. '{print "[[ "$1*65536+$2*256+$3" -ge "$4*65536+$5*256+$6" ]]"}' )" || {
-#   echo "This .rvmrc file requires at least RVM ${rvmrc_rvm_version}, aborting loading."
-#   return 1
-# }
-
-# First we attempt to load the desired environment directly from the environment
-# file. This is very fast and efficient compared to running through the entire
-# CLI and selector. If you want feedback on which environment was used then
-# insert the word 'use' after --create as this triggers verbose mode.
-if [[ -d "${rvm_path:-$HOME/.rvm}/environments"
-  && -s "${rvm_path:-$HOME/.rvm}/environments/$environment_id" ]]
-then
-  \. "${rvm_path:-$HOME/.rvm}/environments/$environment_id"
-  [[ -s "${rvm_path:-$HOME/.rvm}/hooks/after_use" ]] &&
-    \. "${rvm_path:-$HOME/.rvm}/hooks/after_use" || true
-else
-  # If the environment file has not yet been created, use the RVM CLI to select.
-  rvm --create  "$environment_id" || {
-    echo "Failed to create RVM environment '${environment_id}'."
-    return 1
-  }
-fi
-
-# If you use bundler, this might be useful to you:
-# if [[ -s Gemfile ]] && {
-#   ! builtin command -v bundle >/dev/null ||
-#   builtin command -v bundle | GREP_OPTIONS= \grep $rvm_path/bin/bundle >/dev/null
-# }
-# then
-#   printf "%b" "The rubygem 'bundler' is not installed. Installing it now.\n"
-#   gem install bundler
-# fi
-# if [[ -s Gemfile ]] && builtin command -v bundle >/dev/null
-# then
-#   bundle install | GREP_OPTIONS= \grep -vE '^Using|Your bundle is complete'
-# fi