remarkable_activerecord 3.1.0 → 3.1.1

data/CHANGELOG

@@ -1,3 +1,8 @@
+* validate_length_of accepts :with_kind_of to enable it to work with associations [#69]
+  In your Post specs now you can write:
+
+    should_validate_length_of :comments, :maximum => 10, :with_kind_of => Comment
+
 # v3.1
 
 * Allow validate_presence_of to work with associations [#63]

data/lib/remarkable_activerecord/matchers/validate_length_of_matcher.rb

@@ -5,9 +5,10 @@ module Remarkable
         arguments :collection => :attributes, :as => :attribute
 
         optional :within, :alias => :in
-        optional :minimum, :maximum, :is
+        optional :minimum, :maximum, :is
+        optional :with_kind_of
         optional :allow_nil, :allow_blank, :default => true
-        optional :message, :too_short, :too_long, :wrong_length
+        optional :message, :too_short, :too_long, :wrong_length
 
         collection_assertions :less_than_min_length?, :exactly_min_length?,
                               :more_than_max_length?, :exactly_max_length?,
@@ -55,8 +56,14 @@ module Remarkable
             @max_value.nil? || @min_value == @max_value || good?(value_for_length(@max_value), default_message_for(:too_long))
           end
 
-          def value_for_length(value)
-            "x" * value
+          def value_for_length(value)
+            repeatable = if @options[:with_kind_of]
+              [ @options[:with_kind_of].new ]
+            else
+              "x"
+            end
+
+            repeatable * value
           end
 
           def interpolation_options
@@ -96,6 +103,13 @@ module Remarkable
       #   Regexp, string or symbol. Default = <tt>I18n.translate('activerecord.errors.messages.wrong_length') % range.last</tt>
       # * <tt>:message</tt> - value the test expects to find in <tt>errors.on(:attribute)</tt>.
       #   Regexp, string or symbol. Default = <tt>I18n.translate('activerecord.errors.messages.wrong_length') % value</tt>
+      #
+      # It also accepts an extra option called :with_kind_of. If you are validating
+      # the size of an association array, you have to specify the kind of the array
+      # being validated. For example, if your post accepts maximum 10 comments, you
+      # can do:
+      #
+      #   validate_length_of :comments, :maximum => 10, :with_kind_of => Comment
       #
       # == Gotcha
       #

data/locale/en.yml

@@ -203,7 +203,9 @@ en:
           minimum:
             positive: "is minimum {{inspect}} characters"
           is:
-            positive: "is equal to {{inspect}} characters"
+            positive: "is equal to {{inspect}} characters"
+          with_kind_of:
+            positive: "with kind of {{value}}"
 
       validate_numericality_of:
         description: "ensure numericality of {{attributes}}"

data/spec/validate_length_of_matcher_spec.rb

@@ -143,6 +143,29 @@ describe 'validate_length_of' do
       it { should define_and_validate(:is => 3).is(3)     }
       it { should_not define_and_validate(:is => 3).is(2) }
       it { should_not define_and_validate(:is => 3).is(4) }
+    end
+
+    describe "with with kind of" do
+      def define_and_validate(options)
+        define_model :variant, :product_id => :integer
+
+        @model = define_model :product do
+          has_many :variants
+          validates_length_of :variants, options
+        end
+
+        validate_length_of(:variants)
+      end
+
+      it { should define_and_validate(:within => 3..6).within(3..6).with_kind_of(Variant) }
+      it { should_not define_and_validate(:within => 2..6).within(3..6).with_kind_of(Variant) }
+      it { should_not define_and_validate(:within => 3..7).within(3..6).with_kind_of(Variant) }
+
+      it "should raise association type mismatch if with_kind_of is not supplied" do
+        lambda {
+          should_not define_and_validate(:within => 3..6).within(3..6)
+        }.should raise_error(ActiveRecord::AssociationTypeMismatch)
+      end
     end
 
     # Those are macros to test optionals which accept only boolean values

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: remarkable_activerecord
 version: !ruby/object:Gem::Version 
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors: 
 - Carlos Brando
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-04 00:00:00 +02:00
+date: 2009-05-13 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -22,7 +22,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 3.1.0
+        version: 3.1.1
     version: 
 description: "Remarkable ActiveRecord: collection of matchers and macros with I18n for ActiveRecord"
 email: