relevance-github_hook 0.5.8 → 0.6.0

data/CHANGELOG

@@ -1,4 +1,4 @@
-v0.0.6. Update for latest Github json spec
+v0.0.6. Update for latest Github json spec; maintain backwards compatibility to avoid breaking stuff
 
 v0.5.8. Prep for release
 

data/Rakefile

@@ -12,4 +12,5 @@ Echoe.new('github_hook', GithubHook::VERSION) do |p|
   rdoc_template = `allison --path`.strip << ".rb"
   p.rdoc_template = rdoc_template
   p.test_pattern = 'spec/**/*_spec.rb'
+  p.dependencies = "json"
 end

data/github_hook.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |s|
   s.name = %q{github_hook}
-  s.version = "0.5.8"
+  s.version = "0.6.0"
 
   s.required_rubygems_version = Gem::Requirement.new("= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Rob Sanheim"]
-  s.date = %q{2008-07-30}
+  s.date = %q{2008-08-05}
   s.description = %q{Wrapper around the github post receive JSON payload.}
   s.email = %q{opensource@thinkrelevance.com}
   s.extra_rdoc_files = ["CHANGELOG", "lib/github_hook.rb", "README.txt"]
@@ -23,11 +23,14 @@ Gem::Specification.new do |s|
     s.specification_version = 2
 
     if current_version >= 3 then
+      s.add_runtime_dependency(%q<json>, [">= 0"])
       s.add_development_dependency(%q<echoe>, [">= 0"])
     else
+      s.add_dependency(%q<json>, [">= 0"])
       s.add_dependency(%q<echoe>, [">= 0"])
     end
   else
+    s.add_dependency(%q<json>, [">= 0"])
     s.add_dependency(%q<echoe>, [">= 0"])
   end
 end

data/lib/github_hook.rb

@@ -1,8 +1,9 @@
+require 'rubygems'
 require 'json'
 require 'ostruct'
 
 class GithubHook
-  VERSION = '0.5.8'
+  VERSION = '0.6.0'
   attr_reader :before, :after, :ref, :repository, :owner, :commits
 
   def initialize(json)
@@ -10,17 +11,27 @@ class GithubHook
     @before, @after, @ref = payload["before"], payload["after"], payload["ref"]
     @repository = OpenStruct.new(payload["repository"])
     @owner = OpenStruct.new(payload["repository"]["owner"])
-    @commits = payload['commits'].map do |hash|
+    @commits = create_commits(payload)
+  end
+  
+  def create_commits(payload)
+    payload['commits'].map do |hash|
       commit_ostruct = OpenStruct.new(hash)
       commit_ostruct.sha = hash["id"]
       commit_ostruct.author = OpenStruct.new(hash["author"])
       commit_ostruct
     end
+  rescue NoMethodError
+    payload['commits'].map do |sha, hash|
+      commit_ostruct = OpenStruct.new(hash)
+      commit_ostruct.sha = sha
+      commit_ostruct.author = OpenStruct.new(hash["author"])
+      commit_ostruct
+    end
   end
   
-  # just the most recent commit
   def last_commit
-    @commits.first
+    @commits.sort_by { |commit| commit.timestamp }.last
   end
   
 end

data/spec/github_hook_spec.rb

@@ -1,51 +1,82 @@
 require File.join(File.dirname(__FILE__), *%w[helper])
 
 describe GithubHook do
-  before { @pc = GithubHook.new(PayloadAfterJuly30)}
 
-  it "should have repo" do
-    repository = @pc.repository
-    repository.url.should ==  "http://github.com/defunkt/github"
-    repository.name.should == "github"
-  end
+  describe "old format" do
+    before { @pc = GithubHook.new(PayloadBeforeJuly30)}
+    
+    it "has an array of commit objects" do
+      commits = @pc.commits
+      commits[0].sha.should == "de8251ff97ee194a289832576287d6f8ad74e3d0"
+      commits[1].sha.should == "41a212ee83ca127e3c8cf465891ab7216a705f59"
+    end
 
-  it "has reference to branch" do
-    @pc.ref.should == "refs/heads/master"
-  end
+    it "has commit values" do
+      commit = @pc.commits.first
+      commit.url.should == "http://github.com/defunkt/github/commit/de8251ff97ee194a289832576287d6f8ad74e3d0"
+      commit.message.should == "update pricing a tad"
+      commit.timestamp.should == "2008-02-15T14:36:34-08:00" 
+    end
 
-  it "has before and after tag" do
-    @pc.before.should == "5aef35982fb2d34e9d9d4502f6ede1072793222d"
-    @pc.after.should == "de8251ff97ee194a289832576287d6f8ad74e3d0"
-  end
+    it "has commit author" do
+      author = @pc.commits.first.author
+      author.name.should == "Chris Wanstrath"
+      author.email.should == "chris@ozmm.org"
+    end
 
-  it "has owner" do
-    owner = @pc.owner
-    owner.email.should == "chris@ozmm.org"
-    owner.name.should == "defunkt"
+    it "has last commit" do
+      @pc.last_commit.sha.should == "41a212ee83ca127e3c8cf465891ab7216a705f59"
+    end
   end
+  
+  describe "new format" do
+    before { @pc = GithubHook.new(PayloadAfterJuly30)}
+    
+    it "should have repo" do
+      repository = @pc.repository
+      repository.url.should ==  "http://github.com/defunkt/github"
+      repository.name.should == "github"
+    end
 
-  it "has an array of commit objects" do
-    commits = @pc.commits
-    commits[0].sha.should == "41a212ee83ca127e3c8cf465891ab7216a705f59"
-    commits[1].sha.should == "de8251ff97ee194a289832576287d6f8ad74e3d0"
-  end
+    it "has reference to branch" do
+      @pc.ref.should == "refs/heads/master"
+    end
 
-  it "has commit values" do
-    commit = @pc.commits.first
-    commit.url.should == "http://github.com/defunkt/github/commit/41a212ee83ca127e3c8cf465891ab7216a705f59"
-    commit.message.should == "okay i give in"
-    commit.timestamp.should == "2008-02-15T14:57:17-08:00"
-  end
+    it "has before and after tag" do
+      @pc.before.should == "5aef35982fb2d34e9d9d4502f6ede1072793222d"
+      @pc.after.should == "de8251ff97ee194a289832576287d6f8ad74e3d0"
+    end
 
-  it "has commit author" do
-    author = @pc.commits.first.author
-    author.name.should == "Chris Wanstrath"
-    author.email.should == "chris@ozmm.org"
-  end
+    it "has owner" do
+      owner = @pc.owner
+      owner.email.should == "chris@ozmm.org"
+      owner.name.should == "defunkt"
+    end
 
-  it "has last commit" do
-    @pc.last_commit.should == @pc.commits.first
-  end
+    it "has an array of commit objects" do
+      commits = @pc.commits
+      commits[0].sha.should == "41a212ee83ca127e3c8cf465891ab7216a705f59"
+      commits[1].sha.should == "de8251ff97ee194a289832576287d6f8ad74e3d0"
+    end
+
+    it "has commit values" do
+      commit = @pc.commits.first
+      commit.url.should == "http://github.com/defunkt/github/commit/41a212ee83ca127e3c8cf465891ab7216a705f59"
+      commit.message.should == "okay i give in"
+      commit.timestamp.should == "2008-02-15T14:57:17-08:00"
+    end
 
+    it "has commit author" do
+      author = @pc.commits.first.author
+      author.name.should == "Chris Wanstrath"
+      author.email.should == "chris@ozmm.org"
+    end
+
+    it "has last commit" do
+      @pc.last_commit.sha.should == "41a212ee83ca127e3c8cf465891ab7216a705f59"
+    end
+    
+  end
+  
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: relevance-github_hook
 version: !ruby/object:Gem::Version 
-  version: 0.5.8
+  version: 0.6.0
 platform: ruby
 authors: 
 - Rob Sanheim
@@ -9,9 +9,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-07-30 00:00:00 -07:00
+date: 2008-08-05 00:00:00 -07:00
 default_executable: 
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: json
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+    version: 
 - !ruby/object:Gem::Dependency 
   name: echoe
   version_requirement: