relaton-itu 1.7.3 → 1.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 971645ffb5b0111df7d841c47f6ac1a64904cc85274218f2f6ff622dbba3b576
-  data.tar.gz: 68bc7e0bbb844896c7bf30c6d3e5747a9d6f0e68aa9384f9e761f2881f3be2bc
+  metadata.gz: cd478e1103e026b9ff40937a19dccc0166da6f839fc2fb216a59ac306b4958f1
+  data.tar.gz: 12bc7a7304aadb7ea91df2bc618b49ef1333ea58d577c760e9273c955fd5fd01
 SHA512:
-  metadata.gz: 83a9d8ee974bfe44cad5715db0199dfcf1eec9709d2a1d778d08cdc21379a69063bb6d6f0ee818b962f825c684d680bb4dda5cbba9b0ca48b24dc8dde4876cdd
-  data.tar.gz: 96a7cf63dd9ff84a115959d7766544e8d8f5f1328fa976737875b7808152939f1168e6a1644e0eb5e4af5cd22f6077b232cf45968e6945bc1a86d2a7721f8e19
+  metadata.gz: a4ee1c7e0c5ff26729f598b744035e8ebbf285703f04da910a978d38f3e3a9dc44f9e76d4bc17e6257e443b953c5dd218526305bd95106af410ddbcc667db83f
+  data.tar.gz: b10b5dc734cfed86b6653e8d0f56257ac52a4e06718c30a9256897eecd11a03642ded7820cf7d9797d2c3c7731ccc093035b6e7a7ab4477b6787f120449ca494

data/.github/workflows/rake.yml

@@ -0,0 +1,46 @@
+# Auto-generated by Cimas: Do not edit it manually!
+# See https://github.com/metanorma/cimas
+name: rake
+
+on:
+  push:
+    branches: [ master, main ]
+    tags: [ v* ]
+  pull_request:
+
+jobs:
+  rake:
+    name: Test on Ruby ${{ matrix.ruby }} ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    continue-on-error: ${{ matrix.experimental }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ '2.7', '2.6', '2.5', '2.4' ]
+        os: [ ubuntu-latest, windows-latest, macos-latest ]
+        experimental: [ false ]
+        include:
+          - ruby: '3.0'
+            os: 'ubuntu-latest'
+            experimental: true
+          - ruby: '3.0'
+            os: 'windows-latest'
+            experimental: true
+          - ruby: '3.0'
+            os: 'macos-latest'
+            experimental: true
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+
+      # https://github.com/ruby-debug/debase/issues/89#issuecomment-686827382
+      - if: matrix.os == 'macos-latest' && matrix.ruby == '2.5'
+        run: echo BUNDLE_BUILD__DEBASE="--with-cflags=\"-Wno-error=implicit-function-declaration\"" >> $GITHUB_ENV
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - run: bundle exec rake

data/README.adoc

@@ -97,6 +97,29 @@ RelatonItu::ItuBibliography.get "ITU-T G.989.2/Amd 1"
 ...
 ----
 
+=== Get ITU-R documents
+
+[source,ruby]
+----
+RelatonItu::ItuBibliography.get "ITU-R REC-BO.600-1"
+[relaton-itu] ("ITU-R REC-BO.600-1") fetching...
+[relaton-itu] ("ITU-R REC-BO.600-1") found R-REC-BO.600-1
+=> #<RelatonItu::ItuBibliographicItem:0x007f84e9930498
+...
+----
+
+=== Get ITU-R Radio Regulations (RR)
+
+[source,ruby]
+----
+RelatonItu::ItuBibliography.get 'ITU-R RR (2020)'
+[relaton-itu] ("ITU-R RR") fetching...
+[relaton-itu] WARNING: invalid doctype: publication
+[relaton-itu] ("ITU-R RR") found ITU-R RR
+=> #<RelatonItu::ItuBibliographicItem:0x007fb4b55eb660
+...
+----
+
 === Create bibliographic item form YAML
 [source,ruby]
 ----

data/lib/relaton_itu/editorial_group.rb

@@ -20,7 +20,7 @@ module RelatonItu
         warn "[relaton-itu] WARNING: invalid bureau: #{bureau}"
       end
       @bureau = bureau
-      @group = group.is_a?(Hash) ? ItuGroup.new(group) : group
+      @group = group.is_a?(Hash) ? ItuGroup.new(**group) : group
       @subgroup = subgroup.is_a?(Hash) ? ItuGroup.new(subgroup) : subgroup
       @workgroup = workgroup.is_a?(Hash) ? ItuGroup.new(workgroup) : workgroup
     end

data/lib/relaton_itu/hash_converter.rb

@@ -7,7 +7,7 @@ module RelatonItu
         eg = ret[:editorialgroup]
         return unless eg
 
-        ret[:editorialgroup] = EditorialGroup.new eg
+        ret[:editorialgroup] = EditorialGroup.new **eg
       end
 
       # @param ret [Hash]
@@ -15,7 +15,7 @@ module RelatonItu
         return unless ret[:structuredidentifier]
 
         ret[:structuredidentifier] = StructuredIdentifier.new(
-          ret[:structuredidentifier]
+          **ret[:structuredidentifier]
         )
       end
     end

data/lib/relaton_itu/hit.rb

@@ -3,6 +3,8 @@
 module RelatonItu
   # Hit.
   class Hit < RelatonBib::Hit
+    attr_writer :fetch
+
     # Parse page.
     # @return [RelatonItu::ItuBibliographicItem]
     def fetch

data/lib/relaton_itu/hit_collection.rb

@@ -14,23 +14,35 @@ module RelatonItu
 
     # @param ref [String]
     # @param year [String]
-    def initialize(ref, year = nil)
+    def initialize(ref, year = nil) # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
       text = ref.sub /(?<=\.)Imp\s?(?=\d)/, ""
       super text, year
       @gi_imp = /\.Imp\d/.match?(ref)
-      uri = URI "#{DOMAIN}/net4/ITU-T/search/GlobalSearch/Search"
-      data = { json: params.to_json }
-      resp = Net::HTTP.post(uri, data.to_json,
-                            "Content-Type" => "application/json")
-      @array = hits JSON.parse(resp.body)
+      if ref.match? /^(ITU-T|ITU-R\sRR)/
+        uri = URI "#{DOMAIN}/net4/ITU-T/search/GlobalSearch/Search"
+        data = { json: params.to_json }
+        resp = Net::HTTP.post(uri, data.to_json,
+                              "Content-Type" => "application/json")
+        @array = hits JSON.parse(resp.body)
+      elsif ref.match? /^ITU-R/
+        rf = ref.sub(/^ITU-R\s/, "").upcase
+        url = "https://raw.githubusercontent.com/relaton/relaton-data-itu-r/master/data/#{rf}.yaml"
+        hash = YAML.safe_load Net::HTTP.get(URI(url))
+        item_hash = HashConverter.hash_to_bib(hash)
+        item = ItuBibliographicItem.new **item_hash
+        hit = Hit.new({ url: url }, self)
+        hit.fetch = item
+        @array = [hit]
+      end
     end
 
     private
 
     # @return [String]
     def group
-      @group ||= if %r{OB|Operational Bulletin}.match? text then "Publications"
-                 else "Recommendations"
+      @group ||= case text
+                 when %r{OB|Operational Bulletin}, %r{^ITU-R\sRR} then "Publications"
+                 when %r{^ITU-T} then "Recommendations"
                  end
     end
 
@@ -46,7 +58,7 @@ module RelatonItu
         "ExactPhrase" => false,
         "CollectionName" => "General",
         "CollectionGroup" => group,
-        "Sector" => "t",
+        "Sector" => text.match(/(?<=^ITU-)\w/).to_s.downcase,
         "Criterias" => [{
           "Name" => "Search in",
           "Criterias" => [

data/lib/relaton_itu/itu_bibliography.rb

@@ -32,7 +32,7 @@ module RelatonItu
       # @return [String] Relaton XML serialisation of reference
       def get(code, year = nil, opts = {}) # rubocop:disable Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
         if year.nil?
-          /^(?<code1>[^\s]+\s[^\s]+)\s\(\d{2}\/(?<year1>\d+)\)$/ =~ code
+          /^(?<code1>[^\s]+\s[^\s]+)\s\((\d{2}\/)?(?<year1>\d+)\)$/ =~ code
           unless code1.nil?
             code = code1
             year = year1
@@ -54,9 +54,11 @@ module RelatonItu
         id = year ? "#{code}:#{year}" : code
         warn "[relaton-itu] WARNING: no match found online for #{id}. "\
           "The code must be exactly like it is on the standards website."
-        warn "[relaton-itu] (There was no match for #{year}, though there were matches "\
-          "found for #{missed_years.join(', ')}.)" unless missed_years.empty?
-        if /\d-\d/ =~ code
+        unless missed_years.empty?
+          warn "[relaton-itu] (There was no match for #{year}, though there were matches "\
+            "found for #{missed_years.join(', ')}.)"
+        end
+        if /\d-\d/.match? code
           warn "[relaton-itu] The provided document part may not exist, or the document "\
             "may no longer be published in parts."
         else
@@ -82,6 +84,8 @@ module RelatonItu
         result = search(code)
         code1.sub! /(?<=\.)Imp(?=\d)/, "" if result.gi_imp
         result.select do |i|
+          next true unless i.hit[:code]
+
           %r{
             ^(?<pref2>ITU)?(-(?<type2>\w))?\s?(?<code2>[\S]+)
             (\s\(((?<month2>\d{2})\/)?(?<year2>\d{4})\))?
@@ -94,8 +98,6 @@ module RelatonItu
             (!year || year == year2) && (!month1 || month1 == month2) &&
             corr1 == corr2 && (!coryear1 || coryear1 == coryear2) &&
             buldate1 == buldate2 && (!cormonth1 || cormonth1 == cormonth2)
-          # i.hit[:code] &&
-          #   i.hit[:code].match(docidrx).to_s == c
         end
       end
 
@@ -108,10 +110,10 @@ module RelatonItu
       def isobib_results_filter(result, year)
         missed_years = []
         result.each do |r|
-          return { ret: r.fetch } if !year
-
-          /\(\d{2}\/(?<pyear>\d{4})\)/ =~ r.hit[:code]
-          return { ret: r.fetch } if year == pyear
+          if !year || /\((\d{2}\/)?(?<pyear>\d{4})\)/ =~ r.hit[:code]
+            ret = r.fetch
+            return { ret: ret } if ret
+          end
 
           missed_years << pyear
         end

data/lib/relaton_itu/itu_group.rb

@@ -63,7 +63,7 @@ module RelatonItu
       @type = type
       @name = name
       @acronym = acronym
-      @period = period.is_a?(Hash) ? Period.new(period) : period
+      @period = period.is_a?(Hash) ? Period.new(**period) : period
     end
 
     # @param builder [Nokogiri::XML::Builder]

data/lib/relaton_itu/scrapper.rb

@@ -31,6 +31,8 @@ module RelatonItu
       # @return [Hash]
       def parse_page(hit_data, imp = false)
         url, doc = get_page hit_data[:url]
+        return unless doc
+
         if imp
           a = doc.at "//span[contains(@id, 'tab_ig_uc_rec')]/a"
           return unless a
@@ -69,17 +71,19 @@ module RelatonItu
       # Fetch abstracts.
       # @param doc [Nokigiri::HTML::Document]
       # @return [Array<Array>]
-      def fetch_abstract(doc)
+      def fetch_abstract(doc) # rubocop:disable Metrics/AbcSize
         abstract_url = doc.at('//table/tr/td/span[contains(@id, "lbl_dms")]/div')
-        return [] unless abstract_url
-
-        url = abstract_url[:onclick].match(/https?[^']+/).to_s
-        d = Nokogiri::HTML Net::HTTP.get(URI(url)).encode(undef: :replace, replace: "")
-        abstract_content = d.css("p.MsoNormal").text.gsub(/\r\n/, "")
-          .squeeze(" ").gsub(/\u00a0/, "")
+        content = if abstract_url
+                    url = abstract_url[:onclick].match(/https?[^']+/).to_s
+                    d = Nokogiri::HTML Net::HTTP.get(URI(url)).encode(undef: :replace, replace: "")
+                    d.css("p.MsoNormal").text.gsub(/\r\n/, "").squeeze(" ").gsub(/\u00a0/, "")
+                  elsif a = doc.at('//table/tr/td/span[contains(@class, "observation")]/text()')
+                    a.text.strip
+                  end
+        return [] unless content
 
         [{
-          content: abstract_content,
+          content: content,
           language: "en",
           script: "Latn",
         }]
@@ -92,6 +96,8 @@ module RelatonItu
         uri = URI url
         resp = Net::HTTP.get_response(uri)
         until resp.code == "200"
+          return if resp["location"] == "/en/publications/pages/notfound.aspx"
+
           uri = URI resp["location"] if resp.code.match? /^30/
           resp = Net::HTTP.get_response(uri)
         end
@@ -117,13 +123,13 @@ module RelatonItu
         docids
       end
 
-      def createdocid(text)
+      def createdocid(text) # rubocop:disable Metrics/MethodLength
         %r{
           ^(?<code>((ITU-\w|ISO\/IEC)\s)?[^\(:]+)
-          (\(((?<month>\d{2})\/)?(?<year>\d{4})\))?
+          (\(((?<_month>\d{2})\/)?(?<_year>\d{4})\))?
           (:[^\(]+\((?<buldate>\d{2}\.\w{1,4}\.\d{4})\))?
           (\s(?<corr>(Amd|Cor)\.\s?\d+))?
-          # (\s\(((?<cormonth>\d{2})\/)?(?<coryear>\d{4})\))?
+          # (\s\(((?<_cormonth>\d{2})\/)?(?<_coryear>\d{4})\))?
         }x =~ text.squeeze(" ")
         corr&.sub! /\.\s?/, " "
         id = [code.sub(/[[:space:]]$/, ""), corr].compact.join "/"
@@ -204,13 +210,15 @@ module RelatonItu
       # Fetch dates
       # @param doc [Nokogiri::HTML::Document]
       # @return [Array<Hash>]
-      def fetch_dates(doc) # rubocop:disable Metrics/CyclomaticComplexity
+      def fetch_dates(doc) # rubocop:disable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
         dates = []
         date = doc.at("//table/tr/td/span[contains(@id, 'Label5')]",
                       "//p[contains(.,'Approved in')]")
         pdate = date&.text&.match(/\d{4}-\d{2}-\d{2}/).to_s || ob_date(doc)
         if pdate && !pdate&.empty?
           dates << { type: "published", on: pdate }
+        elsif pdate = ob_date(doc)
+          dates << { type: "published", on: pdate }
         end
         dates
       end
@@ -222,7 +230,7 @@ module RelatonItu
         pdate = doc.at('//table/tbody/tr/td[contains(text(), "Year:")]')
         return unless pdate
 
-        roman_to_arabic pdate.text.match(%r{(?<=Year: )\d{2}.\w+.\d{4}}).to_s
+        roman_to_arabic pdate.text.match(%r{(?<=Year: )(\d{2}.\w+.)?\d{4}}).to_s
       end
 
       # Convert roman month number in string date to arabic number
@@ -230,8 +238,11 @@ module RelatonItu
       # @return [String]
       def roman_to_arabic(date)
         %r{(?<rmonth>[IVX]+)} =~ date
-        month = ROMAN_MONTHS.index(rmonth) + 1
-        Date.parse(date.sub(%r{[IVX]+}, month.to_s)).to_s
+        if ROMAN_MONTHS.index(rmonth)
+          month = ROMAN_MONTHS.index(rmonth) + 1
+          Date.parse(date.sub(%r{[IVX]+}, month.to_s)).to_s
+        else date
+        end
       end
 
       # Fetch contributors

data/lib/relaton_itu/version.rb

@@ -1,3 +1,3 @@
 module RelatonItu
-  VERSION = "1.7.3".freeze
+  VERSION = "1.7.4".freeze
 end

data/lib/relaton_itu/xml_parser.rb

@@ -8,7 +8,7 @@ module RelatonItu
       # @param item_hash [Hash]
       # @return [RelatonItu::ItuBibliographicItem]
       def bib_item(item_hash)
-        ItuBibliographicItem.new item_hash
+        ItuBibliographicItem.new **item_hash
       end
 
       # @param ext [Nokogiri::XML::Element]

data/relaton-itu.gemspec

@@ -26,12 +26,12 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
 
-  spec.add_development_dependency "debase"
+  # spec.add_development_dependency "debase"
   spec.add_development_dependency "equivalent-xml", "~> 0.6"
   spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "ruby-debug-ide"
+  # spec.add_development_dependency "ruby-debug-ide"
   spec.add_development_dependency "ruby-jing"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "vcr", "~> 5.0.0"

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: relaton-itu
 version: !ruby/object:Gem::Version
-  version: 1.7.3
+  version: 1.7.4
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-04 00:00:00.000000000 Z
+date: 2021-03-18 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: debase
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: equivalent-xml
   requirement: !ruby/object:Gem::Requirement
@@ -80,20 +66,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: ruby-debug-ide
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby-jing
   requirement: !ruby/object:Gem::Requirement
@@ -172,9 +144,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/workflows/macos.yml"
-- ".github/workflows/ubuntu.yml"
-- ".github/workflows/windows.yml"
+- ".github/workflows/rake.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"

data/.github/workflows/macos.yml

@@ -1,34 +0,0 @@
-# Auto-generated by Cimas: Do not edit it manually!
-# See https://github.com/metanorma/cimas
-name: macos
-
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ '**' ]
-
-jobs:
-  test-macos:
-    name: Test on Ruby ${{ matrix.ruby }} macOS
-    runs-on: macos-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby: [ '2.6', '2.5', '2.4' ]
-    steps:
-      - uses: actions/checkout@master
-      - name: Use Ruby
-        uses: actions/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          architecture: 'x64'
-      - name: Update gems
-        run: |
-          sudo gem install bundler --force
-          ruby -v | grep 2.5 && bundle config set build.debase --with-cflags="-Wno-error=implicit-function-declaration"
-          ruby -v | grep 2.5 && bundle config set build.ruby-debug-ide --with-cflags="-Wno-error=implicit-function-declaration"
-          bundle install --jobs 4 --retry 3
-      - name: Run specs
-        run: |
-          bundle exec rake

data/.github/workflows/ubuntu.yml

@@ -1,33 +0,0 @@
-# Auto-generated by Cimas: Do not edit it manually!
-# See https://github.com/metanorma/cimas
-name: ubuntu
-
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ '**' ]
-
-jobs:
-  test-linux:
-    name: Test on Ruby ${{ matrix.ruby }} Ubuntu
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby: [ '2.6', '2.5', '2.4' ]
-    steps:
-      - uses: actions/checkout@master
-      - name: Use Ruby
-        uses: actions/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          architecture: 'x64'
-      - name: Update gems
-        run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
-      - name: Run specs
-        run: |
-          unset JAVA_TOOL_OPTIONS
-          bundle exec rake

data/.github/workflows/windows.yml

@@ -1,35 +0,0 @@
-# Auto-generated by Cimas: Do not edit it manually!
-# See https://github.com/metanorma/cimas
-name: windows
-
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ '**' ]
-
-jobs:
-  test-windows:
-    name: Test on Ruby ${{ matrix.ruby }} Windows
-    runs-on: windows-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby: [ '2.6', '2.5', '2.4' ]
-    steps:
-      - uses: actions/checkout@master
-      - name: Use Ruby
-        uses: actions/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          architecture: 'x64'
-      - name: Update gems
-        shell: pwsh
-        run: |
-          gem install bundler
-          bundle config --local path vendor/bundle
-          bundle update
-          bundle install --jobs 4 --retry 3
-      - name: Run specs
-        run: |
-          bundle exec rake