relaton-iso-bib 1.8.1 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d78e904143a4ec066e6be9a6c1ab261567ef2c19c490562c4ba630018b1e08a
-  data.tar.gz: f51466e6bca101168d888da8f39b700f7c51bf1df5190b1b149f134ee6e185f4
+  metadata.gz: 8a2758475cec25c3c0550c1416f9c2a0ca31434a9ad64bdd20b34bec8c4fd82e
+  data.tar.gz: '0949b8e51c7df831207611ef56a1d65967a140335781b9184b837a849f377c1b'
 SHA512:
-  metadata.gz: a2d969777e4aaf36149c4308a98d78b9eb7edcb54277cf1e8af5d9f89790e1118bda9c71f17a4dfcacd86885f64686f8057e920e207d2e9462a8948ae45e9167
-  data.tar.gz: 1f80ba255e507e5b9e521e874a48e4d53f101efb6c42056913200c3708d39d8e8be07fda06bbb3993ff0343f35bd4bd1001ae14dbdf4fcc5b71d31c1b98b0a88
+  metadata.gz: ea108dbdd61b94fd973b5530bed8aa637cbe2da4c1ea99845d4280d771a11c522652b879e67438822d80a0198075a25c8b04352f7a0ae70af338e63547a15f09
+  data.tar.gz: 0b0e78dcd9728b5e1e1590b9b8fe0d4cbfc9ddfcb9b7a31e23a9df6be071b81f88d5f59cd5ee1ba7e99d9684d7d06dedeb06c6592a9daf02a724d7fac9117510

data/.github/workflows/rake.yml

@@ -16,19 +16,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ '2.7', '2.6', '2.5', '2.4' ]
+        ruby: [ '3.0', '2.7', '2.6', '2.5' ]
         os: [ ubuntu-latest, windows-latest, macos-latest ]
         experimental: [ false ]
-        include:
-          - ruby: '3.0'
-            os: 'ubuntu-latest'
-            experimental: true
-          - ruby: '3.0'
-            os: 'windows-latest'
-            experimental: true
-          - ruby: '3.0'
-            os: 'macos-latest'
-            experimental: true
     steps:
       - uses: actions/checkout@v2
         with:

data/.rubocop.yml

@@ -5,6 +5,6 @@
 inherit_from:
   - https://raw.githubusercontent.com/riboseinc/oss-guides/master/ci/rubocop.yml
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
 Rails:
   Enabled: false

data/bin/rspec

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

data/grammars/biblio.rng

@@ -787,6 +787,7 @@
       <value>adapted</value>
       <value>vote-started</value>
       <value>vote-ended</value>
+      <value>announced</value>
     </choice>
   </define>
   <define name="bdate">

data/grammars/isodoc.rng

@@ -45,6 +45,11 @@
         <optional>
           <attribute name="alt"/>
         </optional>
+        <optional>
+          <attribute name="updatetype">
+            <data type="boolean"/>
+          </attribute>
+        </optional>
         <text/>
       </element>
     </define>
@@ -199,6 +204,18 @@
         </zeroOrMore>
       </element>
     </define>
+    <define name="dt">
+      <element name="dt">
+        <optional>
+          <attribute name="id">
+            <data type="ID"/>
+          </attribute>
+        </optional>
+        <zeroOrMore>
+          <ref name="TextElement"/>
+        </zeroOrMore>
+      </element>
+    </define>
     <define name="example">
       <element name="example">
         <attribute name="id">
@@ -543,6 +560,9 @@
     </define>
     <define name="BibDataExtensionType">
       <ref name="doctype"/>
+      <optional>
+        <ref name="docsubtype"/>
+      </optional>
       <optional>
         <ref name="editorialgroup"/>
       </optional>
@@ -890,6 +910,14 @@
     </define>
   </include>
   <!-- end overrides -->
+  <define name="docsubtype">
+    <element name="subdoctype">
+      <ref name="DocumentSubtype"/>
+    </element>
+  </define>
+  <define name="DocumentSubtype">
+    <text/>
+  </define>
   <define name="colgroup">
     <element name="colgroup">
       <oneOrMore>
@@ -939,7 +967,34 @@
   <define name="concept">
     <element name="concept">
       <optional>
-        <attribute name="term"/>
+        <attribute name="ital">
+          <data type="boolean"/>
+        </attribute>
+      </optional>
+      <optional>
+        <attribute name="ref">
+          <data type="boolean"/>
+        </attribute>
+      </optional>
+      <optional>
+        <element name="refterm">
+          <zeroOrMore>
+            <choice>
+              <ref name="PureTextElement"/>
+              <ref name="stem"/>
+            </choice>
+          </zeroOrMore>
+        </element>
+      </optional>
+      <optional>
+        <element name="renderterm">
+          <zeroOrMore>
+            <choice>
+              <ref name="PureTextElement"/>
+              <ref name="stem"/>
+            </choice>
+          </zeroOrMore>
+        </element>
       </optional>
       <choice>
         <ref name="eref"/>
@@ -965,6 +1020,9 @@
       </attribute>
       <attribute name="name"/>
       <attribute name="action"/>
+      <optional>
+        <attribute name="class"/>
+      </optional>
       <zeroOrMore>
         <choice>
           <ref name="TextElement"/>
@@ -1191,13 +1249,17 @@
   </define>
   <define name="IsoWorkgroup">
     <optional>
-      <attribute name="number">
-        <data type="int"/>
-      </attribute>
+      <attribute name="number"/>
     </optional>
     <optional>
       <attribute name="type"/>
     </optional>
+    <optional>
+      <attribute name="identifier"/>
+    </optional>
+    <optional>
+      <attribute name="prefix"/>
+    </optional>
     <text/>
   </define>
   <define name="ics">
@@ -1459,26 +1521,26 @@
     <optional>
       <ref name="section-title"/>
     </optional>
-    <group>
+    <choice>
       <choice>
         <group>
-          <zeroOrMore>
+          <oneOrMore>
             <ref name="BasicBlock"/>
-          </zeroOrMore>
+          </oneOrMore>
           <zeroOrMore>
             <ref name="note"/>
           </zeroOrMore>
         </group>
         <ref name="amend"/>
       </choice>
-      <zeroOrMore>
+      <oneOrMore>
         <choice>
           <ref name="clause-subsection"/>
           <ref name="terms"/>
           <ref name="definitions"/>
         </choice>
-      </zeroOrMore>
-    </group>
+      </oneOrMore>
+    </choice>
   </define>
   <define name="Annex-Section">
     <optional>

data/grammars/isostandard.rng

@@ -38,6 +38,9 @@
     </define>
     <define name="BibDataExtensionType">
       <ref name="doctype"/>
+      <optional>
+        <ref name="docsubtype"/>
+      </optional>
       <optional>
         <ref name="horizontal"/>
       </optional>
@@ -98,7 +101,11 @@
           <ref name="definitions"/>
         </optional>
         <oneOrMore>
-          <ref name="clause"/>
+          <choice>
+            <ref name="clause"/>
+            <ref name="term-clause"/>
+            <ref name="terms"/>
+          </choice>
         </oneOrMore>
       </element>
     </define>
@@ -133,7 +140,7 @@
       <optional>
         <ref name="section-title"/>
       </optional>
-      <group>
+      <choice>
         <choice>
           <group>
             <oneOrMore>
@@ -148,7 +155,7 @@
         <oneOrMore>
           <ref name="clause-subsection"/>
         </oneOrMore>
-      </group>
+      </choice>
     </define>
     <define name="term">
       <element name="term">
@@ -259,6 +266,14 @@
         <value>directive</value>
       </choice>
     </define>
+    <define name="DocumentSubtype">
+      <choice>
+        <value>specification</value>
+        <value>method-of-test</value>
+        <value>vocabulary</value>
+        <value>code-of-practice</value>
+      </choice>
+    </define>
     <define name="structuredidentifier">
       <element name="structuredidentifier">
         <optional>

data/lib/relaton_iso_bib/editorial_group.rb

@@ -35,13 +35,13 @@ module RelatonIsoBib
     # @param secretariat [String, NilClass]
     def initialize(technical_committee:, **args) # rubocop:disable Metrics/CyclomaticComplexity,Metrics/AbcSize
       @technical_committee = technical_committee.map do |tc|
-        tc.is_a?(Hash) ? IsoSubgroup.new(**tc) : tc
+        tc.is_a?(Hash) ? RelatonBib::WorkGroup.new(**tc) : tc
       end
       @subcommittee = args.fetch(:subcommittee, []).map do |sc|
-        sc.is_a?(Hash) ? IsoSubgroup.new(**sc) : sc
+        sc.is_a?(Hash) ? RelatonBib::WorkGroup.new(**sc) : sc
       end
       @workgroup = args.fetch(:workgroup, []).map do |wg|
-        wg.is_a?(Hash) ? IsoSubgroup.new(**wg) : wg
+        wg.is_a?(Hash) ? RelatonBib::WorkGroup.new(**wg) : wg
       end
       @secretariat = args[:secretariat]
     end
@@ -86,7 +86,7 @@ module RelatonIsoBib
     # @param prefix [String]
     # @return [String]
     def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-      pref = prefix.empty? ? prefix : prefix + "."
+      pref = prefix.empty? ? prefix : "#{prefix}."
       pref += "editorialgroup"
       out = ""
       technical_committee.each do |tc|
@@ -105,48 +105,48 @@ module RelatonIsoBib
   end
 
   # ISO subgroup.
-  class IsoSubgroup
-    # @return [String, NilClass]
-    attr_reader :type
-
-    # @return [Integer, NilClass]
-    attr_reader :number
-
-    # @return [String]
-    attr_reader :name
-
-    # @param name [String]
-    # @param type [String, NilClass]
-    # @param number [Integer, NilClass]
-    def initialize(name:, type: nil, number: nil)
-      @name   = name
-      @type   = type
-      @number = number
-    end
-
-    # @param builder [Nokogiri::XML::Builder]
-    def to_xml(builder)
-      builder.parent[:number] = number if number
-      builder.parent[:type] = type if type
-      builder.text name
-    end
-
-    # @return [Hash]
-    def to_hash
-      hash = { "name" => name }
-      hash["type"] = type if type
-      hash["number"] = number if number
-      hash
-    end
-
-    # @param prefix [String]
-    # @param count [Integer] number of the elements
-    def to_asciibib(prefix, count = 1)
-      out = count > 1 ? "#{prefix}::\n" : ""
-      out += "#{prefix}.type:: #{type}\n" if type
-      out += "#{prefix}.number:: #{number}\n" if number
-      out += "#{prefix}.name:: #{name}\n"
-      out
-    end
-  end
+  # class IsoSubgroup
+  #   # @return [String, NilClass]
+  #   attr_reader :type
+
+  #   # @return [Integer, NilClass]
+  #   attr_reader :number
+
+  #   # @return [String]
+  #   attr_reader :name
+
+  #   # @param name [String]
+  #   # @param type [String, NilClass]
+  #   # @param number [Integer, NilClass]
+  #   def initialize(name:, type: nil, number: nil)
+  #     @name   = name
+  #     @type   = type
+  #     @number = number
+  #   end
+
+  #   # @param builder [Nokogiri::XML::Builder]
+  #   def to_xml(builder)
+  #     builder.parent[:number] = number if number
+  #     builder.parent[:type] = type if type
+  #     builder.text name
+  #   end
+
+  #   # @return [Hash]
+  #   def to_hash
+  #     hash = { "name" => name }
+  #     hash["type"] = type if type
+  #     hash["number"] = number if number
+  #     hash
+  #   end
+
+  #   # @param prefix [String]
+  #   # @param count [Integer] number of the elements
+  #   def to_asciibib(prefix, count = 1)
+  #     out = count > 1 ? "#{prefix}::\n" : ""
+  #     out += "#{prefix}.type:: #{type}\n" if type
+  #     out += "#{prefix}.number:: #{number}\n" if number
+  #     out += "#{prefix}.name:: #{name}\n"
+  #     out
+  #   end
+  # end
 end

data/lib/relaton_iso_bib/hash_converter.rb

@@ -18,7 +18,7 @@ module RelatonIsoBib
       # @param title [Hash]
       # @return [RelatonBib::TypedTitleString]
       def typed_title_strig(title)
-        RelatonBib::TypedTitleString.new **title
+        RelatonBib::TypedTitleString.new(**title)
       end
 
       # @param ret [Hash]

data/lib/relaton_iso_bib/iso_bibliographic_item.rb

@@ -27,6 +27,8 @@ module RelatonIsoBib
       amendment technical-corrigendum directive
     ].freeze
 
+    SUBDOCTYPES = %w[specification method-of-test vocabulary code-of-practice].freeze
+
     # @return [RelatonIsoBib::StructuredIdentifier]
     attr_reader :structuredidentifier
 
@@ -66,6 +68,7 @@ module RelatonIsoBib
     # @param validity [RelatonBib:Validity, NilClass]
     # @param docid [Array<RelatonBib::DocumentIdentifier>]
     # @param doctype [String, nil]
+    # @param subdoctype [String, nil]
     # @param horizontal [Boolean, nil]
     # @param structuredidentifier [RelatonIsoBib::StructuredIdentifier]
     # @param stagename [String, NilClass]
@@ -130,13 +133,14 @@ module RelatonIsoBib
     def initialize(**args)
       check_doctype args[:doctype]
 
-      super_args = args.select do |k|
-        %i[id title docnumber language script docstatus date abstract
-           contributor edition version relation biblionote series medium place
-           copyright link fetched docid formattedref extent accesslocation
-           classification validity doctype keyword].include? k
-      end
-      super **super_args
+      arg_names = %i[
+        id title docnumber language script docstatus date abstract contributor
+        edition version relation biblionote series medium place copyright link
+        fetched docid formattedref extent accesslocation classification validity
+        editorialgroup doctype keyword
+      ]
+      super_args = args.select { |k| arg_names.include? k }
+      super(**super_args)
 
       @type = args[:type] || "standard"
 
@@ -147,6 +151,10 @@ module RelatonIsoBib
                           end
       end
 
+      if args[:subdoctype] && !SUBDOCTYPES.include?(args[:subdoctype])
+        warn "Invald subdoctype '#{args[:subdoctype]}'. Allowed values are: #{SUBDOCTYPES.join(', ')}"
+      end
+      @subdoctype = args[:subdoctype]
       @structuredidentifier = args[:structuredidentifier]
       @horizontal = args[:horizontal]
       @ics = args.fetch(:ics, []).map { |i| i.is_a?(Hash) ? Ics.new(**i) : i }
@@ -160,23 +168,17 @@ module RelatonIsoBib
     # @option opts [String] :lang language
     # @return [String] XML
     def to_xml(**opts)
-      super **opts do |b|
+      super(**opts) do |b|
         if block_given? then yield b
         elsif opts[:bibdata] && has_ext_attrs?
           b.ext do
             b.doctype doctype if doctype
+            b.subdoctype subdoctype if subdoctype
             b.horizontal horizontal unless horizontal.nil?
-            # b.docsubtype docsubtype if respond_to?(:docsubtype) && docsubtype
-            # GB renders gbcommittee elements istead of an editorialgroup
-            # if respond_to? :committee
-            #   committee&.to_xml b
-            # else
             editorialgroup&.to_xml b
-            # end
             ics.each { |i| i.to_xml b }
             structuredidentifier&.to_xml b
             b.stagename stagename if stagename
-            # yield b if block_given?
           end
         end
       end
@@ -208,7 +210,8 @@ module RelatonIsoBib
     # @raise ArgumentError
     def check_doctype(doctype)
       if doctype && !self.class::TYPES.include?(doctype)
-        warn "[relaton-iso-bib] invalid doctype: #{doctype}"
+        warn "[relaton-iso-bib] WARNING: invalid doctype: #{doctype}"
+        warn "[relaton-iso-bib] Allowed doctypes are: #{self.class::TYPES.join(', ')}"
       end
     end
 

data/lib/relaton_iso_bib/structured_identifier.rb

@@ -31,8 +31,8 @@ module RelatonIsoBib
 
     # in docid manipulations, assume ISO as the default: id-part:year
     def remove_part
-      @part_number = nil
-      @subpart_number = nil
+      @part = nil
+      @subpart = nil
       @project_number = case @type
                         when "Chinese Standard"
                           @project_number.sub(/\.\d+/, "")

data/lib/relaton_iso_bib/version.rb

@@ -1,3 +1,3 @@
 module RelatonIsoBib
-  VERSION = "1.8.1".freeze
+  VERSION = "1.9.0".freeze
 end

data/lib/relaton_iso_bib/xml_parser.rb

@@ -23,7 +23,7 @@ module RelatonIsoBib
       # @param item_hash [Hash]
       # @return [RelatonIsoBib::IsoBibliographicItem]
       def bib_item(item_hash)
-        IsoBibliographicItem.new **item_hash
+        IsoBibliographicItem.new(**item_hash)
       end
 
       # @param ext [Nokogiri::XML::Element]
@@ -60,8 +60,8 @@ module RelatonIsoBib
       def iso_subgroup(com)
         return nil if com.nil?
 
-        IsoSubgroup.new(name: com.text, type: com[:type],
-                        number: com[:number]&.to_i)
+        RelatonBib::WorkGroup.new(name: com.text, type: com[:type],
+                                  number: com[:number]&.to_i)
       end
     end
   end

data/relaton_iso_bib.gemspec

@@ -24,17 +24,17 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")
 
   # spec.add_development_dependency "debase"
   spec.add_development_dependency "equivalent-xml", "~> 0.6"
   spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   # spec.add_development_dependency "ruby-debug-ide"
   spec.add_development_dependency "ruby-jing"
   spec.add_development_dependency "simplecov"
 
   spec.add_dependency "isoics", "~> 0.1.6"
-  spec.add_dependency "relaton-bib", "~> 1.8.0"
+  spec.add_dependency "relaton-bib", "~> 1.9.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relaton-iso-bib
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.9.0
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-31 00:00:00.000000000 Z
+date: 2021-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: equivalent-xml
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
 description: 'RelatonIsoBib: Ruby ISOXMLDOC impementation.'
 email:
 - open.source@ribose.com
@@ -138,6 +138,7 @@ files:
 - README.adoc
 - Rakefile
 - bin/console
+- bin/rspec
 - bin/setup
 - grammars/basicdoc.rng
 - grammars/biblio.rng
@@ -166,7 +167,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="