relaton-iso-bib 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b02914af398916111849f7377145375f05ce647e3ff02c6c2ca83013464b4d0
-  data.tar.gz: b32bddded529b02ae662959a692cf03e6a4df256751da54648fe9aca899845d3
+  metadata.gz: f9f99c30bfb243452c65a6d360870fdee10666c5943523fbfb9fa3a4621b74cf
+  data.tar.gz: 6b89f2abf535eca4eb2f2228825e4c4e35ee43c837898d549f68abe37859dc92
 SHA512:
-  metadata.gz: c5521cd8a693d3ba710aa6a3c1675033682ef390d882603398cdb15f2826182dd7b3bf8e5e00fcdd44f9e13d7b7676ea5aab357e9d76a94e639a4ae4c4179133
-  data.tar.gz: e92e7afbdead56a076456aba13be52f1484b191736787d3b4c3928daa6e77259ccaba67d6e2af1ebb59b4acf73277b984875c8caf96d3a4fa1a8021a4cade423
+  metadata.gz: 7b06406809884e1059d4dbf7e58875bb052e6d9ed1abe1f6ee58036b224f336cc662d6ba7d9ee6359d4216c80ca504803116b1ad848c1fc544d12483b6b790ae
+  data.tar.gz: 7f93851f6f71d1d37871b3735aa6033e1c8ea5711d2246258cf91a7161c587f6d16168d4d3111168fce7f29d76ec654f113eaa55477bf3cf5c88ec81fa7e6978

data/.github/workflows/ubuntu.yml

@@ -29,4 +29,5 @@ jobs:
           bundle install --jobs 4 --retry 3
       - name: Run specs
         run: |
+          unset JAVA_TOOL_OPTIONS
           bundle exec rake

data/.rubocop.yml

@@ -5,6 +5,6 @@
 inherit_from:
   - https://raw.githubusercontent.com/riboseinc/oss-guides/master/ci/rubocop.yml
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 Rails:
-  Enabled: true
+  Enabled: false

data/lib/relaton_iso_bib/editorial_group.rb

@@ -33,7 +33,7 @@ module RelatonIsoBib
     # @option workgroup [Integer] :number
     #
     # @param secretariat [String, NilClass]
-    def initialize(technical_committee:, **args)
+    def initialize(technical_committee:, **args) # rubocop:disable Metrics/CyclomaticComplexity
       @technical_committee = technical_committee.map do |tc|
         tc.is_a?(Hash) ? IsoSubgroup.new(tc) : tc
       end
@@ -49,8 +49,9 @@ module RelatonIsoBib
     # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
 
     # @param builder [Nokogiri::XML::Builder]
-    def to_xml(builder)
-      return unless technical_committee || subcommittee || workgroup || secretariat
+    def to_xml(builder) # rubocop:disable Metrics/CyclomaticComplexity
+      return unless technical_committee || subcommittee || workgroup ||
+        secretariat
 
       builder.editorialgroup do
         technical_committee.each do |tc|
@@ -69,12 +70,36 @@ module RelatonIsoBib
 
     # @return [Hash]
     def to_hash
-      hash = { "technical_committee" => single_element_array(technical_committee) }
-      hash["subcommittee"] = single_element_array(subcommittee) if subcommittee&.any?
+      hash = {
+        "technical_committee" => single_element_array(technical_committee),
+      }
+      if subcommittee&.any?
+        hash["subcommittee"] = single_element_array(subcommittee)
+      end
       hash["workgroup"] = single_element_array(workgroup) if workgroup&.any?
       hash["secretariat"] = secretariat if secretariat
       hash
     end
+
+    # @param prefix [String]
+    # @return [String]
+    def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      pref = prefix.empty? ? prefix : prefix + "."
+      pref += "editorialgroup"
+      out = ""
+      technical_committee.each do |tc|
+        out += tc.to_asciibib "#{pref}.technical_committee",
+                              technical_committee.size
+      end
+      subcommittee.each do |sc|
+        out += sc.to_asciibib "#{pref}.subcommittee", subcommittee.size
+      end
+      workgroup.each do |wg|
+        out += wg.to_asciibib "#{pref}.workgroup", workgroup.size
+      end
+      out += "#{pref}.secretariat:: #{secretariat}\n" if secretariat
+      out
+    end
   end
 
   # ISO subgroup.
@@ -111,5 +136,15 @@ module RelatonIsoBib
       hash["number"] = number if number
       hash
     end
+
+    # @param prefix [String]
+    # @param count [Integer] number of the elements
+    def to_asciibib(prefix, count = 1)
+      out = count > 1 ? "#{prefix}::\n" : ""
+      out += "#{prefix}.type:: #{type}\n" if type
+      out += "#{prefix}.number:: #{number}\n" if number
+      out += "#{prefix}.name:: #{name}\n"
+      out
+    end
   end
 end

data/lib/relaton_iso_bib/ics.rb

@@ -7,7 +7,8 @@ module RelatonIsoBib
     # @param subgroup [Integer, NilClass]
     def initialize(code = nil, field: nil, group: nil, subgroup: nil)
       unless code || field
-        raise ArgumentError, "wrong arguments (should be string or { fieldcode: [String] }"
+        raise ArgumentError,
+              "wrong arguments (should be string or { fieldcode: [String] }"
       end
 
       field, group, subgroup = code.split "." if code
@@ -28,5 +29,17 @@ module RelatonIsoBib
       hash["code"] = code if code
       hash
     end
+
+    # @param prefix [String]
+    # @param count [Integer] number of ICS
+    # @return [String]
+    def to_asciibib(prefix = "", count = 1)
+      pref = prefix.empty? ? prefix : prefix + "."
+      pref += "ics"
+      out = count > 1 ? "#{pref}::\n" : ""
+      out += "#{pref}.code:: #{code}\n"
+      out += "#{pref}.description:: #{description}\n"
+      out
+    end
   end
 end

data/lib/relaton_iso_bib/iso_bibliographic_item.rb

@@ -3,7 +3,6 @@
 require "nokogiri"
 require "isoics"
 require "relaton_bib"
-# require "relaton_iso_bib/typed_title_string"
 require "relaton_iso_bib/editorial_group"
 require "relaton_iso_bib/xml_parser"
 require "relaton_iso_bib/structured_identifier"
@@ -160,11 +159,11 @@ module RelatonIsoBib
     end
 
     # @return [String]
-    def to_xml(builder = nil, **opts, &block)
+    def to_xml(builder = nil, **opts)
       if opts[:note]&.any?
         opts.fetch(:note, []).each do |n|
           @biblionote << RelatonBib::BiblioNote.new(
-            content: n[:text], type: n[:type], format: "text/plain",
+            content: n[:text], type: n[:type], format: "text/plain"
           )
         end
       end
@@ -175,7 +174,7 @@ module RelatonIsoBib
           b.ext do
             b.doctype doctype if doctype
             b.docsubtype docsubtype if respond_to?(:docsubtype) && docsubtype
-            # GB renders gbcommittee elements istead of an editorialgroup element.
+            # GB renders gbcommittee elements istead of an editorialgroup
             if respond_to? :committee
               committee&.to_xml b
             else
@@ -196,12 +195,19 @@ module RelatonIsoBib
     # @return [Hash]
     def to_hash
       hash = super
-      hash["editorialgroup"] = editorialgroup.to_hash if editorialgroup
-      hash["ics"] = single_element_array(ics) if ics&.any?
       hash["stagename"] = stagename if stagename
       hash
     end
 
+    # @param prefix [String]
+    # @return [String]
+    def to_asciibib(prefix = "")
+      pref = prefix.empty? ? prefix : prefix + "."
+      out = super
+      out += "#{pref}stagename:: #{stagename}\n" if stagename
+      out
+    end
+
     private
 
     # @param doctype [String]
@@ -212,7 +218,7 @@ module RelatonIsoBib
       end
     end
 
-    def makeid(id, attribute, _delim = "")
+    def makeid(id, attribute, _delim = "") # rubocop:disable Metrics/CyclomaticComplexity
       return nil if attribute && !@id_attribute
 
       id ||= @docidentifier.reject { |i| i&.type == "DOI" }[0]

data/lib/relaton_iso_bib/structured_identifier.rb

@@ -33,11 +33,12 @@ module RelatonIsoBib
     def remove_part
       @part_number = nil
       @subpart_number = nil
-      case @type
-      when "Chinese Standard" then @project_number = @project_number.sub(/\.\d+/, "")
-      else
-        @project_number = @project_number.sub(/-\d+/, "")
-      end
+      @project_number = case @type
+                        when "Chinese Standard"
+                          @project_number.sub(/\.\d+/, "")
+                        else
+                          @project_number = @project_number.sub(/-\d+/, "")
+                        end
     end
 
     def remove_date
@@ -62,7 +63,9 @@ module RelatonIsoBib
         pn = builder.send "project-number", project_number
         pn[:part] = part if part
         pn[:subpart] = subpart if subpart
-        builder.send "tc-document-number", tc_document_number if tc_document_number
+        if tc_document_number
+          builder.send "tc-document-number", tc_document_number
+        end
       end
       xml[:type] = type if type
     end
@@ -78,6 +81,24 @@ module RelatonIsoBib
       hash
     end
 
+    # @param prefix [String]
+    # @return [String]
+    def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
+      pref = prefix.empty? ? prefix : prefix + "."
+      pref += "structured_identifier"
+      out = ""
+      if tc_document_number
+        out += "#{pref}.tc_document_number:: #{tc_document_number}\n"
+      end
+      if project_number
+        out += "#{pref}.project_number:: #{project_number}\n"
+      end
+      out += "#{pref}.part:: #{part}\n" if part
+      out += "#{pref}.subpart:: #{subpart}\n" if subpart
+      out += "#{pref}.type:: #{type}\n" if type
+      out
+    end
+
     def presence?
       true
     end

data/lib/relaton_iso_bib/version.rb

@@ -1,3 +1,3 @@
 module RelatonIsoBib
-  VERSION = "1.2.0".freeze
+  VERSION = "1.3.0".freeze
 end

data/lib/relaton_iso_bib/xml_parser.rb

@@ -56,7 +56,7 @@ module RelatonIsoBib
       # @TODO Organization doesn't recreated
       # @param ext [Nokogiri::XML::Element]
       # @return [RelatonIsoBib::EditorialGroup]
-      def fetch_editorialgroup(ext)
+      def fetch_editorialgroup(ext) # rubocop:disable Metrics/CyclomaticComplexity
         eg = ext&.at("./editorialgroup")
         return unless eg
 

data/relaton_iso_bib.gemspec

@@ -36,5 +36,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov"
 
   spec.add_dependency "isoics", "~> 0.1.6"
-  spec.add_dependency "relaton-bib", "~> 1.2.0"
+  spec.add_dependency "relaton-bib", "~> 1.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relaton-iso-bib
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-26 00:00:00.000000000 Z
+date: 2020-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: debase
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.3.0
 description: 'RelatonIsoBib: Ruby ISOXMLDOC impementation.'
 email:
 - open.source@ribose.com